Commit graph

39657 commits

Author SHA1 Message Date
Ankush Menat
06aaaaaedf build: move all devDependencies to Dependencies
These are real dependencies without which you can't locally build apps.
2022-09-14 19:40:22 +05:30
Rucha Mahabal
529e8ebde1
fix(minor): Use colors passed to render_graph on form dashboards (#18132) 2022-09-14 17:31:18 +05:30
Athul Cyriac Ajay
31a37ed671
chore: Add make_put_requests method for Server Scripts (#18128) 2022-09-14 15:54:15 +05:30
rohitwaghchaure
fd3df669f7
fix: dynamic label for document rename (#18125) 2022-09-14 15:51:28 +05:30
Ankush Menat
4ca3bf2d0b
fix: show portal sidebar on login (#18126) 2022-09-14 15:37:43 +05:30
Ankush Menat
7453e8e3a1 perf: drop all old parent indexes
- re-add parent index on custom_docperm
2022-09-14 14:28:47 +05:30
Ankush Menat
3a5a45d8af perf: drop many unused indexes
- reference owner - only used for activity page which is unusable
  *anyway*
- same for timeline and link doctypes

perf: drop unused index from Commment

Can't find a single  query that uses this index

perf: drop pointless "Is home folder" index

just why? It's checkbox index with 1 entry which has unique name already

Most pointless index I've seen no far.

perf: Drop "attached to doctype" separate index

There is already a composite index for this.

perf: drop indexes from web page view log

BOTH are totally unused in any of the queries related to this doctype.

Only "website analytics" report uses this which doesn't even show this
data lmao.

perf: drop unused index from EPS log

We never filter by doctype or type. pointless indexing.

perf: fix up notification log indexes

- drop unused index
- add "for user" index
2022-09-14 14:28:47 +05:30
Ritwik Puri
255bc211af
refactor(minor): simplify show_kanban_dialog & allow multiple kanban board creation (#18111)
* allow multiple kanban board creation for the same doctype
* simplify show_kanban_dialog
* directly jump to a kanban if available/from last_opened_kanban property - no need to show a dialog for selection
2022-09-14 14:26:18 +05:30
Ankush Menat
4120d5a8e3
fix: RQ job name when func object is passed (#18112)
[skip ci]
2022-09-13 19:10:21 +05:30
Shariq Ansari
df9ec9cb16
Merge pull request #18109 from shariquerik/duplicate-workspace-fix 2022-09-13 17:13:19 +05:30
Shariq Ansari
f00cf1e290 fix: always show edit button 2022-09-13 16:47:02 +05:30
Shariq Ansari
21650ef383 fix: while duplicating do not set module field 2022-09-13 16:43:21 +05:30
Shariq Ansari
d1abbed18b fix: create a private workspace if user doesnt have access while duplicating 2022-09-13 16:32:55 +05:30
Rucha Mahabal
14a84793a8
fix: Show quick list only if user has access (#18102) 2022-09-13 16:09:33 +05:30
Ankush Menat
b47f9c25e5
chore: let frappe bot raise stable branch PRs
[skip ci]
2022-09-13 15:15:34 +05:30
Shariq Ansari
235171796d
fix: coalesce not in queries (#18099)
* fix: get workspaces with empty module fields

* Revert "fix: get workspaces with empty module fields"

This reverts commit 1f194be2c3642e31ebe2165e461b2f24be8cda4c.

* fix: always coalesce `not in` queries

Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-09-13 12:08:07 +05:30
Ernesto Ruiz
931e91be3d
fix: Add text inside translate function (#18085) 2022-09-12 18:01:34 +05:30
Ankush Menat
fd3b4c919a
Merge pull request #18089 from phot0n/sync-dashboard
fix: sync app dashboard on app install
2022-09-12 17:54:42 +05:30
Ritwik Puri
7f4974e923
Merge branch 'develop' into sync-dashboard 2022-09-12 16:19:19 +05:30
phot0n
1d27f936e9 fix: allow syncing of dashboard even if setup is not complete 2022-09-12 16:03:06 +05:30
Sagar Vora
627302d851
fix: set doctype and name in docinfo (#18088) 2022-09-12 14:18:20 +05:30
Ankush Menat
2866069eb4 chore: make contribution license explicitly known
This is implicitly assumed.

[skip ci]
2022-09-12 13:52:39 +05:30
Ankush Menat
1a60049af0
refactor: simpler job queued checking (#18091) 2022-09-12 12:59:00 +05:30
phot0n
3539dacdf0 fix: commit after app install
Since we destroy the connection after app installation,
mariadb implicitly rollsback the transaction hence committing upon successfull
app installation to prevent data sync loss
2022-09-12 12:23:14 +05:30
Ankush Menat
e20655bd20
Merge pull request #18086 from ankush/rq_redo
feat: Improved RQ monitoring and control with virtual doctypes
2022-09-12 11:49:53 +05:30
Ankush Menat
11936a76df feat: kill a running background job -f
Also refactor permission checks
2022-09-12 11:49:25 +05:30
Ankush Menat
2267d40420 test: add tests for bg job monitoring code 2022-09-12 11:49:25 +05:30
Ankush Menat
fc048ae5e3 refactor!: remove background jobs page 2022-09-12 11:49:25 +05:30
Ankush Menat
4ae85b20db feat: auto refresh RQ job page 2022-09-12 11:49:25 +05:30
Ankush Menat
46df97c3f2 feat: show scheduler status on RQ job page 2022-09-12 11:49:25 +05:30
Ankush Menat
6d264b149a fix: serialize function objects to their repr 2022-09-12 11:49:25 +05:30
Ankush Menat
7a3c3910fe refactor: remove dead code related to scheduler activation 2022-09-12 11:49:25 +05:30
Ankush Menat
c021b07255 fix: disable count and stats 2022-09-12 11:49:25 +05:30
Ankush Menat
dca6592b7e feat: delete background jobs from form views 2022-09-12 11:49:19 +05:30
Ankush Menat
fc0ff7bd2e feat: RQ job doctype 2022-09-12 11:49:05 +05:30
phot0n
51ac3e8a99 fix: sync app dashboard on app install
* chore: fix sync_dashboards' docstring
2022-09-12 00:01:21 +05:30
Ankush Menat
330bd08210 feat: RQ worker virtual doctype
Enuff manual JS and HTML crap, lets reuse list and form views!
2022-09-11 11:44:12 +05:30
Ankush Menat
5152f13b10 fix: RQ reduce failed job TTL from 1 year to 7 days 2022-09-10 23:54:43 +05:30
Ankush Menat
f5a45a7e78 fix: erase default before adding new series-es 2022-09-10 13:14:23 +05:30
Ankush Menat
45b74861af test: fix broken test
Not sure why there's test on doctype "created by". Makes no sense.
2022-09-10 13:07:37 +05:30
Ankush Menat
0896873c8a test: add test role to user 2022-09-10 12:48:33 +05:30
Ankush Menat
a6b341bd59 test: fix tests using admin account 2022-09-10 12:48:33 +05:30
Ankush Menat
f07bc3b369 test(UI): use non-admin user for tests 2022-09-10 12:48:33 +05:30
Ankush Menat
d19790e03d fix: error handling without user set 2022-09-10 12:45:25 +05:30
Ankush Menat
87092ec0b3 fix: don't attempt to delete session during read only session 2022-09-10 12:45:25 +05:30
Ankush Menat
49af8f7db1
Merge pull request #18050 from ankush/read_only_maintenance
feat: Zero* downtime migrations
2022-09-09 18:17:57 +05:30
Ankush Menat
06d888126b fix(UX): show read only mode warning on web pages 2022-09-09 17:34:46 +05:30
Ankush Menat
ea7fbb2c10 refactor: remove dead flag db.read_only
This was added in last DB refactor but it does nothing, it was probably
supposed to do something with the connection pool but to best of my
knowledge "read only" is not a property of a connection.

It can be achieved with users who only have read access, that however
isn't implemented anywhere.

Removing this for now.
2022-09-09 17:34:46 +05:30
Ankush Menat
f6c548c7b9 feat(ux): no-indicator-dot for indicator pills
Adding this class will disable indicator's tiny dot added before text.
2022-09-09 17:34:46 +05:30
Ankush Menat
7f316fa427 test: add api tests for read only mode 2022-09-09 17:34:46 +05:30