Commit graph

6451 commits

Author SHA1 Message Date
Aditya Patil
35909f5c45
refactor: removed usage of cmd for login (#36801)
* refactor: removed usage of `cmd` for login

* refactor: use `set_request` in activity log tests
2026-02-16 14:09:48 +05:30
Saqib Ansari
2f3606bb39
fix: bad permission check 2026-02-10 20:53:00 +05:30
AarDG10
6ae860f4bb feat: skip sending mail when in developer mode for impersonation 2026-02-09 14:55:39 +05:30
Sagar Vora
81d82a088a
Merge pull request #36853 from barredterra/rename-virtual-doctype
fix: skip db changes while renaming virtual doctype
2026-02-09 06:37:42 +00:00
s-aga-r
786adfd341
fix(Communication): set In-Reply-To (#36746) 2026-02-09 10:42:19 +05:30
Shrihari Mahabal
193cb67e9c
fix: bypass size limit check for requesting personal information (#36584)
* fix: bypass size limit check for requesting personal information

* refactor: make size check skip generalized using flags and fix email sending test

* fix: test for large file request

* fix: update file size check flag name

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>

* fix: Update flag name to skip_file_size_check

---------

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2026-02-09 01:59:06 +00:00
barredterra
251189a1e2 fix: skip db changes while renaming virtual doctype 2026-02-08 17:44:04 +01:00
sokumon
f2b5c3f60f feat: show description on click 2026-02-06 15:17:59 +05:30
Aarol D'Souza
77af2d53d6
fix(system console): allow read-only queries in system console (#36652)
* fix(system console): allow read-only queries in system console

* fix(security): make transactions strictly read only for console and scripts

* test: remove test to reflect ban on cte's for security

* fix: Only enable read only mode for SQL query

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2026-02-05 11:39:10 +00:00
Aarol D'Souza
73479e724d
Merge pull request #36240 from AarDG10/fix-email-impersonation
feat(user): send user a mail when an impersonation session has commenced
2026-02-04 17:27:34 +05:30
AarDG10
4b86e92fbc fix(user): use sendmail instead of enqueuing 2026-02-04 17:15:46 +05:30
Soham Kulkarni
40711ffcef
Merge pull request #36650 from safwansamsudeen/autocreate-calendar-controller 2026-02-03 18:25:47 +05:30
Safwan Samsudeen
e24a50b327 feat: autocreate calendar controller file 2026-02-03 17:55:34 +05:30
Safwan
fc6f48c42a
fix: check file type before decoding content (#36647)
Closes: #36592
2026-02-03 11:18:19 +00:00
Suraj Shetty
c935cf6cdb
Merge pull request #36589 from safwansamsudeen/duplicate-save-file
fix: only duplicate file on disk if required
2026-02-03 14:01:41 +05:30
Safwan Samsudeen
4a03c1f0a6 fix: only duplicate file on disk if required 2026-02-02 18:07:07 +05:30
Clayton
d7776767a8 fix: guard role_profiles_add/remove when roles_editor is missing 2026-02-02 04:41:26 -06:00
Clayton
20e57c2df5 fix: show roles section when creating new user 2026-02-02 01:11:11 -06:00
Hussain Nagaria
4911303977 fix: filters is expected to be a list
* check the next line, extend is being called
2026-01-30 18:04:41 +05:30
Akhil Narang
7f5b5d4164
fix(comment): block some additional tags
Although we escape HTML before sending the comment, that's done in the frontend.
People can directly send a request to the add_comment API with unescaped HTML.
This extra validation ensures comments can't lead to some form of phishing.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-01-29 12:10:36 +05:30
sokumon
c1f0f08648 chore: update description of field 2026-01-28 15:58:45 +05:30
Sagar Vora
4b84dcdc9a
Merge pull request #36378 from shubhdoshi21/aggregate-column-in-auto-email-report-fix 2026-01-27 18:24:43 +05:30
Shubh Doshi
87c3c71d3d fix: auto email report SQL function validation error 2026-01-27 17:31:37 +05:30
Ejaaz Khan
de7e6f8450
Merge pull request #36361 from gajjug004/fix/role-perm-reset-dialog
fix(ui): text overflow in reset permission dialog
2026-01-27 16:35:23 +05:30
Gajendra Nishad
34a4098ad7 fix(ui): text overflow in reset permission dialog
closes #36355
2026-01-27 13:10:38 +05:30
AarDG10
ead918c53f fix(user_permission): fix dead click effect on applicable for field 2026-01-24 13:22:05 +05:30
Hussain Nagaria
15b1de165d
fix(File): consider import error for perm check (#36277) 2026-01-23 14:35:58 +00:00
Ejaaz Khan
dea7da5dae
Merge pull request #35616 from nabinhait/settings-timeline
fix: Hide timeline and right sidebar from system settings
2026-01-23 15:33:29 +05:30
Ejaaz Khan
3c982e4938 style: run precommit to make ci green 2026-01-23 15:09:09 +05:30
Ejaaz Khan
3deaf9a403
Merge pull request #36150 from vorasmit/save-as-code
fix: save error message for prepared report in `code` field
2026-01-23 12:13:47 +05:30
AarDG10
8976ba74c8 feat(user): send user a mail when an impersonation session has begun 2026-01-22 23:53:42 +05:30
Raffael Meyer
f813fc1c1e
fix: role-perm validation (#35640) 2026-01-22 12:31:22 +01:00
Ejaaz Khan
571408c443 fix(UI): checkbox alignment and delete icon 2026-01-21 16:43:39 +05:30
Smit Vora
cd41c054a6 fix: save error message for prepared report in code field 2026-01-21 10:56:18 +05:30
git-avc
7b012af2f4 fix: linters 2026-01-19 00:29:02 +01:00
git-avc
75b4366325 fix: let's alignment on customize form 2026-01-19 00:07:22 +01:00
avc
7df7cf1878
Merge branch 'frappe:develop' into form_control_alignment 2026-01-18 22:53:57 +01:00
Ejaaz Khan
5bec48fd39
Merge pull request #35986 from Shllokkk/tree-fix
feat(doctype): generate controller_tree.js boilerplate for tree doctypes
2026-01-16 11:02:20 +05:30
Raffael Meyer
345e9ed503
feat(version): add HTML diff view for multiline field changes (#35837)
Co-authored-by: Copilot <175728472+Copilot@users.noreply.github.com>
2026-01-15 23:33:25 +00:00
Shllokkk
a98e94caf1 feat(doctype): generate controller_tree.js boilerplate for tree doctypes 2026-01-15 17:50:27 +05:30
git-avc
59c3a02f28 fix: add Currency fieldtype 2026-01-13 23:43:09 +01:00
git-avc
bfb8ccb628 feat: let's control alignment 2026-01-13 23:01:16 +01:00
sokumon
eb903033ab fix: revert setting desk theme to auto 2026-01-12 16:05:29 +05:30
sokumon
a8950ad086 chore: remove system workspace 2026-01-12 14:24:54 +05:30
Akhil Narang
8c5b5ecec3
Merge pull request #35775 from akhilnarang/multisql-wildcard
feat(multisql): support passing a wildcard query
2026-01-12 12:23:31 +05:30
sokumon
2c423c255c fix: recreate system workspace 2026-01-12 00:04:24 +05:30
sokumon
65d4e1262d fix: add workspace for users 2026-01-11 23:34:25 +05:30
Ankush Menat
29be54a35d
perf: misc v16 fixes (#35790)
* perf: Reduce queries for setup wizard progress

These are queried on boot continuously, can just cache installed app doc.

* fix: remove stray db.commit in csrf generation
2026-01-09 11:06:06 +00:00
Akhil Narang
8657690ef5
refactor: use wildcard to avoid duplicating some queries
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-01-08 18:56:05 +05:30
Akhil Narang
4c58eba58b
fix: "fetch from" was broken on SQLite (#35774)
SQLite (like PostgreSQL) doesn't support `INNER JOIN` within `UPDATE`
We can use the psql fallback we anyway had.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-01-08 13:00:14 +00:00