Commit graph

343 commits

Author SHA1 Message Date
Ejaaz Khan
50121fd81a
Revert "fix: show sidebar in print format builder" 2026-01-25 11:53:54 +05:30
KerollesFathy
df7e007d08 fix: show sidebar in print format builder 2026-01-24 22:14:00 +00:00
circlecrystalin
43a03d4a44 style: apply prettier formatting and remove trailing whitespace 2026-01-20 18:17:40 +01:00
circlecrystalin
65dbc16948 refactor: scope checkbox selection to dialog and extract reusable function
- Scope checkbox selector to .column-selector-list to prevent selecting checkboxes outside the dialog
- Refactor Select All and Unselect All into reusable toggle_all_checkboxes function
- Reduce code duplication and improve maintainability
2026-01-20 18:14:30 +01:00
circlecrystalin
b3b85b9090 refactor: use const instead of var in Select All/Unselect All functions 2026-01-20 13:34:07 +01:00
circlecrystalin
7539c76471 feat: Add Select All/Unselect All option in Select Table Columns dialog 2026-01-20 12:26:06 +01:00
KerollesFathy
bb94d98754 fix: show sidebar when print view is displayed 2026-01-12 23:43:46 +00:00
KerollesFathy
52365e1598 fix: show sidebar in print view 2026-01-12 22:19:20 +00:00
Rahul Agrawal
a046710bd1 fix: rename select field 2026-01-10 11:56:54 +05:30
Rahul Agrawal
08c5d095af fix: use select instead of check 2026-01-10 11:13:42 +05:30
Rahul Agrawal
8649c18125 feat: allow use of chrome pdf generator for standard print format 2026-01-10 10:22:00 +05:30
sokumon
6075e557df fix: load correct sidebar for printview 2026-01-08 09:30:53 +05:30
Packeting
2f62168654 fix: show form button in mobile print view 2026-01-04 11:17:30 +08:00
Vishnu Priya Baskaran
66f1491c9d
fix: clear defaults in on_trash (#35508) 2025-12-30 15:24:53 +05:30
sokumon
dd2dc053ca chore: more renames to /desk 2025-12-18 20:45:04 +05:30
sokumon
95c275f4bc refactor: setting the correct sidebar 2025-12-17 02:04:37 +05:30
avc
b429b7e35d
fix: use bool properly
Co-authored-by: Ejaaz Khan <67804911+iamejaaz@users.noreply.github.com>
2025-11-24 07:17:25 +01:00
git-avc
fd6be0549d feat: add ability to disable new product suggestion 2025-11-23 13:38:09 +01:00
Ejaaz Khan
fdd464fc14
Merge pull request #34414 from khushi8112/standard-jinja-custom-print-format-edit
feat: redirect to print format doc when type is jinja
2025-10-15 14:19:34 +05:30
khushi8112
587d770c49 refactor: add better name to variable 2025-10-15 12:54:49 +05:30
khushi8112
4b20d236f5 feat: redirect to print format doc when type is jinja 2025-10-15 12:30:35 +05:30
Ejaaz Khan
964dd6c034 feat: Chrome PDF generator
Co-authored-by: maharshivpatel <maharshivpatel@users.noreply.github.com>
2025-09-29 12:15:51 +05:30
Ejaaz Khan
9c747bd363
Merge pull request #34000 from diptanilsaha/report_jinja_print_format
fix: print format for reports
2025-09-17 10:45:01 +05:30
Ejaaz Khan
6704277232 refactor: add in_install flag condition in default values 2025-09-17 00:45:20 +05:30
diptanilsaha
28a13ce58a fix: print format for reports 2025-09-16 11:59:38 +05:30
Ejaaz Khan
48c3337e91 fix: dont set default value on migrate 2025-09-15 13:01:09 +00:00
Ejaaz Khan
5265d7fb1a fix: multiple call of fucntion 2025-09-05 12:51:33 +05:30
Ejaaz Khan
bbb3a35ffe feat: add shortcut to refresh print preview 2025-09-04 18:17:57 +05:30
Ravibharathi
a812021809
fix(print-format): typo in doctype (#33761) 2025-08-25 11:19:51 +05:30
mergify[bot]
ddd7c96924
Merge branch 'develop' into develop 2025-07-31 05:26:30 +00:00
Ejaaz Khan
4da190ca8b fix: minor fix and adds validation 2025-07-02 12:12:04 +05:30
Ejaaz Khan
c48b801c2e fix: remove default mandatory 2025-07-01 18:02:50 +05:30
Ejaaz Khan
924ca85e59 feat: print format for Reports 2025-07-01 17:33:59 +05:30
Sagar Vora
8d47138504 fix: update print heading doctype 2025-06-26 15:13:55 +05:30
Sagar Vora
b3e1eda4c8
feat: global frappe.in_test flag (#32960)
* feat: global `frappe.in_test` flag

* feat: helper utility to toggle `frappe.in_test`

* fix: use `toggle_test_mode` util

* fix: use `frappe.in_test`

* chore: add comment explaining global `in_test`

* chore: ignore commit replacing flag usage

* test: temporarily disable `frappe.in_test`

this worked earlier because flag was set in werkzeug.local which was separate for API test client

* test: add comment explaining change
2025-06-17 19:19:31 +05:30
maheini
e6d9966514
fix: Add proper html skeleton to preview iframe
This will prevent Quircks compatibility CSS rules from beeing applied, which leads to differences in preview/print-view
2025-06-15 01:57:56 +02:00
Raffael Meyer
294af0d318
fix: set print format as default (#32862)
- add param type hint
- check write perms on the specific Print Format
2025-06-12 09:33:34 +02:00
Ankush Menat
8088bd3891
chore: Drop empty UnitTestCases (#32867)
Next to zero adoption after introduction, just noise in codebase.

I don't see any point in arguing about purity of test cases when
existence and quality of test cases is usually the bigger problem.

Dropped using semgrep
2025-06-10 05:28:53 +00:00
Aayush Dalal
ca5b4cea0b
fix: throw permission error (#32860) 2025-06-10 08:47:49 +05:30
Ankush Menat
f9ff807e4c
refactor: Rename get_settings -> get_single_value (#32840)
Not all single doctypes are settings, so this is better. Implicit
caching is fine, same is done for `db` APIs on singles. We *should* aim
for 100% correctness of caching implementation, especially for singles.

Thanks to @netchampfaris for the suggestion.
2025-06-09 04:20:29 +00:00
Ankush Menat
caf415f13e
feat: get_settings (#32821)
* feat: get_settings

get_cached_value doesn't work well with singles because you either need
to pass `None` or repeat doctype name... both are awekward and easy to
shoot yourself in foot with.

* refactor: Use cached settings
2025-06-06 18:34:17 +05:30
Maharshi Patel
35b4bc2581 fix(minor): don't update modified date in patch 2025-02-19 14:09:39 +05:30
Maharshi Patel
463d1f2b05 fix: code changes as pdf_generator is now select field 2025-02-14 17:04:13 +05:30
Maharshi Patel
e818ef22f7 fix: make pdf_generator select field
As per review, renamed chrome_pdf_generator to pdf_generator and made it a select field.
- default option available for select is wkhtmltopdf.
- default for new print formats is wkhtmltopdf.
- print designer on install adds a new option ( chrome ) to the select field.
- added patch to update existing print format to wkhtmltopdf.
2025-02-14 16:27:10 +05:30
Maharshi Patel
f3e0ec5367 chore: added chrome_pdf_generator field
instead of making field custom in print_designer added field in Print Format DocType
2025-02-13 18:42:10 +05:30
Soni Karm
d4ff214a6f
fix: clear print format selector if default print format is absent (#31123) 2025-02-05 06:43:13 +00:00
Soni Karm
ecd90601fe
fix: use frappe.db.set_value instead of frappe.db.sql (#31124) 2025-02-05 06:29:07 +00:00
Ejaaz Khan
2fb0629197
fix: alignment Issues with Serial Numbers and Descriptions (#29093)
* fix: serial numbers not aligned with other cells

* refactor: remove top margin from editor
2025-01-13 11:50:01 +05:30
mahsem
e8698a98de
fix: add strings and fields to translation 2024-12-21 13:17:01 +01:00
Ankush Menat
60bc472ab6
revert: restore JSON files (#28717)
* Revert: bring back JSON files

* chore: re-apply changes to new files

* chore: remove old TOML files

* chore: delete empty files
2024-12-09 08:41:56 +00:00