ruthra kumar
08d5b59778
refactor: filter on name while fetching custom column ( #22133 )
2023-08-21 15:05:10 +05:30
Himanshu Shivhare
3784ce8507
chore: typo
...
typo fix
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-08-21 14:43:48 +05:30
Shariq Ansari
769fa08a00
Merge pull request #22134 from shariquerik/create-doctype-with-meta
2023-08-21 13:30:45 +05:30
Ankush Menat
85ca83ae45
Revert "feat: allow re-running patches in developer mode"
...
This reverts commit 3bbe4498a0 .
2023-08-21 13:06:42 +05:30
Ankush Menat
8ddde056a0
fix: dont allow NamedExpr in safe_eval
2023-08-21 12:42:21 +05:30
Ankush Menat
fd740b780b
fix: use vanilla eval
2023-08-21 12:09:45 +05:30
Ankush Menat
eede56d5df
fix: dont allow writes to live objects
2023-08-21 12:04:55 +05:30
Shariq Ansari
05adc0b777
fix: Unable to create doctype using 'Copy To Clipboard'
2023-08-21 12:01:56 +05:30
Ankush Menat
1c15c556d4
test: add more safe_eval tests
2023-08-21 11:59:53 +05:30
Ankush Menat
f449262050
fix: allow dict access and unpacks
2023-08-21 11:59:53 +05:30
Ankush Menat
14b62d7ff1
fix: correct getattr implementation for safe_eval
2023-08-21 11:59:53 +05:30
Ankush Menat
3531f58b54
refactor: unify safe_exec and safe_eval code
...
A lot of duplication was present for this code.
2023-08-21 11:59:53 +05:30
mergify[bot]
d6d82eb581
Merge pull request #22110 from resilient-tech/perf-as_dict-2
...
perf: undo regression in `as_dict` performance
2023-08-21 06:10:54 +00:00
mergify[bot]
2a086cf9c6
Merge pull request #22128 from resilient-tech/unsafe-attrs-jinja
...
fix: disallow unsafe attrs in jinja env
2023-08-21 04:55:53 +00:00
Sagar Vora
01c269726f
fix: disallow unsafe attrs in jinja
2023-08-20 22:26:19 +05:30
Raffael Meyer
6fbfc3192d
Merge pull request #21837 from barredterra/refactor-attach-print
2023-08-20 17:47:58 +02:00
barredterra
5944d387be
Merge remote-tracking branch 'upstream/develop' into refactor-attach-print
2023-08-20 15:38:05 +02:00
Sagar Vora
91ceb889cc
test: ensure only property can be called for virtual docfields
2023-08-18 23:04:22 +05:30
Sagar Vora
151874c035
test: ensure get_permitted_fieldnames is called only once per doc
2023-08-18 22:47:37 +05:30
Sagar Vora
7dc67f2feb
chore: add back getattr for virtual docfields which get value from a property
2023-08-18 21:51:56 +05:30
Ankush Menat
8243d3d5a3
fix: dont guess extension without filename
2023-08-18 18:59:42 +05:30
Ankush Menat
412c9811a9
Merge pull request #22109 from ankush/misc_fixes
...
fix: misc fixes related to setup etc
2023-08-18 18:18:16 +05:30
RitvikSardana
18cdfc3b84
fix: Re Run Logs in System Console ( #22103 )
2023-08-18 18:10:54 +05:30
Ankush Menat
66ea947ae6
fix: clear system settings cache explicitly
2023-08-18 17:48:22 +05:30
Ankush Menat
8ec5a8e84b
refactor: Add all roles while creating new user
2023-08-18 17:48:14 +05:30
Ankush Menat
a1927bcf31
fix: delete prepared report job from queue
2023-08-18 17:48:14 +05:30
Ankush Menat
d1495bb991
perf: ignore log links and disable in background jobs
...
Scheduled job type keeps getting updated for every scheduled job. This
is not required at all and not triggered by user.
This feature is for prioritizing user selected links, background jobs
should be ignored.
2023-08-18 17:47:58 +05:30
Sagar Vora
928bc46be3
perf: undo regression in as_dict performance
2023-08-18 17:44:45 +05:30
mergify[bot]
06ba61ff97
Merge pull request #22064 from barredterra/assignment-rule-on-change
...
fix(Assignment Rule): also run `on_cancel` and `on_update_after_submit`
2023-08-17 14:44:23 +00:00
Ankush Menat
c7847395da
fix: remove thread-unsafe class attributes ( #22097 )
...
The problem is same as mutable defaults. Container type class attributes
are mutable and shared between all objects.
```python
class CLS:
attr = {}
...
a = CLS()
b = CLS()
a.attr is b.attr # => True
```
2023-08-17 20:11:20 +05:30
barredterra
68d984dbb2
fix(Assignment Rule): run on additional events
...
- on_cancel
- on_update_after_submit
2023-08-17 13:10:03 +02:00
Ankush Menat
7af8f6a8ff
refactor: replace usage of mktemp ( #22093 )
2023-08-17 11:03:02 +00:00
barredterra
63aded91f9
Revert "fix: run assignment rule on change"
...
This reverts commit 88cbba5f21 .
2023-08-17 13:02:41 +02:00
Shariq Ansari
f796ed04ef
Merge pull request #22089 from maharshivpatel/fix-grid-last-row-css
...
fix(minor): grid row layout on small viewport
2023-08-17 13:53:00 +05:30
Maharshi Patel
fb62a22cd9
fix: hide "Edit" text on md viewport
...
hide text on md viewport and add min-width of 0 instead of 50px
2023-08-17 13:48:42 +05:30
Maharshi Patel
4d88daac66
fix(minor): grid row layout on small viewport
...
on small viewports header and body rows were not aligned due to "Edit" text.
2023-08-17 12:43:08 +05:30
Ankush Menat
48f72655ad
feat(dx): Run gunicorn in development setup ( #22088 )
...
This lets developer run gunicorn in development setup while still being
able to use statics/assets.
While this is not "first class" support, it's usable for me. I don't see
need for more right now. Making this default in developer mode isn't
ideal IMO as it's quite heavy compared to werkzeug (and no debugger or
decent request logging)
To use in development mode swap `bench serve` with gunicorn command,
refer gunicorn config docs for more info.
```diff
- web: bench serve --port 8000
+ unicorn: gunicorn -b 127.0.0.1:8000 -w 1 --chdir /home/user/benches/develop/sites 'frappe.app:application_with_statics()' --preload
```
`no-docs`
2023-08-17 11:34:45 +05:30
Ankush Menat
79392260d4
fix: autoincr caching and clear site cache after restore ( #22079 )
...
* fix: remove hazardous cache for autoincr
* fix: move cache to redis
* fix: clear all redis cache after restoring a site
2023-08-17 11:11:27 +05:30
Ankush Menat
4649c8dacf
build(deps): Bump gunicorn to latest version ( #22086 )
2023-08-17 11:11:01 +05:30
bVisible
88c2e64899
fix: translation of buttons in the Form tour ( #22055 )
2023-08-17 10:51:27 +05:30
Suraj Shetty
4dad5428cf
Merge pull request #22084 from surajshetty3416/dynamic-routes-hook
2023-08-17 09:51:45 +05:30
Suraj Shetty
77e5ad26fe
Merge pull request #21819 from marination/attachments-access
2023-08-17 09:46:30 +05:30
Suraj Shetty
5d85341984
feat: Hook to add dynamic routes for other web view doctypes
2023-08-17 09:30:24 +05:30
Deepesh Garg
112836dcd7
chore: Provision to ignore prepared report via route options ( #22077 )
2023-08-16 20:18:57 +05:30
Corentin Flr
274ffe8d68
fix(link_selector): Fix page_length value ( #22076 )
...
cbe4da6437/frappe/desk/search.py (L60)
2023-08-16 20:18:06 +05:30
Shariq Ansari
1c72218eba
Merge pull request #21913 from barredterra/close-assignment-from-sidebar
2023-08-16 18:17:15 +05:30
barredterra
f6ca94705e
fix: don't show closed assignments in list view
2023-08-16 11:56:01 +02:00
Raffael Meyer
cd56c6aaec
fix: faster transition and improved button style
...
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2023-08-16 11:46:04 +02:00
Shariq Ansari
cbe4da6437
Merge pull request #22073 from shariquerik/remove-unused-fields
2023-08-16 13:49:12 +05:30
Shariq Ansari
ac775c0e68
fix: removed duplicate doctype_properties from customize form
2023-08-16 13:46:52 +05:30