Commit graph

51802 commits

Author SHA1 Message Date
Akhil Narang
08e7a72ba2
refactor: uppercase function assertions
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
49c451068f
fix: adjust tests for query builder permission
Earlier you could use fields you didn't have access to for filtering, now you can't.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:58 +05:30
Akhil Narang
ddcda11d67
fix: function detection
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
b407fe8093
fix: allow function aliases
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
3040ab7eb2
feat(query): add in IFNULL logic from db_query
Use `IFNULL(var, "") == ""` instead of `isnull()`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
df5080b45e
fix(linked_with): don't add tab prefix
query builder takes care of this

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
0ea49a8f1e
fix: make sure limit is an integer
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
bd48f5df65
fix(convert_to_value): convert dict_keys and dict_values to a tuple as well
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
a9d0abaf7b
fix(test_server_script): loosen test a bit, allow any case
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
e420e7646f
fix(query): match db_query, add parentheses around condition
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
b4cf69732b
fix(query): allow numeric strings
For things like `COUNT(1)`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
e15ec47ba1
fix(query): allow passing as in any case
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
8e03924356
fix(query): allow AggregateFunction as well in apply_field_permissions
Without this `fields=[{"COUNT": "name"}]` didn't work, although fields=[{"COUNT": "NAME"}] did.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
1d2a73f659
fix: support virtual doctype handling
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
7183caf871
fix(query_builder): default sorting based on doctype meta
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
5d992a5eb1
refactor: migrate a few queries to use query builder
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
977aee5ab3
refactor: backticks aren't allowed in order_by or group_by
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
90ed0502fa
refactor: support new function style
- Migrate all SQL function usage from string format to dict format
- Old: fields=['count(*) as count']
- New: fields=[{'COUNT': '*', 'as': 'count'}]
- Add `NULLIF`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
5d3f7aaab9
refactor: use qb_query for get_list
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Akhil Narang
340fe279b3
feat: add in initial version of DatabaseQuery using query builder
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-11-19 21:15:57 +05:30
Soham Kulkarni
518e94ea98
Merge pull request #34769 from sokumon/desktop-fixes
fix: delete desktop icons when app is uninstalled
2025-11-19 16:45:36 +05:30
sokumon
7c93730cfc fix: semgrep issues 2025-11-19 13:21:52 +05:30
sokumon
a0edd3e3f2 fix: delete desktop icons when app is uninstalled 2025-11-19 12:30:15 +05:30
Soham Kulkarni
7aba4a3dfd
Merge pull request #34766 from sokumon/desktop-fixes
fix: dark mode for folder icons and desktop icon access restrict
2025-11-19 10:58:52 +05:30
sokumon
656aaa1f2f feat: show restricted desktop icons 2025-11-19 10:33:22 +05:30
Akhil Narang
1e2d730202
Merge pull request #34670 from trustedcomputer/cogkfix-host-url-when-printing-outside-request
fix: Get host URL when printing outside of request
2025-11-18 17:39:32 +05:30
sokumon
ed56722b03 fix: folder icon styles polish 2025-11-18 15:22:29 +05:30
Soham Kulkarni
7f72e988af
Merge pull request #34744 from sokumon/desktop-fixes
fix: set a fix width of sidebar header
2025-11-18 14:09:47 +05:30
Ankush Menat
0583c6875c
fix: Tolerate version creation failure during remove_from_installed_apps (#34754)
These functions are usually called when site is not migated, so version
schema mismatch will result in failure that makes it impossible to use
this function.

This change:
- tries creating version
- if fails, tries without creating version
2025-11-18 08:25:00 +00:00
rohitwaghchaure
53f7bca5f3
Merge pull request #34663 from rohitwaghchaure/fixed-read-lock-for-series
fix: read lock applied while fetching the current value from the tabSeries
2025-11-18 12:04:43 +05:30
Rohit Waghchaure
2b0ee31cb4 fix: read lock applied while fetching the current value from the tabSeries 2025-11-18 11:51:10 +05:30
Ejaaz Khan
bff514d313
Merge pull request #34730 from iamejaaz/34648-duplicate-row-fix
fix: hide duplicate button after action
2025-11-18 11:45:15 +05:30
Ejaaz Khan
9c0b593b51
Merge pull request #34714 from rehanrehman389/console-fix
fix: failure caused by mandatory depends on
2025-11-18 11:42:53 +05:30
mergify[bot]
fd9317b886
Merge branch 'develop' into 34648-duplicate-row-fix 2025-11-18 06:01:48 +00:00
sokumon
2e21d6d804 fix: set a fix width of sidebar header 2025-11-18 11:30:21 +05:30
Soham Kulkarni
111427abe0
Merge pull request #34742 from sokumon/desktop-fixes
fix: check in_import before exporting
2025-11-18 10:56:31 +05:30
sokumon
e0f0d5a0c9 fix: match awesombar styles 2025-11-18 10:32:12 +05:30
sokumon
2def9cd40f fix: check in_import before exporting 2025-11-18 10:21:44 +05:30
Soham Kulkarni
0eef9d9ef5
Merge pull request #34732 from sokumon/desktop-fixes
fix: show logo url if it exists
2025-11-18 09:38:59 +05:30
sokumon
589c48d712 fix(menu): apply href on anchor tag 2025-11-18 00:58:36 +05:30
sokumon
fa0524d349 fix: show logo url if it exists 2025-11-18 00:34:58 +05:30
Soham Kulkarni
4cadaa844c
Merge pull request #34736 from sokumon/ci-db-version
fix(ci): set mariadb version in repo setup
2025-11-18 00:34:03 +05:30
sokumon
661820415c fix(ci): set mariadb version in repo setup 2025-11-17 23:43:51 +05:30
Ejaaz Khan
56ab477bfe fix: hide duplicate button after action 2025-11-17 17:39:32 +05:30
rohitwaghchaure
a2ab8a654a
Merge pull request #34728 from rohitwaghchaure/fixed-placing-icon
fix: desktop icon placing
2025-11-17 17:27:30 +05:30
Rohit Waghchaure
8970141da6 fix: desktop icon placing 2025-11-17 17:02:19 +05:30
Ejaaz Khan
6225755971
fix(Website): throw error only if images are attached (#34725) 2025-11-17 16:37:37 +05:30
Ejaaz Khan
faeeecb1a6 fix(Website): throw error only if images are attached 2025-11-17 16:16:53 +05:30
Saqib Ansari
d4a0181379
Merge pull request #33905 from nextchamp-saqib/custom-perm-types
feat: custom permission types
2025-11-17 16:00:17 +05:30
Ejaaz Khan
30ccd6a424
Merge pull request #34723 from iamejaaz/child-table-header-row
fix(Grid): minor height issue on focus
2025-11-17 15:59:17 +05:30