Shariq Ansari
0b9a9ebfac
fix: load avatars of user in notification dropdown ( #17630 )
2022-07-27 10:42:01 +05:30
Sagar Vora
84c6c09b80
fix: fallback to unscrubbed table fieldname if label not found ( #17599 )
2022-07-26 21:10:54 +05:30
Sagar Vora
70284ad6b0
fix: use comma as separator instead of space for offset ( #17627 )
2022-07-26 21:09:37 +05:30
Shariq Ansari
3216529deb
fix: Letter head image not working ( #17608 )
2022-07-25 17:46:27 +05:30
Gavin D'souza
d2a5b8b002
ci: Skip pre-commit on branch builds
2022-07-25 16:30:11 +05:30
gavin
2eccdad19d
Merge pull request #17605 from gavindsouza/ci-actions-refactor
...
ci: Actions Cleanup
2022-07-25 16:25:03 +05:30
Gavin D'souza
590e983a7f
ci: Rename release action
...
release.yml was a bit ambiguous given we have separate action configs
related to release event or intent.
2022-07-25 15:26:17 +05:30
Gavin D'souza
1e40b32ebf
ci: Combine actions to be triggered 'on release'
...
* Trigger static asset building & updating release assets
* Trigger Docker release build
2022-07-25 15:26:17 +05:30
Gavin D'souza
de97eaf603
ci: Merge vulnerable dependency check to linter action
2022-07-25 15:26:17 +05:30
Gavin D'souza
a7ab78bde1
ci(minor): Actions
...
* Rename CI actions to add database_type
* Add workflow_dispatch to assets build action on develop
* Rename unit test jobs for better labelling on PR check titles
* Rename Patch action for consistency
2022-07-25 15:26:12 +05:30
Gavin D'souza
4289e7c7ea
ci: Merge PR linter checks
...
* Combine jobs to be triggered at pull_request events: commit-lint,
docs-required, linter
* PY310-ize helper scripts
2022-07-25 14:33:30 +05:30
Gavin D'souza
31658e5241
ci: Install wkhtmltopdf in the background
2022-07-25 13:07:53 +05:30
Gavin D'souza
d23705f60c
ci: Cleanup install.sh
2022-07-25 13:06:07 +05:30
mergify[bot]
249e647fc4
Merge pull request #17592 from nabinhait/notify-mentions
...
feat: Enable mentions and notify users from any text field
2022-07-23 14:12:38 +00:00
Shadrak Gurupnor
c38f79edd6
style: Fix import order
2022-07-23 19:23:05 +05:30
mergify[bot]
b718bfe6b8
Merge pull request #17482 from ChillarAnand/cleanup
...
refactor!: Removed parse package
2022-07-23 06:44:22 +00:00
Ankush Menat
615f0dbcb8
Revert "refactor: desk missing doc handling"
...
This reverts commit d11fdc3ca4
2022-07-22 19:24:34 +05:30
Ankush Menat
d11fdc3ca4
refactor: desk missing doc handling
...
- reduce 1 query
- make normal and virtual doc behave in same manner
2022-07-22 18:50:06 +05:30
Shridhar Patil
0285d4f686
fix: frappe.db.exists will always return error for virtual doctype ( #17595 )
...
So first check whether the doctype is virutal
2022-07-22 18:49:38 +05:30
Nabin Hait
ad1de51b0d
Merge branch 'develop' into notify-mentions
2022-07-22 17:39:58 +05:30
Ankush Menat
ac83a0fdda
Merge pull request #17548 from ankush/fix_virtual_doctype
...
refactor!: Virtual DocType
2022-07-22 17:25:49 +05:30
Ankush Menat
0f83e9e944
fix: correct import path
...
Co-authored-by: gavin <gavin18d@gmail.com>
2022-07-22 16:24:02 +05:30
Ankush Menat
e35671203c
refactor: simplify virtual doctype example
2022-07-22 16:15:16 +05:30
Ankush Menat
d83712d553
feat: delete support for virtual doctypes from desk
2022-07-22 15:42:04 +05:30
Ankush Menat
4c877258f0
test: add tests for virtual doctype desk interactions
2022-07-22 15:34:54 +05:30
Nabin Hait
53c22b0493
feat: Enable mentions and notify users from any text field
2022-07-22 15:26:37 +05:30
gavin
7eb7ec2663
Merge branch 'develop' into cleanup
2022-07-22 15:10:34 +05:30
Gavin D'souza
9dba593a6e
refactor: Add typing + comprehensions for readability
2022-07-22 15:09:39 +05:30
Gavin D'souza
ad90923801
test(communication): Add test for handling duplicate email signatures
2022-07-22 14:59:47 +05:30
Ankush Menat
f1d638473f
refactor: add reload function back
...
Assigning a function to a different name breaks inheritance model.
E.g. doc.reload() won't call virtual doctype's load_from_db but call
original load_from_db
2022-07-22 14:50:13 +05:30
Ankush Menat
e8efd64dbc
refactor!: better API contracts for virtual doctype
...
Current APIs implement class methods as instance method, which is
problamamtic while implementing methods. E.g. If load_from_db doesn't
like empty docname then all class method will stop working.
This change while breaking is essential for usability of virtual
doctype.
2022-07-22 14:26:02 +05:30
Ankush Menat
b8d56eaefb
chore: remove test doctypes from prod
2022-07-22 14:25:49 +05:30
Ankush Menat
e88bc35cae
refactor: move is_virtual_doctype to relevant file
2022-07-22 14:25:48 +05:30
Shridhar
b2203893a1
fix: do not fetch comments from parent for virtual doctype
2022-07-22 14:25:48 +05:30
Ankush Menat
10da1622f4
fix: form view broken for virtual doctype
2022-07-22 14:25:48 +05:30
gavin
b52fdbba45
Merge pull request #16961 from gavindsouza/mariadb-client-refactor
...
refactor!: Database
2022-07-22 14:19:38 +05:30
gavin
f40214bca8
fix(get_last_doc): Allow for_update as kwarg only
...
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2022-07-22 13:34:04 +05:30
Gavin D'souza
d1fbab1c45
test(db): Add tests for untested db methods
2022-07-22 13:30:47 +05:30
Gavin D'souza
2bef29bb46
chore: Deprecate backup script + minor refactors
2022-07-22 13:21:29 +05:30
Gavin D'souza
1dbc0b4d3c
fix(db*): Use common fallback Datetime str
...
There existed inconsistencies between db_query & db's fallback for min
datetime in str format - missing decimal seconds places. Now, we're
storing the default string once and re-using it to reduce
inconsistencies or room for human errors.
2022-07-22 13:19:25 +05:30
Gavin D'souza
bcfa8c276e
fix: Set default port attribute for Database classes
...
db.default_port wil be available as a class attribute to hold defaults
for DB types.
Usage: frappe.conf.db_port or frappe.db.default_port
Why: I couldn't run the mariadb command because the defaults aren't set
for my system. server is remote / containerized. Setting port in
equivalent mysql command fixes this.
2022-07-22 13:16:26 +05:30
gavin
d285ce910f
Merge branch 'develop' into mariadb-client-refactor
2022-07-22 12:11:54 +05:30
Gavin D'souza
1a610e135d
fix(db): Use sentinel object for default values paramters
2022-07-22 12:11:01 +05:30
Gavin D'souza
e411132c6e
fix(db): Revert breaking change of wrapping NoneType in sequence
2022-07-22 12:11:01 +05:30
Gavin D'souza
63e618c709
test: More resilient tests for sequences
2022-07-22 12:11:01 +05:30
Gavin D'souza
006ebcbede
refactor: Use pymysql over mariadb client
...
This is supposed to be a temporary switch to make the parent PR easier
to digest. MariaDB client has some issues with release, and system
dependencies.
This commit may be reverted to enable mariadb client again.
2022-07-22 12:10:54 +05:30
Shariq Ansari
b1e9bc8d12
fix: error while genarating date for blog post google search preview ( #17581 )
2022-07-21 20:46:03 +05:30
Suraj Shetty
623650ab3b
Merge branch 'develop' of https://github.com/frappe/frappe into develop
2022-07-21 17:03:58 +05:30
Suraj Shetty
9e87598dda
refactor: Use FrappeTestCase as it rolls back test data
2022-07-21 17:03:52 +05:30
Ankush Menat
d2177d16a1
ci: bump node version to node16 ( #17564 )
...
* ci: bump node version to node16
* chore: remove `node-sass` - no longer used
Co-authored-by: Sagar Vora <sagar@resilient.tech>
2022-07-21 16:54:41 +05:30
