Commit graph

1375 commits

Author SHA1 Message Date
Ankush Menat
bbcc365a24
fix: use monotonic clock for timing code (#19138)
* fix: use monotonic time for timing code

`time.time()` depends on system clock which can drift away and get corrected
over time. If you're unlucky it will get corrected in your timing code
and give absurd results.

* test: dont check for status

can refresh and give wrong output

[skip ci]
2022-12-06 15:42:37 +05:30
Ankush Menat
6dda853278
fix: broken link for email tracking pixels (#19030) 2022-11-28 20:46:51 +05:30
Gavin D'souza
c3c1848b2a fix: Restrict socket data to respective users after commit
Fix conditions to bother only those who asked for the data:
- Clear permissions cache only for updated users' data
- Defer appropriate events until commit to avoid ghost events
- Remove event unused by desk (and other apps)
2022-11-16 23:07:07 +05:30
Sagar Vora
838a52328c fix: hardcode doctype in google oauth callback 2022-11-12 23:51:15 +05:30
Ankush Menat
a7377d23fc
refactor!: Drop deprecated functionality (#18815) 2022-11-11 19:54:36 +05:30
Andrew McLeod
01fe2da368
fix(email): generate random filename when attachment filenames are same upon inbound email (#18483)
Fix issue when an email has multiple inline images with the same filename. Currently the cid_map is overwritten; instead, attach the files with different names. Emails where every inline image has the filename 'image.png', only one of the images ends up correctly linked.
2022-10-24 00:37:49 +05:30
avc
94398aab0e
fix: Notifications. Get Alerts for Today button #18423 2022-10-17 12:32:05 +05:30
Ritwik Puri
43101e0356
fix(minor): consider only email id as sender email for auto email report (#18231) 2022-09-27 13:46:30 +05:30
Devin Slauenwhite
4affd9b076
feat: specify sender for auto email report (#18073)
Co-authored-by: phot0n <ritwikpuri5678@gmail.com>
2022-09-16 18:56:36 +05:30
Nrtyck
1e87483a2c
fix: Must check array length (#18161)
If not check , it will not  work
2022-09-16 17:05:05 +05:30
phot0n
94795aa571 test: fix test_retry_partially_sent_newsletter and add stricter assertions 2022-09-06 22:11:08 +05:30
phot0n
d49a35ce5e refactor(minor): get_success_recipients -> get_queued_recipients
* chore: remove status filter from get_queued_recipients (previously
  get_success_recipients)

* chore: removed not used statuses from Email Queue Recipient
2022-09-06 22:11:08 +05:30
Ritwik Puri
7fae79c200
Merge pull request #17883 from phot0n/fetch-domain-values
fix: fetch email domain values for email account
2022-08-23 11:16:58 +05:30
phot0n
141693a75b fix: use debounced frappe.call on domain selection
Also removed  tag from domain and service labels in email account doctype
2022-08-23 00:36:53 +05:30
Sagar Vora
c5face41b3 fix: clear notifications cache when deleting a Notification 2022-08-22 19:04:18 +05:30
Ankush Menat
2eec621e95 chore: db.get_all -> get_all
Reduces 1 pointless function call.
Function calls are also not "super cheap" in python.
2022-08-22 11:35:14 +05:30
phot0n
c450058a37 chore: move all email domain attributes to a global variable 2022-08-19 23:56:20 +05:30
phot0n
a3cd00a3ed fix: fetch values from email domain for email account
* chore: remove dead code related to fetching the same
2022-08-19 20:42:00 +05:30
HENRY Florian
11a17d3867
feat: STARTTLS authentication for IMAP (#17683)
Co-authored-by: phot0n <ritwikpuri5678@gmail.com>
2022-08-19 13:40:06 +05:30
phot0n
613d8472b4 test: skip badly written test temporarily 2022-08-17 16:39:42 +05:30
Ankush Menat
1c9ea57279 fix: dont use sendmail with now=True 2022-08-17 16:39:42 +05:30
Ankush Menat
3e2d2a703a test: Use FrappeTestCase everywhere 2022-08-17 16:39:42 +05:30
Ankush Menat
b7a7f97a7a refactor: convert get email count query to ORM
- also fix capitalization of column names on postgres
2022-08-16 10:53:28 +05:30
P-Godfroid
62420f78ae
fix: update append_to misleading message in email account (#17718)
* chore: remove append_to field from email domain doctype

* minor: add incoming and outgoing server fields to list view

Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2022-08-10 21:50:00 +05:30
phot0n
dc6be2de48 refactor: add handle_error decorator and cleanup server validations 2022-08-09 15:46:15 +05:30
phot0n
037746cddc feat(minor): fetch attachment_limit from get_max_file_size api 2022-08-09 14:49:18 +05:30
phot0n
f6c8c927d8 feat(minor): add connection link to email accounts in email domain 2022-08-09 14:49:00 +05:30
phot0n
dfbe25e1a2 refactor(minor): move out email domain validations to different methods
* used Timed mixins for incoming server validation to emulate things as close to email account
2022-08-09 13:35:02 +05:30
phot0n
ff0899e458 fix: consistent fieldnames and keep port alongside server field 2022-08-09 13:35:02 +05:30
phot0n
515fafd9a5 chore: add headline for letting users know about how email domain sets attributes 2022-08-09 13:34:59 +05:30
phot0n
0614c4098c chore: remove example email id field from email domain 2022-08-09 13:34:48 +05:30
phot0n
d5aa898151 chore: remove unnecessary autoname controller hook 2022-08-09 13:34:33 +05:30
phot0n
9fee012389 chore: remove unnecessary refresh event from email domain 2022-08-09 13:34:31 +05:30
phot0n
b31b99aaca fix(ux): email domain doctype 2022-08-09 13:34:11 +05:30
Ankush Menat
40f27f908a style: format JS files with prettier 2022-08-04 14:51:01 +05:30
Gavin D'souza
85e3ee9403 chore: Minified DocType JSON notation from old verbose notation 2022-08-03 12:22:03 +05:30
P-Godfroid
2d1fe02dba
fix: Append to condition misleading message (#17696)
* Update Append to doctype description

Hello,

To append email to a doctype to enable automatic creation, there are two required fields listed
![image](https://user-images.githubusercontent.com/109596710/182173486-d7141ec9-451d-4de9-8303-a8e8dbd289bf.png)

However, there is a third one required which is lacking in the above description (as seen below), because the email settings of the document must be enabled.
![image_2022-08-01_163225456](https://user-images.githubusercontent.com/109596710/182173390-7285e92f-6f04-4e42-a215-ad45e50e0fd3.png)

I propose to simply modify the sentence to the following :

Append as communication against this DocType (must have fields ("Status", "Subject") and "Sender" defined in the related doctype Email Settings).


To avoid any problem, in the code, it becomes the following : 
Append as communication against this DocType (must have fields (\"Status\", \"Subject\") and \"Sender\" defined in the related doctype Email Settings).


The same must be applied in email_domain.json and in lots of csv in translations of course.

Pierre

* Update email_domain.json

* Updated sentence email account

* Updated sentence of email domain

* More brackets

* More brackets

* Typo

* Update email_account.json

* No dot
2022-08-02 15:20:19 +05:30
phot0n
16f9a2e811 fix: clear password when saving account with Oauth 2022-07-30 00:03:02 +05:30
Gavin D'souza
1ccdad811a Merge branch 'develop' of github.com:frappe/frappe into mariadb-client-refactor 2022-07-19 16:23:24 +05:30
Ankush Menat
066d5a4245
Merge pull request #17528 from phot0n/mis-fixes-goauth
fix: misc fixes (google oauth)
2022-07-19 15:55:24 +05:30
Sagar Vora
4b0a9da400 refactor: rename hold_queue to suspend_email_queue 2022-07-18 22:32:12 +05:30
Sagar Vora
9a7f92ca1d fix!: allow system managers to toggle email queue 2022-07-18 16:53:49 +00:00
phot0n
1fd47f1c10 chore: remove unused no_remaining field from email account doctype 2022-07-18 10:53:27 +05:30
phot0n
f679dc3fdd fix(security): restrict the god google callback
the common google callback can be used to trigger any method in the whole codebase
restrict it by only allowing domain specific callback method and raise
an error if the domain is not found
2022-07-17 21:37:21 +05:30
phot0n
8edae2ce09 fix: encrypt access_token when setting in db after refreshing access_token 2022-07-17 21:35:06 +05:30
phot0n
7d5262f5e0 chore: translate authorization message and add nosemgrep 2022-07-13 12:50:04 +05:30
phot0n
9090b0fe3a chore: remove unnecessary failure_query_param for email oauth 2022-07-13 12:41:32 +05:30
phot0n
01a1860491 fix(ux): better ux for successful oauthorization 2022-07-13 12:05:46 +05:30
phot0n
d1a199258d fix: pull from accounts for oauth whose refresh_token is not null
* chore: rename Oauth to OAuth
2022-07-13 12:05:46 +05:30
phot0n
81bb9c411a chore: fix sider 2022-07-13 12:05:46 +05:30