Commit graph

280 commits

Author SHA1 Message Date
Ankush Menat
35ba00a54e
fix: handle isatty correctly (#18277)
sys.stdin can be `None`

[skip ci]
2022-10-03 12:05:55 +05:30
Ankush Menat
abeed35461
fix: throw exception if backup failed (#18230) 2022-09-28 14:29:38 +05:30
Ankush Menat
c76277f1bf fix: correctly order args and kwargs 2022-09-26 11:26:03 +05:30
Ankush Menat
17d327719e build(deps): drop unused dependencies
- googlemaps
- google-auth-httplib2
- urllib3
- pypng
- pyasn1
- gitdb
2022-08-26 10:23:09 +05:30
Ankush Menat
b7a7f97a7a refactor: convert get email count query to ORM
- also fix capitalization of column names on postgres
2022-08-16 10:53:28 +05:30
Ankush Menat
3fa4ec1bd6 refactor: container utils and misc tests 2022-08-16 10:53:28 +05:30
Ankush Menat
ad4cb710f2 refactor: duplication in gravatar code 2022-08-16 10:53:28 +05:30
Ankush Menat
9b5565437c refactor: extract_email_id condition
The condition made no sense and could never be True.
2022-08-16 10:53:28 +05:30
Ankush Menat
9bf9256049 test: validate name 2022-08-16 10:53:28 +05:30
Ankush Menat
26bf65b87c test: phone number validation 2022-08-16 10:53:28 +05:30
Gavin D'souza
a428c73a90 refactor: Itenticon
* Use later updated library code (fixes bug) from existing vendored dependency
* Update attributions.md
* Simplify usage in get_gravatar
2022-08-11 23:53:21 +05:30
Gavin D'souza
7f2c9e84b3 feat(minor): Expose use_cookies kwarg to test client 2022-08-02 17:30:07 +05:30
Faris Ansari
21bbe18cc4 fix: absolute option for terminal progress bar 2022-07-27 12:37:19 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features (#17367)
refactor: clean up code to py39+ supported syntax

- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes

Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
Suraj Shetty
8e2555f510
fix: Erroneous regex usage
Fixes: https://github.com/frappe/frappe/pull/17111#issuecomment-1150118499

Issue introduce via: https://github.com/frappe/frappe/pull/17111
2022-06-09 07:12:04 +05:30
Gavin D'souza
b696fa6da5 perf: Pre-compile and re-use regexp pattern
Converted all possible usages of re.* that weren't compiling the regex
separately and re-using it. Separated out the compiled patterns as
global variables. Repetitive patterns could be made DRY-er.

Would be nicer to have all regexes in a single module so that we could
re-use better, keep track of outdated, and keep checks for possible
reDos' etc
2022-06-08 14:07:38 +05:30
Suraj Shetty
ccc82e2c4c
Merge pull request #15538 from noahjacob/phone_field_control
feat: Phone Control Type
2022-04-28 10:27:52 +05:30
Gavin D'souza
418dcdd2f4 fix!: Use event as a differentiator for frappe.utils.log 2022-04-21 13:33:40 +05:30
Gavin D'souza
4e533682ba feat: get_traceback with context 2022-04-21 13:26:12 +05:30
Suraj Shetty
a396afc7d4 fix: Validation error 2022-04-14 17:05:07 +05:30
Suraj Shetty
48cd1c2ad4 refactor: Fix naming and simpify code
- Ability to clear code, by hiting backspace
2022-04-14 14:14:00 +05:30
Noah Jacob
1637e3af08 fix: linting 2022-04-12 21:06:59 +05:30
Noah Jacob
c2f2fc10e7 Merge branch develop into phone_field_control 2022-04-12 20:40:29 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black (#16453)
Co-authored-by: Frappe Bot <developers@frappe.io>
2022-04-12 10:59:25 +05:30
Noah Jacob
2d3c1053a0 refactor(ui): updated validation messages with fieldname 2022-04-11 15:25:27 +05:30
Noah Jacob
bf92b363e2
Merge branch 'develop' into phone_field_control 2022-04-07 15:04:47 +05:30
Noah Jacob
7d49693a33 refactor: updated error messages for invalid phone numbers 2022-04-07 15:04:26 +05:30
Sagar Vora
e02e640497 perf: dont cache assets_json in Redis for developer_mode 2022-03-31 14:50:15 +05:30
Sagar Vora
987b47557d perf: cache parsed assets_json instead of string 2022-03-31 12:28:23 +05:30
Noah Jacob
579d0643c4 Merge branch 'develop' into phone_field_control 2022-03-22 15:05:45 +05:30
saxenabhishek
c53e6d822d feat: parse app name from tags and urls 2022-03-22 14:16:59 +05:30
Rushabh Mehta
0b8a2edee7 fix(build): separate assets.json and assets-rtl.json to fix concurrency issue 2022-03-17 14:54:17 +05:30
Gavin D'souza
8b01c04a75 chore: Add type hints 2022-02-11 13:18:24 +05:30
Gavin D'souza
188373b1eb refactor(test): Frappe REST Test Suite
* Use Werkzeug Test Client instead of requests
    This change should start tracking coverage for the `api` module.
    Committing to ensure state maintainence will not be necessary.
* Refactor get_test_client to reset locals on each request
* Separate FrappeAPITestCase to enable formation of a generic API testing engine.
2022-02-09 17:02:40 +05:30
phot0n
b31f3c24f6 refactor: remove parent, parenttype, parentfield, idx columns from non-child table doctypes
* feat: add parent, parenttype, idx, parentfield columns to doctypes when transitioning from normal -> child table

* fix: remove parent, parenttype, parentfield, idx from DocType DocType
2022-02-07 15:12:37 +05:30
Gavin D'souza
5b6ceb5543 Merge branch 'develop' of github.com:frappe/frappe into set_value-refactor 2022-01-28 18:39:12 +05:30
Gavin D'souza
8037866dc1 fix: Handle parsing and formatting timedeltas
* Added utils parse_timedelta, format_timedelta
* Added to json_handler for de-serializing timedelta objects
2022-01-28 18:33:03 +05:30
Shariq Ansari
54b3a32968 fix: get timezone in user_info 2022-01-25 16:19:49 +05:30
barredterra
b1383df15a refactor: use is None instead of == None 2022-01-17 10:37:51 +01:00
Gavin D'souza
227dc26707 Merge branch 'develop' of github.com:frappe/frappe into set_value-refactor 2022-01-17 14:04:13 +05:30
Suraj Shetty
b180854766
Merge branch 'develop' into phone_field_control 2022-01-14 20:11:11 +05:30
Rushabh Mehta
545a3a3ac4 fix(minor): handle for illegal user 2022-01-13 18:49:18 +05:30
Rushabh Mehta
853287f49d fix: load user_info on-demand 2022-01-13 16:39:24 +05:30
Gavin D'souza
6aa9a0bef5 style: Sorted imports & whitespace consistency 2022-01-07 20:44:51 +05:30
Noah Jacob
b25f7cc805 Merge branch develop into phone_field_control 2022-01-07 13:47:58 +05:30
Noah Jacob
b45e5dda63 refactor: moved phone_validation to frappe.utils 2022-01-07 13:40:03 +05:30
Rutwik Hiwalkar
1ec54c87c8
feat: patched frappe email to work with frappecloud mail app (#15248)
* feat: patched EmailQueue.send and frappe.utils.get_formatted_email

* chore: renamed hooks and handled an edge case

* fix: if the get_sender_details hook is defined but it returns invalid input
2021-12-12 21:09:31 +05:30
Ankush Menat
00d38d568c
fix: remove slash prefix 2021-12-12 15:20:50 +05:30
Ankush Menat
38cd12a95b fix: remove bench path from traceback
This is mostly useless for debugging and clutters the error message.
2021-12-12 11:53:13 +05:30
Kevin Backhouse
2f99306d63
Fix ReDoS bug: GHSL-2021-122 (#15201) 2021-12-08 04:57:07 +00:00