marination
5b319f0830
test: Check if Kanban Board is not editable by non-system user who does not own the board
...
- User should only be able to view the board, and drag the cards
- No column actions, no board actions
2022-12-29 23:11:30 +05:30
Hussain Nagaria
e96ce83343
test: not in list view by default for not allowed mandatory field types
2022-12-29 17:40:58 +05:30
Hussain Nagaria
f1553c479c
fix(test): override fields of test doctype if passed
2022-12-29 16:20:07 +05:30
Faris Ansari
faae4e7a86
Merge pull request #19433 from netchampfaris/allow-video-files
2022-12-29 16:09:10 +05:30
Faris Ansari
d60acc7cb4
fix: allow video files to be uploaded
2022-12-29 15:40:41 +05:30
Hussain Nagaria
048de262fd
fix: don't set default in list view for fields not allowed
2022-12-29 15:24:59 +05:30
Ritwik Puri
db0baa2da3
Merge pull request #19422 from gavindsouza/rename-socketio-events
...
fix(socketio): Event list_update > doctype_subscribe
2022-12-29 14:02:21 +05:30
marination
49143922c5
chore: Kanban and ToDo UI test helpers
...
- `create_admin_kanban` and `create_todo` UI test helpers
- `switch_to_user` Cypress command: logs out and logs in as specified user
- Used `remove_role` in permissions test
- Used `switch_to_user` command in test helper
2022-12-28 23:00:00 +05:30
Gavin D'souza
c960382667
fix(socketio)!: Event list_update > doctype_subscribe
2022-12-28 00:25:58 +05:30
Gavin D'souza
d13c377848
refactor: OAuth
...
* Added typing hints for Oauth APIs and dependant utils
* Simplify oauth core flows
* Remove long commented code
* Use newer, simpler syntax for better readability
2022-12-27 19:25:43 +05:30
rohitwaghchaure
a72fdcbd89
fix: not able to make delivery note from pick list ( #19418 )
2022-12-27 17:58:04 +05:30
marination
d5c4af53d8
chore: Cleaner Cypress commands
...
- Clearer APIs `add_role` and `remove_role`
2022-12-27 17:00:00 +05:30
Ritwik Puri
de525b2ef1
Merge pull request #19411 from phot0n/autoname-child-table
...
fix(minor): dont set autoincrement autoname by default for child table
2022-12-27 15:57:57 +05:30
Gavin D'souza
ef82ef944e
fix: build_response for re.Match
2022-12-27 14:17:09 +05:30
Ritwik Puri
09e500ea90
Merge pull request #19407 from adityahase/fix-subscription-manage
...
fix(subscription): Allow remote_login even if subscription.expiry is not set
2022-12-27 12:56:53 +05:30
phot0n
8ea093b973
fix(minor): dont set autoincrement autoname by default for child table
2022-12-27 12:48:47 +05:30
Shariq Ansari
dc8aad9bbd
Merge pull request #19391 from shariquerik/cmd/ctrl-to-see-fieldname
2022-12-26 16:32:46 +05:30
marination
ef75e0f9b8
fix: Dispatch update_order always. Handle perm-wise action in backend
...
- Currently, `update_order` is also responsible for fetching fresh column order from db as well updating card order
- In the .py file, return board doc if no write permission as that is used to render thr right columns order
- Without it, stale order (before moving columns) is restored as there is no db call getting columns that were last stored
2022-12-26 16:05:07 +05:30
Aditya Hase
6f8a087c5f
fix(subscription): Allow remote_login even if subscription.expiry is not set
...
remote_login is used for the "Subscribe" banner as well as the Manage Subscription button.
2022-12-26 14:18:58 +05:30
Shariq Ansari
70fac30e77
Merge branch 'develop' into kanban-access-w-perms
2022-12-26 12:27:59 +05:30
Shariq Ansari
a6db8ab5bc
fix: removed footer
...
Capitalized log in to frappe button
2022-12-26 12:19:55 +05:30
Shariq Ansari
24b5d0fb7b
Merge branch 'develop' into cmd/ctrl-to-see-fieldname
2022-12-26 12:03:35 +05:30
Hussain Nagaria
b9a6db3c08
refactor: ngrok_auth_token -> ngrok_authtoken
...
* to be consistent with ngrok's naming convention
2022-12-24 12:45:24 +05:30
Hussain Nagaria
5c7b583582
fix(commands): require ngrok auth token in site_config.json to use ngrok command
...
* ngrok authtoken is now required to use the host_header feature
2022-12-24 12:32:51 +05:30
Sabu Siyad
5e6ac70644
fix(link/js): handle undefined link_title_doctypes in frappe.boot ( #19398 )
...
Signed-off-by: Sabu Siyad <hello@ssiyad.com>
Signed-off-by: Sabu Siyad <hello@ssiyad.com>
2022-12-24 11:07:28 +05:30
Sagar Vora
1458429d98
chore(Document): remove code that resets self.latest ( #19399 )
2022-12-24 00:13:28 +05:30
Sagar Vora
d072e20cbd
chore: fix typo
2022-12-23 06:13:07 +00:00
Sagar Vora
7fdcafddce
chore: remove code for handling old dict cache
2022-12-23 06:13:07 +00:00
marination
5d0ad77d62
fix: Hide Menu if empty & render columns without state change
...
- 'Refresh' btn is always present in dropdown menu. Show menu if any other action is also present.
- Without `update_order` state is not changed, and thus columns are not rendered on `init()`
- If we are not updating order in the db, render columns with whatever information we have currently
2022-12-23 00:44:53 +05:30
Marica
988b725b67
Merge branch 'develop' into kanban-access-w-perms
2022-12-22 19:45:40 +05:30
stephen
6b0950e1d2
fix: prevent emails from being queued multiple times ( #19386 )
...
* fix: prevent emails from being queued multiple times
* style: fmt
* refactor: optimistic error handling
- Combined email queue sending to single call instead of different
branches for testing.
- If failing to get jobs -> attempt sending anyway. Failure could be
form one bad job which shouldn't completely stop everything.
* chore: type
Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-12-22 19:02:18 +05:30
Shariq Ansari
64569c39eb
fix: missed not operator
2022-12-22 17:50:42 +05:30
Shariq Ansari
22192686c3
Merge branch 'develop' into cmd/ctrl-to-see-fieldname
2022-12-22 17:47:19 +05:30
Shariq Ansari
8c9c9b9f37
fix: support ctrl key for linux/windows
2022-12-22 17:46:14 +05:30
Shariq Ansari
1b8bf0f64c
Merge branch 'develop' into cmd/ctrl-to-see-fieldname
2022-12-22 15:55:24 +05:30
Saqib Ansari
296ef1f9bd
chore: add methodname to monitor log ( #19388 )
2022-12-22 14:18:42 +05:30
Bread Genie
9e79df9802
ci: use $GITHUB_OUTPUT instead of set-output ( #19389 )
...
* refactor(boilerplate): use `$GITHUB_OUTPUT` instead of `set-output`
* ci: use `$GITHUB_OUTPUT` instead of `set-output`
* fix: remove unterminated string literal
2022-12-22 14:16:09 +05:30
Shariq Ansari
5b75ac9d22
feat(minor): show fieldname on hover in non-dev mode when cmd/ctrl is pressed
2022-12-22 11:34:37 +05:30
Ankush Menat
a18e63ef92
fix: Allow emailing disabled user ( #19382 )
...
Not sure why we need to validate this. A disabled user can still exist
outside of system with same active email address.
2022-12-21 15:10:50 +05:30
Shariq Ansari
289aa9a13b
test: test valid & invalid key
2022-12-21 14:43:10 +05:30
Bread Genie
211880d693
fix(boilerplate): add redis services in GHA ( #19376 )
...
* feat(boilerplate): add redis services
* chore: bump all action versions
[skip ci]
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2022-12-21 12:39:00 +05:30
Ankush Menat
1ab85a66c5
ci: better release notes generation ( #19380 )
...
[skip ci]
2022-12-21 12:14:35 +05:30
Shariq Ansari
8dad07949a
chore: again renaming to Login with email link
2022-12-20 21:53:13 +05:30
Shariq Ansari
eb7293c1d2
fix: suggested changes and added passwordless_login_expiry option
...
rate limit, better description, redirect_post_login, removed subject
2022-12-20 18:21:22 +05:30
Ahmed Hasanin
bb5e21de5f
fix(error snapshot): fix seen update qeury in error snapshot to work with postgres ( #19373 )
...
[skip ci]
2022-12-20 17:52:48 +05:30
Shariq Ansari
83bf33c1fc
fix: renamed login without password to passwordless login
...
made text translatable in email template
2022-12-20 16:14:46 +05:30
Ankush Menat
272d9e0085
fix: shift-select checkboxes ranges ( #19367 )
...
This doesn't work if document names have spaces in them. This is because
data props are urlencoded while we are comparing it with raw data.
2022-12-20 16:06:46 +05:30
Shariq Ansari
68baa81f3f
fix: type checking
...
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2022-12-20 15:33:03 +05:30
Ankush Menat
8c947f5abf
Merge branch 'develop' into login-without-password
2022-12-20 15:19:32 +05:30
Ankush Menat
3ff49ec0ad
fix: mariadb convert port to string for os.execv
2022-12-20 15:14:38 +05:30