Gavin D'souza
4df118906f
fix: Run test skipped earlier due to missing indent
2021-08-19 20:10:11 +05:30
Gavin D'souza
32c6cf1c44
refactor(misc): frappe.db.delete > frappe.db.sql
...
Use frappe.db.delete wherever possible. Get rid of all the frappe.db.sql ;)
This commit focuses on the pending modules that had relatively easier
DELETE statements.
2021-08-19 19:53:16 +05:30
Gavin D'souza
ebc220db39
refactor(tests): frappe.db.delete > frappe.db.sql
...
Use frappe.db.delete wherever possible. Get rid of all the frappe.db.sql ;)
This commit focuses on the tests written under the doctype specific
tests
2021-08-19 19:50:48 +05:30
Gavin D'souza
c00a5003f4
refactor(tests): frappe.db.delete > frappe.db.sql
...
Use frappe.db.delete wherever possible. Get rid of all the frappe.db.sql
;)
This commit focuses on the frappe.tests module
2021-08-19 19:48:42 +05:30
Suraj Shetty
07906594e3
test: Fix failing test
2021-08-19 19:33:37 +05:30
Gavin D'souza
6b789ec53a
fix: Revert auto_commit after frappe.sendmail
2021-08-19 18:44:36 +05:30
Suraj Shetty
133be72dfd
fix: Do frappe.db.commit() only for GET request
2021-08-19 18:21:40 +05:30
mergify[bot]
4cbf2c40e6
Merge pull request #13958 from ankush/pw_reset
...
fix: broken template in password reset
2021-08-19 12:46:29 +00:00
mergify[bot]
53e2c21a6a
Merge pull request #13915 from gavindsouza/newsletter-refactor
...
refactor(minor): Newsletter
2021-08-19 12:35:52 +00:00
Suraj Shetty
1cf1bc1e06
refactor: Remove unused functions
2021-08-19 17:48:40 +05:30
Suraj Shetty
ebc9d35da1
fix: File name from data URI headers
2021-08-19 17:39:45 +05:30
Suraj Shetty
bc234e9052
test: Add test case for extract_image_from_doc
2021-08-19 17:38:09 +05:30
Suraj Shetty
44c82276e8
refactor: Remove unused methods
2021-08-19 17:37:01 +05:30
Suraj Shetty
21e664b23b
test: Fix file_name assertion
2021-08-19 16:02:20 +05:30
Suraj Shetty
6b1955b34a
test: Add test image file
2021-08-19 15:27:48 +05:30
Suraj Shetty
a7fb1816aa
refactor: Remove unused and redundant code
2021-08-19 15:27:25 +05:30
Suraj Shetty
1427712c88
test: Add test cases for file
...
- file_url validations
- make_thumbnail
2021-08-19 14:41:25 +05:30
Suraj Shetty
c681b1af27
fix: Make thumbnail function
2021-08-19 14:40:20 +05:30
shariquerik
ca4d220f14
fix: sider fix
2021-08-19 14:20:18 +05:30
shariquerik
6a599f77eb
fix: Content validation
2021-08-19 14:07:52 +05:30
shariquerik
bb55ca4c29
fix: Make title and label field mandatory
2021-08-19 12:51:40 +05:30
shariquerik
1032d3a7d1
fix: Removed default collapsing sidebar section
2021-08-19 12:49:45 +05:30
shariquerik
461dfd6c6e
fix: Make Content hidden and added validation
2021-08-19 12:42:43 +05:30
shariquerik
b96b4c90f7
fix: Can't navigate to webpage with name same as private workspace
2021-08-19 12:30:59 +05:30
shariquerik
68263b8663
fix: App without home page gives error when navigate to home
2021-08-19 12:27:44 +05:30
mergify[bot]
eb218a06d1
Merge pull request #13959 from mituldavid/testing-library
...
test: Add support for Testing-Library queries within Cypress tests
2021-08-19 04:51:56 +00:00
Deepesh Garg
2fcd3b556d
fix: Use query report build_xlsx_data function for XLSX and CSV format
2021-08-18 22:53:35 +05:30
Mohammad Hasnain Mohsin Rajan
12c106719d
style: close curly brace on the same line
2021-08-18 20:44:36 +05:30
hasnain2808
eb37566ac0
feat: min lines for ace editor
2021-08-18 20:34:58 +05:30
Deepesh Garg
5640366757
fix: Handle null values rows for XLSX format
2021-08-18 19:59:56 +05:30
MitulDavid
29dfffb9c5
refactor: Replace .format() with f-strings
2021-08-18 19:32:16 +05:30
MitulDavid
93198b7123
test: Replace existing queries with Testing-Library queries
2021-08-18 19:11:01 +05:30
Suraj Shetty
e77fd18cec
Merge branch 'develop' into maxlines-argument-to-ace-editor
2021-08-18 15:37:01 +05:30
Manuel
06e13ad01d
Merge branch 'frappe:develop' into develop
2021-08-18 10:57:52 +02:00
hasnain2808
6da11e7a26
fix: use snake case
2021-08-18 14:06:11 +05:30
Mohammad Hasnain Mohsin Rajan
03c975a1f1
fix: use snake case
...
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-08-18 14:03:22 +05:30
Mohammad Hasnain Mohsin Rajan
f3e0a30ec7
style: add space after else keyword
2021-08-18 13:55:33 +05:30
Suraj Shetty
b23713bf5d
Merge branch 'develop' of https://github.com/frappe/frappe into core-test-coverage-1
2021-08-18 13:39:34 +05:30
Shariq Ansari
3baa33d5da
fix: Use IP Address instead of Email field ( #13553 )
2021-08-18 13:21:10 +05:30
hasnain2808
68b9ae808b
feat: maxLines in ace editor
2021-08-18 12:35:05 +05:30
Rushabh Mehta
cf67f9d283
fix(minor): remove url from metatags
2021-08-18 12:01:44 +05:30
Deepesh Garg
3fd60b70ee
fix: Length change for docfield not updated in Database
2021-08-18 11:42:44 +05:30
Suraj Shetty
fe15028df3
test: Fix reset password test
2021-08-18 10:20:08 +05:30
Suraj Shetty
093c72e963
test: Update role profile test case with more assertions
2021-08-18 09:04:01 +05:30
Suraj Shetty
7217277394
test: Fix flaky test
2021-08-18 09:03:03 +05:30
Suraj Shetty
d1c63a4b54
refactor: Move code to appropriate location
...
- update_roles had no use in user.py so moved it to role_profile.py where it is actually used
2021-08-18 08:22:48 +05:30
Suraj Shetty
604263929f
test: Add more assersions to test cases
...
- for better coverage
2021-08-18 08:20:22 +05:30
Leela vadlamudi
d3bc38f5aa
Merge pull request #13961 from leela/fix-amend-patch-query
...
fix: rename cancelled docs patch query
2021-08-17 23:49:31 +05:30
leela
05166f919c
fix: rename cancelled docs patch query
...
use backquotes in queries where column names are dynamic(To avoid query
issues incase reserved keywords used as a table columns.)
2021-08-17 22:48:52 +05:30
MitulDavid
b417218f1d
test: Add support for Testing-Library queries within Cypress tests
2021-08-17 19:06:01 +05:30
