Commit graph

36088 commits

Author SHA1 Message Date
Gavin D'souza
8fc2577e9a fix: Remove cross import statements 2021-08-12 17:44:14 +05:30
shariquerik
e4e79dd424 test: minor fix 2021-08-12 17:41:53 +05:30
Gavin D'souza
233b42b945 Merge branch 'develop' of github.com:frappe/frappe into execute-query 2021-08-12 17:35:25 +05:30
Gavin D'souza
43b9b452ff fix: Don't clear Newsletter table at setupClass 2021-08-12 17:30:23 +05:30
mergify[bot]
3dc9dfe0c7
Merge pull request #13842 from netchampfaris/safe-render-off
fix: ability to disable safe_render for template pages
2021-08-12 11:54:32 +00:00
Gavin D'souza
d5739cd43b fix: Add exceptions classes for Newsletter 2021-08-12 16:47:01 +05:30
Gavin D'souza
1015283731 fix(global_search): Typecast variable for comparision
Previously start was being type casted with int. That was reverted by refactoring query to use new Query Builder
This bug was introduced via ee3c84beef
2021-08-12 16:23:40 +05:30
Gavin D'souza
a5010af92a test: Update tests for Newsletter
Added tests for better coverage: Increased to 77% ~ near complete
coverage of controller class, missing tests for API endpoints
2021-08-12 16:17:31 +05:30
Gavin D'souza
c5eb78edd7 refactor: Simplify validations, fix test_send 2021-08-12 16:12:04 +05:30
shariquerik
fa53d7473e fix: Updated Public Page edit restriction message for user without access 2021-08-12 15:55:34 +05:30
Komal-Saraf0609
06efca0fa6 test: Fixed sider issues 2021-08-12 13:48:03 +05:30
Komal-Saraf0609
b897a41b08 test: Added test script for dashboard links
(tests if any doc is added to any dashboard connection, the counter for it is updated or not)
2021-08-12 13:25:24 +05:30
Gavin D'souza
83f56f2c45 Merge branch 'develop' of github.com:frappe/frappe into newsletter-refactor 2021-08-12 11:14:48 +05:30
shariquerik
e8d958dd3e fix: sider fix 2021-08-12 11:09:31 +05:30
shariquerik
f8a6736183 fix: Removing hide cards feature 2021-08-12 10:57:05 +05:30
shariquerik
5372a73ca4 fix: Generate Custom Report & Custom Documents Card 2021-08-12 10:44:09 +05:30
mergify[bot]
c2524c797f
Merge pull request #13395 from nextchamp-saqib/chart-in-custom-script-reports-dev
feat: allow duration fields in aggregate function fields
2021-08-12 03:51:21 +00:00
mergify[bot]
579e73d7df
Merge pull request #13839 from ankush/report_source_url
fix(DX): sourceURL to debug report and page JS
2021-08-12 03:37:53 +00:00
Gavin D'souza
b28a5beb53 refactor(minor): Newsletter Controller
* Resolve conflicting methods in the controller
* Add docstring
2021-08-11 21:01:56 +05:30
Gavin D'souza
cda48832f4 chore(test): Update API usages
Striving for better readability

* Use frappe.db.delete instead of frappe.db.sql
* Use named kwargs instead of positional
2021-08-11 20:49:32 +05:30
Gavin D'souza
e80d5f25c6 refactor: Newsletter failure handling
Don't raise after handling generic Exception class. Just log error and
go on. This way, other newsletters will continue to loop instead of
breaking after one failure

Added more context (docname) to logged error
2021-08-11 20:49:32 +05:30
Gavin D'souza
46c6b6621e refactor: Newsletter
* Re-send Newsletter only to the recipients who haven't received it yet (Check Email Queue before setting email recipients)
* Re-structed code, broken larger methods to "byte" sized "bits" (hehe)
* Added validations for recipients list
* Added Newsletter.newsletter_recipients property
* Used newer APIs and Fixed namespaces for usages/imports
* Added convenience methods for Newsletter APIs
* Added type annotations for all(?) methods
2021-08-11 20:48:59 +05:30
mergify[bot]
86e512452d
Merge pull request #13855 from netchampfaris/frappe-scanner
feat: frappe.ui.Scanner
2021-08-11 09:34:39 +00:00
Mohammad Hasnain Mohsin Rajan
b4453396f4
fix: website_content_field based indexing fails since fields are not passed correctly(#13907) 2021-08-11 12:23:03 +05:30
mergify[bot]
be5f7125cf
Merge pull request #13777 from jon-nfc/issue-13738
feat: Improve LDAP implementation to be standards compliant
2021-08-11 06:01:55 +00:00
mergify[bot]
29203416ad
Merge pull request #13904 from saxenabhishek/aks-style-qb
style: split qb.table into doctype and table
2021-08-11 05:24:34 +00:00
dependabot[bot]
6af73a1155
chore(deps): bump path-parse from 1.0.6 to 1.0.7
Bumps [path-parse](https://github.com/jbgutierrez/path-parse) from 1.0.6 to 1.0.7.
- [Release notes](https://github.com/jbgutierrez/path-parse/releases)
- [Commits](https://github.com/jbgutierrez/path-parse/commits/v1.0.7)

---
updated-dependencies:
- dependency-name: path-parse
  dependency-type: indirect
...

Signed-off-by: dependabot[bot] <support@github.com>
2021-08-10 22:18:59 +00:00
shariquerik
1619f96791 fix: adding child page to sidebar minor fix 2021-08-10 21:14:35 +05:30
Saqib Ansari
23d8c336b4 chore: ignore console statements 2021-08-10 19:47:44 +05:30
Saqib Ansari
e742719c56 Merge branch 'develop' of https://github.com/frappe/frappe into frappe-scanner 2021-08-10 19:46:05 +05:30
Komal-Saraf0609
166574b1d0 test: Fixed sider issues 2021-08-10 19:10:27 +05:30
shariquerik
09cfd3b026 test: minor fix 2021-08-10 19:06:13 +05:30
Komal-Saraf0609
3fbacb97f4 test: Added test cases for folder navigation and checking if the nested folder contains the added file 2021-08-10 18:53:20 +05:30
shariquerik
e5da8b3359 test: UI test for Workspace 2.0 2021-08-10 18:20:38 +05:30
shariquerik
5bed8031a2 fix: removed padding code from wspace json files & patch 2021-08-10 17:52:42 +05:30
Gavin D'souza
1c5608f8db Merge branch 'develop' into fix-workspace-boot-error 2021-08-10 14:43:47 +05:30
Manuel
9e7a1521c0
Merge branch 'frappe:develop' into develop 2021-08-10 09:15:10 +02:00
Shariq Ansari
1ab70d2145
Merge branch 'frappe:develop' into wiki-based-desk 2021-08-10 12:20:08 +05:30
shariquerik
9da6fcadc8 fix: sider fix 2021-08-10 11:31:16 +05:30
shariquerik
ed99915a79 refactor: Refactored code 2021-08-10 11:20:23 +05:30
Suraj Shetty
17882e4633
Merge branch 'develop' into chart-in-custom-script-reports-dev 2021-08-10 11:12:50 +05:30
mergify[bot]
25fcc60d7a
Merge pull request #13891 from Komal-Saraf0609/timeline_cancel_functionality
test: Added test case for cancel functionality
2021-08-10 05:37:51 +00:00
Suraj Shetty
1d878199f1
Merge pull request #13899 from surajshetty3416/fix-print-format-header 2021-08-10 11:05:35 +05:30
Suraj Shetty
dfa1c688fb
Merge pull request #13889 from surajshetty3416/core-test-coverage 2021-08-10 10:56:44 +05:30
mergify[bot]
afd69729de
Merge pull request #13835 from MitulDavid/image-processing
feat: Image cropping and optimization
2021-08-10 05:16:08 +00:00
shariquerik
256b678d8a fix: removed padding tune & some minor UX fixes 2021-08-10 10:45:21 +05:30
Suraj Shetty
291d7b0f16 fix: Call is_rtl function to get the actual value 2021-08-10 10:13:19 +05:30
MitulDavid
401b56ee39 fix: Image with .jpeg extension breaks file uploader 2021-08-10 08:26:44 +05:30
mergify[bot]
a6d9170e5f
Merge pull request #13878 from AfshanKhan/fix-date-formatting-for-babel
fix: format string for formating date
2021-08-09 16:20:11 +00:00
Komal-Saraf0609
b46b5546f7 test: Corrected function description and shorten some of the selectors by removing unwanted classes 2021-08-09 20:42:26 +05:30