* fix: same as previous row treated as one doc
treat repeated parent doc rows as same doc(parent), because legacy system downloaded data with inner join will normally have repeat same content for the parent docs
* fix: attached url with utf8 characters file name e.g Chinese
fix attached file via URL in comment by file name with utf8 characters
* fix: revert as it is already in other PR
* refactor: use frappe.safe_encode
Co-authored-by: Faris Ansari <netchampfaris@users.noreply.github.com>
CLI is more flexible at present. Until github action catches up,
switch to CLI version.
This also fixes failure from forks which don't contain semgrep config
yet.
* fix: set_primary and set_primary_email bug
When user untick the `is_primary_phone` or `is_primary_mobile` from the contact numbers table, we should reset the phone, mobile number etc.
Same goes for the email address table.
* Update frappe/contacts/doctype/contact/contact.py
fix variable naming as suggested
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
* Update frappe/contacts/doctype/contact/contact.py
fix variable naming as suggested
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
* Update frappe/contacts/doctype/contact/contact.py
fix variable naming as suggested
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
* Update frappe/contacts/doctype/contact/contact.py
fix variable naming as suggested
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
* Update frappe/contacts/doctype/contact/contact.py
fix variable naming as suggested
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
* Update frappe/contacts/doctype/contact/contact.py
fix variable naming as suggested
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
* test: Set empty string instead of none for number
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
As we make all configurations editable through dashboard(ex: password_reset_limit), it makes sense
to provide limit as a callable so that it can be accessed dynamically.
We have rate limiter for reset passowrd alone and it is not re-usable
for other endpoints. Added a generic rate limiter decorator that can be
used for any endpoint.
