Commit graph

39736 commits

Author SHA1 Message Date
Shariq Ansari
14f0b8a512
Merge pull request #18306 from shariquerik/ui-test-fix 2022-10-06 18:58:31 +05:30
Shariq Ansari
458757708f test: minor change 2022-10-06 18:05:24 +05:30
Shariq Ansari
8989bc49ae
Merge branch 'develop' into ui-test-fix 2022-10-06 17:12:29 +05:30
Shariq Ansari
930f8c34ed test: minor change 2022-10-06 16:52:39 +05:30
Ankush Menat
1d186db6a6
fix: disable autocommit before each patch (#18307) 2022-10-06 16:08:39 +05:30
Shariq Ansari
2e80f044c2
Merge branch 'develop' into ui-test-fix 2022-10-06 16:08:24 +05:30
Raffael Meyer
112c492f3e
feat: consistent, translatable timeline messages (#17526)
* feat: consistent, translatable timeline messages

* fix: save only filename for attachment comments

The rest of the comment will be added and translated ad-hoc by form_timeline.js

* patch: clean up Comments of type "Attachment"

* feat: further message types

* style: format with prettier

* test: cypress timeline

Timeline now correctly displays "You ..." instead of "{User} ..."

* feat: german transations for timeline comments

* fix: enable auto_commit_on_many_writes

* fix: don't update modified timestamp in patch
2022-10-06 16:05:34 +05:30
Ankush Menat
6aaefd6633
fix!: Dont update modified by default in db.set_value (#18301) 2022-10-06 16:01:20 +05:30
Shariq Ansari
36bc9d3142 test: flaky Cypress test 2022-10-06 15:57:49 +05:30
Ankush Menat
6ed3ce5875
Merge pull request #18262 from ankush/indexing_validation
fix: correct index syncing
2022-10-06 11:38:47 +05:30
Ankush Menat
da561c237d fix: index column should be first 2022-10-06 11:11:03 +05:30
Ankush Menat
cbe4b59100 fix: correct index re-syncing
The implementation of syncing unique and non-unique index depended on
index names which used to be different before because of that there's
tendency to incorrectly identify index.

This PR adds a separate util for checking if a column has index without
relying on naming convention. It just goes and checks if there's any
index with that column in it, hence far more reliable.
2022-10-06 11:11:03 +05:30
Ankush Menat
6de41a78e9 refactor: guard clause 2022-10-06 11:11:03 +05:30
Ankush Menat
d597acb5e2
fix: let charts handle aggregation (#18293)
Currently we are doing aggregation of remaining slices manually BUT this
breaks basic principle of DRY:

- dashboard chart decides how many groups to consider
- frappe charts has different maxSlices config

This results in mess like frappe computing "Other" and Frappe charts
computing "rest" separately.

Fix: Just pass all data to charts and let it figure out the "Rest".
2022-10-05 12:48:32 +05:30
Ankush Menat
bd21398252
fix: ignore perm level validation if row deleted (#18290) 2022-10-05 11:16:28 +05:30
Ankush Menat
b8ed8d624c fix: ignore child tables when init-ing parent doc 2022-10-04 14:27:25 +05:30
Ritwik Puri
2b782610ca
chore: remove unnecessary translation files (#17557)
translation files with _ in them are not considered by load_lang
2022-10-04 13:03:02 +05:30
Deepesh Garg
c1c4ee8b04
fix(minor): More button in list view (#18283) 2022-10-04 11:10:12 +05:30
mergify[bot]
939d926b91
feat: Added Subscription Banner for remotely logging into FrappeCloud dashboard from site (backport #18263) (#18281)
* feat: Added Subscription Banner for remotely logging into FrappeCloud dashboard from site (#18263)

* feat: added Subscription Banner and Manage Subscription button

* feat[patch]: added a patch for adding `Manage Subscription` button in
navbar_settings

* chore: removed console ;)

* refactor: make the `Manage Subscription` navbar item optional

* keep it hidden by default, only show when the site configs are present

* style: prettier, isort and stuff

* chore: handling null responses, translation and refactored patch

* fix: correct index reset

* perf: reduce network/db calls

If not sys manager then why make a request?

* fix: removed network call and added subscription_expiry to boot process

* chore: added enable_manage_susbcriptions as daily background job and refactored patch

* chore: added hook to hooks.py

* this looks clean enough, also don't have insert for child tables ;)

Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit 68f315d372cc8c6e41f2aabda61eba0d42dcf6e4)

# Conflicts:
#	frappe/patches.txt

* chore: conflicts

* style: format

[skip ci]

Co-authored-by: Rutwik Hiwalkar <50401596+rutwikhdev@users.noreply.github.com>
2022-10-03 16:41:12 +05:30
Abhinav Raut
fd81a290b2
fix: geolocation (#18250)
- set center and zoom for leaflet.

Co-authored-by: Abhinav Raut <abhinav.raut@zerodha.com>
2022-10-03 16:38:28 +05:30
Ankush Menat
35ba00a54e
fix: handle isatty correctly (#18277)
sys.stdin can be `None`

[skip ci]
2022-10-03 12:05:55 +05:30
Raffael Meyer
513321810d
fix(Data Import): don't validate empty values (#17923)
* refactor: exclude header from column values earlier

* fix: don't validate empty columns

Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-10-03 10:57:42 +05:30
aliX40
77be534e22
chore(translation): use Acceuil instead of Maison in fr translation (#18271)
In French ``Maison`` means house, but here the word ``Acceuil`` is what we actually need
2022-10-02 15:46:45 +05:30
Cleo Menezes Jr
af24bbff1b
fix: Show Report button should appear only if the doc is saved (#18268) 2022-10-01 00:10:55 +05:30
Shariq Ansari
fc1e01555b fix: added missing operators 2022-09-30 17:16:40 +05:30
Shariq Ansari
3162d192b8 fix: Chart filter not working if not operator is used 2022-09-30 17:16:40 +05:30
Ankush Menat
7b36265bad style: whitespace 2022-09-30 11:58:18 +05:30
Ankush Menat
7c423416b4
fix: report generation - frappe monitor (#18259)
- Identify original report name correctly.
- If sending to background, don't log it.
2022-09-29 19:35:38 +05:30
Ritwik Puri
66a31917f7
refactor(minor): reorder and remove unnecessary branches in set_new_name (#18243) 2022-09-29 16:23:55 +05:30
Ankush Menat
0e0e7f276c
fix: dont assume issingle exists (#18236) 2022-09-29 10:45:37 +05:30
Ankush Menat
b9e757782f
fix: correct boilerplate for virtual doctypes (#18248) 2022-09-28 15:49:15 +05:30
Ankush Menat
abeed35461
fix: throw exception if backup failed (#18230) 2022-09-28 14:29:38 +05:30
Ankush Menat
0825fd55c0 style: prettier 2022-09-28 11:21:22 +05:30
Ernesto Ruiz
4b67ebc2f1
fix: Add translate function to strings (#18153)
* fix: Add translate function to strings

fix: Add translate function to strings

* fix: add more strings to translate function

* fix: Add strings on translate function HTML tags

* fix: lint text on translate function

* fix: use single quotes on translate strings

* fix: Add template literals to translate HTML strings

* Update frappe/public/js/frappe/ui/toolbar/about.js

Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>

Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2022-09-28 11:17:41 +05:30
Ernesto Ruiz
d399951fab
fix: add translate function to some strings (#18188)
* fix: typo on dashboard_view

* fix: add string to translate function

* fix: add string to translate function

* fix: add string to translate function

* fix: upddate translatet text to single quote

* fix: update translated strings to single quote

* fix: add country to translate function

* fix: add country to translate function

* fix: add string to translate function

* fix: add string to translate function

* fix: add string to translate function

* fix: Revert translate for country

* fix: revert single quote to Search for icons text

* fix: refactor the translate labels directly to html variable
2022-09-28 11:15:41 +05:30
Ankush Menat
0642708f01
perf: use modified instead of creation in scheduler (#18234)
creation doesn't have index and does full table scan. On large site with
~3M activity logs it takes ~1.5 seconds just to begin scheduler.


[skip ci]
2022-09-27 19:21:02 +05:30
Ankush Menat
07662ebaf3
fix: only allow verified_command on GET requests (#18235) 2022-09-27 18:17:58 +05:30
Ritwik Puri
43101e0356
fix(minor): consider only email id as sender email for auto email report (#18231) 2022-09-27 13:46:30 +05:30
aliX40
13e6aca115
fix: chart label not being translated (#18212)
* Fix  chart translation issue

also used .html() instead of .text() in line 58, because otherwise it resulted in html escape errors. In french ' is used in many words and when using the text() method it results in this string being inserted &#39;

* refactor: use data attribute

for semantic consistency

Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-09-26 19:33:22 +05:30
Ankush Menat
56920e409a
perf: send all translations for setup wizard (#18226)
Computing all translations is far slower than just sending everything.
This is how boot works too.
2022-09-26 17:50:49 +05:30
Ankush Menat
3ab68980dd
Merge pull request #18219 from ankush/mdb_comments
fix: remove mariadb specific comments from column
2022-09-26 16:46:35 +05:30
Ankush Menat
6ba28061f6
test: flaky API tests due to autherror (#18221) 2022-09-26 12:33:20 +05:30
Ankush Menat
c76277f1bf fix: correctly order args and kwargs 2022-09-26 11:26:03 +05:30
Ankush Menat
9c84d078fa fix: remove mariadb specific comments from column
MariaDB has additional syntax for comments which are like python.
2022-09-26 11:09:39 +05:30
Devin Slauenwhite
5330814d7a
fix: make module to export required. (#18204) 2022-09-25 15:14:13 +05:30
Ankush Menat
939bf872ae fix: use compact JSON representation for monitor 2022-09-25 15:07:30 +05:30
Ankush Menat
967cc26fab feat: capture custom values in frappe monitor
lets monitor add extra info for:
- Save/Submit by doctype
- Report generation time by standard report name
2022-09-25 15:07:30 +05:30
mergify[bot]
002b27dbdd
fix: pypika does not parse datetime.time (backport #18184) (#18205)
* fix: pypika does not parse datetime.time

(cherry picked from commit b8f5a4304cccda954822cfe69d4805a18d9f07a7)

* fix: style - imports sort order fixed

(cherry picked from commit c3562c643ab9bff38d230202675d8ce1ae190912)

* test: add test for query builder parsing datetime.time

(cherry picked from commit 99889c270199da4b26b0d3858ae0f0a416d49d90)

* fix: format_time instead of format_datetime, test was failing!

(cherry picked from commit 5d697a22ac8cb98c8f8f44b3f99c57b932c5223c)

* fix(style): linter issues

(cherry picked from commit e231e1b0eadf63e84c9f81cfed9e2926e086fc44)

* test: add test for postgres

(cherry picked from commit 695591c43af9672cb83ce856a46c97e0bddfa9c3)

* fix: converting datepart and timepart to strings for Combinedatetime

(cherry picked from commit 1ebda943a607688bfb3db9fb42c80723a9050973)

* fix: style, linter issues

(cherry picked from commit c01262ad02b8831fdb0c5332b6973499e8adf6ad)

Co-authored-by: Anoop Kurungadam <anoop@earthianslive.com>
Co-authored-by: Aradhya <aradhyatripathi51@gmail.com>
2022-09-23 15:46:31 +05:30
Ankush Menat
4263aace27 chore: dont run cypress on forks 2022-09-22 14:59:39 +05:30
Shariq Ansari
5cfcc4a075
fix: Chart date format on x-axis is inaccurate (#18191) 2022-09-21 16:20:44 +05:30