barredterra
15396ceb60
fix: add required_apps to hooks boilerplate
2023-06-22 15:48:04 +02:00
barredterra
d044b30522
fix: remove app_version from hooks boilerplate
...
It's not used by any frappe/erpnext code and linters complain about the
unused import
2023-06-22 15:47:34 +02:00
Ankush Menat
085eb41245
ci: use multiple python version in patch test ( #21443 )
...
* ci: bump pyenv action
* ci: set default python version in patch test
* ci: setup pyenv manually
* ci: replace pyenv with setup-action
* debug
* use multiple python versions directly
* Revert "debug"
This reverts commit 692cbc0c9a407b86647ee09079fdde1510f300d7.
* setup py with --python flag
2023-06-22 13:48:20 +05:30
Ankush Menat
4f70200bd5
chore: track update actions per doctype
...
[skip ci]
2023-06-22 12:10:43 +05:30
Ankush Menat
69220a9a9e
fix(dx): Reset module onboarding progress
...
Useful while working on form tours to quickly reset progress
[skip ci]
2023-06-22 11:53:22 +05:30
Ernesto Ruiz
378c97871b
chore: Add translation to confirmation text on Update kanban_view.js ( #21453 )
...
[skip ci]
2023-06-22 11:21:30 +05:30
Ankush Menat
b3840596fc
test: mock github API calls ( #21450 )
...
[skip ci]
2023-06-21 16:33:09 +05:30
Ernesto Ruiz
7d352d7c34
chore: add translation to label on new doc in Update quick_entry.js ( #21444 )
...
[skip ci]
2023-06-21 15:53:17 +05:30
gavin
05893bef42
fix: Rename document/update title via toolbar (update_document_title API) ( #21404 )
...
* fix: update_document_title
* Fix broken socket event
* Fix broken title + name doc update
* fix: if only title updated then dont enqueue
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-06-21 15:46:09 +05:30
Suraj Shetty
1b0c2f03fa
Merge pull request #21394 from barredterra/fix-group-by
2023-06-21 11:59:45 +05:30
Dany Robert
4f3c0f6e99
feat: configurable amended document naming ( #21414 )
...
* feat: configurable amendment naming
* patch: set default amend naming
* chore: linters and document filter
* test: amended document naming
* refactor: use set_single_value
* chore: typo, fix copy
* fix(UX): move action button below table
* refactor: Series Counter -> Default Naming
The behaviour in this PR doesn't necessarily mean to apply naming series
it can be:
- Naming Series
- hash
- Naming Rule
- Some code
So the name was misleading.
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-06-20 21:37:08 +05:30
Ankush Menat
cbe8a41cff
build: Add responses as developer dependency ( #21440 )
...
Useful for mocking HTTP responses in tests
2023-06-20 19:50:51 +05:30
Raffael Meyer
49ee3a4b30
Merge branch 'develop' into fix-group-by
2023-06-20 14:45:35 +02:00
Alfredo Altamirano
c6b1b026c5
fix: data-import command fails with local files ( #20521 ) ( #21381 )
...
* fix: data is retrieved from db instead of local file
* fix: data import command only accepts absolute path
* fix: revert expanduser
- Shells expand it. Works fine with bash/zsh
- Doesn't work anyway as click wont let you init a path that doesn't
exist
* Revert "fix: data is retrieved from db instead of local file"
This reverts commit cbe50a26da61e01b5a9a7c51f8632defb0913aab.
* fix: allow local import if from console
---------
Co-authored-by: Alfredo Altamirano <Ahuahuachi@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-06-20 18:09:23 +05:30
Suraj Shetty
9c06d864c1
test: Add wait before checking for value
2023-06-20 15:08:44 +05:30
Smit Vora
db6a06d204
fix: make sure number is not zero for bankers_rounding ( #21431 )
...
* fix: make sure num is not zero for bankers_rounding
* test: rounding near zero
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-06-20 12:00:22 +05:30
David Arnold
4da6796b2d
feat: add style & onEachFeature function for geojson in geolocation controller ( #21322 )
...
This no-op function can be overriden / inherited in custom controllers
to craft richer map experiences
2023-06-20 11:54:22 +05:30
Suraj Shetty
c042a944bd
Merge pull request #21432 from surajshetty3416/fix-text-2
2023-06-20 11:33:56 +05:30
Suraj Shetty
ddadee3f3d
test: Fix navigation test
2023-06-20 10:50:50 +05:30
Suraj Shetty
08bb03abd6
test(awesomebar): Remove unnecessary delay
2023-06-20 10:50:21 +05:30
Suraj Shetty
eb63faaf05
test: Change viewport to regular size
2023-06-20 10:30:37 +05:30
Ankush Menat
d0ba31c911
refactor!: Prefix all custom fieldnames created from Desk ( #21355 )
...
* fix: actualy remove special characterso
`or "_"` is always truthy, this code didn't do anything
* refactor!: Prefix all custom fieldnames created from Desk
Why?
- Custom and standard field clashes are frequent. This will prevent it
from happening. E.g. recent `incoterm` field addition in ERPNext.
- Apps/fixtures can still specify exact fieldnames
* test: custom field naming
2023-06-19 18:22:36 +05:30
Anand Baburajan
38960f4219
feat: migrate translations command ( #21362 )
...
* feat: migrate translations command
* chore: formatting
2023-06-19 18:19:07 +05:30
Ankush Menat
276b11d331
fix: ignore undefined fields on new doctype form
2023-06-19 18:07:23 +05:30
Ankush Menat
0e92fc9bf5
fix: Clear cache after role perm manager
2023-06-19 16:29:35 +05:30
Ankush Menat
727059a2d1
fix(UX): Indicate that list view is empty because of filters ( #21427 )
2023-06-19 16:21:58 +05:30
Shariq Ansari
d25d4137e2
Merge pull request #21372 from shariquerik/re-delete-after-deleting-dependent-doc
2023-06-19 12:13:56 +05:30
Suraj Shetty
6cdded4e08
Merge pull request #21305 from barredterra/data-import-cast-select
2023-06-19 11:52:36 +05:30
Suraj Shetty
e500dcde3b
Merge pull request #21418 from blaggacao/fix-section-field-list
2023-06-19 11:43:08 +05:30
Shariq Ansari
b0793ebb7f
Merge branch 'develop' into re-delete-after-deleting-dependent-doc
2023-06-19 11:39:55 +05:30
Devin Slauenwhite
62a3a70bf8
feat: webhook timeout ( #21410 )
...
* feat: webhook timeout
* fix: ensure default timeout 5 seconds
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-06-18 20:53:03 +05:30
David Arnold
e94cdc0515
fix: section fields_dict
...
the previous code was an oversight as fieldobj.fieldname is undefined
2023-06-17 20:48:00 -05:00
Ankush Menat
ae0edd85fe
perf: Faster report exporting logic ( #21415 )
...
* perf: Faster report exports to Excel
Try exporting report with 100K rows, most likely it fails or takes a really long time.
Root causes:
- visible_idx was a list, lookups are SLOW AF when lists grow to 100k+
- visible_idx check is not required when I am exporting entire report.
Test with 85,000 rows.
| | Before | After | Improvement |
| --- | --- | --- | --- |
| Export | 25.99 | 0.77 | ~33x faster |
2023-06-17 21:07:59 +05:30
Shariq Ansari
51fe34006b
Merge branch 'develop' into re-delete-after-deleting-dependent-doc
2023-06-16 16:59:59 +05:30
Suraj Shetty
53b074c16a
Merge pull request #21400 from surajshetty3416/fix-tests
2023-06-16 13:27:33 +05:30
Suraj Shetty
826ee3e73d
Merge pull request #21405 from adityahase/fix-esbuild-failure-node-14
2023-06-16 12:57:46 +05:30
gavin
6303e53eda
fix(desk): Allow setting filters_description via df API ( #21382 )
2023-06-16 12:54:05 +05:30
Suraj Shetty
821f75c3ad
fix: Try waiting for logout
2023-06-16 12:47:39 +05:30
Aditya Hase
5b52350ae0
fix(build): Exit build process instead of throwing an exception
2023-06-16 12:27:30 +05:30
Suraj Shetty
8008afaf77
test: Fix Kanban test
2023-06-16 11:53:35 +05:30
Suraj Shetty
49d7f132da
test: Fix control link flaky test
2023-06-16 11:32:55 +05:30
Suraj Shetty
6c3957aa30
test: Return cy.request promise from login
...
- to make cypress wait for the promise.
2023-06-16 11:01:21 +05:30
Suraj Shetty
91afe51c7c
test: Make folder navigation test less flaky
2023-06-16 10:58:27 +05:30
Suraj Shetty
e8ebf19308
style: Fix formatting issue
2023-06-16 10:30:02 +05:30
Suraj Shetty
9a963bedb5
test: Fix failing test for icon & phone
...
- for some reason findBYRole("searchbox") stopped working
- there are no changes to related DOM recently
- There's pending issue related to this
https://github.com/testing-library/cypress-testing-library/issues/205#issuecomment-1572230102
2023-06-16 10:23:05 +05:30
Suraj Shetty
1283ece760
Merge pull request #21396 from cogk/feat-icon-arrow-down-right-for-number-card
2023-06-16 09:14:02 +05:30
Corentin Flr
e586a1e5cf
perf(icons): Remove uneeded code on some arrow icons
2023-06-16 00:50:11 +02:00
Corentin Flr
7710dbb8bb
feat(icons): Add new icon arrow-down-right for Number Card
2023-06-16 00:28:34 +02:00
Ritwik Puri
71bfafc6b2
Merge pull request #21365 from treasuryesc/develop
...
fix: "Remember Last Selected Value" not working (frappe#21364)
2023-06-15 20:48:31 +05:30
Ritwik Puri
c999508cbf
Merge pull request #21392 from ankush/perf_share
...
perf: faster docshare queries
2023-06-15 20:37:07 +05:30