Commit graph

23 commits

Author SHA1 Message Date
Ankush Menat
45645c3f73 feat: consistent, translatable timeline messages (#17526)
reapply accidentally reverted commit

[skip ci]
2022-10-12 22:27:04 +05:30
Ankush Menat
ab3f706948 Revert "feat: consistent, translatable timeline messages (#17526)"
This reverts commit 112c492f3e.
2022-10-12 18:03:57 +05:30
Raffael Meyer
112c492f3e
feat: consistent, translatable timeline messages (#17526)
* feat: consistent, translatable timeline messages

* fix: save only filename for attachment comments

The rest of the comment will be added and translated ad-hoc by form_timeline.js

* patch: clean up Comments of type "Attachment"

* feat: further message types

* style: format with prettier

* test: cypress timeline

Timeline now correctly displays "You ..." instead of "{User} ..."

* feat: german transations for timeline comments

* fix: enable auto_commit_on_many_writes

* fix: don't update modified timestamp in patch
2022-10-06 16:05:34 +05:30
Ankush Menat
a6b341bd59 test: fix tests using admin account 2022-09-10 12:48:33 +05:30
Ankush Menat
40f27f908a style: format JS files with prettier 2022-08-04 14:51:01 +05:30
Ankush Menat
e762fe9ce1
test: clear filters on ToDo before running test (#17494) 2022-07-13 12:29:41 +05:30
Shariq Ansari
176518ed2c
fix: Mandatory field bad UX (#16919)
Mandatory fields are highlighted red on page load. It should only highlight if we save the document.

**Before:** Form

https://user-images.githubusercontent.com/30859809/168791201-049c1de2-b7f5-4dff-bf40-093ff96d4510.mov

**After:** Form

https://user-images.githubusercontent.com/30859809/168791164-45e2289b-2d2c-4ebb-8b4d-cd2932140572.mov

**Before:** Dialog

https://user-images.githubusercontent.com/30859809/168791207-800ba9e5-b4eb-419f-8a99-f94916c21c79.mov

**After:** Dialog

https://user-images.githubusercontent.com/30859809/168791210-f2761d23-3a60-40c2-8aff-2d2cebbd77fa.mov

Resolves https://github.com/frappe/frappe/issues/16866
2022-05-18 09:57:49 +00:00
Shariq Ansari
67aab24bd0 test: fixed failing tests 2021-11-11 14:52:31 +05:30
Shariq Ansari
15daadf5a6 test: failing test fixes 2021-11-11 11:20:50 +05:30
Shariq Ansari
8f1e7b9704 test: failing test fixes 2021-11-10 22:16:37 +05:30
Shariq Ansari
cf416aa779 test: minor fix 2021-11-08 11:00:45 +05:30
Shariq Ansari
7a6bee9dab test: fixed failing test(timeline, recorder, navigation) 2021-11-02 15:37:57 +05:30
Shariq Ansari
749e12b544
Merge branch 'develop' into cypress-ui-test 2021-10-19 18:31:28 +05:30
Shariq Ansari
d18852f793 test: timeline.js ui test fix 2021-10-19 18:18:22 +05:30
Suraj Shetty
efdd267cd5 Merge branch 'develop' of https://github.com/frappe/frappe into shareable-link-for-comments 2021-10-08 09:00:43 +05:30
Suraj Shetty
59e0501cc7 test: Fix timeline tests 2021-10-08 08:58:52 +05:30
MitulDavid
b9d6063755 test: Fix flaky test in timeline.js 2021-09-30 16:17:02 +05:30
Suraj Shetty
3aed8f9e22 test: Miscellaneous fixes to avoid flaky tests 2021-09-07 16:19:27 +05:30
MitulDavid
93198b7123 test: Replace existing queries with Testing-Library queries 2021-08-18 19:11:01 +05:30
Komal-Saraf0609
b46b5546f7 test: Corrected function description and shorten some of the selectors by removing unwanted classes 2021-08-09 20:42:26 +05:30
Komal-Saraf0609
eb669c16f6 test: fixing sider issues 2021-08-09 17:17:27 +05:30
Komal-Saraf0609
716452ea69 test: Added test case for cancel functionality 2021-08-09 16:48:49 +05:30
Komal-Saraf0609
a8fe3a8668
test: Adding Cypress tests for sidebar, timeline and email testing (#13729)
* test: fix get_field command

* test: Add timeline email test cases

* test: Add sidebar test cases

* test: Add timeline test cases

* test: Added new commands

* test: Added proper name for test case, added comments and removed redundancy

* test: Added proper name for test case, added comments and removed redundancy

* test: Added proper name for test case, added comments and removed redundancy

* test: Added new commands

* test: Added proper name for test case, added comments and removed redundancy

* test: Added proper name for test case, added comments and removed redundancy

* fix: Sider issues

* fix: Sider issues

* fix: Sider issues

* fix: UI Tests

* fix: UI tests

* fix: UI tests

* fix: UI tests

* fix: UI tests

* fix: UI tests

* fix: UI tests

* fix: UI tests

* fix: UI tests

* fix: UI tests

* fix: UI tests

* fix: UI tests

* fix: UI test

* fix: UI tests

* fix: UI tests

* fix: Context correction

* test: fix fill_field command

* test: fixed get_field command
(removed :visible for code)

* test: Fixed fill_field command
(removed .blur())

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-08-06 07:52:24 +00:00