Commit graph

5107 commits

Author SHA1 Message Date
Dany Robert
4f3c0f6e99
feat: configurable amended document naming (#21414)
* feat: configurable amendment naming

* patch: set default amend naming

* chore: linters and document filter

* test: amended document naming

* refactor: use set_single_value

* chore: typo, fix copy

* fix(UX): move action button below table

* refactor: Series Counter -> Default Naming

The behaviour in this PR doesn't necessarily mean to apply naming series
it can be:
- Naming Series
- hash
- Naming Rule
- Some code

So the name was misleading.

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-06-20 21:37:08 +05:30
Alfredo Altamirano
c6b1b026c5
fix: data-import command fails with local files (#20521) (#21381)
* fix: data is retrieved from db instead of local file

* fix: data import command only accepts absolute path

* fix: revert expanduser

- Shells expand it. Works fine with bash/zsh
- Doesn't work anyway as click wont let you init a path that doesn't
  exist

* Revert "fix: data is retrieved from db instead of local file"

This reverts commit cbe50a26da61e01b5a9a7c51f8632defb0913aab.

* fix: allow local import if from console

---------

Co-authored-by: Alfredo Altamirano <Ahuahuachi@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-06-20 18:09:23 +05:30
Ankush Menat
0e92fc9bf5 fix: Clear cache after role perm manager 2023-06-19 16:29:35 +05:30
Suraj Shetty
6cdded4e08
Merge pull request #21305 from barredterra/data-import-cast-select 2023-06-19 11:52:36 +05:30
Ankush Menat
85cef317f2 perf: Index everyone in DocShare
A typical share query looks like this.

select `share_name` from `tabDocShare` where `tabDocShare`.`read` = 1.0 and
`tabDocShare`.`share_doctype` = 'Pick List' and (`tabDocShare`.`user` = 'username'
or `tabDocShare`.`everyone` = 1.0) order by `tabDocShare`.`modified` DESC;

None of existing indexes provide `everyone` values quickly, so `OR`
clause effectively clauses full table scan ALL THE TIME.
2023-06-15 18:04:58 +05:30
Ankush Menat
8b187b395c chore: remove translation tool related APIs
This was removed a while ago, this function seems like leftover code

Not used anywhere else.
2023-06-14 17:14:54 +05:30
Ankush Menat
039be73af4
refactor: Consider singles for dynamic set_value usage (#21367)
Found all usage using this semgrep rule:

```yaml
    - pattern: frappe.db.set_value($DOCTYPE, ...)
    - pattern-not: frappe.db.set_value("$STR", ...)
```
2023-06-14 10:46:25 +05:30
Ankush Menat
3d0888a5d5 refactor: set_value usage 2023-06-13 16:00:43 +05:30
Vishal Kumar
9d20509492
fix: no role assigned message when role profile is passed (#21342)
* Fix: no role assigned message when role profile is passed

* refactor: rename misleading method

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-06-13 11:10:47 +05:30
Suraj Shetty
a8557d8796
Merge pull request #20864 from barredterra/sort-options 2023-06-12 21:40:20 +05:30
Ritwik Puri
fbc25d206e
Merge pull request #21304 from phot0n/fix-expiry-for-email-queue
feat: bulk retry for email queue & remove infinite* retry for certain smtp exceptions
2023-06-12 15:08:44 +05:30
Raffael Meyer
574ebf0f12
Merge branch 'develop' into sort-options 2023-06-12 11:19:32 +02:00
Ankush Menat
828490e01a chore: bump many more old packages 2023-06-10 20:47:27 +05:30
barredterra
983a9a6ef9 fix(Data Import): cast selected value to string 2023-06-09 12:20:10 +02:00
phot0n
1f8598891e fix: remove infinite sending retries for certain exceptions for email queue
* chore: remove expired status & set_expiry job from email queue
2023-06-09 14:38:55 +05:30
barredterra
6a22be0739 feat: enable "Sort Options" for Type field 2023-06-08 19:08:55 +02:00
barredterra
49ccc0ab6e feat: make option sorting configurable 2023-06-08 18:55:53 +02:00
Ankush Menat
fa6dc03cc8
refactor: frappe.cache() usage to frappe.cache (#21282) 2023-06-08 11:47:17 +05:30
Ritwik Puri
094b8589f7
chore: add skipped in list view for patch log (#21264) 2023-06-07 00:01:52 +05:30
Shariq Ansari
f6cad90304
Merge branch 'develop' into workspace-content-duplicating-fix 2023-06-06 08:07:44 +05:30
Shariq Ansari
4f459f7146 fix(unrelated): make create doctype using form builder default button 2023-06-06 08:07:01 +05:30
Ankush Menat
90fd748592
fix(UX): Notify if newly created user has no roles (#21251)
- System user with no role is useless
- By default adding a new system user doesn't give them ANY role so
they can't really access desk even if they have system user role.
2023-06-05 22:27:01 +05:30
Ankush Menat
e30b823eeb fix!: Webhook naming should be prompt 2023-06-04 10:46:38 +05:30
Ankush Menat
07e1d34568 refactor: RQ enqueue after commit and tests 2023-06-03 18:44:19 +05:30
Ankush Menat
b3d370a0b1 refactor!: remove rollback_observers
use `frappe.db.after_rollback.add` instead
2023-06-03 18:44:19 +05:30
Ankush Menat
5185374f72
refactor!: Remove dynamic addition of _comments (#21217)
This isn't required anymore, was added to handle old sites.
2023-06-02 21:57:58 +05:30
Ankush Menat
cb885a86ae feat: allow clearing view logs
These dont need to exist for eternity. Let site admins decide when to
drop them.
2023-06-02 17:32:33 +05:30
Sagar Vora
f223bc0249 chore: fix formatting in user.py 2023-06-02 14:26:50 +05:30
Suraj Shetty
69927ce12f
Merge pull request #21110 from yjane99/customise-welcome-password-reset-emails 2023-06-02 12:41:49 +05:30
Ankush Menat
3bbe4498a0 feat: allow re-running patches in developer mode
Simpler debugging.
2023-05-31 16:39:29 +05:30
Ankush Menat
4104e7d733
feat: show db table utilization on doctype (#21193)
* feat: show db table utilization on doctype

* fix: nicer error message with docs
2023-05-31 16:28:44 +05:30
Corentin Flr
66eb377492
fix(role): Set desk properties (e.g. search_bar) to 1 for roles with desk access (#21162)
Replace get_doc with new_doc, because default values are not retrieved when using get_doc. Some roles with desk_access had no access to most features of the desk, such as the search bar or the form's sidebar.
2023-05-30 10:37:26 +05:30
mergify[bot]
95fc535f1a
Merge pull request #21142 from gavindsouza/server_script-cron
feat: Allow setting cron as Server Script frequency
2023-05-29 13:26:11 +00:00
Gavin D'souza
cdef2ccdd6
fix: Clear scheduled events if cron_format is changed 2023-05-29 18:34:39 +05:30
Ankush Menat
9f53b56bdb test: save server script 2023-05-29 18:30:17 +05:30
Gavin D'souza
a1b16792f9
fix: Pass cron format only if frequency is Cron 2023-05-29 18:16:23 +05:30
Ankush Menat
888209f6d2 test: cron/scheduled scripts 2023-05-29 17:45:26 +05:30
Gavin D'souza
b00aac92ba
feat: Allow setting cron as Server Script frequency 2023-05-27 16:52:09 +05:30
Shariq Ansari
25a243aa6d fix: replaced add doctype button with select group button 2023-05-26 21:03:52 +05:30
Shariq Ansari
ac3fb73702 fix: replaced add doctype button with select group button 2023-05-26 20:42:43 +05:30
Nabin Hait
af7502bba7
refactor: Workspace cleanup (#21100)
* refactor: Workspace cleanup

* fix: Resolved conflict
2023-05-26 14:42:31 +05:30
Yash Jane
76d7e6e379 feat: added email template customization option for welcome and password reset emails 2023-05-25 13:19:07 +05:30
Maharshi Patel
f612d84247 fix: change onboarding_status fieldtype
change onboarding_status to small text and handle null cases.
2023-05-24 15:42:16 +05:30
Ankush Menat
a39d478e2c fix: email notification 2023-05-24 13:29:18 +05:30
Ankush Menat
4376ebb3dc refactor: replace todo tour with user tour
adding more users is most likely to improve adoption. so better place to
show tours is user doctype?
2023-05-24 13:24:09 +05:30
Maharshi Patel
e7c71a2411 Merge branch 'onboarding-tour' of https://github.com/maharshivpatel/frappe into onboarding-tour 2023-05-24 11:43:29 +05:30
Maharshi Patel
9fec2fb499 fix: change onboarding_status type to long text
json type breaks unrelated tests and in mariadb json is alias for long text.
2023-05-24 11:42:35 +05:30
Maharshi Patel
5f91ed93ef
Merge branch 'develop' into onboarding-tour 2023-05-23 18:16:20 +05:30
Maharshi Patel
20d0e28092 fix: remove onboarding_tours_section 2023-05-23 15:20:35 +05:30
Maharshi Patel
028508c947 fix: remove from settings from core module. 2023-05-23 13:25:37 +05:30