* fix: actualy remove special characterso
`or "_"` is always truthy, this code didn't do anything
* refactor!: Prefix all custom fieldnames created from Desk
Why?
- Custom and standard field clashes are frequent. This will prevent it
from happening. E.g. recent `incoterm` field addition in ERPNext.
- Apps/fixtures can still specify exact fieldnames
* test: custom field naming
* feat: rearranging standing fields
* fix: fixed creation of property setter
* refactor: renamed setup_sortable
* fix: loading field_order property
* refactor: removed redundant db call
* fix: field_order not found
* test: Added tests for field order in customize form
* refactor: better naming
* refactor: simplified logic
* feat: Updating field order on custom field creation
* feat: Added support for custom fiels
* refactor: moving to meta
* refactor: changed property type to json
* fix: new standard field insert order.
* fix: don't modify insert_after of system generated custom fields.
# This is because system generated fields are to be treated as standard fields. If the user restores the form to default, this value will be used to reset the original position.
# The new position of form fields are stored in the field_order Property Setter.
* fix: treat system generated fields as standard fields when sorting.
* revert: check for is_system_generated
* Revert "fix: new standard field insert order."
This reverts commit 6cdbe42f28d5944165dd100a9bb9172463951fda.
* fix: prioritize field_order over insert_after.
# Use insert_after as fallback in event the field doesn't exist in field_order
* fix(test): delete existing custom field
* fix: order of standard fields without field_order property.
* Revert "Revert "fix: new standard field insert order.""
This reverts commit c830f1ba2fe1e602b09c11a897869d9992097c1e.
* test: field order of newly migrated standard fields.
* fix(test): clear test_standard_field from previous test run.
* fix: sort with insert_after for system generated fields.
* fix(test): reset standard field creation before re-run and after successful test.
* fix: insert_after position should be + 1
* chore: remove debug statement
* test: system generated customized fields
* chore: remove print
* chore: lint all
* fix: show quick link to Table MultiSelect DocTypes
* refactor: change backend implementation of `CustomizeForm` and `Meta`
* test: simplify tests
* fix: rename `idx` to `index` for clarity
* perf: define `existing_fields` conditionally
---------
Co-authored-by: Aradhya <aradhyatripathi51@gmail.com>
Co-authored-by: Aradhya Tripathi <67282231+Aradhya-Tripathi@users.noreply.github.com>
Co-authored-by: Sagar Vora <sagar@resilient.tech>
* fix(meta): ensure that `insert_after` is always considered when sorting fields
* test: add nosemgrep to comment
Co-authored-by: Dany Roberts <danyrt@wahni.com>
This has never worked since 2016... which can mean two things:
- No one really uses this.
- If I fix this now suddenly people will find different behaviour in
naming because `name_case` is selected in some doctypes (but never
tested)
* feat: add video conferencing (via google meet) for events syncing with google calendar
* fix: unset add_video_conferencing if sync_with_google_calendar not enabled
* fix: remove conference data if add_video_conferencing disabled during update
* fix: restrict add conferencing if event_category in Event, Meeting and Other
* fix: save meet link while pulling from calendar
updated response API Response comment with conference details
show google calendar section if pulled from google calendar
* feat: show link to join video conference with google meet
* fix(style): linter errors
* fix(style): linter errors
* fix: set conferenceDataVersion 1 only if google meet conferencing enabled
remove google meet link from event needs both conferenceData as null and conferenceDataVersion 1
* Update frappe/desk/doctype/event/event.py
show add_video_conferencing for events of all categories
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
* Update frappe/desk/doctype/event/event.json
show add_video_conferencing for events of all categories
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
* fix: handle empty ends_on, use starts_on
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
* fix: do not update Event modified time on db set meet link
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
* fix: add email field event participants table
set email from linked contact
google calendar event to use event participant email as attendees
* fix: attendees not cleared from google calendar event
* fix(style): linter suggestions
* fix: make email field non-read only, called set_participants_email from before_save hook
* test: update new no of fields in event doctype in test_fetch_to_customize
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
