Commit graph

148 commits

Author SHA1 Message Date
Shariq Ansari
9e0ed9d2a2 fix: convert string to int 2023-06-13 16:23:39 +05:30
Shariq Ansari
0e962078fe revert: temp fix to load communications 2023-06-13 16:20:07 +05:30
Ankush Menat
22149b5bff chore: increase communication limit
This needs better fix, added temporarily
2023-06-13 12:12:21 +05:30
Ankush Menat
8a30667a97
fix: Fetch non-cached version of Meta on Customize Form. (#21269)
* fix: Replace meta cache when uncached meta is requested

* fix: use meta from DB on customize form

* refactor: make cached kw only, use _dev_server
2023-06-12 14:59:42 +05:30
Ritwik Puri
47edc63170
fix: support for different delimiter for timeline email linking (#19751) 2023-02-03 11:47:38 +05:30
Raffael Meyer
e82046ef00
ci: bump isort to 5.12.0 (#19836)
* ci: bump isort to 5.12.0

* style: remove trailing whitespace
2023-01-30 15:11:55 +05:30
morehardik
d3d76865f7
fix: check permission before running onload hook #11774 (#19823)
Added fix for issue wherein Document is loaded post permission check
2023-01-29 03:01:29 +05:30
Sagar Vora
fc3ee12baf
perf: cache FormMeta directly (#18165)
* perf: cache `FormMeta` directly

* perf: check if `dt` is table, use `db.get_value` instead of `get_all`
2022-09-19 16:10:32 +05:30
Sagar Vora
627302d851
fix: set doctype and name in docinfo (#18088) 2022-09-12 14:18:20 +05:30
Ankush Menat
62d65aa843 perf: drop useless indexes from view log 2022-09-09 17:34:46 +05:30
Ankush Menat
7b3cc322f1
Merge pull request #17891 from ankush/misc_fixes
perf: ~45% faster Desk first response
2022-08-22 11:45:20 +05:30
Ankush Menat
2eec621e95 chore: db.get_all -> get_all
Reduces 1 pointless function call.
Function calls are also not "super cheap" in python.
2022-08-22 11:35:14 +05:30
Ankush Menat
48869d506f perf: dont order by for uniq searches 2022-08-21 17:37:40 +05:30
Ankush Menat
615f0dbcb8 Revert "refactor: desk missing doc handling"
This reverts commit d11fdc3ca4.
2022-07-22 19:24:34 +05:30
Ankush Menat
d11fdc3ca4 refactor: desk missing doc handling
- reduce 1 query
- make normal and virtual doc behave in same manner
2022-07-22 18:50:06 +05:30
Shridhar Patil
0285d4f686
fix: frappe.db.exists will always return error for virtual doctype (#17595)
So first check whether the doctype is virutal
2022-07-22 18:49:38 +05:30
Ankush Menat
e88bc35cae refactor: move is_virtual_doctype to relevant file 2022-07-22 14:25:48 +05:30
Ankush Menat
10da1622f4 fix: form view broken for virtual doctype 2022-07-22 14:25:48 +05:30
Ankush Menat
06ce1f33ec refactor: remove unnecessary exception handling 2022-07-04 11:59:54 +05:30
Ankush Menat
e9a9496ebc fix: duplicate tracebacks in console 2022-07-04 11:25:47 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features (#17367)
refactor: clean up code to py39+ supported syntax

- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes

Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
chillaranand
25f82e966c refactor: Remove unused imports & code 2022-05-19 15:34:35 +05:30
Ankush Menat
2fbf8c905f
fix: dont override local proxies (#16611) 2022-04-13 20:44:10 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black (#16453)
Co-authored-by: Frappe Bot <developers@frappe.io>
2022-04-12 10:59:25 +05:30
Nabin Hait
762aeb32f0 fix: Show assignments based on allocated todo only 2022-03-23 13:13:31 +05:30
Rushabh Mehta
dd02496dad
Merge pull request #15964 from phot0n/integer-primary-keys
feat: integer primary keys
2022-03-16 17:07:20 +05:30
Ankush Menat
db0925d446 fix: dont return docinfo as message
The return was added for testability but it also becomes part of
response so response size doubles. :)
2022-03-15 12:46:36 +05:30
phot0n
bebc8058b6 feat: integer primary keys 2022-03-11 23:46:00 +05:30
ChillarAnand
2b48c08340 fix: Fix flaky tests 2022-02-28 12:44:06 +05:30
Saqib Ansari
f63b02191d perf: cache db.get_value 2022-02-14 15:11:14 +05:30
Saqib Ansari
422e0d4461 Merge branch 'develop' of https://github.com/frappe/frappe into link_title_refactor 2022-02-01 22:57:22 +05:30
Ankush Menat
300031aa36 revert "refactor: get_docinfo without side effects"
This reverts commit 79f5a6b640.
2022-02-01 19:39:02 +05:30
Saqib Ansari
b42cc400b9 Merge branch 'develop' of https://github.com/frappe/frappe into link_title_refactor 2022-02-01 15:08:57 +05:30
Ankush Menat
79f5a6b640 refactor: get_docinfo without side effects 2022-02-01 11:18:35 +05:30
Ankush Menat
2f239dbe4f fix: communication missing from form timeline 2022-02-01 10:16:24 +05:30
Saqib Ansari
30ba577c0a Merge branch 'develop' of https://github.com/frappe/frappe into link_title_refactor 2022-01-14 15:20:56 +05:30
Rushabh Mehta
d2b9fc89ed fix(minor): incorrect condition 2022-01-13 16:55:28 +05:30
Rushabh Mehta
853287f49d fix: load user_info on-demand 2022-01-13 16:39:24 +05:30
Saqib Ansari
f760aa1de2 perf: use get_value instead of get_cached_value
get_cached_value internally calls get_doc which is much slower than fetching a value from db
2022-01-07 16:43:58 +05:30
Saqib Ansari
06b00e8e01 Merge branch 'develop' of https://github.com/frappe/frappe into link_title_refactor 2022-01-07 16:01:44 +05:30
Gavin D'souza
6e4aa52e2e fix: Show assignments correctly for Forms 2022-01-04 19:20:03 +05:30
Saqib Ansari
ab9700d947 Merge branch 'develop' of https://github.com/frappe/frappe into link_title_refactor 2021-12-15 19:32:16 +05:30
Sagar Vora
c560d67a57 fix: remove/update older whitelist calls 2021-10-18 16:47:11 +05:30
Gavin D'souza
a233bf1061 fix: Add workflow comments in form timeline
* Add Edit, Label along with Info timeline logs
* Added title field for timeline icon
2021-09-06 19:39:08 +05:30
Gavin D'souza
6f0a02aaa5 fix: Handle multiple comment types in get_comments 2021-09-06 19:37:39 +05:30
Gavin D'souza
3446026555 chore: Update header: license.txt => LICENSE
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
hrwx
d056beb0ef feat: show title links in Link Fields 2021-08-03 15:55:32 +05:30
Gavin D'souza
e407b78506 chore: Drop dead and deprecated code
* Remove six for PY2 compatability since our dependencies are not, PY2
  is legacy.
* Removed usages of utils from future/past libraries since they are
  deprecated. This includes 'from __future__ ...' and 'from past...'
  statements.
* Removed compatibility imports for PY2, switched from six imports to
  standard library imports.
* Removed utils code blocks that handle operations depending on PY2/3
  versions.
* Removed 'from __future__ ...' lines from templates/code generators
* Used PY3 syntaxes in place of PY2 compatible blocks. eg: metaclass
2021-05-26 15:31:29 +05:30
Leela vadlamudi
e5d3aac707
Merge pull request #12693 from leela/notifications-into-timeline
feat: Include automated mail notifications in timeline
2021-04-08 20:38:29 +05:30
leela
5c2bda478c Refactor(Improv): Include automated mail notifications in timeline
Notifications sent through notifications doctype are not part of
communications doctype and also not into timelines. Added these
notifications into timeline by adding docs into Communication doctype.
2021-04-05 09:45:17 +05:30