Commit graph

1445 commits

Author SHA1 Message Date
phot0n
f49818089a feat(minor): bulk retry for email queue
* chore: add retry_sending as a email queue class method
2023-06-12 14:38:43 +05:30
phot0n
1f8598891e fix: remove infinite sending retries for certain exceptions for email queue
* chore: remove expired status & set_expiry job from email queue
2023-06-09 14:38:55 +05:30
phot0n
129fdc803a chore: fix linter 2023-06-08 16:20:10 +05:30
phot0n
4ceafe14e3 chore: remove unused is_background_task and add_to_sent_list -> update_recipient_status_to_sent
* set status to be hidden in queue doc
* don't maintain a list of sent to recipeint, a boolean is enough to set the status to partially sent
2023-06-08 16:19:37 +05:30
phot0n
aac74726ff chore: add recipient to sent list regardless of email sending method 2023-06-08 16:19:37 +05:30
phot0n
df7afa93b8 chore: log traceback directly to the queue doc 2023-06-08 16:19:37 +05:30
phot0n
742a6082ac fix: remove unnecessary statuses from email queue and only append emails to sent if imap is enabled 2023-06-08 16:19:37 +05:30
phot0n
2b22556309 chore: remove deprecated send method from smtp 2023-06-08 16:19:37 +05:30
Vishal Kumar
a21412e12a
feat: allow no_smtp_authentication to be set from site config (#21274) 2023-06-08 13:15:43 +05:30
Ankush Menat
fa6dc03cc8
refactor: frappe.cache() usage to frappe.cache (#21282) 2023-06-08 11:47:17 +05:30
Ankush Menat
2cb2934f96
perf: query queued_recipients only once (#21277)
O(N) -> O(1) check for queued recipients

Caused by https://github.com/frappe/frappe/pull/18044

Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
2023-06-07 18:05:06 +05:30
Doridel Cahanap Mendez
4b2730642d refactor: attach txt file in received emails
(cherry picked from commit a36d6a9df02e9a86e3701fcc6861c9c64bd40c66)
2023-05-26 11:45:03 +00:00
ljain112
70de5d05f2 fix: don't mutate notification when getting cc and bcc 2023-05-25 19:03:23 +05:30
Anand Baburajan
58c363da14
Merge branch 'develop' into custom_report_export_and_auto_email 2023-05-16 12:59:25 +05:30
Sabu Siyad
2ec893278a
fix: email: get unsub email: use cstr instead of encode (#20985)
`encode` fails if reference name is an integer. use `cstr` instead which
use `as_unicode` under the hood
2023-05-14 17:29:38 +05:30
anandbaburajan
348f852792 fix: custom filters while exporting and creating new auto email reports 2023-05-10 19:08:01 +05:30
Smit Vora
9f35d0e894
fix: don't use default filters for auto-email report (#20876) 2023-05-10 13:12:05 +05:30
Ankush Menat
715dc569e9
fix: reload communication before re-save (#20914) 2023-05-06 15:51:07 +05:30
Ankush Menat
eeda161e98
fix: handle SMTPRecipientsRefused retries (#20819)
* fix: remove trailing and leading quotes from email

* chore: typo

* fix: dont retry `SMTPRecipientsRefused`

If refused once it's unlikely to work again just by retrying. There's no
mechanism to prevent infinite retry. This will still attempt for
MAX_RETRY_COUNT.

* Revert "fix: remove trailing and leading quotes from email"

This reverts commit 2676ac2c7fe76c34049da05a209554fee6b3d911.

refer https://github.com/frappe/frappe/pull/20819#discussion_r1175166987
2023-04-24 17:34:24 +05:30
phot0n
97b2adfaf2 chore: rename message_meta -> uid 2023-04-18 19:36:12 +05:30
phot0n
2a5ed28777 fix: make_error_msg for imap 2023-04-18 19:12:54 +05:30
phot0n
f6606781fb chore: take out email_list to function scope 2023-04-18 14:33:05 +05:30
Ritwik Puri
6ae91fb3b6
Merge branch 'develop' into email-retrieve-cleanup 2023-04-18 14:23:21 +05:30
phot0n
b483deac3d refactor(minor): email retreiveing 2023-04-18 14:01:11 +05:30
Ankush Menat
a2f40290d8
fix: bump poplib limit (#20739)
* fix: bump poplib limit

* Update receive.py

[skip ci]
2023-04-17 16:52:41 +05:30
phot0n
c7632d0e51 fix: use frappe.log_error in EmailServer exception handling 2023-04-12 13:20:32 +05:30
Suraj Shetty
7a92a604e0
style: Fix formatting 2023-03-31 14:03:49 +05:30
Himanshu Shivhare
2cb492561a
fix(ux): correct email account setup path in error message (#20513) 2023-03-30 17:57:00 +05:30
Samuel Danieli
dc4509796d
fix: suggested email ids in New Email dialog (#20319)
* chore: enhance UX of New Email dialog

* do not show contacts without an email
* use name as value, y? if several contacts use the same email address, the entry will be displayed several times, but always with the same description, which leads to confusion - using name as value makes the entries distinguishable

* chore: ignore semgrep

Rewriting the query is not in the scope of this PR.

* chore: keep semgrep failing on raw query

[skip ci]

* fix: use email_id as value

* Revert "fix: use email_id as value"

This reverts commit e4c44e2094ddb9b525bc34d400642dcee5656096.

* chore: comment confusing code

---------

Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-03-28 11:47:56 +05:30
Ritwik Puri
d9383afae6
fix: exception handling for bulk email sending (#20451) 2023-03-24 13:45:46 +05:30
Suraj Shetty
02b661bbb9 fix: Remove mandatory and save URL params to localstorage
- Saving URL params to localstorage to avoid re-entering the data.
Usually only 1 or 2 param(s) change is required to generate new link
2023-03-21 11:31:05 +05:30
Suraj Shetty
ed7d6931ca fix: Update code to update links with campaign and medium 2023-03-20 23:42:50 +05:30
Ankush Menat
7ed43e2a68
fix: Drop message_id index before migrating email queue (#20376)
[skip c]
2023-03-17 15:57:51 +05:30
Ankush Menat
f2f7d43811
fix: tolerant newsletter view logging (#20369)
* fix: tolerant newsletter view logging

* Revert "fix: tolerant newsletter view logging"

This reverts commit 5a8567a9405f336c3dc8a481c27af70860334b2b.

* fix: use raw query for updating count
2023-03-16 20:07:43 +05:30
Ankush Menat
fdcdb61a2d
fix: email linking and message_id indexing (#20356)
* fix: find communication regardless of system reply

* perf: convert and index message_id
2023-03-16 14:01:25 +05:30
Ankush Menat
9430b6a8c2
fix: Permission error while processing role based notifications (#20315) 2023-03-14 17:27:30 +05:30
Ritwik Puri
985a8ca18a
fix: proper errror translation for finding outgoing email account (#20316) 2023-03-13 21:05:48 +05:30
barredterra
3694e654a1 refactor: rename convert_utc_to_user_timezone to convert_utc_to_system_timezone 2023-03-04 19:02:25 +01:00
Shariq Ansari
52db146094
Merge branch 'develop' into better-error-msg 2023-03-02 19:36:53 +05:30
Shariq Ansari
a6db20fe3b fix(DX): better error message for notification from reference doctype 2023-03-02 19:35:18 +05:30
Ritwik Puri
92ca30074b
fix: dont get message attribute in error string in has_login_limit_exceeded 2023-03-02 15:59:34 +05:30
Suraj Shetty
7abdad3282 Merge branch 'develop' of https://github.com/frappe/frappe into newsletter-analytics 2023-02-28 14:31:03 +05:30
Suraj Shetty
540bf5a984 fix: Do not update modified while updating total views 2023-02-28 14:17:19 +05:30
Suraj Shetty
6c8f88b8cd refactor: Remove UTM references just set source in web page view to simplify things 2023-02-28 14:17:16 +05:30
Suraj Shetty
3eff93ea6e refactor: Only send email_read_tracker_url instead of method 2023-02-28 14:16:46 +05:30
Suraj Shetty
b9f632aa8d fix: Rename is_internal_link to is_site_link 2023-02-28 14:15:41 +05:30
Ritwik Puri
6a37c19d0e
fix: dont try to connect to server again when appending email to sent folder 2023-02-27 12:52:13 +05:30
Suraj Shetty
7d5c98c206 feat: Add UTM tracking parameters to internal links in newsletters
- Also, extend web page view to store UTM tracking data.
2023-02-23 16:19:07 +05:30
Suraj Shetty
b397ec3858 feat: Track count of views on newsletter emails 2023-02-23 13:45:53 +05:30
Ankush Menat
8446875257
refactor!: Remove "Set user permission" permtype (#20090)
This has never worked and setting user permission requires system
manager role always (because of permissions on list view)
2023-02-20 16:07:49 +05:30