Shariq Ansari
b143194803
feat: undo/redo
2023-02-20 18:10:15 +05:30
Ankush Menat
30f0b4ea2d
perf!: frappe.db.exists without order_by ( #20093 )
2023-02-20 17:28:03 +05:30
Shariq Ansari
3a4516e97c
fix: renaming local variable to avoid overlap with global store variable
2023-02-20 17:07:02 +05:30
Ankush Menat
8446875257
refactor!: Remove "Set user permission" permtype ( #20090 )
...
This has never worked and setting user permission requires system
manager role always (because of permissions on list view)
2023-02-20 16:07:49 +05:30
Shariq Ansari
28bba3c188
fix: always use layout from store
2023-02-20 13:20:41 +05:30
Shariq Ansari
7f73906528
fix: switching from option store syntax to setup store syntax
2023-02-20 13:19:20 +05:30
Ankush Menat
68df7d621f
docs: document_naming_settings field label
...
[skip ci]
2023-02-20 13:13:56 +05:30
Ankush Menat
b55bbd0a8c
fix(UX): Sort case-insensitive where it makes sense ( #20088 )
2023-02-20 13:07:32 +05:30
Rucha Mahabal
c94d3ccc16
fix: Hide perm level fields for Section, Column and Tab Breaks ( #20084 )
2023-02-20 12:51:24 +05:30
Rucha Mahabal
89d63ea82b
fix: false positive attr check while applying permlevel ( #20069 )
...
* fix: false positive attr check while applying permlevel
* Revert "fix: false positive attr check while applying permlevel"
This reverts commit 9114788590ce12be977df847c13b00e3bf72ac2a.
* fix: ignore AttributeError while trying to pop low permlevel fields
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-02-20 12:18:37 +05:30
Suraj Shetty
537172ac02
Merge pull request #20051 from ruchamahabal/fix-calendar-timezone
2023-02-20 11:24:04 +05:30
Shariq Ansari
ec1bf2da3f
Merge branch 'develop' into custom-fieldname-restriction
2023-02-20 11:21:41 +05:30
Suraj Shetty
adca7969b5
Merge branch 'develop' into fix-calendar-timezone
2023-02-20 11:21:26 +05:30
Shariq Ansari
7afc46401b
chore: changed freeze message
2023-02-20 11:21:24 +05:30
Ankush Menat
649c211b9b
fix(UX): show message when form is read only ( #20077 )
...
[skip ci]
2023-02-20 10:13:49 +05:30
Raffael Meyer
97dde45067
Merge branch 'develop' into fix-note-2
2023-02-17 11:04:26 +01:00
Rohan Bansal
2af64893a3
feat: allow number cards in workspaces
2023-02-17 14:44:54 +05:30
Ankush Menat
d6d67bce64
Merge pull request #19971 from gavindsouza/request-job-hooks
...
feat: Request, Job Hooks {Before/After}
2023-02-17 14:24:30 +05:30
Shariq Ansari
0c3ab52320
Merge pull request #20066 from frappe/publish-custom-button-blog-post
2023-02-17 12:05:14 +05:30
Gavin D'souza
985e0913a5
Merge branch 'develop' into request-job-hooks
2023-02-17 11:40:13 +05:30
Hussain Nagaria
24d7637538
fix: hide published checkbox
2023-02-17 11:31:53 +05:30
Gavin D'souza
5d0bd512e1
fix(after_hook): Don't pass exception object to hook
...
* it can fetch most relevant details via response object
* Exceptions not supported by Frappe's WSGI (unsupported HTTP methods) may not be accessible to the after_request hooks - but the lack of active response may be an indicator / and peeking in the request
2023-02-17 11:24:01 +05:30
Hussain Nagaria
110204e2df
feat: publish button in blog post form
2023-02-16 20:05:36 +05:30
Shariq Ansari
908545241b
fix: enable update button if fieldname change is rejected
2023-02-16 19:31:07 +05:30
Shariq Ansari
b1fc05af64
Merge branch 'develop' into custom-fieldname-restriction
2023-02-16 18:44:48 +05:30
Shariq Ansari
80a4932983
fix: ask before changing restricted fieldnames
2023-02-16 18:42:24 +05:30
Zhixuan Lai
2d416098c2
fix: link validation fetch from virtual doc ( #20055 )
...
Problem:
document.save() throws "Object is not scriptable exception" when fetching values from virtual doc.
Root cause:
```python
# ....
if frappe.get_meta(doctype).get("is_virtual"):
values = frappe.get_doc(doctype, docname) <--- Document is not scriptable.
.as_dict()
# ....
def set_fetch_from_value(self, doctype, df, values):
fetch_from_fieldname = df.fetch_from.split(".")[-1]
value = values[fetch_from_fieldname] <--- Tries to access value by key and throws "Object is not scriptable" exception
```
Solution:
```python
if frappe.get_meta(doctype).get("is_virtual"):
values = frappe.get_doc(doctype, docname).as_dict() <--- Makes the document scriptable.
```
2023-02-16 18:15:40 +05:30
Shariq Ansari
7a3dfaae8a
Merge pull request #20060 from shariquerik/doc-link-ui-fix
2023-02-16 15:57:21 +05:30
Shariq Ansari
6bf326996e
fix: do not show help-icon in report view (datatable)
2023-02-16 14:57:27 +05:30
Shariq Ansari
8b3bd5adc3
fix: help-icon taking space if doc url is not set
2023-02-16 14:19:19 +05:30
Ejaaz Khan
ce6e86b484
fix: unable to upload image in responsive mode ( #19963 )
...
Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
2023-02-16 12:32:37 +05:30
Ankush Menat
cd4d601ed4
fix: traceback sanitizer got extra positional args
2023-02-15 17:51:21 +05:30
Rucha Mahabal
39761d3d7e
feat(Calendar): Add a new option convertToUserTz to address timezone inconsistencies
2023-02-15 16:55:28 +05:30
Raffael Meyer
0bef75f540
Merge branch 'develop' into load-address-and-contact-display
2023-02-15 12:07:35 +01:00
Gavin D'souza
fe26c542b7
refactor: Move before/after tasks as hooks
...
Moved before/after tasks in Requests as hooks for:
- monitor
- rate_limiter
- recorder
Moved before/after tasks in Jobs as hooks for:
- monitor
- releasing document locks
2023-02-15 15:30:02 +05:30
Raffael Meyer
9f73b94a74
build(deps): bump cryptography to 39.0.1 ( #20042 )
...
Security fix: https://cryptography.io/en/latest/changelog/#v39-0-1
2023-02-15 14:59:36 +05:30
Ankush Menat
3235b7a77e
fix: Notification JS relied on leaked locals ( #20048 )
...
this breaks after https://github.com/frappe/frappe/pull/19882
[skip ci]
2023-02-15 14:56:11 +05:30
Gavin D'souza
6d70b5e934
fix(app): Move after_request hook inside finally block
...
Also, rename after_request fn to sync_database to better match functionality
2023-02-15 14:52:08 +05:30
Ankush Menat
99513db062
feat: fetch from with fields in Customize form ( #20046 )
...
extends https://github.com/frappe/frappe/pull/13760/
2023-02-15 13:08:35 +05:30
Gavin D'souza
825f1d32f1
Merge branch 'develop' into request-job-hooks
2023-02-15 12:57:14 +05:30
Raffael Meyer
d8101cdf69
ci: print any vulnerabilities found ( #20044 )
...
[skip ci]
2023-02-15 11:41:50 +05:30
Ankush Menat
1d4ea95105
Merge pull request #20043 from barredterra/bump-ipython
...
build(deps): bump ipython to 8.10.0
2023-02-15 11:41:12 +05:30
barredterra
3f528dac75
build(deps): bump ipython to 8.10.0
...
Minor security fix: https://ipython.readthedocs.io/en/stable/whatsnew/version8.html#ipython-8-10
2023-02-15 00:44:37 +01:00
Samuel Danieli
0bd74bfa5c
chore: do not copy data import status ( #20034 )
...
status is used by other fields and may corrupt view if copied
2023-02-14 22:43:31 +05:30
Shariq Ansari
84e20bfb17
Merge pull request #20027 from shariquerik/checkbox-squeezing-fix
2023-02-14 18:37:01 +05:30
Ankush Menat
c7e1bec0bd
Merge pull request #19972 from gavindsouza/cli-scheduler-status
...
refactor(cli): Scheduler
2023-02-14 18:09:21 +05:30
Ankush Menat
013f023255
fix: restrict DocType layout permissions ( #20028 )
...
Guest -> All.
This doctype doesn't have anything that's useful for guest users.
[skip ci]
2023-02-14 17:55:12 +05:30
gavin
c3fa753ed2
Merge branch 'develop' into cli-scheduler-status
2023-02-14 16:13:56 +05:30
Shariq Ansari
91d371e21b
Merge branch 'develop' into checkbox-squeezing-fix
2023-02-14 16:05:55 +05:30
Shariq Ansari
efd82c464e
fix: checkbox is getting squeezed if label is long
2023-02-14 15:57:11 +05:30