Marica
988b725b67
Merge branch 'develop' into kanban-access-w-perms
2022-12-22 19:45:40 +05:30
stephen
6b0950e1d2
fix: prevent emails from being queued multiple times ( #19386 )
...
* fix: prevent emails from being queued multiple times
* style: fmt
* refactor: optimistic error handling
- Combined email queue sending to single call instead of different
branches for testing.
- If failing to get jobs -> attempt sending anyway. Failure could be
form one bad job which shouldn't completely stop everything.
* chore: type
Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-12-22 19:02:18 +05:30
Shariq Ansari
64569c39eb
fix: missed not operator
2022-12-22 17:50:42 +05:30
Shariq Ansari
22192686c3
Merge branch 'develop' into cmd/ctrl-to-see-fieldname
2022-12-22 17:47:19 +05:30
Shariq Ansari
8c9c9b9f37
fix: support ctrl key for linux/windows
2022-12-22 17:46:14 +05:30
Shariq Ansari
1b8bf0f64c
Merge branch 'develop' into cmd/ctrl-to-see-fieldname
2022-12-22 15:55:24 +05:30
Saqib Ansari
296ef1f9bd
chore: add methodname to monitor log ( #19388 )
2022-12-22 14:18:42 +05:30
Bread Genie
9e79df9802
ci: use $GITHUB_OUTPUT instead of set-output ( #19389 )
...
* refactor(boilerplate): use `$GITHUB_OUTPUT` instead of `set-output`
* ci: use `$GITHUB_OUTPUT` instead of `set-output`
* fix: remove unterminated string literal
2022-12-22 14:16:09 +05:30
Shariq Ansari
5b75ac9d22
feat(minor): show fieldname on hover in non-dev mode when cmd/ctrl is pressed
2022-12-22 11:34:37 +05:30
Ankush Menat
a18e63ef92
fix: Allow emailing disabled user ( #19382 )
...
Not sure why we need to validate this. A disabled user can still exist
outside of system with same active email address.
2022-12-21 15:10:50 +05:30
Shariq Ansari
289aa9a13b
test: test valid & invalid key
2022-12-21 14:43:10 +05:30
Bread Genie
211880d693
fix(boilerplate): add redis services in GHA ( #19376 )
...
* feat(boilerplate): add redis services
* chore: bump all action versions
[skip ci]
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2022-12-21 12:39:00 +05:30
Ankush Menat
1ab85a66c5
ci: better release notes generation ( #19380 )
...
[skip ci]
2022-12-21 12:14:35 +05:30
Shariq Ansari
8dad07949a
chore: again renaming to Login with email link
2022-12-20 21:53:13 +05:30
barredterra
d0f75363a5
refactor: make test for assignment independent of Note
2022-12-20 16:30:11 +01:00
barredterra
3afdb39372
fix: test update with content instead of title
2022-12-20 15:30:15 +01:00
barredterra
5ab75908ee
fix: permlevel 1 on seen_by
2022-12-20 15:04:13 +01:00
barredterra
ebce8ee002
fix: button label
2022-12-20 14:54:43 +01:00
barredterra
fdafce9b63
fix: only System Manager can work with public Notes
2022-12-20 14:44:05 +01:00
Shariq Ansari
eb7293c1d2
fix: suggested changes and added passwordless_login_expiry option
...
rate limit, better description, redirect_post_login, removed subject
2022-12-20 18:21:22 +05:30
Ahmed Hasanin
bb5e21de5f
fix(error snapshot): fix seen update qeury in error snapshot to work with postgres ( #19373 )
...
[skip ci]
2022-12-20 17:52:48 +05:30
Shariq Ansari
83bf33c1fc
fix: renamed login without password to passwordless login
...
made text translatable in email template
2022-12-20 16:14:46 +05:30
Ankush Menat
272d9e0085
fix: shift-select checkboxes ranges ( #19367 )
...
This doesn't work if document names have spaces in them. This is because
data props are urlencoded while we are comparing it with raw data.
2022-12-20 16:06:46 +05:30
Shariq Ansari
68baa81f3f
fix: type checking
...
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2022-12-20 15:33:03 +05:30
Ankush Menat
8c947f5abf
Merge branch 'develop' into login-without-password
2022-12-20 15:19:32 +05:30
Ankush Menat
3ff49ec0ad
fix: mariadb convert port to string for os.execv
2022-12-20 15:14:38 +05:30
Ankush Menat
db35431b8c
fix(postgres): psql with remote databases
...
If you dont use unix socket psql command doesn't work.
2022-12-20 15:14:38 +05:30
Shariq Ansari
e43854c30b
Merge branch 'develop' into login-without-password
2022-12-20 14:29:58 +05:30
Shariq Ansari
55ac130823
chore: linter fix
2022-12-20 14:28:14 +05:30
Shariq Ansari
60c29b6939
fix: removed logo implementation
2022-12-20 13:54:40 +05:30
Shariq Ansari
57c2d23422
Merge pull request #19358 from shariquerik/datepicker-arabic-fix
...
Fixes https://github.com/frappe/frappe/issues/19351
2022-12-20 13:02:58 +05:30
Shariq Ansari
570442865b
feat: Login without password (through link sent on email)
2022-12-20 13:00:23 +05:30
Ankush Menat
89a34159f9
fix: postgres query ( #19357 )
...
Double quotes are supposed to be used for table/columns only in
postgres. Mariadb is fine with either.
[skip ci]
2022-12-20 12:50:00 +05:30
Shariq Ansari
cbc869e8fa
fix: datepicker not working for arabic language
2022-12-20 12:39:39 +05:30
Ankush Menat
f52869482d
chore: dont log 404 as errors
2022-12-20 11:20:50 +05:30
Daizy Modi
d88ef967b9
feat: hook ignore_links_on_delete to skip doctypes on delete ( #19347 )
...
* feat: hook `ignore_links_on_delete` to skip doctypes on delete
* fix: helper comment
* fix: helper comment
* test: test case for `ignore_links_on_delete`
* test: fix test case
2022-12-20 11:17:28 +05:30
Ankush Menat
f2e958deeb
Merge pull request #19353 from barredterra/get-print-html
...
fix: re-introduce html param for attach_print
2022-12-20 11:11:49 +05:30
barredterra
ab95cffae9
fix: re-introduce html param for attach_print
...
Fix error introced by d64836c1c4
2022-12-19 14:26:15 +01:00
Ankush Menat
ee9bfed4ec
Merge pull request #19029 from gavindsouza/runtime-type-checks-api
...
feat(whitelisted): Runtime typing hints validation
2022-12-19 15:46:49 +05:30
Ankush Menat
e0688f25a8
chore: pin markupsafe ( #19348 )
...
We depend on it for escaping. Currently this works because of indirect
dependencies:
```
λ pipdeptree -p MarkupSafe --reverse
MarkupSafe==2.1.1
- Jinja2==3.1.2 [requires: MarkupSafe>=2.0]
- frappe==15.0.0.dev0 [requires: Jinja2~=3.1.2]
- Werkzeug==2.2.2 [requires: MarkupSafe>=2.1.1]
- frappe==15.0.0.dev0 [requires: Werkzeug~=2.2.2]
```
[skip ci]
2022-12-19 15:37:28 +05:30
gavin
2c498910ba
Merge branch 'develop' into runtime-type-checks-api
2022-12-19 15:12:06 +05:30
Gavin D'souza
b8da76d483
test(typing-utils): Specify exc type
...
Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-12-19 15:10:56 +05:30
Gavin D'souza
d66eed129c
refactor: validate_argument_types
...
* Rename API for ease of public use
* Add validation condition parameter
* Move function to utils module instead of frappe namespace
2022-12-19 15:07:03 +05:30
Ankush Menat
a1132075a0
Merge pull request #19326 from resilient-tech/get-latest-fix
...
perf: reuse `_doc_before_save` in `doc.get_latest`
2022-12-19 12:30:30 +05:30
Ahmed Hasanin
57bc2ebf57
fix(workflow): Remove docstatus field from get_workflow_state_count ( #19332 )
...
remove docstatus from get_workflow_state_count as it is not being used
and causes error with postgresql as it requires the selected column
to either appear in the group by clause or an aggregat function
[skip ci]
2022-12-19 11:50:58 +05:30
Sagar Vora
2fd2d426cc
fix: better check of whether doctype is child table ( #19329 )
...
* fix: better check of whether doctype is child table
* perf: init `_table_fields` earlier
2022-12-19 11:50:16 +05:30
bosdaring
0d26627c66
build: bump pyyaml ( #19331 )
...
* Cython and PyYAML
compatible version for rhel based os
* chore: dont pin cython
Co-authored-by: Ankush Menat <ankush@frappe.io>
[skip ci]
2022-12-19 11:47:03 +05:30
Smit Vora
b2581430ed
fix: allow zero page length in get_list to return complete list ( #19322 )
...
* fix: allow zero page length to return complete list
* fix: linting issues
[skip ci]
2022-12-19 11:38:10 +05:30
Ankush Menat
95039a1265
fix: db ssl connection ( #19308 )
...
ref: https://pymysql.readthedocs.io/en/latest/modules/connections.html
[skip ci]
2022-12-19 11:21:15 +05:30
Shariq Ansari
80da745cf6
Merge pull request #19327 from resilient-tech/no-share-for-std
2022-12-19 11:07:21 +05:30