Commit graph

42389 commits

Author SHA1 Message Date
Sabu Siyad
406f894141
feat: default value options: sort (#19019)
[skip ci]

Signed-off-by: Sabu Siyad <hello@ssiyad.com>
2022-11-28 11:09:15 +05:30
barredterra
b8b6db541a feat: german translations for export dialog 2022-11-27 17:13:22 +01:00
barredterra
1d25437121 fix: duplicate translation of field labels 2022-11-27 17:10:53 +01:00
barredterra
d7139af6cc feat: hide csv settings in collapsible section 2022-11-27 17:02:25 +01:00
Raffael Meyer
83e2f524e2
Merge branch 'develop' into csv-params 2022-11-26 20:10:51 +01:00
barredterra
433b285b92 refactor: use provide_binary_file 2022-11-26 20:08:50 +01:00
barredterra
839de22d95 feat: add test for exporting reportview as CSV 2022-11-26 20:01:48 +01:00
barredterra
d70e5e73e2 refactor: extract common methods 2022-11-26 20:00:58 +01:00
Ankush Menat
263055e247
fix: site creation using non-root users (#19014) 2022-11-26 12:45:57 +05:30
Marica
a4db4550e9
fix: Avoid update_order twice on Kanban load (#19011)
* fix: Avoid `update_order` twice on kanban load

- The older logic called `kanban.update()` on a refresh (not on load) and returned from `render()`
- Due to a recent PR, it calls `kanban.update()` AND builds a new board on load, which invokes `update_order` twice consecutively and causes a timestamp error to be thrown

* chore: Remove redundant condition

Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2022-11-25 20:55:16 +05:30
marination
203e73dacb chore: Change card cursor to default from grab if no write access to Ref. Doctype 2022-11-25 19:35:55 +05:30
Marica
fd966a35b5
Merge branch 'develop' into kanban-access-w-perms 2022-11-25 16:37:08 +05:30
Sagar Vora
a14367f1d9
chore: replace use of cur_frm with this.frm (#19005) 2022-11-25 14:38:30 +05:30
Sagar Vora
375de8647a fix: discovery and styling issues in grid buttons 2022-11-25 14:13:05 +05:30
Ankush Menat
763bdb5d3c
Merge pull request #18996 from gavindsouza/spaces-db_query
fix(db_query): Space resilient sanitization
2022-11-25 13:12:20 +05:30
Ankush Menat
d00b98f460 chore: typo 2022-11-25 13:10:43 +05:30
Ankush Menat
4661083247
Merge pull request #18995 from ankush/multi_queue_workers
feat(workers): many small RQ worker features
2022-11-25 12:47:47 +05:30
gavin
35827af172
fix: Strip white spaces on lower cased field value
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2022-11-25 12:39:11 +05:30
Ankush Menat
ed28626021 refactor: simpler deque strat selection
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2022-11-25 12:14:37 +05:30
Ankush Menat
a8bf86ef75 feat: support dequeuing strategies for worker 2022-11-25 12:14:37 +05:30
Ankush Menat
aece93fbc5 feat: burst mode in workers
https://python-rq.org/docs/workers/#burst-mode
2022-11-25 12:14:33 +05:30
marination
d6bdd636dc fix: Check Reference Doctype perms & control indicator change
- Don’t change indicator on filter change if user can’t write to board. They can’t save filters
- Invoke `update_order` on Kanban board init() only if user has `write` access to reference doctype (non-deliberate invocation)
- All deliberate invocations of `update_order` via UI actions are blocked/hidden without `write` access
- Remove elements with no access instead of hiding to avoid inspect element hacks
- Card Actions: Block card dragging if no `write` access to reference doctype
- Card Actions: Block card adding  if no `create` access to reference doctype
2022-11-25 12:13:49 +05:30
Ankush Menat
0ebd3945ff refactor: consider multi-queue consumption 2022-11-25 12:03:34 +05:30
Ankush Menat
40b2929c0d feat(workers): allow consuming multiple queues 2022-11-25 12:03:34 +05:30
Ankush Menat
b7cef3ae71 fix: prioritize short queue when using all queues 2022-11-25 12:03:34 +05:30
Sagar Vora
b1703117fc
chore: remove unused whitelisting from API (#19000) 2022-11-25 11:59:04 +05:30
Cleo Menezes Jr
3bbf423093 fix: Widget control on dashboard chart breaks on smaller screens 2022-11-24 12:11:08 -03:00
marination
0981f593ff fix: Allow card actions (adding/dragging) if access to reference doctype
- allow user to update kanban column cards order even without write access
2022-11-24 20:30:24 +05:30
Gavin D'souza
1a5e5f546b fix: Move function check inside subquery 2022-11-24 16:27:54 +05:30
Himanshu Shivhare
c7461a05c6
chore: Typo correction (#18997)
[skip ci]
2022-11-24 16:25:11 +05:30
Gavin D'souza
1f913248aa test: Add more tests for illegal subquery and fn usage 2022-11-24 15:36:31 +05:30
Gavin D'souza
575d32ec35 fix(db_query): Space resilient matching 2022-11-24 15:36:28 +05:30
marination
77f3a74eca fix: Hide Sort Selector in Kanban
- It just re-renders the board that gets the card order from the db and makes no difference to the card order even temporarily
2022-11-24 14:08:05 +05:30
Raffael Meyer
73f0256aa8
feat: add param letterhead to frappe.get_print (#18989)
* feat: add param letterhead to frappe.get_print
2022-11-24 13:15:24 +05:30
Ankush Menat
08aa17e5a3
Merge branch 'develop' into select-print-language 2022-11-24 13:04:27 +05:30
Raffael Meyer
920606f10e
fix: handle "No Letterhead" in new print format builder (#18990)
[skip ci]
2022-11-24 10:54:46 +05:30
Sagar Vora
8486109f2f
Merge pull request #18985 from resilient-tech/fix-key-check
fix: only accept string values for `key`
2022-11-23 17:49:53 +00:00
Sagar Vora
8cc504709b fix: only accept string values for key 2022-11-23 23:00:48 +05:30
marination
dcbfcdf8b9 fix: Check perms on Kanban Column actions
- Check Column options access (archive, indicators)
- Check column dragability access (allow if write access to board)
- Check card dragability access (allow if write access to board)
- Hide "Add Column" if no write access to board
- Avoid board update on load without write access
2022-11-23 20:41:04 +05:30
Shariq Ansari
22350dc118
Merge branch 'develop' into patch-1 2022-11-23 17:29:48 +05:30
Marica
4bef9e3559
Merge branch 'develop' into kanban-access-w-perms 2022-11-23 16:09:24 +05:30
Shariq Ansari
526a00884e
Merge pull request #18973 from shariquerik/rtl-horizontal-scroll-fix
fix: horizontal scroll in rtl language
2022-11-23 12:37:32 +05:30
Abdo Hamoud
752fdc9eaf
Merge branch 'develop' into patch-1 2022-11-23 02:25:46 +02:00
Shariq Ansari
5c45106971 fix: horizontal scroll in rtl language 2022-11-22 19:30:23 +05:30
Raffael Meyer
eae918d545
feat: contact full name (#18596)
* feat: contact full name

* patch: autocommit and don't update modified

* patch: print progress while updating contacts

* patch: don't overwrite existing full_name
2022-11-22 18:57:41 +05:30
Shariq Ansari
4cd1d3c669
Merge pull request #18965 from netchampfaris/attach-field-in-table
fix(file): set fieldname to table fieldname
2022-11-22 13:14:01 +05:30
Faris Ansari
45230cf938
fix: succinct version
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2022-11-22 00:00:37 +05:30
Faris Ansari
6479163899 fix(file): set fieldname to table fieldname
because files are always attached to parent
2022-11-21 19:28:54 +05:30
Shariq Ansari
f47755480d
Merge pull request #18962 from shariquerik/phone-field-in-web-form 2022-11-21 18:51:41 +05:30
Shariq Ansari
941949e0a1
Merge branch 'develop' into phone-field-in-web-form 2022-11-21 18:26:57 +05:30