Commit graph

42389 commits

Author SHA1 Message Date
Ponnusamy
58c262a3ed
List view -> add custom buttons to menu 2022-11-02 12:27:50 +05:30
Aradhya
0bc2ba0545 refactor: better naming 2022-11-02 02:40:23 +05:30
Aradhya
97b0b743ae test: Updated tests for parenttype condition 2022-11-02 02:40:23 +05:30
Aradhya
e5d19d78d7 feat: considering parenttype while joining 2022-11-02 02:39:53 +05:30
Shariq Ansari
7bbd36345a
Merge pull request #18712 from Ponnusamy1-V/patch-1 2022-11-01 20:05:42 +05:30
Ponnusamy
0cf2043ab0
fix: not able to click checkbox in file grid view 2022-11-01 19:32:46 +05:30
Shariq Ansari
fe8c545829
Merge pull request #18708 from shariquerik/list-view-format-fix 2022-11-01 19:16:05 +05:30
Shariq Ansari
3bccc75620
Merge pull request #18707 from shariquerik/webform-validation-fix 2022-11-01 18:10:01 +05:30
Shariq Ansari
97f97a81f9 fix: show 0 for empty currency, float, & duration fields in list view 2022-11-01 18:07:44 +05:30
Shariq Ansari
cc20037af9 fix: webform validation script not working 2022-11-01 17:44:44 +05:30
Aradhya
8e118773f3 refactor: joining tables 2022-11-01 14:35:37 +05:30
Ankush Menat
9e5c0740dc
Merge pull request #18699 from ankush/symlinked_files
fix: support symlinked /files directory
2022-11-01 14:06:05 +05:30
Ankush Menat
589bcf149a
Merge pull request #18701 from shariquerik/workspace-message
fix(UX): Info message on workspace for better UX
2022-11-01 14:05:45 +05:30
Shariq Ansari
3d1e14e127
Merge branch 'develop' into workspace-message 2022-11-01 13:56:49 +05:30
Shariq Ansari
302024608e fix: added go to workspace link in sidebar 2022-11-01 13:53:12 +05:30
Aradhya
5703303abb Merge branch 'develop' of https://github.com/frappe/frappe into qb-fixes 2022-11-01 13:45:11 +05:30
Ankush Menat
fec24632a9 style: format
[skip ci]
2022-11-01 13:36:37 +05:30
Ankush Menat
56640a0723 fix: support symlinked and /files directory
Easiest way to move site/files or site/private directories is to symlink
them, the validation for file path was failing because it resolves only
until site path.

Resolving real path doesn't seem to be _REALLY_ required here.
2022-11-01 13:25:21 +05:30
Shariq Ansari
c66d264871 fix(UX): Info message on workspace for better UX 2022-11-01 13:12:26 +05:30
Ritwik Puri
c76c02f43d
Merge pull request #18697 from phot0n/custom-module-def-ux
fix: make module def custom checkbox readonly in prod mode
2022-11-01 12:50:07 +05:30
phot0n
3ccd5f7d60 fix: make module def custom checkbox readonly in prod mode 2022-11-01 12:44:38 +05:30
Ankush Menat
f0ab6cb488
Revert "fix: use is_file_path_valid instead of is_safe_path (#18316)" (#18688)
This reverts commit d35aa6c545.
2022-11-01 12:40:54 +05:30
Aradhya Tripathi
5ed696cd3d
fix(qb): fixed implicit join for child tables (#18692)
* test: Added test for multiple joins
2022-11-01 11:25:02 +05:30
DrZoidberg09
0bc2f16772
fix: Signature form (#18477)
Co-authored-by: Ankush Menat <ankush@frappe.io>
Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
Co-authored-by: Shariq Ansari <30859809+shariquerik@users.noreply.github.com>
2022-10-31 19:45:46 +05:30
Aradhya
6474e5bccc Merge branch 'qb-fixes' of https://github.com/Aradhya-Tripathi/frappe into qb-fixes 2022-10-31 19:17:02 +05:30
Aradhya
84c8cb8705 test: Added more tests 2022-10-31 19:16:00 +05:30
DrZoidberg09
cd9ee5b98c
refactor: allow to include head.html in custom app (#18671)
* Update base.html

* Create head.html

Co-authored-by: Ankush Menat <ankush@frappe.io>
2022-10-31 16:55:53 +05:30
Sagar Vora
cb7d25a293
fix(meta): ensure that insert_after is always considered when sorting fields (#18682)
* fix(meta): ensure that `insert_after` is always considered when sorting fields

* test: add nosemgrep to comment

Co-authored-by: Dany Roberts <danyrt@wahni.com>
2022-10-31 15:37:55 +05:30
Sagar Vora
623633f35e
chore: bump Pillow to 9.3.0 (#18683) 2022-10-31 13:24:59 +05:30
phot0n
51ae7afdee feat: reload listener for form 2022-10-31 12:56:35 +05:30
Ankush Menat
e564dcb3fc
fix(UX): session expiry explanation and defaults (#18680)
closes https://github.com/frappe/frappe/issues/12957
2022-10-31 11:28:49 +05:30
Ankush Menat
8cca50bf26
refactor: remove naming case feature (#18672)
This has never worked since 2016... which can mean two things:
- No one really uses this.
- If I fix this now suddenly people will find different behaviour in
  naming because `name_case` is selected in some doctypes (but never
  tested)
2022-10-31 11:23:49 +05:30
phot0n
b0f3016c76 chore: add confirm dialog for unlock doc button 2022-10-31 01:28:25 +05:30
phot0n
c3e2cd1629 fix: only allow queue_in_background in customize form 2022-10-30 23:42:14 +05:30
phot0n
759ee1a116 feat(minor): submission queue banner for showing recent submissions 2022-10-30 23:16:09 +05:30
phot0n
2952077a6d refactor(minor): remove additional document states and rename message to exception 2022-10-30 19:23:15 +05:30
phot0n
a21eb1efd6 refactor(minor): move staticmethod after properties 2022-10-30 19:19:32 +05:30
phot0n
1856d2eb3f fix: realtime alert
use session object's last updated time to figure out whether to send a realtime alert or a notification
2022-10-30 19:11:13 +05:30
phot0n
ff1389327a chore: rename queue to background_submission 2022-10-30 18:23:20 +05:30
Shariq Ansari
f10d463bff fix: change tab-content height based on tab-header 2022-10-30 00:08:45 +05:30
Shariq Ansari
4f7e7ba7d8 fix: disable section title & hide tab header if there is none if read_only 2022-10-29 23:56:16 +05:30
Shariq Ansari
503172885c fix: cannot lose focus from field input if non draggable element is clicked
also section title input field was disabled for non draggable elemnts
2022-10-29 23:21:57 +05:30
barredterra
62d68a8be6 refactor: reuse functions from reportview 2022-10-29 18:07:51 +02:00
barredterra
a232e7f0c1 fix: don't parse CSV params for Excel 2022-10-29 18:05:52 +02:00
barredterra
685eb419eb refactor: utility function get_export_dialog 2022-10-29 17:17:05 +02:00
Aradhya Tripathi
f10572cf53
Merge branch 'develop' into qb-fixes 2022-10-29 20:38:52 +05:30
Sagar Vora
6d45b500a1
perf: load _doc_before_save sooner to avoid DB call in check_if_latest (#18666)
* perf: load `_doc_before_save` sooner to avoid DB calls in `check_if_latest`

* fix: specify `for update` in `load_doc_before_save`
2022-10-29 17:55:57 +05:30
Sagar Vora
8f057ef04a
perf: ensure cache works for non_standard_user_types when empty (#18665) 2022-10-29 17:55:19 +05:30
Sagar Vora
764370f3c6
fix: set proper cache key for singles when name is passed as None (#18667)
[skip ci]
2022-10-29 17:34:52 +05:30
Shariq Ansari
87cb09448a fix: hide column action in read only mode 2022-10-28 23:25:45 +05:30