Commit graph

1145 commits

Author SHA1 Message Date
Gavin D'souza
3446026555 chore: Update header: license.txt => LICENSE
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
Gavin D'souza
65864c027f chore: Update module license header
These modules were imported from the ERPNext codebase into Frappe.
License header was overlooked at that point. These were contributed
initially by Frappe Technologies Pvt Ltd under GPLv3 (ERPNext's license) and now
we, as Frappe Technologies Pvt Ltd converting them to MIT to comply with
Frappe's license.
2021-09-03 11:51:01 +05:30
Rushabh Mehta
cec53b595a fix(cleanup): cleanup email account, bug fix for web_template.js and more 2021-08-31 15:27:25 +05:30
Suraj Shetty
8948eadaf5
Merge branch 'develop' into auto_email_report_null_values 2021-08-30 11:21:53 +05:30
Suraj Shetty
743e361449
Merge branch 'develop' into core-test-coverage-1 2021-08-23 11:02:50 +05:30
Suraj Shetty
5587ab5a91 style: Fix liinter warnings 2021-08-20 23:54:42 +05:30
gavin
d3f3df2ce1
Merge pull request #13984 from gavindsouza/newsletter-unset-autocommit
fix: Revert auto_commit after frappe.sendmail
2021-08-20 16:23:48 +05:30
Suraj Shetty
0262210d1f Merge branch 'develop' of https://github.com/frappe/frappe into core-test-coverage-1 2021-08-19 22:04:50 +05:30
Gavin D'souza
ebc220db39 refactor(tests): frappe.db.delete > frappe.db.sql
Use frappe.db.delete wherever possible. Get rid of all the frappe.db.sql ;)
This commit focuses on the tests written under the doctype specific
tests
2021-08-19 19:50:48 +05:30
Gavin D'souza
6b789ec53a fix: Revert auto_commit after frappe.sendmail 2021-08-19 18:44:36 +05:30
Deepesh Garg
2fcd3b556d fix: Use query report build_xlsx_data function for XLSX and CSV format 2021-08-18 22:53:35 +05:30
Deepesh Garg
5640366757 fix: Handle null values rows for XLSX format 2021-08-18 19:59:56 +05:30
Suraj Shetty
3e7e35351b refactor: Move set_email_password code to email_account.py 2021-08-17 11:20:05 +05:30
Suraj Shetty
475c3ec8b8 fix: import error 2021-08-17 10:24:12 +05:30
Suraj Shetty
3f2a93201b refactor: Move email account related code to email_account.py 2021-08-17 10:00:39 +05:30
Gavin D'souza
6feae59b20 fix: Hanlde Newsletter.get_email_groups & tests cleanup 2021-08-13 17:23:01 +05:30
Gavin D'souza
f2641c37f2 test: Delete newsletters and email docs created in test 2021-08-13 13:04:52 +05:30
Gavin D'souza
cefa75c8dc test: Setup email group at the start of testcase 2021-08-13 12:44:25 +05:30
Gavin D'souza
189f9f81ae fix(Newsletter): Remove "double" validations
Validations for checking recipients and statuses were being checked again later on, via validate_send. This gets rid of doing it twice
2021-08-12 17:47:38 +05:30
Gavin D'souza
43b9b452ff fix: Don't clear Newsletter table at setupClass 2021-08-12 17:30:23 +05:30
Gavin D'souza
d5739cd43b fix: Add exceptions classes for Newsletter 2021-08-12 16:47:01 +05:30
Gavin D'souza
a5010af92a test: Update tests for Newsletter
Added tests for better coverage: Increased to 77% ~ near complete
coverage of controller class, missing tests for API endpoints
2021-08-12 16:17:31 +05:30
Gavin D'souza
c5eb78edd7 refactor: Simplify validations, fix test_send 2021-08-12 16:12:04 +05:30
Gavin D'souza
b28a5beb53 refactor(minor): Newsletter Controller
* Resolve conflicting methods in the controller
* Add docstring
2021-08-11 21:01:56 +05:30
Gavin D'souza
cda48832f4 chore(test): Update API usages
Striving for better readability

* Use frappe.db.delete instead of frappe.db.sql
* Use named kwargs instead of positional
2021-08-11 20:49:32 +05:30
Gavin D'souza
e80d5f25c6 refactor: Newsletter failure handling
Don't raise after handling generic Exception class. Just log error and
go on. This way, other newsletters will continue to loop instead of
breaking after one failure

Added more context (docname) to logged error
2021-08-11 20:49:32 +05:30
Gavin D'souza
46c6b6621e refactor: Newsletter
* Re-send Newsletter only to the recipients who haven't received it yet (Check Email Queue before setting email recipients)
* Re-structed code, broken larger methods to "byte" sized "bits" (hehe)
* Added validations for recipients list
* Added Newsletter.newsletter_recipients property
* Used newer APIs and Fixed namespaces for usages/imports
* Added convenience methods for Newsletter APIs
* Added type annotations for all(?) methods
2021-08-11 20:48:59 +05:30
Gavin D'souza
d63affc732 refactor(minor): Use ORM instead of raw delete queries
Modified query building for "IN" statements, as well as older condition
builders to use frappe.db.delete
2021-07-28 19:04:18 +05:30
Gavin D'souza
a02848849d Merge branch 'develop' of github.com:frappe/frappe into at-queries 2021-07-28 16:00:46 +05:30
Aradhya-Tripathi
84ff1d0af9 style: removed frappe.db.sql comments 2021-07-28 13:48:01 +05:30
Aradhya-Tripathi
a256219dd2 refactor: moved from raw queries in frappe email to
frappe orm
2021-07-21 19:16:59 +05:30
Suraj Shetty
e1c78bb9b3 test: Update test 2021-07-20 15:21:22 +05:30
leela
f54600a400 fix: incoming mail handler
While creating a communication record from incoming mail is failing
in a case where there exists a reference document.

reason for bug is misspelled `self.from_email` as `email.from_email`
2021-06-17 07:31:10 +05:30
mergify[bot]
d699a99b5c
Merge pull request #13496 from shariquerik/allow_rename_email_grp
fix: Allow renaming Email Groups
2021-06-16 08:33:51 +00:00
shariquerik
818ba11031 fix: Allow renaming Email Groups 2021-06-15 11:26:51 +05:30
mergify[bot]
7c5624dd56
Merge pull request #13173 from ankush/unnecessary_comprehensions
perf(minor): remove unnecessary comprehensions
2021-06-14 07:14:20 +00:00
Leela vadlamudi
5a2ea4edc8
Merge pull request #13476 from leela/email-account-based-mail-usage
fix: consider email accounts while checking email limits
2021-06-14 12:10:34 +05:30
Gavin D'souza
e6bdfd8d4f Merge branch 'develop' of github.com:frappe/frappe into unnecessary_comprehensions 2021-06-14 11:53:21 +05:30
Leela vadlamudi
b4f4e48bd6
Merge pull request #13484 from frappe/mergify/bp/develop/pr-13314
fix: encode error to add outgoing mail to sent folder
2021-06-14 10:53:12 +05:30
leela
c523e760fd fix: encode error to add outgoing mail to sent folder
Failed to add outgoing mail to sent folder because of encoding issue.
fixed it by using safe_encode method.

(cherry picked from commit 5165e2afa3884310fd653280c834d984a5feda8d)
2021-06-14 09:37:02 +05:30
Gavin D'souza
cd6f353175 chore: Remove dead and sort imports 2021-06-11 19:33:32 +05:30
Gavin D'souza
c489846547 Merge branch 'develop' into unnecessary_comprehensions 2021-06-11 19:30:23 +05:30
leela
97ac79a295 fix: consider email account while checking email limits
Added email_account argument for out going email count utility functions as
these are used to validate email limits.
2021-06-11 13:54:54 +05:30
leela
efb3489a23 refactor: sendmail of communication doctype
Added a CommunicationEmailMixin that has all mail related
functionality
2021-06-08 12:28:30 +05:30
leela
70a1cfb1ab fix: inbound mail handling for pop3 protocol 2021-06-04 06:55:17 +05:30
Gavin D'souza
2ad9d202cb Merge branch 'develop' of github.com:frappe/frappe into drop-py2-code 2021-06-03 11:21:55 +05:30
Leela vadlamudi
b40a82a659
Merge pull request #13393 from leela/email-queue
refactor: build Email queue from send mail request
2021-06-01 21:56:35 +05:30
leela
8e3b358b9f refactor: email queue builder is added
replaced queue.send function with Queue builder.
Queue builder builds a queue from sendmail request and sends the mail
if requested to send mail immediately.
2021-06-01 21:39:02 +05:30
Gavin D'souza
8558116c70 Merge branch 'develop' of github.com:frappe/frappe into drop-py2-code 2021-05-31 18:28:28 +05:30
getsali
0afe774ddb
fix: Select appropriate email template response (#13051)
* Update email_group.py

Fix: Select appropriate email template response, Welcome email template can be either html or rich text

* refactor: Simpify code

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-05-31 16:32:58 +05:30