Commit graph

6644 commits

Author SHA1 Message Date
6fbb6547bc Merge remote-tracking branch 'upstream/develop' into seitime 2026-05-05 18:51:04 -06:00
353073f996 Allow system manager to impersonate 2026-05-05 18:35:45 -06:00
7d99357ac7 Docperms 2026-05-05 18:33:52 -06:00
Ankush Menat
d9f8b24853 fix: Erase invalid default apps
and ignore at runtime in /apps handlers
2026-05-01 13:34:41 +05:30
Ankush Menat
1bdda7a803 fix: Avoid suggesting invalid " " as default app 2026-05-01 13:23:18 +05:30
Shrihari Mahabal
f185f03660
Merge pull request #39008 from ShrihariMahabal/invalidate-accepted-user-invitation
fix: invalidate user invitation if already accepted
2026-04-29 19:32:28 +05:30
Shrihari Mahabal
7e45db4cec fix: invalidate user invitation if already accepted 2026-04-29 19:20:47 +05:30
Ejaaz Khan
74f8cec1c3
Merge pull request #38976 from KerollesFathy/fix/prevent-standard-report-without-developer-mode
fix(report): prevent standard report creation when developer mode is off
2026-04-29 16:36:48 +05:30
KerollesFathy
a1383ed98f refactor: extract standard report validation into dedicated method
Co-authored-by: Ejaaz Khan <ejaaz@frappe.io>
2026-04-29 10:23:47 +00:00
Ejaaz Khan
c2163c7028
Merge pull request #38932 from KerollesFathy/fix/create-permission-type
fix(Permission Type): disable user cannot create permission
2026-04-29 15:29:04 +05:30
KerollesFathy
acb342efad refactor: add validate_standard_report_developer_mode method
Co-authored-by: Ejaaz Khan <ejaaz@frappe.io>
2026-04-29 09:37:01 +00:00
Raheel Khan
9d5783e519
fix: remove user_doctypes limit from user type as there is no per employee user limit on desk (#38975) 2026-04-29 14:33:09 +05:30
Shrihari Mahabal
0eb922b05d
Merge pull request #38984 from ShrihariMahabal/validate-pvt-file-access
fix: validate private file access before inserting
2026-04-29 13:42:48 +05:30
Shrihari Mahabal
b33929cea8 fix: validate private file access before inserting 2026-04-29 13:31:16 +05:30
Ejaaz Khan
d4b995af04 fix: default show navigation button 2026-04-28 22:00:47 +05:30
KerollesFathy
15966a78a6 fix(report): prevent standard report creation when developer mode is off 2026-04-28 13:32:46 +00:00
KerollesFathy
9c8eefab7b fix(Permission Type): disable user can not create 2026-04-27 10:31:04 +00:00
Ejaaz Khan
e13017794b
Merge pull request #38523 from frappe/38448-property-to-include-fields-in-default-import-template
feat: property to include fields in default import template
2026-04-27 14:55:38 +05:30
Ejaaz Khan
e6daaa6c48
Merge pull request #38567 from frappe/38159-allow-bulk-edit-in-child-tables
feat: allow Bulk Edit in Child Table
2026-04-27 14:50:55 +05:30
Shrihari Mahabal
6284ad13cd
Merge pull request #38876 from ShrihariMahabal/check-perm-on-user-email-awaiting
fix: add perm check on user email awaiting
2026-04-24 18:12:59 +05:30
Shrihari Mahabal
c19dd276ba fix: add perm check on user email awaiting 2026-04-24 17:10:50 +05:30
RitvikSardana
b484cf0136
fix: pytz to filter out deprecated timezones (#38751) 2026-04-24 14:06:40 +05:30
Sumit Jain
aea2f722e7
Merge branch 'develop' into 38159-allow-bulk-edit-in-child-tables 2026-04-24 13:44:28 +05:30
Sumit Jain
78b81fc7cf refactor: Rename 'include_in_import_template' to 'in_import_template' 2026-04-24 13:34:42 +05:30
Ejaaz Khan
778aa12feb
Merge pull request #38393 from barredterra/defer-doctype-export
fix: defer DocType exports until after save response
2026-04-23 23:19:16 +05:30
Ejaaz Khan
b17f60a7fa fix(BulkEdit): Default app options not populating 2026-04-22 17:47:44 +05:30
Abdeali Chharchhodawala
690826ff9b
feat!: faster generation and formatting utils for excel exports (#36323)
* feat: Style builder for report xlsx formatting

* fix: update report to use direct import for query report execution

* refactor: simplify module method retrieval in report execution

* feat: get xlsx styles for report

* refactor: enhance XLSXStyleBuilder with currency formatting and default style registration

* feat: add xlsxwriter dependency for enhanced XLSX report generation

* refactor: enhance XLSXStyleBuilder with improved style registration and formatting methods

* feat: enhance XLSX export functionality with improved styling and metadata support

* refactor: default formatting of currency

* chore: remove some typo

* feat: update make_xlsx function to use xlsxwriter for improved Excel file generation and styling

* perf: some micro optimisations

* refactor: inline generator back and improve condition

* refactor: replace frappe.request_cache with functools.cache

* fix: handle styling in email

* fix: fix old test case to handle styles in export

* refactor: enhance XLSX style handling and registration methods

* refactor: improve currency formatting logic

* fix: update make_xlsx to use constant_memory for large datasets and improve row style handling

* fix: handle None style_id in XLSXStyleBuilder methods to prevent errors

* fix: include owner field with proper doctype naming

* fix: set default date format in XLSX workbook creation

* fix: pass applied filters to metadata

* fix: getting accurate field info for report view exporting

* chore: Minor changes

* feat: add function to generate default XLSX styles for exports

* feat: integrate default XLSX styles into builder report export functionality

* feat: styles on export docs xlsx

* feat: enhance make_xlsx function to support file path saving

* feat: add make_xls function for creating Excel files in old format and improve sheet name sanitization

* fix: handle default date formatting

* refactor: changes xlsx builder usage

* refactor: update xlsx style builder usage

* refactor: enhance field info retrieval with default field support

* fix: handle update key in report data

* refactor: enhance get_field_info to include options and improve label retrieval

* fix: improve error handling for unsupported file formats and ensure applied filters are set correctly

* refactor: update XLSX header index handling and improve metadata structure

* fix: handle currency formatting in reportview export

* fix: update default date format to datetime format in XLSX creation

* fix: update serial number field in auto email report to use 'sr' instead of 'idx'

* fix: enhance XLSX styling by adding right alignment for specific field types

* chore: remove unused code

* fix: update XLSXMetadata attributes for improved report styling options

* perf: further improve currency styling

* fix: correct column index mapping in XLSX export header

* refactor: optimize indentation style registration in XLSXStyleBuilder

* perf: improve apply_indentations

* fix: reduce more attr lookup

* refactor: remove duplication

* fix: use report name in XLSX export instead of hardcoded title

* fix: remove ignore_visible_idx from XLSXMetadata

* fix: review

* fix: update XLSX style fetching logic in build_xlsx_data function

* fix: add right alignment to date, time, and datetime styles in XLSXStyleBuilder

* fix: simplify number format handling in XLSXStyleBuilder

* fix: register common styles in XLSXStyleBuilder for improved style management

* test: add tests for XLSX styles structure and fieldtype column styles in XLSXStyleBuilder

---------

Co-authored-by: Sagar Vora <16315650+sagarvora@users.noreply.github.com>
2026-04-21 19:07:43 +05:30
Aarol D'Souza
4358f5bd44
Merge pull request #38740 from AarDG10/fix-backup
fix(response): harden download_backup
2026-04-21 12:11:08 +05:30
Ejaaz Khan
486d56934b
Merge pull request #38741 from KerollesFathy/fix-hide-permissions-tab
fix(doctype): show Permissions tab only when doctype is not a child table
2026-04-21 06:59:48 +05:30
Raffael Meyer
166bb914c1
fix: set autocomplete attribute for password fields in user and setup wizard forms (#38744) 2026-04-20 23:09:49 +00:00
KerollesFathy
5c7d28a826 fix(doctype): show Permissions tab only when doctype is not a child table 2026-04-20 14:16:10 +00:00
AarDG10
7c9ce26469 feat(utils): add util to ensure sandboxing
This util can be used in places where sandboxing is needed.
2026-04-20 18:49:42 +05:30
Nihantra C. Patel
0cefdf0f8d
fix: formatting 2026-04-20 12:44:34 +05:30
Nihantra C. Patel
c36dc287b4
fix: skip report letter head validation when no letter head is set 2026-04-20 12:36:44 +05:30
Ejaaz Khan
843e396b44
Merge pull request #38466 from kaulith/fix/role-profile-not-visible-in-user-list-view
fix: sync role_profile_name for user list view display
2026-04-18 23:50:11 +05:30
Saqib Ansari
75bae453ac
fix(prepared_report): handle missing attachments in get_prepared_data method (#38449) 2026-04-18 19:28:41 +05:30
Ejaaz Khan
13480db3fd
Merge pull request #36792 from aerele/fix/doctype-duplicate-auto-repeat
fix(doctype): disable allow_auto_repeat during duplication
2026-04-18 08:43:15 +05:30
diptanilsaha
37b05961c7
fix(security_settings): enabled track_changes and convert expires to UTC timezone (#38675)
* fix(security_settings): convert expires timestamp from system timezone to UTC

* fix(security_settings): enabled `track_changes` on `Security Settings` DocType
2026-04-17 14:29:28 +05:30
Dharanidharan2813
d6b5941c83 fix(doctype): disable allow_auto_repeat during duplication to prevent save failure 2026-04-17 12:44:03 +05:30
Shllokkk
44b5228598
feat: introduce standard and letter_head_for fields in letter head doctype (#38417)
* feat: introduce standard and letter_head_for fields in letter head doctype

* feat: introduce a module link field to letterhead doctype to support json creation

* feat: make Letter Head importable via sync

* test(Letter Head): fix the test_auto_image test case for letter head doctype

* fix: make module field depend on standard field value

* feat: introduce letter heads for standard reports

* fix: letter heads for non-standard reports

* fix: letter_head validation in report and letter head doctype edit access based on users

* fix: correct validation for standard letter head creation
2026-04-17 12:34:33 +05:30
Aarol D'Souza
9f63f8167d
Merge pull request #38219 from kaulith/fix/prepared-report-timestamp-mismatch
fix: reload Prepared Report before save to avoid TimestampMismatchError
2026-04-16 17:19:02 +05:30
rohitwaghchaure
6bf4712930
Merge pull request #38631 from rohitwaghchaure/fixed-slow-query
fix: site slow having huge numbers of files
2026-04-16 16:04:44 +05:30
Rohit Waghchaure
13bf909b22 fix: site slow having huge numbers of files 2026-04-15 19:59:16 +05:30
Shariq Ansari
304283c222
Merge pull request #38588 from shariquerik/reset-password-fix 2026-04-15 16:13:28 +05:30
shariquerik
71613d6fc8 fix: correct wording in password reset message for consistency 2026-04-15 15:32:03 +05:30
Shariq Ansari
667787cb47
fix: updated message 2026-04-15 02:53:07 -07:00
Shariq Ansari
74a5b3c8a3
fix: updated message 2026-04-15 02:39:17 -07:00
shariquerik
33077e0a2c test: ensure consistent response and messaging in password reset functionality 2026-04-15 12:13:19 +05:30
shariquerik
fe1edb3c01 fix: change return type to None 2026-04-15 12:04:53 +05:30
shariquerik
9f92e7bf0d fix: enhance error handling in password reset process 2026-04-15 12:02:20 +05:30