Commit graph

1863 commits

Author SHA1 Message Date
Aarol D'Souza
3b8d67ae11
Merge pull request #38941 from AarDG10/fix-email-acc
fix(email_account): add perm. check to set_email_password
2026-04-28 12:15:52 +05:30
AarDG10
9bcac62d98 fix(standard_macros): escape fields in standard print format template
Escaping on output, and reverting changes made in formatters.py.
2026-04-28 08:12:16 +05:30
AarDG10
dd9450dc46 fix(email_account): add perm. check to set_email_password
Not too certain why a perm. check was skipped here, adding nonetheless.
2026-04-27 17:34:47 +05:30
Aarol D'Souza
cdc6dca582
Merge pull request #38835 from AarDG10/fix-formatters
fix(formatters)!: escape input fields
2026-04-27 12:26:38 +05:30
KerollesFathy
615b2c5e8d fix(EmailQueue): ensure communication exists before updating delivery status 2026-04-26 12:11:25 +00:00
Kerolles Fathy
3d414812c8
Merge pull request #38857 from devdiogenes/fix-condition-examples-translatable
fix: Makes Condition Examples title translatable
2026-04-24 01:08:52 +03:00
AarDG10
785c85e6a5 fix(formatters): escape fields
Escaped fields so as to render them as text nodes.
2026-04-23 20:10:01 +05:30
s-aga-r
7f355b3f53 fix(SMTP): config to disable EHLO after AUTH 2026-04-23 11:25:54 +05:30
devdiogenes
95d0fecee7 fix: Makes Condition Examples title translatable 2026-04-22 18:50:01 +00:00
Henning Wendtland
3571469cea fix(queue): correct the conditional check in retry_sending_emails 2026-04-22 17:25:19 +05:30
Abdeali Chharchhodawala
690826ff9b
feat!: faster generation and formatting utils for excel exports (#36323)
* feat: Style builder for report xlsx formatting

* fix: update report to use direct import for query report execution

* refactor: simplify module method retrieval in report execution

* feat: get xlsx styles for report

* refactor: enhance XLSXStyleBuilder with currency formatting and default style registration

* feat: add xlsxwriter dependency for enhanced XLSX report generation

* refactor: enhance XLSXStyleBuilder with improved style registration and formatting methods

* feat: enhance XLSX export functionality with improved styling and metadata support

* refactor: default formatting of currency

* chore: remove some typo

* feat: update make_xlsx function to use xlsxwriter for improved Excel file generation and styling

* perf: some micro optimisations

* refactor: inline generator back and improve condition

* refactor: replace frappe.request_cache with functools.cache

* fix: handle styling in email

* fix: fix old test case to handle styles in export

* refactor: enhance XLSX style handling and registration methods

* refactor: improve currency formatting logic

* fix: update make_xlsx to use constant_memory for large datasets and improve row style handling

* fix: handle None style_id in XLSXStyleBuilder methods to prevent errors

* fix: include owner field with proper doctype naming

* fix: set default date format in XLSX workbook creation

* fix: pass applied filters to metadata

* fix: getting accurate field info for report view exporting

* chore: Minor changes

* feat: add function to generate default XLSX styles for exports

* feat: integrate default XLSX styles into builder report export functionality

* feat: styles on export docs xlsx

* feat: enhance make_xlsx function to support file path saving

* feat: add make_xls function for creating Excel files in old format and improve sheet name sanitization

* fix: handle default date formatting

* refactor: changes xlsx builder usage

* refactor: update xlsx style builder usage

* refactor: enhance field info retrieval with default field support

* fix: handle update key in report data

* refactor: enhance get_field_info to include options and improve label retrieval

* fix: improve error handling for unsupported file formats and ensure applied filters are set correctly

* refactor: update XLSX header index handling and improve metadata structure

* fix: handle currency formatting in reportview export

* fix: update default date format to datetime format in XLSX creation

* fix: update serial number field in auto email report to use 'sr' instead of 'idx'

* fix: enhance XLSX styling by adding right alignment for specific field types

* chore: remove unused code

* fix: update XLSXMetadata attributes for improved report styling options

* perf: further improve currency styling

* fix: correct column index mapping in XLSX export header

* refactor: optimize indentation style registration in XLSXStyleBuilder

* perf: improve apply_indentations

* fix: reduce more attr lookup

* refactor: remove duplication

* fix: use report name in XLSX export instead of hardcoded title

* fix: remove ignore_visible_idx from XLSXMetadata

* fix: review

* fix: update XLSX style fetching logic in build_xlsx_data function

* fix: add right alignment to date, time, and datetime styles in XLSXStyleBuilder

* fix: simplify number format handling in XLSXStyleBuilder

* fix: register common styles in XLSXStyleBuilder for improved style management

* test: add tests for XLSX styles structure and fieldtype column styles in XLSXStyleBuilder

---------

Co-authored-by: Sagar Vora <16315650+sagarvora@users.noreply.github.com>
2026-04-21 19:07:43 +05:30
Ankush Menat
0d8ddb5958 Merge branch 'develop' into get-docs 2026-04-08 10:50:31 +05:30
Raffael Meyer
8a80840abd
fix(Email Account): create_dummy (#38480) 2026-04-07 22:37:09 +02:00
s-aga-r
5b4d36b087
fix(email): validate message size only when SIZE limit is greater than 0 (#38441) 2026-04-07 03:39:36 +00:00
s-aga-r
b6c9cebc27
Merge pull request #37246 from prathameshkurunkar7/37186-inline_images-parameter-in-frappesendmail-is-ignored
fix(sendmail): respect inline_images parameter in sendmail
2026-04-01 18:10:30 +05:30
mergify[bot]
1907293ba7
Merge branch 'develop' into get-docs 2026-03-19 11:48:31 +00:00
iamkhanraheel
d226e0a47e fix(auto_email_report): run onload event of report to update dynamic filters 2026-03-17 08:16:53 +05:30
Shrihari Mahabal
c174881534 refactor: change existing functionality in framework to check if get_docs is working 2026-03-10 13:26:38 +05:30
Ankush Menat
a655bbdfa6
Merge pull request #37760 from ShrihariMahabal/undo-email-send
feat: Allow undo email send for 10 seconds
2026-03-10 13:06:52 +05:30
Akhil Narang
3e4f139ff3
fix: use string representation of exceptions in translated strings (#37756)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-03-06 13:02:16 +05:30
Shrihari Mahabal
55de855b32 fix: correct add_to_date function call and parameterize batch size in get_queue sql query 2026-03-04 17:44:09 +05:30
Shrihari Mahabal
5f4174be2d feat(email): delay email queue flushing for recording created between now and 10 seconds 2026-03-04 16:34:57 +05:30
s-aga-r
c13cdd1adc
Merge pull request #37752 from s-aga-r/fix-37296
fix(email): validate IMAP folders using `SELECT` instead of `LIST` parsing
2026-03-04 10:32:38 +00:00
s-aga-r
70a8693b1b
Merge pull request #37710 from s-aga-r/fix-18694
fix(email): ensure `text/plain` part contains plain text instead of markdown
2026-03-03 11:56:45 +05:30
s-aga-r
9454fb4e6e fix(email): ensure text/plain part contains plain text instead of markdown 2026-03-03 11:37:40 +05:30
Suraj Shetty
bb904fa60c
Merge pull request #36994 from s-aga-r/19370 2026-02-25 17:24:20 +05:30
Akhil Narang
e725c414ac
feat(email_queue): log suspend/resume actions in activity log (#37450)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2026-02-25 10:09:24 +05:30
Sagar Vora
39b0cea12f
Merge pull request #37420 from diptanilsaha/nr_delete
fix: delete standard notification and report files after `commit`
2026-02-23 21:53:01 +05:30
diptanilsaha
539d0f9d7a fix: delete standard notification and report files after commit 2026-02-23 19:18:19 +05:30
s-aga-r
9a3d173b62 fix: prevent UTF-8 corruption in text attachments 2026-02-23 15:40:14 +05:30
Priyal208
b7214c6957
fix: report and notification folder deletion on deletion from ui (#37190)
Co-authored-by: Sagar Vora <16315650+sagarvora@users.noreply.github.com>
2026-02-23 08:45:43 +00:00
s-aga-r
9bf9fa6d7b
Merge pull request #37362 from s-aga-r/fix-36281
fix(IMAP): safely handle `UID FETCH` response
2026-02-23 13:20:55 +05:30
s-aga-r
d3eab14047
Merge pull request #37304 from s-aga-r/21201
fix: validate message size against SMTP SIZE limit
2026-02-23 12:43:30 +05:30
s-aga-r
dc11227b73 fix(IMAP): safely handle UID FETCH response 2026-02-23 11:45:08 +05:30
s-aga-r
cc7474abee fix: ignore attachments over the attachment_limit 2026-02-23 09:58:37 +05:30
Sumit Jain
617e4a8d8f
fix(notification): remove Custom type from send_alert_on as it's not getting used somewhere (#37256) 2026-02-20 19:57:21 +05:30
s-aga-r
2547b710cf fix: validate message size against SMTP SIZE limit 2026-02-20 14:43:49 +05:30
s-aga-r
6be1608350 fix: validate IMAP folders exist 2026-02-20 12:21:38 +05:30
s-aga-r
647b376339 refactor: IMAP settings validation 2026-02-20 11:49:09 +05:30
s-aga-r
fef9d89ce0
feat: configurable DSN (#36988)
* feat: configurable `DSN`

* chore: validate dsn support on save

* fix: DSN validation
2026-02-20 10:30:14 +05:30
prathameshkurunkar7
90615ea4df docs(test_email_body): clarify test docs 2026-02-19 15:04:26 +05:30
Aarol D'Souza
08793c57f7
fix: force type check in whitelisted methods 2 (#37086)
* fix(diff): add type hints to whitelisted methods

* fix(global_search): add type hints to whitelisted methods

* fix(custom_html_block): add type hints to whitelisted methods

* fix(deleted_document): add type hints to whitelisted methods

* fix(log_settings): add type hints to whitelisted methods

* fix(role): add type hints to whitelisted methods

* fix(user_type): add type hints to whitelisted methods

* fix(rq_job): add type hints to whitelisted methods

* fix(link_preview): add type hints to whitelisted methods

* fix(email_account): add type hints to whitelisted methods

* fix(web_form): add type hints to whitelisted methods

* fix(web_page_view): add type hints to whitelisted methods

* fix(csvutils): add type hints to whitelisted methods

* fix(file_manager): add type hints to whitelisted methods

* fix(email_body): add type hints to whitelisted methods

* fix(email_queue): add type hints to whitelisted methods

* fix(email_template): add type hints to whitelisted methods

* fix(notification): add type hints to whitelisted methods

* fix(email_group): add type hints to whitelisted methods

* fix(inbox): add type hints to whitelisted methods

* fix(recorder): add type hints to whitelisted methods

* fix(sms_settings): add type hints to whitelisted methods

* fix: tighten type hints

* fix(data_import): add type hints to whitelisted methods

* fix(user_permission): add type hints to whitelisted methods

* fix(gantt): add type hints to whitelisted methods

* fix(like): add type hints to whitelisted methods

* fix(search): add type hints to whitelisted methods

* fix(onboarding_step): add type hints to whitelisted methods

* fix(system_console): add type hints to whitelisted methods

* fix(workspace_sidebar): add type hints to whitelisted methods

* fix(todo): add type hints to whitelisted methods

* fix: correct type hints

* fix(print_format): add type hints to whitelisted methods

* fix(client): add type hints to whitelisted methods
2026-02-19 14:58:16 +05:30
prathameshkurunkar7
a252e7e265 fix(sendmail): respect inline_images parameter in sendmail 2026-02-19 14:53:32 +05:30
s-aga-r
6a132e94e0
fix(Email Account): remove redundant field (#37229) 2026-02-19 07:40:37 +00:00
s-aga-r
2960865605
fix: use default incoming email account as Reply-To (#36793)
* fix: use default incoming email account as `Reply-To`

* chore: set incoming account email as Reply-To

---------

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2026-02-19 06:55:04 +00:00
s-aga-r
8bfb42deb4
feat: configurable Reply-To (#36774)
* feat: configurable `Reply-To`

* chore: set `add_reply_to_header` to `1`

* fix: Resolve conflicts

---------

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2026-02-19 12:13:55 +05:30
s-aga-r
e735ae774e
fix: lower timeout when validating Email Account (#37147)
* fix: reduce Email Domain validate timeout

* fix: lower timeout when validating Email Account (SMTP)

* fix: lower timeout when validating Email Account (IMAP/POP)
2026-02-19 12:01:28 +05:30
Prathamesh Kurunkar
79003d6674
docs(sendmail): clarify behavior of queue_separately and CC/BCC in email_queue (#37113)
* fix(sendmail): enhance queuing of cc and bcc recipients to avoid duplicates

* revert: fix(sendmail): enhance queuing of cc and bcc recipients to avoid duplicates

This reverts commit 66c0c1cfb7c0f46f5687ce5266f945e88dadc1db.

* docs(email_queue): clarify behavior of queue_separately and CC/BCC in email queue
2026-02-18 15:57:20 +05:30
Prathamesh Kurunkar
3e061b026b
fix(email): ensure CC header visibility according to email semantics (#37182)
* fix(email): ensure CC header visibility according to email semantics

* chore(email): fix linting in docs
2026-02-18 15:55:06 +05:30
s-aga-r
13c7a38fce
fix: link received reply of sent email (#37177) 2026-02-18 15:20:48 +05:30