Commit graph

2327 commits

Author SHA1 Message Date
Corentin Flr
8b03a48f24
fix(WebForm): Replace get_cached_value with get_value
frappe.get_cached_value does not support filters
2023-11-20 12:13:55 +01:00
mergify[bot]
318b2e5ca2
fix:The title of the Link control does not appear correctly in the we… (backport #23270) (#23280)
Co-authored-by: Nrtyck <37080373+Nrtyck@users.noreply.github.com>
2023-11-18 23:06:12 +05:30
Corentin Flr
b079d3ef78
fix(web): Send first_day_of_the_week and number_format in bootinfo 2023-11-17 16:14:37 +01:00
David Arnold
18f34c36f6
fix(float): input formatting 2023-11-07 18:07:06 +01:00
Raffael Meyer
f0155674a5
refactor!: remove redundant sending of translations (#22962)
* chore!: remove redundant translation

* refactor!: remove "get_translated_dict" hook

Instead, include the results from
`frappe.geo.country_info.get_translated_dict` in `get_all_translations`.

* test: money_in_words uses translated currency

... and now we have translations.

* Revert "test: money_in_words uses translated currency"

This reverts commit e07d594ac1ce4b120c0fceb5d23377cb981fe820.

* refactor!: stop translating timezone and currency

* refactor: rename `get_translated_dict`

... to `get_translated_countries`
2023-11-02 20:04:14 +05:30
Suraj Shetty
b56cbdfff8
perf: Enqueue "removing of index" on web page deletion (#23044) 2023-11-01 09:40:51 +05:30
Akhil Narang
796b11d665
chore(help_article): drop usage of ifnull
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-31 15:36:01 +05:30
Thomas Fojan
36ad7e053e
fix: developer mode in website theme (#22958)
[skip ci]
2023-10-30 18:06:19 +05:30
Suraj Shetty
7497b00167
Merge pull request #22967 from maharshivpatel/fix-inter-font-load-web 2023-10-30 17:39:38 +05:30
Akhil Narang
13537ad0f6
chore(blog_post): drop usage of ifnull (#22983)
`published` is a `Check` (int, non-nullable) field which has a default value in the database

Signed-off-by: Akhil Narang <me@akhilnarang.dev>


[skip ci]
2023-10-30 17:21:43 +05:30
Maharshi Patel
cd8c2dd21c fix: font loading on custom website theme
- added inter.scss as css import is failing in custom website theme
- changed css to inter.scss for website/index.scss
- inter.css is deprecated and should be removed in future
- update --font-stack if custom fonts are used in website theme.
- removed espresso variables from css_variables.scss
  as they are already imported in variables.scss
2023-10-30 12:44:35 +05:30
Maharshi Patel
259695a1c7 fix: web styles espresso
- added Inter & Inter V on website and font-stack
- added flex to logged-in to center avatar
- decreased brand logo height to 22px
- added primary border-bottom to active navbar link
- added underline to links for blog content
  and added to from-markdown for web pages
2023-10-26 12:50:56 +05:30
Ankush Menat
018ed845bd refactor: defer unnecessary json-dumping of messages
Also avoid accessing locals where interface is present like for popping last message.
2023-10-16 18:13:50 +05:30
Ankush Menat
e1f2f4bb54 fix: Let social login key control signups
There are cases where certain social login keys

- Should not allow signups at all and only allow logins. E.g. social media login keys.
- Should allow signups even if global sign ups are disabled. e.g. internal SSO like setups.
2023-10-14 12:43:48 +05:30
Shariq Ansari
009d9e010b
Merge pull request #22679 from shariquerik/conditional-webform-list-view 2023-10-10 15:47:27 +05:30
Shariq Ansari
46f3b5b12d fix: changed table style to match grid style
updated description and some minor fixes
2023-10-10 12:53:21 +05:30
Shariq Ansari
fb9c111ed2 fix: conditional webform with list view enabled 2023-10-10 11:47:03 +05:30
Corentin Forler
443ffa06d5
fix(NotPermittedPage): Add redirect-to even if starting with /app
A page like "/appointment" would redirect to /login, but without the redirect-to parameter, which is undesired
2023-09-27 12:16:06 +02:00
Ankush Menat
4122eba784 fix: Add crossorigin for preload
If crossorigin isn't specified browsers don't seem to use it.
2023-09-23 17:34:48 +05:30
Ankush Menat
428d78a491 chore: move svg icons to end and correct version 2023-09-23 15:17:05 +05:30
Ankush Menat
d7a9d0111c
perf: lazy load SVG icons (#22517)
| Metric                             | Before | After | Change    |
| ---                                | ---    | ---   | ---       |
| app.html first response size       | 421kb  | 106kb | -75% (!)  |
| First response duration            | 60ms   | 40ms  | -33%      |

huge thanks to @cogk for doing most of the work for this PR on this issue: https://github.com/frappe/frappe/issues/17449#issuecomment-1728328726

Co-authored-by: Corentin Flr <10946971+cogk@users.noreply.github.com>
2023-09-23 15:13:43 +05:30
Ankush Menat
8779be9b49
fix: propogate correct HTTP status code (#22450) 2023-09-18 10:30:12 +00:00
Gursheen Kaur Anand
e03525efba
fix: remove items linked to non-existing doctypes from portal settings (#22417)
* fix: remove non-existing ref doctypes from portal settings

* fix: use separate list to iterate
2023-09-15 15:06:51 +05:30
Suraj Shetty
2587d3e2e0
perf: Enqueue "removing of index" on web page save (#22409)
* perf: Enqueue "removing of index" on web page save

* fix: Enqueue after commit

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>

* fix: enqueue after commit

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-09-14 14:58:19 +05:30
Ankush Menat
b445c20e22
test: ignore whitespace changes while comparing HTML (#22386) 2023-09-13 08:18:56 +00:00
mergify[bot]
1f810c14a8
fix: convert category tojson (#22342) (#22343)
(cherry picked from commit 91c4a9571da5255186c26b78b5b21800f758055f)

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-09-10 17:08:29 +05:30
Raffael Meyer
1dcf1d1f4b
Merge pull request #21874 from blaggacao/fix-website-asset-discovery 2023-08-29 19:23:55 +02:00
Ankush Menat
dc8d7b019a refactor!: Lower roles from All To Desk User 2023-08-29 12:07:57 +05:30
Corentin Forler
1c64334916 fix(webform): Retrieve layout fields too 2023-08-24 16:08:54 +02:00
David Arnold
414febab96
fix(test): ensure tests construe the site url from its constructor 2023-08-23 12:04:57 +02:00
Raffael Meyer
6ea739e4cf
refactor(File): explicitly import utils (#22143) 2023-08-23 11:08:22 +05:30
David Arnold
8dabd2bae6
refactor: make the app source accessor explicit
The parent folder of a python module (inside `./site-packages`) can be
`./lib`. Separate code paths that depend on the app source into its own
getter so that patching that function becomes easier in those cases
where the python module is not served from the source checkout.
2023-08-20 01:11:05 +02:00
Suraj Shetty
5d85341984 feat: Hook to add dynamic routes for other web view doctypes 2023-08-17 09:30:24 +05:30
Raffael Meyer
d6dfe6f0fe
fix(Web Form): redirect countdown (#22032) 2023-08-14 13:57:12 +05:30
Ankush Menat
58568115a9
Merge pull request #21955 from barredterra/refactor-with-sourcery
refactor: run sourcery on all files
2023-08-10 10:11:20 +05:30
barredterra
88c8baa9ee refactor: for append to extend, merge list extend
Replace a for append loop with list extend.
Create the list with values instead of creating
an empty list and extending it with another list.
2023-08-09 13:25:39 +02:00
barredterra
b553ed98d8 refactor: inline immediately returned variable
Inline a variable to a return in the case when the
variable being declared is immediately returned
2023-08-08 18:09:49 +02:00
Raffael Meyer
c3aaab3447
fix(Web Form): translation of forwarding message (#21948) 2023-08-08 11:05:42 +05:30
Jannat Patel
49a9f53d24
feat: text editor and mentions for discussions (#21886) 2023-08-07 20:23:53 +05:30
Sagar Vora
e588f2d70b
Merge pull request #21928 from resilient-tech/fix-rate-limiter 2023-08-05 17:38:08 +00:00
Sagar Vora
2b96324c31
fix: rate limit for all HTTP methods (#21929) 2023-08-05 22:32:55 +05:30
Sagar Vora
773cefea69 test: specify args or kwargs instead of frappe.form_dict 2023-08-05 14:14:03 +05:30
Sagar Vora
0cced74766 fix: add rate limiting and type hints for add_feedback 2023-08-05 12:46:31 +05:30
Corentin Forler
d7aea1773f fix(web_form): Allow Jinja extension of header buttons 2023-07-28 18:12:45 +02:00
Ankush Menat
927cd647e4 chore: generate type annotations 2023-07-24 15:32:48 +05:30
Sagar Vora
d2becc7f1d fix: no API call required to set cookie in browser 2023-07-22 17:54:41 +05:30
barredterra
588bbd9d1c fix: include languages when clearing website cache 2023-07-18 12:53:57 +02:00
Gursheen Kaur Anand
149467a71b
fix: fetch portal sidebar items (#21703) 2023-07-18 09:34:52 +05:30
Ankush Menat
b5409f6f07 chore: remove eslint-disable* 2023-07-14 15:41:20 +05:30
Ankush Menat
58cf770760 fix: All ESLint errors 2023-07-14 15:25:48 +05:30