Commit graph

23166 commits

Author SHA1 Message Date
cjpit
f34af5bc25 fix: rfc5322 compliance for python3 (#8912)
* start of tests

* rfc compliant emails for frappe.

* fix for deepsource

* fix length of strings.

* fix bug that I'm not sure where it came from?

* codacy and deepsource issues trying to keep them happy

* take a punt in the dark

* fix: use SMTPUTF8 instead of SMTP and other minor fixes

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2019-12-17 14:01:52 +05:30
mergify[bot]
2071d81081
Merge pull request #9046 from prssanna/new-doc-fix
fix: user default value for Link fields
2019-12-16 13:17:57 +00:00
mergify[bot]
662a94ef7b
Merge pull request #9047 from prssanna/filter-email-fix
fix: don't validate email for standard filters
2019-12-16 12:02:53 +00:00
prssanna
e7d9e6edf9 fix: don't validate email for standard filters 2019-12-16 17:12:34 +05:30
prssanna
c83ff2679f fix: before setting user default value, if fieldtype is Link check if doc exists 2019-12-16 16:26:20 +05:30
mergify[bot]
9851f626e1
Merge pull request #9044 from surajshetty3416/fix-grid
fix(grid): Empty row validation
2019-12-16 07:30:49 +00:00
Suraj Shetty
13bda71188 style: Fix code formatting 2019-12-16 12:43:38 +05:30
Suraj Shetty
65854bf3ef fix: Empty row validation 2019-12-16 12:40:55 +05:30
Suraj Shetty
39cbeac6db
Merge pull request #9011 from surajshetty3416/fix-report-view-edit-option
fix: Allow field of submitted doc to edit if field has allow_on_submit enabled
2019-12-14 23:47:40 +05:30
Suraj Shetty
5bd9023f8c test: Clear cache after creating doctype 2019-12-14 23:29:21 +05:30
mergify[bot]
de5cf4a007
Merge pull request #9016 from surajshetty3416/fix-report-user-permission
fix: User permission issue in query report
2019-12-14 16:06:07 +00:00
Suraj Shetty
843a5fb520
Merge branch 'develop' into fix-report-view-edit-option 2019-12-14 21:20:49 +05:30
mathieu.brunot
d38e9855be
Merge remote-tracking branch 'origin/develop' into ci/reports
Signed-off-by: mathieu.brunot <mathieu.brunot@monogramm.io>
2019-12-14 14:38:43 +01:00
Suraj Shetty
7cf5dee097 test: Add assert statement for value 2019-12-14 18:27:58 +05:30
mergify[bot]
62baf3e7cf
Merge pull request #9037 from surajshetty3416/fix-desk-modules
fix: Add a patch to fix all user's home settings
2019-12-14 12:35:31 +00:00
mergify[bot]
59613665e7
Merge pull request #9026 from surajshetty3416/fix-report-column-hide
fix(report): Hidden columns should be hidden even after refresh
2019-12-14 12:16:54 +00:00
Suraj Shetty
09ec275c2b fix: Remove limit 2019-12-14 17:44:17 +05:30
Suraj Shetty
310233c56a
fix: Show default currency as a fallback for currency fieldtype (#8944)
* fix: Show default currency as a fallback for currency fieldtype

* test: Add a test for currency formatting
2019-12-14 17:34:04 +05:30
Prssanna Desai
e5c1f80071 fix(Grid): Child table pagination fixes (#9034)
* fix: don't render result if grid_rows is undefined and fix truncate_rows

* fix: change page length to 50

* fix: grid pagination ui test

* fix: confirm before deleting all child table rows
2019-12-13 22:35:27 +05:30
mergify[bot]
579ebb8b81
Merge pull request #9038 from prssanna/upload-fix
fix: grid file upload fix
2019-12-13 12:12:33 +00:00
prssanna
ce7929e1e2 fix: grid file upload fix 2019-12-13 15:56:59 +05:30
Chinmay D. Pai
7347764c87
fix: use filter for removing administrator from email list
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
Co-authored-by: Saurabh Palande <saurabh6790@gmail.com>
2019-12-13 15:28:55 +05:30
Suraj Shetty
129bc14495 fix: Add a patch to fix all user's home settings 2019-12-13 14:09:23 +05:30
deepeshgarg007
ea274cc999 fix: Add mandatory depends on and read only depends on field in custom field doctype 2019-12-12 21:51:20 +05:30
Himanshu
f9777268b8 feat: add default email account for email linking (#8833)
* feat: add default email account for email linking

* fix: remove unused import

* fix: remove try-catch
2019-12-12 16:10:56 +00:00
deepeshgarg007
33ec59ad53 Merge barnch develop into mandatory-depends-on 2019-12-12 20:58:27 +05:30
Suraj Shetty
d1c0579c70 fix(file): Public-private issue (#9029)
* fix: Pass file's is_private for doc creation

* fix: File is_private and file_url mismatch

* fix: Check if file_url exists

* fix: Validation check

* fix(postgres): Convert is_private to int

* fix: File path for content_hash
2019-12-12 20:00:30 +05:30
Khushal Trivedi
6ab38c2af5 fix: link field search taking trailing and leading spaces (#9031) 2019-12-12 19:24:17 +05:30
Oshosanya Michael
8a11fb57cd feat: Allow full database config on creating site (#8874)
* Allow setting db port on install

* Allow setting db port on install

* Allow full db config on creating site

* bug fix

* bug fix

* Escape character

* Update frappe/commands/site.py

allow only integer argument

Co-Authored-By: Chinmay Pai <chinmaydpai@gmail.com>

* Update frappe/database/db_manager.py

No need to escape integer variable

Co-Authored-By: Chinmay Pai <chinmaydpai@gmail.com>

* cast port to integer to surpress pymysql error

* cast port to string to surpress pymysql error

* Removed type casting
2019-12-12 13:17:07 +05:30
Shivam Mishra
eeabcb8155 fix: height for null state on list view (#8997)
* fix: height for null state on list view

* Update list.less
2019-12-12 11:51:20 +05:30
Suraj Shetty
80fd42aba2 fix: Hidden columns should be hidden even after refresh 2019-12-12 11:35:22 +05:30
mergify[bot]
e689b7adfd
Merge pull request #9008 from Thunderbottom/auto-commit-prepared-rep
fix(patch): auto commit on more than 10000 writes
2019-12-12 05:47:32 +00:00
Chinmay D. Pai
03885a058b
fix(chat): change sql formatting
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2019-12-11 22:13:28 +05:30
Chinmay D. Pai
6c27f876a4
fix(chat): make keyword changes to chat.js
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2019-12-11 21:37:20 +05:30
Prssanna Desai
90f89a754a fix(Leaderboard): Leaderboard timespan options (#8953)
* fix: change leaderboard timespan options and add select from date option

* fix: leaderboard timespan options grouping and add quarter_start and quarter_end to datetime.js

* fix: codacy

* fix: add last month
2019-12-11 21:28:59 +05:30
Chinmay D. Pai
a8d2ed8d45
fix(chat): refactor code to make chat work
fixes issues with token being wrongly passed as the owner, instead of
current session user (ie. frappe.session.user), which in turn causes the
following issue:

Traceback (most recent call last):
  File "/home/frappe/frappe-bench/apps/frappe/frappe/app.py", line 57, in application
    response = frappe.handler.handle()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 22, in handle
    data = execute_cmd(cmd)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/handler.py", line 61, in execute_cmd
    return frappe.call(method, **frappe.form_dict)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 1042, in call
    return fn(*args, **newargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/chat/doctype/chat_room/chat_room.py", line 203, in create
    room.save(ignore_permissions = True)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 272, in save
    return self._save(*args, **kwargs)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 295, in _save
    self.insert()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 223, in insert
    self._validate_links()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/model/document.py", line 756, in _validate_links
    frappe.LinkValidationError)
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 364, in throw
    msgprint(msg, raise_exception=exc, title=title, indicator='red')
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 350, in msgprint
    _raise_exception()
  File "/home/frappe/frappe-bench/apps/frappe/frappe/__init__.py", line 316, in _raise_exception
    raise raise_exception(msg)
frappe.exceptions.LinkValidationError: Could not find Owner: 0a4d6eb7763ef2065f44ece0653d829a1ba189f753562ab9ac261620

also fixes issue where the chat rooms do not load because of wrongly
passed parameters

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
2019-12-11 18:04:09 +05:30
rohitwaghchaure
234ab445a8
Merge pull request #8974 from rohitwaghchaure/fixed_css_for_dashboard_progress_bar
fix: padding for progress bar in dashboard
2019-12-11 12:24:32 +05:30
mergify[bot]
7509736c21
Merge pull request #9015 from zerodhatech/develop
fix(filters): set default id to empty string instead of 0
2019-12-11 06:35:04 +00:00
Suraj Shetty
9ce7f6c6ab fix: Typo 2019-12-11 11:32:01 +05:30
Suraj Shetty
a8b3a6b20b test: Add test to check if field is editable 2019-12-11 11:22:09 +05:30
Suraj Shetty
d6313057b3 fix: Check if the type of row data is tuple 2019-12-11 09:44:59 +05:30
Shridhar
b3b70f3b7f Bug fixed ID value should not be set to 0 by default 2019-12-11 09:21:17 +05:30
mergify[bot]
5613c78ebf
Merge pull request #9009 from frappe/perm-error
fix: permission error
2019-12-10 18:58:38 +00:00
mergify[bot]
315ea7a2a4
Merge pull request #9012 from Mangesh-Khairnar/fix-scheduler
fix(scheduler): import update site config
2019-12-10 13:07:09 +00:00
prssanna
1555ef360b fix: reopen all todos if close condition is not satisfed 2019-12-10 16:09:39 +05:30
Saqib
b0622255d4 revert: changes in currency formatting (#8996)
* fix: reverted currency formatting

* ux: added description for currency's number format
* It doesn't have any effect on how the currency is formatted.

* fix: revert json changes in currency master
2019-12-10 15:50:26 +05:30
Mangesh-Khairnar
a87ca0a6a9 fix(scheduler): import update site config 2019-12-10 15:19:46 +05:30
prssanna
aa8f0d5c41 fix: reopen todo only when assignment rule condition is satisfied 2019-12-10 14:39:15 +05:30
Shivam Mishra
37dba69db0
fix: permission error 2019-12-10 11:42:25 +05:30
Suraj Shetty
4f477cbc94 fix: Allow field of submitted doc to edit if field has allow_on_submit enabled 2019-12-10 10:55:36 +05:30