Commit graph

5214 commits

Author SHA1 Message Date
Ankush Menat
20c2ce8d29 fix: disable activity log global search
has millions of record that don't need to be searched
"globally"

[skip ci]
2023-08-09 15:18:50 +05:30
Ankush Menat
f6326b6145
fix: check before deleting prepared report (#21950) 2023-08-07 14:00:34 +05:30
Sagar Vora
b385fae2dc test: use unique IP to prevent future conflict with other tests 2023-08-07 13:49:52 +05:30
Sagar Vora
e877d926eb
test: set request_ip when testing reset_password (#21937)
* test: set `request_ip` when testing `reset_password`

* test: increase rate limit temporarily while testing `reset_password`
2023-08-07 11:37:23 +05:30
Raffael Meyer
4fae798ad1
fix: check file permission before zipping (#21934) 2023-08-06 17:21:22 +05:30
Sagar Vora
e588f2d70b
Merge pull request #21928 from resilient-tech/fix-rate-limiter 2023-08-05 17:38:08 +00:00
Sagar Vora
2b96324c31
fix: rate limit for all HTTP methods (#21929) 2023-08-05 22:32:55 +05:30
Sagar Vora
773cefea69 test: specify args or kwargs instead of frappe.form_dict 2023-08-05 14:14:03 +05:30
Ankush Menat
2ed85ca9f2 refactor: check license names before sending text
File might not exist.
2023-08-05 11:15:58 +05:30
Raffael Meyer
fa73d5ea03
perf(dx): let developers know that they need to enable index on links (#21745)
* perf: enable indexing for dashboard links

* style: format with black

* fix: nudge index, don't enable

Many edge cases which can't be checked on-the-fly. Best to just notify
developer that they should enable indexing.

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-08-03 11:39:59 +05:30
Suraj Shetty
672835d7a9 fix: Show "View File" in the sidebar of file doc 2023-08-02 10:20:25 +05:30
Suraj Shetty
a7be8ccff2 Merge remote-tracking branch 'upstream' into fix-image-compression 2023-08-02 10:13:52 +05:30
Suraj Shetty
5ebe28b454 feat: Add formatter for "File Size" 2023-08-02 10:13:27 +05:30
Corentin Flr
2c92043998
fix(doctype): Allow cached_property decorator in controllers (#21881) 2023-07-31 21:40:53 +05:30
David Arnold
fddd3b24f7
test: skip tests on RO app paths which require write access (#21878) 2023-07-31 12:46:23 +05:30
niraj gautam
d08ee0284d
fix: Delete module folder on Module Def deletion (#21857)
* fix: Delete module folder on Module Def deletion

* fix: Check if folder exists before removal

* fix: Make use of frappe function to delete folder

* fix: Indentation

* fix: Update linting
2023-07-31 11:39:04 +05:30
mergify[bot]
74899f510a
Merge pull request #21378 from dvdl16/feature/force-web-capture-setting
feat: setting for force web capture mode for camera uploads
2023-07-31 05:41:48 +00:00
Dirk van der Laarse
c66d744824 fix: field order and change label to title case 2023-07-30 15:36:55 +00:00
HarryPaulo
ec5f8fcfa1
fix: Parameter {function} get translated and format doesn't work (#21859) 2023-07-29 18:10:42 +05:30
Shariq Ansari
8a8716f21c chore: updated the welcome message 2023-07-28 20:16:29 +05:30
Shariq Ansari
90f6b44f48 fix: added welcome workspace if user has desk acces but does not have module access
basically if user doesn't have access to any public workspaces

also made welcome workspace hidden if he/she has even one workspace
2023-07-28 19:01:11 +05:30
Ankush Menat
e31038d7f9
feat(sec): log IP addresses of login/logout activities (#21844) 2023-07-28 13:59:52 +05:30
Ankush Menat
6e94cd2eb9
fix: Guess most likely exception source (#21827) 2023-07-27 17:30:04 +05:30
Ankush Menat
927cd647e4 chore: generate type annotations 2023-07-24 15:32:48 +05:30
Ankush Menat
0bc5d1dc3b feat(DX): type annotated python controllers 2023-07-24 15:32:46 +05:30
Ankush Menat
1bfe585b71
fix!: Drop unused link_doctype, link_name (#21788) 2023-07-24 14:22:07 +05:30
Sagar Vora
78ce5020f9 chore: use standard cron expression 2023-07-23 15:52:33 +05:30
Faris Ansari
ebacca3863
fix: better job naming for enqueue_doc (#21755)
DocType.method instead of frappe.utils.background_jobs.run_doc_method
2023-07-21 11:45:06 +05:30
Ankush Menat
e2bd9d5269 fix(rq_worker): show current job iff for same site 2023-07-20 14:05:24 +05:30
Ankush Menat
96e6291692
fix: don't allow setting 0 as max backups (#21747)
This causes new backups to get deleted immediately.

If you want only 0 backups, then don't take backups.
2023-07-20 13:52:54 +05:30
barredterra
c39473b9b0 fix: invalidate cache when language is updated 2023-07-18 13:02:08 +02:00
Sagar Vora
86f0c4e52c fix: store version for name 2023-07-17 16:13:44 +05:30
Sagar Vora
7d7c440a1b fix: compare with doc.amended_from while saving version for newly amended doc 2023-07-17 16:04:28 +05:30
Shariq Ansari
d423dedcd3
Merge pull request #21377 from shariquerik/move-form-builder-in-doctype-form 2023-07-16 14:38:08 +05:30
Shariq Ansari
b3333b803c fix: throw error and store save if validation fails 2023-07-16 13:24:24 +05:30
Ankush Menat
b919618032 perf: eliminate request for user permissions
This is ALWAYS required, then it can just be part of boot. Eliminates 1
unnecessary request.
2023-07-16 12:43:43 +05:30
Ankush Menat
b5409f6f07 chore: remove eslint-disable* 2023-07-14 15:41:20 +05:30
Ankush Menat
58cf770760 fix: All ESLint errors 2023-07-14 15:25:48 +05:30
Ankush Menat
adf30693a9 ci: update pyupgrade 2023-07-14 14:24:08 +05:30
Shariq Ansari
48c9099a0f fix: show fields table for fallback 2023-07-13 11:32:37 +05:30
Ankush Menat
04c1459631
fix: prevent importing core doctypes using data import tool (#21649)
[skip ci]
2023-07-12 12:07:33 +05:30
Ankush Menat
d731db352a
Merge pull request #21596 from Saboti215/patch-1
feat: Add ability to use HTML fields in grids
2023-07-11 15:32:08 +05:30
anandbaburajan
04f8d231a7 fix: dont stop next unattached file from being attached if file_url of first file is invalid 2023-07-11 12:37:29 +05:30
Tobias Schlößer
bcf837cbb5 feat: Add ability to use HTML fields in grids 2023-07-11 09:04:58 +02:00
anandbaburajan
638c9ea5b9 fix: dont stop next unattached file from being unattached 2023-07-11 12:30:07 +05:30
Shariq Ansari
727480480f fix: only show validation error if form is dirty 2023-07-10 19:10:29 +05:30
Shariq Ansari
cbe23facc2 fix: set page action & fetch on page refresh or reload_doc 2023-07-10 16:44:51 +05:30
Shariq Ansari
29555899a7 fix: fetch after save 2023-07-10 16:44:51 +05:30
Shariq Ansari
5db44e858b fix: validate before saving 2023-07-10 16:44:51 +05:30
Shariq Ansari
63fa87d2b4 fix: update fields before save
set default name to fields if not set
2023-07-10 16:44:51 +05:30