Akhil Narang
23bcb6733e
refactor(website_generator): update variable name to make more sense as per usage
...
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-11-23 16:06:07 +05:30
Akhil Narang
cc58fd20ca
refactor(oauth): simplify scopes check with the usage of all()
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-23 16:04:56 +05:30
Akhil Narang
f8c5a61bbd
refactor(report): simplify check further
...
NoneType will evaluate to False here so we don't need this complexity
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-11-23 15:54:13 +05:30
Akhil Narang
fbc88a4d24
refactor(treewide): code cleanup
...
Drop redundant bool conversion
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-23 13:57:51 +05:30
Ankush Menat
f526054ae2
refactor: Remove usage of utcnow ( #23369 )
2023-11-23 13:21:27 +05:30
Maharshi Patel
c2309969d5
fix: typo in strip folder name quotes ( #23368 )
...
fixed incorrect negative index.
2023-11-23 06:16:54 +00:00
Ankush Menat
21e8abf899
build: python 3.12 support ( #22706 )
...
* ci: use python 3.12
We'll use minimum versions on stable branch CI configs.
* build(deps): bump dependencies
- Some for v12 support
- some just for new stuff
2023-11-23 11:42:51 +05:30
Md Hussain Nagaria
6e3b1cc0ad
docs: add BWH link to resources ( #23365 )
2023-11-22 18:27:54 +05:30
mergify[bot]
9789864f2e
Merge pull request #23360 from akhilnarang/simplify-webform-link-title-check
...
refactor(web_form): cleanup code
2023-11-22 12:56:03 +00:00
Suraj Shetty
09ded1b671
Merge pull request #23362 from surajshetty3416/fix-email-formatting
2023-11-22 17:15:49 +05:30
Ankush Menat
31e3b3f981
fix: social key signup without signup conf ( #23359 )
2023-11-22 11:32:45 +00:00
Akhil Narang
3896750e2e
refactor(web_form): cleanup code
...
`frappe.get_meta()` gives us all the data we require
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-22 17:01:01 +05:30
Suraj Shetty
78c78ece34
fix: Show list similar to how it looks in text editor
2023-11-22 16:51:07 +05:30
Ankush Menat
1a3f39daa0
chore: readme logo on dark theme ( #23358 )
...
closes https://github.com/frappe/frappe/issues/23352
2023-11-22 16:20:20 +05:30
Indrajith.vs
a5b102dcd2
fix: button "Add Chart to Dashboard" visible before saving ( #23256 )
...
* fix: dashboard chart - add chart to dashboard btn fix
* style: format
[skip ci]
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-11-22 16:00:09 +05:30
Ankush Menat
e2a7e54af8
Merge pull request #23353 from frappe/mergify/bp/develop/pr-23335
...
fix: zeros converted to empty string in csv (backport #23335 )
2023-11-22 15:48:43 +05:30
Dany Robert
39bd7353d1
fix: zeros converted to empty string in csv
...
(cherry picked from commit fa4b816ea0431e38538e7095a9db4140926d7207)
2023-11-22 10:12:40 +00:00
Suraj Shetty
2b2a7d44f6
Merge pull request #23347 from surajshetty3416/fix-email-pulling
2023-11-22 13:57:37 +05:30
Suraj Shetty
250dbf6a1c
fix(email): Allow users to pull all (read & unread) emails during initial sync
2023-11-22 13:09:34 +05:30
Shariq Ansari
375ec5e470
Merge pull request #23342 from akhilnarang/webform-check-title-link-from-properties
2023-11-22 12:47:17 +05:30
Maharshi Patel
83f2227cdb
fix: review points when added more then once. ( #23239 )
...
* fix: review points when added more then once.
previously when user added review more then once it didn't work properly
because of apply_only_once check which is only meant for rule based points
changed that behaviour to only check when called from energy_point_rule by checking if doc.rule is set.
2023-11-22 12:31:35 +05:30
Akhil Narang
67b74cd4bb
fix(web_form): check properties for title field as well
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-22 11:54:36 +05:30
Ankush Menat
a4cbe36cbe
Merge pull request #23132 from frappe/jitter-scheduling
...
perf(Scheduling): add jitter to job scheduling
2023-11-22 10:59:38 +05:30
Ankush Menat
9738936f60
Merge pull request #23333 from maharshivpatel/fix-file-max-upload-size
...
fix: honour max file size in upload file
2023-11-22 10:56:42 +05:30
Ankush Menat
28d05c41c3
fix: correct max file size in boot
2023-11-22 10:55:52 +05:30
Ankush Menat
515c4410d5
Merge pull request #23337 from blaggacao/fix/naming-rule-polish-list-view
...
fix(naming_rule): polish list view
2023-11-22 10:47:26 +05:30
Ankush Menat
b43b8839c0
chore: remove dead link
2023-11-22 10:26:23 +05:30
David Arnold
f9141d04bf
fix(naming_rule): polish list view
2023-11-21 18:02:22 +01:00
Maharshi Patel
5af9b294f5
fix: honour max file size in upload file
...
In case path is /api/method/upload_file, we should honour the max file size
set in system settings and set request max_content_length to that value.
2023-11-21 16:36:57 +05:30
Ankush Menat
07d0b0aa95
Merge pull request #23317 from frappe/dependabot/github_actions/dessant/lock-threads-5
...
build(deps): bump dessant/lock-threads from 4 to 5
2023-11-21 15:47:56 +05:30
Ankush Menat
878314c0cb
Merge pull request #23322 from akhilnarang/communication-link-distinct-name
...
fix(event/sync_communication): add `distinct` while querying communication links
2023-11-21 15:45:17 +05:30
Maharshi Patel
b54b6867c4
fix: Font for arabic and not supported languages ( #23234 )
...
As we added Inter Variable Font in v15,
we noticed that the font is not supported for Arabic and other languages.
We added a fallback font for Arabic and other languages.
2023-11-21 14:34:12 +05:30
Akhil Narang
da1fb2ff4e
fix(event/sync_communication): add distinct while querying communication links
...
There's cases where these are duplicated
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-21 13:01:19 +05:30
18alantom
aeec01c7f9
perf(Scheduling): add jitter to job scheduling
...
Addresses #19007
2023-11-21 12:21:53 +05:30
Ankush Menat
cd189b3f7f
fix: remove link - modifying while iterating
2023-11-21 12:01:55 +05:30
TechnicalShree
90cf6bb829
feat: Enabling Redirection to a Custom URL on Notification Click ( #22956 )
...
* feat: notification custom routing
* Update frappe/public/js/frappe/ui/notifications/notifications.js
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
* code refactoring
* field name correction
* fix: json
* fix: auto generation
* lint fix
* fix: lint
---------
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-11-21 01:23:41 +05:30
dependabot[bot]
97ae9667d9
build(deps): bump dessant/lock-threads from 4 to 5
...
Bumps [dessant/lock-threads](https://github.com/dessant/lock-threads ) from 4 to 5.
- [Release notes](https://github.com/dessant/lock-threads/releases )
- [Changelog](https://github.com/dessant/lock-threads/blob/main/CHANGELOG.md )
- [Commits](https://github.com/dessant/lock-threads/compare/v4...v5 )
---
updated-dependencies:
- dependency-name: dessant/lock-threads
dependency-type: direct:production
update-type: version-update:semver-major
...
Signed-off-by: dependabot[bot] <support@github.com>
2023-11-20 18:57:30 +00:00
Shariq Ansari
be4e0bbc8a
Merge pull request #23207 from rtdany10/workflow-status
...
feat: workflow state wise status override
2023-11-20 21:06:59 +05:30
Ankush Menat
3cd06d7ebe
Merge pull request #23308 from ankush/addr_line
...
fix: increase length for address lines
2023-11-20 21:01:17 +05:30
Ankush Menat
c6371cbdd0
fix: increase length for address lines
...
140 char default limit is often not enough as demonstrated here https://github.com/frappe/frappe/issues/23259
2023-11-20 17:29:00 +05:30
Ankush Menat
49a0f75782
Merge pull request #23302 from cogk/fix-webform-get-cached-value
...
fix(WebForm): Replace `get_cached_value` with `get_value`
2023-11-20 16:45:43 +05:30
Corentin Flr
8b03a48f24
fix(WebForm): Replace get_cached_value with get_value
...
frappe.get_cached_value does not support filters
2023-11-20 12:13:55 +01:00
Shariq Ansari
978b9f4f30
chore: cleaner code
2023-11-20 15:38:25 +05:30
Ankush Menat
d715b0ad31
Merge pull request #22804 from akhilnarang/non-nullable-fields
...
feat: allow setting fields as not nullable
2023-11-20 12:46:02 +05:30
Akhil Narang
eb45da3913
feat: Allow usage of print() within safe_exec() ( #23084 )
...
* feat(safe_exec): allow usage of `print()`
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* refactor(system_console): update description to mention `print()` instead of `log()`
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* feat: unconditionally add debug logs to response if present
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* chore(safe_exec): add in a test for running `print()` within safe_exec
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* fix(safe_exec): ignore warning
RestrictedPython warns us if we call `print()` don't use their `printed` variable
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* feat: store debug logs from scheduled jobs
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
* fix: avoid ignoring warnings, disabled in prod anyway
* chore: remove unnecessary logging
This can be moved to level 2 when required
---------
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-11-20 12:45:41 +05:30
sibi kumar k
c3b0da60d1
feat: Add image view in Workspace shortcut block ( #23041 )
...
* Feat:Add image view in Workspace creation
* image view condition
2023-11-20 11:56:05 +05:30
Shariq Ansari
c0d47d8ddd
chore: linter fix
2023-11-20 11:46:09 +05:30
Shariq Ansari
9949bf47b7
chore: linter fix
2023-11-20 11:42:19 +05:30
mergify[bot]
a0502e8af1
Merge pull request #23291 from ruthra-kumar/dont_rename_link_fields_in_virtual_doctypes
...
fix: dont rename link fields of Virtual doctypes
2023-11-20 05:13:05 +00:00
Ankush Menat
17ff6998da
fix: ignore invalid token so auth hooks can apply
...
The error will still be raised some 2-3 lines of execution later
2023-11-20 10:16:29 +05:30