Commit graph

37654 commits

Author SHA1 Message Date
Nikhil Kothari
2767ea9d25
feat: more color options for form alerts (#16729)
* Added green and orange color options for message
2022-04-25 15:07:04 +05:30
Suraj Shetty
eb92acfbf3
Merge pull request #16718 from shariquerik/flaky-ui-test-3 2022-04-25 11:15:29 +05:30
Faris Ansari
5f68716303
Merge pull request #16730 from netchampfaris/client-insert
fix(client): better validation for child insert
2022-04-25 08:40:40 +05:30
Faris Ansari
95816f0340 fix: better validation for child insert 2022-04-24 10:38:58 +05:30
Sagar Vora
fa7ea4bce8
perf(BaseDocument): ~50% faster as_dict (#16549)
Co-authored-by: Pruthvi Patel <pruthvipatel145@gmail.com>
2022-04-23 09:01:20 +05:30
Shariq Ansari
042f98bcc5
fix: Workspace Miscellaneous fixes (#16578) 2022-04-22 18:00:44 +05:30
Shariq Ansari
d558f16e71 test: fixed flaky test for form, timeline_email 2022-04-22 17:43:20 +05:30
Shariq Ansari
ff6f4c93c3
Merge branch 'develop' into flaky-ui-test-3 2022-04-22 17:14:33 +05:30
Shariq Ansari
09a0077079 style: fixed indentation 2022-04-22 17:13:46 +05:30
Shariq Ansari
8c953b4f74 test: removing drag drop test(flaky) 2022-04-22 16:59:42 +05:30
Shariq Ansari
7f83178556 test: flaky markdown editor fix 2022-04-22 16:59:22 +05:30
Shariq Ansari
5c3b448c09 refactor: used list comprehension 2022-04-22 16:59:03 +05:30
Shariq Ansari
e1db9bf653
fix: Grid layout broken for some grids (#16702) 2022-04-22 15:37:00 +05:30
Ankush Menat
64b0da3620
Merge pull request #16711 from ChillarAnand/v3.11
chore: Bump wrapt to 1.14.0
2022-04-22 14:37:48 +05:30
Ankush Menat
a245cb51a2
feat: configurable auto email reports limit (#16684)
- The previous limit was 3 per user which is way too less, no known reason to
restrict this other than hogging of system with too many reports. Bumped
default limit to 20.
- site config is not easily discoverable or editable, added config in
  system settings.
- Moved auto email report background job form daily queue to `daily_long` queue. 

closes https://github.com/frappe/frappe/issues/16681 


<img width="1049" alt="Screenshot 2022-04-20 at 12 33 06 PM" src="https://user-images.githubusercontent.com/9079960/164170117-5612d9df-da91-441b-a4f6-acd89d30336e.png">


`no-docs` (error message is sufficient to explain to user what to do without referring docs)


ref: 

ISS-21-22-10245
ISS-21-22-07742
ISS-20-21-10850
ISS-20-21-10112

and many more times. This is such a stupid validation 🤦
2022-04-22 08:02:31 +00:00
gavin
2da85fa8da
Merge pull request #16698 from gavindsouza/traceback-with-context
feat: Traceback with context
2022-04-22 13:04:07 +05:30
chillaranand
7d9695a0d2 chore: Bump wrapt to 1.14.0 2022-04-22 11:10:54 +05:30
Ankush Menat
eb6ec33df2
Merge pull request #16704 from gavindsouza/safe_exec-updates
feat(safe_exec): Allow more APIs
2022-04-21 18:21:34 +05:30
Gavin D'souza
ab1f893e41 feat: Add get_mapped_doc in safe_exec under frappe 2022-04-21 16:52:06 +05:30
gavin
03d02ae11c
Merge branch 'develop' into safe_exec-updates 2022-04-21 16:11:54 +05:30
Gavin D'souza
b6683db57e refactor: frappe.rename_doc definition
Use explicit naming of args, kwargs and don't accept cmd and
ignore_permissions explicitly
2022-04-21 16:09:08 +05:30
KrutikaBhatt
e565deb88e
fix(UI): Duration Filter overlapping issue (#16599) 2022-04-21 16:00:56 +05:30
Gavin D'souza
9823e51512 feat(safe_exec): Allow new_doc, get_last_doc, rename_doc, delte_doc
* rename_doc points to the unwhitelisted method which supports
  ignore_permissions check
* Allowed other safe utils for better DX
2022-04-21 16:00:24 +05:30
Ankush Menat
dfef7192da
refactor: remove duplicate code from db.get_descendants (#16699) 2022-04-21 15:27:59 +05:30
Gavin D'souza
418dcdd2f4 fix!: Use event as a differentiator for frappe.utils.log 2022-04-21 13:33:40 +05:30
Gavin D'souza
c691537e61 chore: Add typing for ease of development 2022-04-21 13:32:13 +05:30
Gavin D'souza
5ecc9fe4ff refactor(log_error): de-clutter & log context with traceback 2022-04-21 13:27:01 +05:30
Gavin D'souza
4e533682ba feat: get_traceback with context 2022-04-21 13:26:12 +05:30
Suraj Shetty
c1e477ce5d
Merge pull request #16697 from surajshetty3416/fix-field-group
fix: Do not use `set_value` for default to avoid change event
2022-04-21 12:52:56 +05:30
Suraj Shetty
b5c3ff16ee fix: Do not use set_value for default to avoid change event 2022-04-21 12:43:46 +05:30
mergify[bot]
cc8d096bd1
Merge pull request #16582 from alyf-de/fix-open-count-no-data
fix: handle no data in set_open_count
2022-04-21 06:15:56 +00:00
Suraj Shetty
acbbeb1de5
Merge pull request #16693 from surajshetty3416/fix-rtl-table 2022-04-21 10:16:06 +05:30
Suraj Shetty
56bb11dc17 fix: Do not change direction of text if already in RTL mode 2022-04-21 08:49:48 +05:30
gavin
5e707d3527
Merge pull request #16689 from gavindsouza/bulk_insert-fix
fix(bulk_insert): Cast values as list before subscripting
2022-04-20 16:59:28 +05:30
Gavin D'souza
35c606707e fix(bulk_insert): Cast values as list before subscripting 2022-04-20 16:43:19 +05:30
Rushabh Mehta
78bddb4127
Merge pull request #16653 from rmehta/error-log-ref
feat(minor): Add document reference to Error Log and doc.log_error
2022-04-20 15:54:59 +05:30
Ankush Menat
296a6bd02f
test: show locals on test failure (#16687)
- Show locals always in CI
- Show locals locally when running in verbose mode
2022-04-20 15:37:54 +05:30
Rushabh Mehta
248c3555e3 fix(minor): add error_log for failed webhooks and web pages 2022-04-20 15:16:44 +05:30
Ankush Menat
dcee40046a
perf!: simpler frappe.get_system_setting (#16685)
Not sure why this needs to be "cached" in locals again when db object
already caches it in value_cache.
2022-04-20 15:16:04 +05:30
Faris Ansari
620a944104
Merge pull request #16622 from netchampfaris/less-flaky-date-test
test: less flaky date control test
2022-04-20 14:10:55 +05:30
Shariq Ansari
11360c5fd8
fix: Check mandatory_depends_on also while checking mandatory on save (#16515) 2022-04-20 13:02:42 +05:30
gavin
0a1b75c452
Merge pull request #16680 from gavindsouza/migrate-fix
fix: Check for required services running after frappe init
2022-04-20 12:05:59 +05:30
Gavin D'souza
91e0cac029 fix: Check for required services running after frappe init
Each site on a single app server can run on separate DBMS' on separate
servers. This site specific config resides in each site's
site_config.json file. Thereby, we need to load site's config before
checking for service's availability.
2022-04-20 11:25:38 +05:30
Pruthvi Patel
8b010e1732
refactor: make frappe.db.bulk_insert work as expected (#16527)
## Issue

`frappe.db.bulk_insert` is not working as expected:
 - It will not insert any row if there are less than 3 values
 - It will not add 1st row at all. e.g if I'm adding 5 values, it will only add 4.
 - It will add values one by one after 2 values, instead it should have inserted items (in db) in chunk of 10000 (as per the code written before).

## Changes Made
 - Solved above issues 
 - use better way to chunk list
 - Added Postgres support for bulk_insert API
 
And now `bulk_insert` will only do **1 db call for each 10000** values.

Note: For testing purpose I made `Test Bulk Insert` doctype and keep chunk size of 100.

## Before
![image](https://user-images.githubusercontent.com/43115036/161979365-c1100745-7602-47d2-a9b8-62d797d2039f.png)

## After
![image](https://user-images.githubusercontent.com/43115036/161978344-3c17d56b-2195-40f4-b00c-e9478d4083f1.png)

nodocs
2022-04-19 14:47:22 +00:00
gavin
d3e7090688
Merge pull request #16675 from gavindsouza/invalid-git-version
fix(version): Handle unable to read commit errors in version command
2022-04-19 20:07:41 +05:30
Gavin D'souza
aef0c0f66e fix: Handle unable to read commit errors 2022-04-19 19:21:25 +05:30
gavin
d1f8c87364
Merge pull request #16666 from phot0n/remove-tag-link-patch
chore: remove tag link patch
2022-04-19 18:52:56 +05:30
Ritwik Puri
586dd3ff02
Merge pull request #16612 from phot0n/customize-form-xss
feat(minor): add ignore_xss_filter to customize form field
2022-04-19 17:50:51 +05:30
Deepesh Garg
b59619f764
chore: Update creds to allow updates on protected branch (#16672) 2022-04-19 17:29:09 +05:30
Faris Ansari
fc4e2780bd chore: pretty logging for dialog command 2022-04-19 16:49:34 +05:30