Commit graph

46197 commits

Author SHA1 Message Date
Akhil Narang
280540a51f
Merge pull request #26081 from akhilnarang/enable-dynamic-filters-number-card
fix: allow setting dynamic filters for number cards even without developer mode
2024-04-22 11:33:31 +05:30
Akhil Narang
178dd89385
fix: allow setting dynamic filters for number cards even without developer mode
This fixes e4b3a3fa02

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-22 11:18:16 +05:30
Akhil Narang
ec5103fc45
Merge pull request #26078 from akhilnarang/enable-dynamic-filters-number-card
feat: enable dynamic filters for standard number cards
2024-04-22 11:07:14 +05:30
Akhil Narang
e4b3a3fa02
feat: enable dynamic filters for standard number cards
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-22 10:52:17 +05:30
Ankush Menat
d11f8e7bcb
fix: only notify for modified greater than DB (#26070) 2024-04-20 14:23:55 +00:00
Akhil Narang
37223b3744
Merge pull request #26054 from akhilnarang/fix-child-table-row-dependent-properties
fix(grid_row): check child table dependent properties whenever a row is selected
2024-04-20 15:20:38 +05:30
Alexandre Lumertz Damiani
01189631c2
fix: don't translate home and attachments folders (#24687)
* create default folders in English
* translate default folders in the UI

---------

Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com>
2024-04-20 10:42:58 +02:00
Safwan Samsudeen
8387b80fb1
fix: improve mobile spacing (#24388)
* improve mobile spacing
* use bootstrap's media queries

https://getbootstrap.com/docs/4.6/layout/overview/#responsive-breakpoints

---------

Co-authored-by: barredterra <14891507+barredterra@users.noreply.github.com>
2024-04-20 10:37:30 +02:00
Rutwik Hiwalkar
c5c7a0ecfe
refactor: move copy to clipboard btn to code.js (#26061)
- ref: https://github.com/frappe/frappe/pull/26049
2024-04-20 06:32:42 +00:00
Nihantra C. Patel
5d51320462
fix: dashboard link number color for timeless night (#26058) 2024-04-19 19:15:12 +05:30
Akhil Narang
3dc568eb15
fix(grid_row): check child table dependent properties whenever a row is selected
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-19 16:23:48 +05:30
Rutwik Hiwalkar
dad7acd87e
Merge pull request #26052 from rutwikhdev/add-light-copy-icon
chore: add light version for line-copy icon
2024-04-19 13:32:43 +05:30
Rutwik Hiwalkar
bb61f4e7d0 chore: add light version for line-copy icon 2024-04-19 13:12:05 +05:30
Rutwik Hiwalkar
8f6f8f5fe3
Merge pull request #26049 from rutwikhdev/feat-copy-to-clipboard
feat: add copy to clipboard on read only code fields
2024-04-19 11:58:05 +05:30
Rutwik Hiwalkar
8d48fbd625 feat: add copy to clipboard on read only code fields 2024-04-19 11:19:08 +05:30
Akhil Narang
5189fbb4b7
Merge pull request #26038 from akhilnarang/fix-reportview-export-all-disabled-count
fix(report_view): allow exporting all rows even if count is disabled
2024-04-18 16:20:29 +05:30
Akhil Narang
4549c69ce3
fix(report_view): allow exporting all rows even if count is disabled
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-04-18 16:05:39 +05:30
Ankush Menat
0f48cbbf99
Merge pull request #26037 from ankush/filter_select
fix: filter select perm in get_doctypes_with_read
2024-04-18 16:00:02 +05:30
Ankush Menat
3f707f1ae1 test: add test for custom docperm behaviour 2024-04-18 15:44:04 +05:30
Ankush Menat
229fc715c9 ci: ruff only fix imports 2024-04-18 15:34:48 +05:30
Ankush Menat
a1bb734079 fix: filter select perm in get_doctypes_with_read
closes https://github.com/frappe/frappe/issues/26015

Extracted from https://github.com/frappe/frappe/pull/26018
2024-04-18 15:15:47 +05:30
Ankush Menat
c2ea8b895b
fix: html template example in notification.js (#26005)
Closing </li> tag was missing in the example html shown on the page.
2024-04-18 14:26:06 +05:30
Ankush Menat
4faac128bf
Merge pull request #26028 from ankush/ensure_stderr
fix: register faulthandler on true stderr only
2024-04-18 14:13:48 +05:30
Ankush Menat
4c85c2038b fix: response logging
if response is 4xx then `Response` object itself is getting logged,
which is stupid. This is because of `res and res.text` and res is falsy
if response is not "OK".
2024-04-18 14:00:37 +05:30
Ankush Menat
3c2bf77c81
fix: Avoid permission check on unsaved doc (#26027)
Use case:
- User has "if owner" perm
- Doc isn't created
- We skip doc perm check because doc doesn't exist
- We check if user has write perm to doctype, which isn't available
  because it's only "if owner"

Fix: We can avoid perm check entirely here, files are only re-attached
if doc saves successfully which implies that reference doc was indeed
saved after perm check.
2024-04-18 13:47:39 +05:30
Ankush Menat
a49189ad6e fix: register faulthandler on true stderr only
https://github.com/frappe/frappe/issues/25613
2024-04-18 13:38:12 +05:30
Ankush Menat
1dcfadf5ca
test: fix cypress tests (#26012)
* ci: less retries for cypress

waste of cpu cycles and time, produces misleading output

* test: fix workspace tests

* chore: drop flaky af tests

* fix: Avoid sending `"undefined"` as docname
2024-04-17 15:26:18 +00:00
Ankush Menat
be0e9350a0
build: bump datatable (#26011)
Fixes filtering https://github.com/frappe/datatable/pull/198
2024-04-17 20:18:58 +05:30
Ankush Menat
cab3b963cd
fix: strip redirect URIs for trailing whitespaces (#26006) 2024-04-17 13:10:39 +00:00
Oguz Bilgic
186150628c
Fix html template example in notification.js
Closing </li> tag was missing in the example html shown on the page.
2024-04-17 20:52:24 +08:00
Ankush Menat
e020862b34
Revert "fix: paragraph spacing in quill" (#25998) 2024-04-17 09:10:21 +00:00
Ankush Menat
bc26ab67dc
fix: runtime error during pot build (#25991) 2024-04-17 14:26:31 +05:30
Ankush Menat
4ce3c8582a
Revert "chore: add v15 to POT file mix" (#25990)
* Revert "chore: add v15 to POT file mix (#25983)"

This reverts commit c94de176c9.

* Update generate-pot-file.yml
2024-04-17 08:39:21 +00:00
Ankush Menat
e1bb9b225e
ci: dont auto apply fixes (#25985)
I've personally encountered ~5 instances of bad auto fixes, let
developers apply the fixes.
2024-04-17 12:54:21 +05:30
Ankush Menat
c94de176c9
chore: add v15 to POT file mix (#25983) 2024-04-17 07:04:02 +00:00
Shariq Ansari
cdbe711527
Merge pull request #25627 from barredterra/list-padding
fix: list row padding
2024-04-17 11:04:19 +05:30
Ankush Menat
723e557da7
build: bump gunicorn (#25980)
https://github.com/benoitc/gunicorn/releases/tag/22.0.0
2024-04-17 10:44:53 +05:30
barredterra
75f588d386 Merge remote-tracking branch 'upstream/develop' into list-padding 2024-04-16 19:49:54 +02:00
barredterra
eb4d0b234a feat: extend the checkbox's clickable area 2024-04-16 19:47:18 +02:00
Akhil Narang
06c8965b86
Merge pull request #25972 from barredterra/bump-deps
chore: update dependencies
2024-04-16 21:35:40 +05:30
barredterra
708e10552c chore: bump sql_metadata to 2.11.0 2024-04-16 17:11:03 +02:00
barredterra
733a7fe6f8 chore: bump sqlparse to v0.5.0 2024-04-16 16:56:54 +02:00
barredterra
53bd1a85d1 chore: bump pydantic to v2.7.0 2024-04-16 16:53:41 +02:00
Corentin Flr
f46c4813ca
fix(ControlLink)!: Fix link selection in tables on iOS (#25472)
* fix(ControlLink)!: Fix link selection in tables on iOS

* test: use correct selector

* test: change selector

---------

Co-authored-by: mergify[bot] <37929162+mergify[bot]@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-04-16 13:36:59 +05:30
Ankush Menat
fd02b912de
fix: title width for form (#25958) 2024-04-16 07:18:02 +00:00
Rutwik Hiwalkar
7b39a9bbd3
feat: add vim and emacs mode for ace-editor (#25936) 2024-04-16 11:35:58 +05:30
avc
9feef371ff
fix: let's color tag in form view (#25949)
* fix: let's color tag in form

* fix: linters
2024-04-15 18:46:24 +05:30
Akhil Narang
26c71bc1be
Merge pull request #25941 from esafwan/list-checkbox-fix
fix: make checkbox clickable in image view of doctype lists
2024-04-15 18:10:44 +05:30
avc
55b1e4a167
fix: filter button translation (#25944) 2024-04-15 17:45:02 +05:30
David Arnold
a99c4ff2b0
fix: don't sanitize defaults and options (#25939) 2024-04-15 17:39:48 +05:30