vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 4
26682 commits 1 branch 0 tags 587 MiB
Commit graph

26682 commits

This branch
This branch
All branches
Author SHA1 Message Date
Suraj Shetty
2bf77cd82a
style: Fix sider 2020-07-22 10:32:12 +05:30
Suraj Shetty
06788762d6 fix(website): Properly load colocated javascript and style 2020-07-22 10:09:58 +05:30
Suraj Shetty
547bd77c20
fix: Do not check all attachments on adding new (#10926) 2020-07-21 18:46:51 +05:30
Suraj Shetty
48b835c1dc
fix: Text editor content style in email and website (#11003) 2020-07-21 18:26:42 +05:30
Prssanna Desai
33be0b023f
Merge pull request #11055 from prssanna/dashboard-fixes 2020-07-21 17:22:24 +05:30
prssanna
e3ce17a0c9 fix: check if dynamic filters exists 2020-07-21 17:16:19 +05:30
Chinmay Pai
02fa765dcc
Merge pull request #11041 from abhishekbalam/prevent_autoreply_inital_sync 2020-07-21 16:58:54 +05:30
Prssanna Desai
502f0ebad5
Merge pull request #11052 from marination/dashboard-chart-fixes 2020-07-21 16:53:45 +05:30
prssanna
6e9fe40b0e style: fix formatting 2020-07-21 16:41:01 +05:30
prssanna
c709ebc9f1 fix: set report name as mandatory 2020-07-21 16:39:58 +05:30
prssanna
660d27389c fix: get_all_filters for number cards 2020-07-21 16:39:26 +05:30
marination
e3e94a5430 fix: Rename pending 'is_custom' usage to 'use_report_chart' 2020-07-21 16:22:19 +05:30
Suraj Shetty
146762767d
refactor: Rename is_custom to use_report_chart (#11051) 
* refactor: Rename is_custom to use_report_chart

* fix: Patch to move is_custom data to use_report_chart

* fix: Import rename_field

* fix: Rename is_custom in depends_on

* fix: Reload doc before renaming field
 2020-07-21 15:49:44 +05:30
Abhishek Balam
2083224609
fix: add a confirmation dialog on enabling auto reply 
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
 2020-07-21 12:37:33 +05:30
mergify[bot]
3769a8bbe9
Merge pull request #11048 from scmmishra/feat-compress-css 
build: compress build from theme generator
 2020-07-20 17:21:53 +00:00
Shivam Mishra
a3cc30437f feat: compress build from theme generator 2020-07-20 21:03:38 +05:30
mergify[bot]
0319dca6e4
Merge pull request #11014 from prssanna/read-only-share-perm 
fix: Add share perm in set_read_only
 2020-07-20 14:31:59 +00:00
Prssanna Desai
fc3816d2de
fix: update all required perms form doc perms 
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
 2020-07-20 19:42:21 +05:30
mergify[bot]
e82dfabc1e
Merge pull request #11036 from Thunderbottom/email-encoding-fix 
fix: email encoding issue inside email queue
 2020-07-20 05:03:06 +00:00
mergify[bot]
e71ba3a68a
Merge pull request #10973 from deepeshgarg007/datetime_label 
fix: Datetime field description
 2020-07-20 04:38:31 +00:00
mergify[bot]
ddb50c55a0
Merge pull request #10995 from prssanna/dashboard-refresh-all 
feat(Dashboard): option to refresh all charts and cards
 2020-07-20 04:04:36 +00:00
Abhishek Balam
0eae7dc1d8
fix(Controls): 'Yes/No' instead of '1/0' in Filter Descriptions for 'Check' values (#11040) 
* fix: show 'Yes/No' instead of '1/0' in Filter Descriptions for 'Check' fieldtype

* fix: spacing

* fix: add gettext and cleanup
 2020-07-20 03:02:05 +00:00
mergify[bot]
b78d80f4d4
Merge pull request #10998 from scmmishra/fix-report-allow-save 
fix: set form perm only for standard reports
 2020-07-19 14:47:01 +00:00
mergify[bot]
805a1c1c51
Merge pull request #11030 from deepeshgarg007/check_tab 
fix: Make checkboxes navigatable via tab key
 2020-07-19 13:20:53 +00:00
Suraj Shetty
3787c4eb28 refactor: Remove un-wanted code 2020-07-19 18:18:29 +05:30
Suraj Shetty
4d25520a62
Merge branch 'develop' into check_tab 2020-07-19 16:57:37 +05:30
prssanna
a4239c4f1f fix: don't set header if empty 2020-07-18 19:40:10 +05:30
Chinmay D. Pai
42591f2828
chore: replace rfc-compatible newline with \n 
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
 2020-07-18 19:08:29 +05:30
Chinmay D. Pai
8a6cb7db3d
chore: replace rfc-compatible newlines with \n 
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
 2020-07-18 18:52:55 +05:30
Deepesh Garg
b32238a295 fix: CSS for mozila browser 2020-07-18 18:40:36 +05:30
Chinmay D. Pai
c45864eac0
fix: specify SMTPUTF8 policy everywhere 
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
 2020-07-18 18:27:44 +05:30
Prssanna Desai
f0ec2e0773
Merge pull request #11044 from prssanna/number-card-json-fix 2020-07-18 17:10:08 +05:30
prssanna
6f83cece05 fix: remove allow_worflow from number_card.json 2020-07-18 17:09:23 +05:30
prssanna
742d79cd5f style: fix indent 2020-07-18 14:16:32 +05:30
prssanna
cac8a8c4a0 fix: set policy to SMTPUTF8 2020-07-18 14:16:16 +05:30
mergify[bot]
27db6b9a23
Merge pull request #11022 from prssanna/number-card-types 
feat: Custom and Report type Number Card
 2020-07-17 14:17:54 +00:00
Chinmay D. Pai
3678435d4a
fix: remove redundant condition for field sanitization 
Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
 2020-07-17 18:38:57 +05:30
prssanna
6bc31f1d6a style: formatting fixes 2020-07-17 18:37:30 +05:30
Chinmay D. Pai
39ec64f1e3
fix: add default email policy to mail body 
the default policy encodes special characters correctly, and is not set
by _default_ unless python3.8 is used. so we'll explicitly define the
policy to be used for the email body

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
 2020-07-17 18:36:53 +05:30
prssanna
b32a47ec58 refactor: set get_number method in settings 2020-07-17 18:29:29 +05:30
prssanna
3551fecd74 fix: update description of method field 2020-07-17 18:13:18 +05:30
prssanna
c4a8852a68 fix: handle result of custom cards 2020-07-17 18:12:44 +05:30
Chinmay D. Pai
ff39b6ae5f
fix: email encoding issue inside email queue 
email addresses get formatted incorrectly inside the email queue,
causing emails to be sent with encoded-words addresses instead of
proper, human readable email addresses. this particularly happens when
the address has special and accented characters. an example of
encoded-words address looks like:

=?utf-8?q?=C3=A1dministr=C3=A1tor?= <admin@example.com>

instead of something like:

ádministrátor <admin@example.com>

another issue that causes this is validations that strip html tags from
field when ignore_xss_filter is not set in a docfield. setting
ignore_xss_filter for the email field inside email queue fixes
this issue.

Signed-off-by: Chinmay D. Pai <chinmaydpai@gmail.com>
 2020-07-17 16:24:31 +05:30
prssanna
8c93d91c5a fix: better variable name 2020-07-17 15:27:07 +05:30
prssanna
e52341f3d6 fix: toggle card button if report has data 2020-07-17 15:19:13 +05:30
Aditya Hase
e3c707c2cf
Merge pull request #11035 from adityahase/samesite-lax 
fix: Use SameSite=Lax instead of SameSite=Strict
 2020-07-17 13:48:44 +05:30
Deepesh Garg
53312282e2 fix: Update CSS 2020-07-17 13:29:54 +05:30
Deepesh Garg
1cdd8c5b92 fix: Update CSS 2020-07-17 13:15:27 +05:30
Aditya Hase
654950fef3
fix: Use SameSite=Lax instead of SameSite=Strict 
Reference: https://web.dev/samesite-cookies-explained/

Scenario:
A user is logged in on a frappe instance. (with, say, sid=abcd)

In an OAuth like flow, a third party site, say, GitHub redirects the user to the frappe instance.

Now because SameSite=Strict is set, the browser can't send the cookies it has (sid=abcd) to the frappe server.

Once the frappe server receives this request without cookies, It assumes that this is an unauthenticated user, and sets cookies in response as sid=Guest.
Reference: f3e14b4ac7/frappe/sessions.py (L178)

Once the browser receives these values in response (sid=Guest) it overwrites the existing cookie values(sid=abcd) and sets sid=Guest,

This effectively causes the user session to be terminated.
 2020-07-17 13:14:44 +05:30
sahil28297
f3e14b4ac7
Merge pull request #11032 from Thunderbottom/rm-example-email-notify 
fix: remove example users email ids from notifications
 2020-07-17 12:36:02 +05:30