phot0n
613d8472b4
test: skip badly written test temporarily
2022-08-17 16:39:42 +05:30
Ankush Menat
1c9ea57279
fix: dont use sendmail with now=True
2022-08-17 16:39:42 +05:30
Ankush Menat
3e2d2a703a
test: Use FrappeTestCase everywhere
2022-08-17 16:39:42 +05:30
Ankush Menat
b7a7f97a7a
refactor: convert get email count query to ORM
...
- also fix capitalization of column names on postgres
2022-08-16 10:53:28 +05:30
P-Godfroid
62420f78ae
fix: update append_to misleading message in email account ( #17718 )
...
* chore: remove append_to field from email domain doctype
* minor: add incoming and outgoing server fields to list view
Co-authored-by: Ritwik Puri <ritwikpuri5678@gmail.com>
2022-08-10 21:50:00 +05:30
phot0n
dc6be2de48
refactor: add handle_error decorator and cleanup server validations
2022-08-09 15:46:15 +05:30
phot0n
037746cddc
feat(minor): fetch attachment_limit from get_max_file_size api
2022-08-09 14:49:18 +05:30
phot0n
f6c8c927d8
feat(minor): add connection link to email accounts in email domain
2022-08-09 14:49:00 +05:30
phot0n
dfbe25e1a2
refactor(minor): move out email domain validations to different methods
...
* used Timed mixins for incoming server validation to emulate things as close to email account
2022-08-09 13:35:02 +05:30
phot0n
ff0899e458
fix: consistent fieldnames and keep port alongside server field
2022-08-09 13:35:02 +05:30
phot0n
515fafd9a5
chore: add headline for letting users know about how email domain sets attributes
2022-08-09 13:34:59 +05:30
phot0n
0614c4098c
chore: remove example email id field from email domain
2022-08-09 13:34:48 +05:30
phot0n
d5aa898151
chore: remove unnecessary autoname controller hook
2022-08-09 13:34:33 +05:30
phot0n
9fee012389
chore: remove unnecessary refresh event from email domain
2022-08-09 13:34:31 +05:30
phot0n
b31b99aaca
fix(ux): email domain doctype
2022-08-09 13:34:11 +05:30
Ankush Menat
40f27f908a
style: format JS files with prettier
2022-08-04 14:51:01 +05:30
Gavin D'souza
85e3ee9403
chore: Minified DocType JSON notation from old verbose notation
2022-08-03 12:22:03 +05:30
P-Godfroid
2d1fe02dba
fix: Append to condition misleading message ( #17696 )
...
* Update Append to doctype description
Hello,
To append email to a doctype to enable automatic creation, there are two required fields listed

However, there is a third one required which is lacking in the above description (as seen below), because the email settings of the document must be enabled.

I propose to simply modify the sentence to the following :
Append as communication against this DocType (must have fields ("Status", "Subject") and "Sender" defined in the related doctype Email Settings).
To avoid any problem, in the code, it becomes the following :
Append as communication against this DocType (must have fields (\"Status\", \"Subject\") and \"Sender\" defined in the related doctype Email Settings).
The same must be applied in email_domain.json and in lots of csv in translations of course.
Pierre
* Update email_domain.json
* Updated sentence email account
* Updated sentence of email domain
* More brackets
* More brackets
* Typo
* Update email_account.json
* No dot
2022-08-02 15:20:19 +05:30
phot0n
16f9a2e811
fix: clear password when saving account with Oauth
2022-07-30 00:03:02 +05:30
Gavin D'souza
1ccdad811a
Merge branch 'develop' of github.com:frappe/frappe into mariadb-client-refactor
2022-07-19 16:23:24 +05:30
Ankush Menat
066d5a4245
Merge pull request #17528 from phot0n/mis-fixes-goauth
...
fix: misc fixes (google oauth)
2022-07-19 15:55:24 +05:30
Sagar Vora
4b0a9da400
refactor: rename hold_queue to suspend_email_queue
2022-07-18 22:32:12 +05:30
Sagar Vora
9a7f92ca1d
fix!: allow system managers to toggle email queue
2022-07-18 16:53:49 +00:00
phot0n
1fd47f1c10
chore: remove unused no_remaining field from email account doctype
2022-07-18 10:53:27 +05:30
phot0n
f679dc3fdd
fix(security): restrict the god google callback
...
the common google callback can be used to trigger any method in the whole codebase
restrict it by only allowing domain specific callback method and raise
an error if the domain is not found
2022-07-17 21:37:21 +05:30
phot0n
8edae2ce09
fix: encrypt access_token when setting in db after refreshing access_token
2022-07-17 21:35:06 +05:30
phot0n
7d5262f5e0
chore: translate authorization message and add nosemgrep
2022-07-13 12:50:04 +05:30
phot0n
9090b0fe3a
chore: remove unnecessary failure_query_param for email oauth
2022-07-13 12:41:32 +05:30
phot0n
01a1860491
fix(ux): better ux for successful oauthorization
2022-07-13 12:05:46 +05:30
phot0n
d1a199258d
fix: pull from accounts for oauth whose refresh_token is not null
...
* chore: rename Oauth to OAuth
2022-07-13 12:05:46 +05:30
phot0n
81bb9c411a
chore: fix sider
2022-07-13 12:05:46 +05:30
phot0n
a50568596a
minor: fetch attachment size from get_max_file_size api
2022-07-13 12:05:46 +05:30
phot0n
5ea642ef7f
fix(ux): update form header upon successful authorization
...
* minor: simplified validations for email account
2022-07-13 12:05:46 +05:30
phot0n
a826f4cc53
fix(ux): consistent field names for ssl and server
...
* keep server and port together
2022-07-13 12:05:46 +05:30
phot0n
2b7bd4eef0
minor(ux): select field for alternating between basic and oauth authentication
2022-07-13 12:05:46 +05:30
phot0n
2907571098
minor: encrypt email oauth refresh and access token
2022-07-13 12:05:46 +05:30
phot0n
5bf26819a8
fix: better/reduced exception handling for email oauth
...
Since the places where connection methods are called already
have a lot of exception handling, we can just raise and let them
handle all the probable cases.
2022-07-13 12:05:46 +05:30
phot0n
8b38fcb438
chore: move getting site address to GoogleOAuth
2022-07-13 12:05:46 +05:30
phot0n
431afaeee4
fix: remove commit
...
* chore: raise not implemented error for services other than gmail
* chore: use fstring for _auth_string property
2022-07-13 12:05:46 +05:30
phot0n
84ad7b74b9
fix: don't show authorize api access button if the form is unsaved
2022-07-13 12:05:46 +05:30
phot0n
484758d6e0
chore: remove additional/unnecessary set_value calls
2022-07-13 12:05:46 +05:30
phot0n
6d3dfca214
fix: consider oauth usage as well for asking/updating user email password
2022-07-13 12:05:46 +05:30
phot0n
5521abd40c
fix: use safe decode for uid
2022-07-13 12:05:46 +05:30
phot0n
4d5dec4048
fix: open authorization url on the current browsing context
2022-07-13 12:05:46 +05:30
phot0n
834410a2a5
fix: dont update modified timestamp on generating and refreshing tokens
2022-07-13 12:05:46 +05:30
phot0n
ab9a577474
minor: better oauth flow
2022-07-13 12:05:46 +05:30
phot0n
221423c718
chore: added docstrings
2022-07-13 12:05:46 +05:30
phot0n
e58afca3f6
minor: simplify authorize_google_access
2022-07-13 12:05:46 +05:30
phot0n
ed0a255353
minor: fetch oauth fields from site config
2022-07-13 12:05:46 +05:30
phot0n
de6f1326f7
minor: move oauth access functions from email_account
2022-07-13 12:05:46 +05:30