Sagar Vora
c82b6e758e
Merge pull request #17681 from resilient-tech/fix-child-perm
...
refactor: improved child table permission check
2022-08-09 10:15:36 +00:00
Sagar Vora
7a19d65ea4
chore: improve docstring
2022-08-09 12:14:26 +05:30
vishdha
9a50c30586
fix: add_user_permission with applicale_for arg set not updating in user permission
2022-08-05 00:27:38 +02:00
Sagar Vora
53118367b2
fix: use warn util
2022-08-02 19:08:02 +05:30
Sagar Vora
56717602b4
fix: reverse logic for failing permission check
2022-08-02 04:09:01 +05:30
Sagar Vora
61ec026712
refactor: improve frappe.only_for
2022-08-01 22:10:25 +00:00
Sagar Vora
d6aa17cc14
chore: add deprecation warning everywhere verbose is used
2022-07-31 00:24:21 +05:30
Sagar Vora
2b873b34dd
refactor: remove verbose parameter; add user parameter to Meta.get_permlevel_access
2022-07-30 23:52:20 +05:30
Sagar Vora
a63363d433
refactor: has_child_table_permission => has_child_permission
2022-07-30 21:56:35 +05:30
Sagar Vora
7183efa60d
fix: assume parentfield to be set and valid
2022-07-30 21:07:02 +05:30
Sagar Vora
4c4d9ac60e
fix: check permlevel only if > 0
2022-07-30 20:49:25 +05:30
Sagar Vora
30175f426e
fix: dont init child doc
2022-07-30 20:02:32 +05:30
Sagar Vora
35671295ee
fix: handle permlevel
2022-07-30 19:51:28 +05:30
Sagar Vora
05c1cb30c6
fix: get correct doc when checking child table permission
2022-07-30 18:59:51 +05:30
Ankush Menat
b5128a35fd
refactor: simplify fetching of readable records ( #17417 )
...
- remove encoding, use cstr directly
- remove falsy values by default None, empty string.
2022-07-07 14:40:59 +05:30
Ankush Menat
9a5d11234c
fix: validate scheduler, hook method names ( #17400 )
...
* chore: warn about missing scheduler / doc events
* fix: pass list instead of filter
filter can only be iterated upon once
* refactor: many typehints in __init__.py
2022-07-04 19:29:16 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features ( #17367 )
...
refactor: clean up code to py39+ supported syntax
- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes
Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
Gavin D'souza
084a1e6c31
refactor: get_permissions
...
* Show page even if dangling Custom DocPerm records encountered
* Add typing hints
* Cleanup APIs
2022-06-27 15:18:06 +05:30
Suraj Shetty
c0c5b2ebdd
style: format all python files using black ( #16453 )
...
Co-authored-by: Frappe Bot <developers@frappe.io>
2022-04-12 10:59:25 +05:30
Shariq Ansari
d97c7e7caf
fix: resolved conflicts in permissions.py
2022-03-21 18:05:01 +05:30
Shariq Ansari
10fbb4330a
fix: setting permissions to any role of some doctypes is not working
...
(cherry picked from commit 6612232babd61852e90ccfc2ca836397d80506cf)
# Conflicts:
# frappe/permissions.py
2022-03-21 05:50:56 +00:00
barredterra
dac9349aef
refactor: use is bool instead of == bool
2022-01-17 15:40:33 +01:00
barredterra
b1383df15a
refactor: use is None instead of == None
2022-01-17 10:37:51 +01:00
Ahmad
bc675bab4a
fix: Convert user to lower case before equating
...
Co-authored-by: Sagar Vora <sagar@resilient.tech>
2021-12-13 15:54:14 +05:30
ahmadpak
22b89f2152
fix: method-get_doc_permissions
2021-12-13 15:53:44 +05:30
Suraj Shetty
4e6ea8fdbd
fix: Docstring of has_permission & made error title translatable
...
- doctype -> DocType
- fixed other typo
2021-10-28 15:25:45 +05:30
Suraj Shetty
bf34de1d04
fix: Assume that child doc will have parent references
2021-10-28 15:06:38 +05:30
Suraj Shetty
7670c0430a
fix: Simplify code and fix typo
2021-10-28 14:49:52 +05:30
Suraj Shetty
cb76118268
refactor: Check parent validity using parent meta
2021-10-28 13:41:12 +05:30
Suraj Shetty
9ce52fcd18
fix: Properly pass kwargs to has_permission of parent
2021-10-28 11:17:10 +05:30
Suraj Shetty
b68d6fe879
fix: typo
2021-10-27 13:57:44 +05:30
Suraj Shetty
9189c62437
fix: Pass parent_doctype while checking permission for child_table in db_query
2021-10-27 13:52:34 +05:30
Suraj Shetty
64822df6ff
Merge branch 'develop' into fix-has-permission-for-child-doc
2021-10-27 13:07:44 +05:30
Suraj Shetty
0f98b4d174
fix: Make parent_doctype mandatory while accessing child doctype
2021-10-27 12:59:42 +05:30
Suraj Shetty
494cc83bde
fix: Return parent doc object for further permission check
2021-10-26 14:30:13 +05:30
mergify[bot]
8cbbda7ab7
Merge pull request #14441 from Aradhya-Tripathi/query-conversion
...
refactor: replacing raw SQL queries with frappe ORM
2021-10-22 09:00:42 +00:00
Gavin D'souza
cb66e6508d
refactor(minor): Use pluck & better var naming
2021-10-22 14:17:52 +05:30
Suraj Shetty
cdde111021
fix: Re-arrange code
...
Return true if user is Admin before checking child table condition
2021-10-21 13:00:52 +05:30
Suraj Shetty
2a2421888f
fix: Check parent permission while doing has_permission for child
...
- Since, permissions for child table is based on parent doctype
2021-10-21 12:21:51 +05:30
Sagar Vora
5c86dc80c7
fix: if_owner constraint being applied wrongly ( #14471 )
...
* fix: `if_owner` constraint being applied wrongly
* test: check if owner on `frappe.get_list`
Co-authored-by: Pruthvi Patel <pruthvipatel145@gmail.com>
2021-10-19 15:03:17 +05:30
Aradhya-Tripathi
e01d97b8df
refactor: replacing queries with frappe ORM
2021-10-14 01:16:46 +05:30
Aradhya-Tripathi
a621c4178c
fix: fixing erroneous query conversions
2021-10-13 14:28:13 +05:30
Aradhya-Tripathi
7315076038
refactor: converted queries
2021-10-13 14:06:34 +05:30
Gavin D'souza
3446026555
chore: Update header: license.txt => LICENSE
...
The license.txt file has been replaced with LICENSE for quite a while
now. INAL but it didn't seem accurate to say "hey, checkout license.txt
although there's no such file". Apart from this, there were
inconsistencies in the headers altogether...this change brings
consistency.
2021-09-03 12:02:59 +05:30
Sagar Vora
e48d979c2b
fix: improved execution logic for has_permission hook
2021-08-05 11:52:31 +05:30
Gavin D'souza
01d275f667
style: Format code for better readability
...
* Remove trailing whitespaces
* Format code to fit module conventions
* Add appropriate new lines between imports, classes, fn defs, etc
* Added comments, docstrings & module headers
2021-07-28 18:55:27 +05:30
Aradhya-Tripathi
84ff1d0af9
style: removed frappe.db.sql comments
2021-07-28 13:48:01 +05:30
Aradhya-Tripathi
538ef2168b
fix: removed wrong queries
2021-07-24 22:58:12 +05:30
Aradhya-Tripathi
1204ae8ce4
fix: fixed spacing and ui tests
2021-07-23 10:45:54 +05:30
Aradhya-Tripathi
eb7e95ae26
refactor: using frappe orm
2021-07-21 19:19:06 +05:30
