Commit graph

46583 commits

Author SHA1 Message Date
barredterra
30756e27d4 fix: shorten_number
Before, `shorten_number(1234.5678, "Germany", 5)` wrongly returned `"1 K"`. Now it correctly returns `"1235"`, which is less than five digits.
2024-06-13 18:58:14 +02:00
Ankush Menat
c146ea24b6
Merge pull request #26710 from marination/block-rename-lang
fix: Avoid renaming language or changing title manually
2024-06-11 15:40:41 +05:30
Ankush Menat
a65c6215e9
fix: Email tracking without "use_ssl" (#26718)
Everyone uses TLS these days, idk why this config exists.

closes https://github.com/frappe/frappe/issues/26717
2024-06-10 08:40:43 +00:00
Rutwik Hiwalkar
cfcc508f8b
fix: Append symbol on number card (#26731)
- broken by this change 7695a0d2ec
2024-06-10 12:54:40 +05:30
Akhil Narang
3ee348acdd
Merge pull request #26688 from akhilnarang/fix-package-release-path
fix(package_release): set path to tarball
2024-06-07 12:26:34 +05:30
marination
f58b28865e fix: Avoid renaming language or changing title manually 2024-06-06 18:27:52 +02:00
Ankush Menat
04642edd63
fix: Move Monitor dump to after_response (#26703)
It needs access to response to capture status code and size etc
2024-06-06 14:38:22 +00:00
Corentin Flr
48e59248e6
chore: Reword "Recursive Fetch From" message (#26706) 2024-06-06 14:35:35 +00:00
David Arnold
a2bff44414
fix(UX): Show reference name in error log list view #26687 2024-06-06 16:19:36 +05:30
Ankush Menat
820a6edae8
fix: Skip virtual fields in all select queries (#26700) 2024-06-06 09:43:36 +00:00
Ankush Menat
ab37665f5b
fix: recursive fetch from causes infinite loop (#26695) 2024-06-06 07:02:00 +00:00
Ankush Menat
63a13d0aff
fix: Skip letter heads if no permission (#26689) 2024-06-05 15:56:56 +00:00
Akhil Narang
b8ebd601f8
fix(package_release): set path to tarball
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-06-05 17:07:11 +05:30
Ankush Menat
737628734d
fix: signup routing (#26685)
closes https://github.com/frappe/frappe/issues/26683
2024-06-05 07:23:47 +00:00
Ankush Menat
f3100d05cb
fix(UX): Disable number card filters on standard (#26676) 2024-06-04 13:12:03 +00:00
Corentin Flr
5a8e00af38
fix(Error Log): Truncate title and convert text to string (#26675) 2024-06-04 18:36:32 +05:30
Ankush Menat
f24b4a1f7f
fix: Auto Email Report not working when Add Total Row is enabled (#26664) 2024-06-04 13:47:03 +05:30
Ninad1306
8f187ac192 Auto Email Report not working when Add Total Row is enabled 2024-06-04 12:15:20 +05:30
Ankush Menat
4ffbcb5200
Merge pull request #26665 from ankush/duplicating_dt
fix(DX): duplicate doctype
2024-06-04 12:05:14 +05:30
Ankush Menat
99f2360a12 fix: Always ensure amended_from is same doctype 2024-06-04 11:52:14 +05:30
Ankush Menat
15902a746e fix: auto repeat on new doctypes
closes https://github.com/frappe/frappe/issues/24091
2024-06-04 11:50:54 +05:30
cwooldridge
3d7381da5d
fix: Red was defined twice. (#26658) 2024-06-04 05:33:58 +00:00
Akhil Narang
fb2df4ab5e
Merge pull request #26656 from akhilnarang/request-check-content-type
fix(make_request): don't blindly try to check the content-type
2024-06-04 10:59:39 +05:30
Ankush Menat
82e6a9a081
fix: Slightly efficient scheduling (#26657)
- Scheduler tick is 1 minute
- Fastest jobs are at least 4 minutes apart.

3/4 times we are wasting cpu cycle for each site.

Fix:
- Check every 4 minutes.
- Align the sleep around real clock to fix problem of jobs executing
  randomly in any part of the minute.

Cons:
Anything not aligned with scheduler interval will be delayed.
2024-06-04 05:21:47 +00:00
Gursheen Kaur Anand
9322381ba1
Merge pull request #26617 from GursheenK/workspace-create-perm-for-desk-user
fix: allow creation of workspace based on desk user role perms
2024-06-04 09:36:17 +05:30
Akhil Narang
152c4d4b91
fix(make_request): don't blindly try to check the content-type
Ensure that the response has one first

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-06-03 18:28:22 +05:30
Anes Fassih
35a02b8d0a
fix(link-preview): Correct synchronization of preview data on change. (#26641)
- Use 'config' attribute instead deprecated 'options' which is always undefined and prevent updating the preview data.

Co-authored-by: Anes Fassih <anes.fassih@nassej.com>
2024-06-03 09:38:34 +00:00
Ankush Menat
b1193675dd
fix: don't copy "Standard" on dashboard chart (#26649) 2024-06-03 08:14:10 +00:00
Corentin Flr
932c58f921
feat(commands): Add bypass-patch command (#26633)
* feat(commands): Add bypass-patch command

* chore: delete comments

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2024-06-03 07:06:18 +00:00
mergify[bot]
65ce529a04
fix: front-end bug in 'customize_form.js', triggered by delete actions on child-tables (#26344) (#26644)
* fix: Doctype Links not updating #26041
https://github.com/frappe/frappe/issues/26041

In refresh_field(fieldname, txt) function of grid_row.js, added the comments :-
    // the below if statement is added to factor in the exception when this.doc is undefined -
    // - after row removals via customize_form.js on links, actions and states child-tables
    if (this.doc)
            field.docname = this.doc.name;

* fix: Doctype Links not updating frappe#26041

In customize_form.js :-
defined parent and parenttype as local variables in the event functions for child tables links, actions and states

* Revert "In customize_form.js :-"

This reverts commit 6732f0aec4733490da46d7bd5cbedf239d13ec89.

* fix: Doctype Links not updating #26041

* style: amended spacing as per 'prettier' in precommit

* style: added comma after last event definitions in child doctype, as per 'prettier' in precommit

(cherry picked from commit b9f48455be10b40ab53375d7aef9fbaac644aea6)

Co-authored-by: Karan Wilson <48678570+karanwilson@users.noreply.github.com>
2024-06-03 12:25:14 +05:30
Ankush Menat
b63295d25c
fix: contact link with autoincr (#26642) 2024-06-03 04:59:48 +00:00
Frappe PR Bot
673f45b3e9
chore: update POT file (#26639) 2024-06-03 10:16:46 +05:30
Corentin Flr
c770c8e216
fix(dev): developer_mode could be a boolean (#26631) 2024-06-01 12:26:16 +05:30
Akhil Narang
7673397734
Merge pull request #26624 from akhilnarang/bypass-ip-restriction-realtime
fix: bypass IP restriction for the methods required for our socketio backend
2024-05-31 16:43:09 +05:30
Akhil Narang
68fd322955
fix: bypass IP restriction for the methods required for our socketio backend
Those requests are made from a separate backend, not by the user.

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-31 16:31:02 +05:30
Ankush Menat
1eab8c2f51
refactor!: Drop v1 style routing (using #) (#26626) 2024-05-31 15:21:02 +05:30
Corentin Flr
9c928ec483
feat(form): Set active tab based on URL hash (#26595) 2024-05-31 14:53:07 +05:30
Ankush Menat
fb27368a53
feat: Link fields with UUID datatype in DB (#26625)
Link fields that refer to doctypes with UUID naming will also be UUID.
2024-05-31 09:17:09 +00:00
Ankush Menat
1269e31170
fix: cast port to integer (#26623)
Not using cint to avoid converting bad input to 0.
2024-05-31 12:44:14 +05:30
Akhil Narang
68c5307fd9
Merge pull request #26611 from akhilnarang/fix-address-search-fields-link
fix(address_query): show search fields in description if set
2024-05-31 11:49:00 +05:30
Akhil Narang
1c6ba0cf82
fix(address_query): show search fields in description if set
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-31 11:36:10 +05:30
Dhia' Shalabi
e97a56b8c8
fix: delete old user notification settings when merging users (#26604) 2024-05-30 19:11:30 +05:30
Gursheen Anand
61807dda71 fix: allow creation of workspace based on desk role perms 2024-05-30 17:35:48 +05:30
Corentin Flr
847012e415
fix(checkbox): Fix checkbox size on small screens (#26596) 2024-05-30 13:44:17 +05:30
Rutwik Hiwalkar
d09ef5431f
fix: kanban filters fixes (#26605)
* fix(kanban): don't concat old cards after filter

- this was messing up rendering filtered cards

* fix: refresh not working without standard fields
2024-05-30 12:38:22 +05:30
Raffael Meyer
0c01da43e9
fix: toggle full width for more than 4 columns (#26607)
Resolves https://github.com/frappe/frappe/pull/26538#issuecomment-2137092812
2024-05-30 12:37:44 +05:30
Ankush Menat
80a3bf33cf
perf: rearrange some frequent jobs (#26591)
* perf: lower frequency of not so useful jobs

* fix: 4x deferred insert frequency
2024-05-29 17:41:06 +05:30
Akhil Narang
b866ee3ef6
Merge pull request #26600 from akhilnarang/fix-number-card-formatting
fix(number_card): ensure value is returned
2024-05-29 16:37:48 +05:30
Akhil Narang
7695a0d2ec
fix(number_card): ensure value is returned
In the case of a number card based on a query report, an integer with
a very basic DF is passed, leading to the "formatted" value being just
the integer as a string, which becomes an empty string after $().text()

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-05-29 16:22:20 +05:30
Ankush Menat
dce308bc65
perf: memory leak on kanban refresh (#26597) 2024-05-29 16:05:44 +05:30