Akhil Narang
33dbf97db2
fix(document): don't try to overwrite name if a string is already set
...
This allows us to pass `name` in via API when creating documents.
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2025-05-05 12:24:58 +05:30
Sagar Vora
f242b34ef2
Merge pull request #32379 from sagarvora/fix-get-onload
...
fix(Document): improve `__onload` implementation
2025-05-03 15:14:24 +00:00
Sagar Vora
f93b87ddd8
fix(Document): improve __onload implementation
2025-05-03 20:35:52 +05:30
Ankush Menat
f708acb59e
Merge pull request #32382 from ankush/qb_ifnull
...
perf: Avoid Coalesce in QB `is` implementation
2025-05-02 19:19:27 +05:30
Ankush Menat
c778ce370f
perf: Avoid Coalesce in QB is implementation
2025-05-02 19:09:51 +05:30
Ankush Menat
b6d44a4725
perf: transform ifnull into two conditions ( #32377 )
...
* fix(DX): Better formatted SQL queries from DB Query
Avoid unnecessary tabs, thought of using dedent but unnecessary overhead
for small stylistic benefit inside code vs. stylistic benefit in logs.
* perf: Split ifnull into two conditions
This produces better query plan with index intersection using 2
conditions instead of fulltable scan on dumb condition
TODO: LOTS OF TESTS
* fix: avoid bad default of `flt` on string types
🤦 this whole thing needs a refactor, fixing all bugs first to
ensure we don't screw up something in process
* perf: optimize `!=` operator when field can be null
* perf: avoid ifnull for `is set` and `is not set`
2025-05-02 13:05:30 +05:30
Ankush Menat
dbb1fcba99
perf: avoid ifnull for is set and is not set
2025-05-02 12:35:58 +05:30
Ankush Menat
6d32ffcc6c
perf: optimize != operator when field can be null
2025-05-02 12:11:27 +05:30
Ankush Menat
e0f63a928f
fix: avoid bad default of flt on string types
...
🤦 this whole thing needs a refactor, fixing all bugs first to
ensure we don't screw up something in process
2025-05-02 12:00:36 +05:30
Ankush Menat
23ffdc87ae
perf: Split ifnull into two conditions
...
This produces better query plan with index intersection using 2
conditions instead of fulltable scan on dumb condition
TODO: LOTS OF TESTS
2025-05-02 11:17:53 +05:30
Ankush Menat
c317462379
fix(DX): Better formatted SQL queries from DB Query
...
Avoid unnecessary tabs, thought of using dedent but unnecessary overhead
for small stylistic benefit inside code vs. stylistic benefit in logs.
2025-05-02 11:10:05 +05:30
Ankush Menat
42f1d1b460
fix(db_query): double-escaped value ( #32376 )
2025-05-02 11:09:11 +05:30
Frappe PR Bot
479c304eae
fix: sync translations from crowdin ( #32230 )
...
Co-authored-by: Raffael Meyer <14891507+barredterra@users.noreply.github.com>
2025-04-29 14:10:15 +00:00
Soham Kulkarni
1dba06e834
chore: bump markdownify to 0.14.1 ( #32348 )
2025-04-29 15:31:35 +05:30
Soham Kulkarni
87c67c8dbe
Merge pull request #32315 from sokumon/link-field-trigger
...
fix(link): dont force set value in model
2025-04-29 14:59:49 +05:30
Ejaaz Khan
49391175a1
Merge pull request #32340 from iamejaaz/fix-grouping-issue
...
refactor: fix ruff linter issue
2025-04-29 13:14:20 +05:30
Akhil Narang
8d42b4d3d6
Merge pull request #32268 from akhilnarang/drop-example-email-address-creation
...
fix: don't create example email domains and email accounts
2025-04-29 12:50:29 +05:30
Ejaaz Khan
3187e115ba
Merge pull request #32306 from rehanrehman389/workflow-fix
...
fix: ensure workflow state field is created post-validation
2025-04-29 12:14:24 +05:30
Ejaaz Khan
71814d3ce6
refactor: fix ruff linter isssue
2025-04-29 12:04:22 +05:30
Akhil Narang
10a17bc29f
Merge pull request #32335 from flaviacastro/chore/add-webform-list-empty-state-messages-to-load-translations
...
chore: add webform list empty state messages to load_translations
2025-04-29 11:52:12 +05:30
rehansari26
70a3eb986c
fix: remove unnecessary clear_cache call
2025-04-29 11:49:50 +05:30
Akhil Narang
a9de0aac1d
Merge pull request #32328 from diptanilsaha/fixed-support-36797
...
fix: prevent updating first_responded_on on automated message
2025-04-29 11:24:04 +05:30
Akhil Narang
2b5802c8b1
Merge pull request #32334 from frappe/dependabot/github_actions/actions/download-artifact-4.3.0
...
chore(deps): bump actions/download-artifact from 4.2.1 to 4.3.0
2025-04-29 10:59:30 +05:30
Ejaaz Khan
e528cf6124
Merge pull request #32333 from iamejaaz/fix-grouping-issue
...
fix: error on group by
2025-04-29 10:47:26 +05:30
flaviacastro
1bf0aaf8ee
chore: add webform list empty state messages to load_translations
2025-04-28 19:44:38 -03:00
dependabot[bot]
5d2df3b588
chore(deps): bump actions/download-artifact from 4.2.1 to 4.3.0
...
Bumps [actions/download-artifact](https://github.com/actions/download-artifact ) from 4.2.1 to 4.3.0.
- [Release notes](https://github.com/actions/download-artifact/releases )
- [Commits](https://github.com/actions/download-artifact/compare/v4.2.1...v4.3.0 )
---
updated-dependencies:
- dependency-name: actions/download-artifact
dependency-version: 4.3.0
dependency-type: direct:production
update-type: version-update:semver-minor
...
Signed-off-by: dependabot[bot] <support@github.com>
2025-04-28 19:35:36 +00:00
Ejaaz Khan
1b471c41bc
refactor: remove debigging code
2025-04-28 23:56:02 +05:30
Ejaaz Khan
9734c8477e
fix: error on gorup by
2025-04-28 23:53:42 +05:30
Marica
3f813b347e
Merge pull request #32283 from barredterra/simplify-comment-refresh
...
refactor: simplify comment refresh
2025-04-28 17:28:08 +05:30
rehansari26
bd055ab78c
fix: create custom field when doctype is changed
2025-04-28 16:41:53 +05:30
Frappe PR Bot
4b33808538
chore: update POT file ( #32314 )
2025-04-28 12:27:40 +02:00
diptanilsaha
94a6bcd97b
fix: prevent updating first_responded_on on automated message
2025-04-28 14:58:34 +05:30
Ejaaz Khan
1b0c886b2f
Merge pull request #32310 from cogk/fix-load-missing-option-dynamic-link
...
fix(load): Don't fetch Dynamic Link titles if missing doctype
2025-04-28 11:52:05 +05:30
Ankush Menat
2dfb96f91c
fix: handle snapshot isolation errors better ( #32318 )
...
* fix: Avoid Snapshot violation
- Main thread created and "read" user
- Other thread modified something
- Main thread wants to delete or "write" to same row.
This violates snapshot isolation.
* fix: treat snapshot violation as deadlock for now
* test: handle snapshot violations
2025-04-28 06:18:38 +00:00
Soham Kulkarni
0535a2f1f6
Merge pull request #32317 from sokumon/better-sidebar
...
fix: sidebar interaction
2025-04-28 01:38:44 +05:30
sokumon
c5ee716890
fix: child sidebar item interaction
2025-04-28 01:19:13 +05:30
Soham Kulkarni
6305e848b4
fix(safe_exec): add get_content_hash ( #32265 )
...
* fix(safe_exec): add get_content_hash
* fix: replace exposed function with sha256
* fix: rename function to sha256_hash and make it consistent
2025-04-27 13:37:25 +05:30
sokumon
181b715aa8
fix(link): dont force set value in model
2025-04-27 13:06:57 +05:30
Sagar Vora
4dd98f8f06
Merge pull request #32309 from cogk/chore-typo-text
...
chore: Fix typo in comment
2025-04-27 00:46:37 +05:30
Corentin Forler
f5e99424ce
fix(load): Don't fetch Dynamic Link titles if missing doctype
2025-04-26 14:42:34 +02:00
Corentin Forler
6180622275
chore: Fix typo in comment
2025-04-26 10:01:50 +02:00
sokumon
b8da56d03d
fix(minor): collapse text should be visible
2025-04-25 18:08:06 +05:30
rehansari26
ca812bb307
fix: ensure workflow state field is created post-validation
2025-04-25 17:51:48 +05:30
Marica
2a75c27d17
fix: Show authorized private attachments in web forms ( #32177 )
2025-04-25 14:21:41 +02:00
Ankush Menat
856513423f
fix: recorder auto-disable ( #32296 )
...
This broke with client cache implementation... oopsie.
2025-04-25 11:32:55 +00:00
Ejaaz Khan
002892d0bf
Merge pull request #32300 from iamejaaz/35786-module-not-found
...
fix: Module not found error for custom doctypes
2025-04-25 15:54:04 +05:30
Marica
790a5fd28c
Merge pull request #32282 from barredterra/comment-notify-update
...
fix(Comment): logic for update notification
2025-04-25 15:36:35 +05:30
Ejaaz Khan
cae7759df6
refactor: pass app as an argument to avoid duplicte function call
2025-04-25 14:55:07 +05:30
Ejaaz Khan
2e0db2d69e
fix: Module not found error for custom doctypes
2025-04-25 14:51:16 +05:30
Soham Kulkarni
84d1403f5c
Merge pull request #32299 from sokumon/better-sidebar
...
fix(minor): clean up variable
2025-04-25 14:15:44 +05:30
