Commit graph

17412 commits

Author SHA1 Message Date
Suraj Shetty
356d0b77ec
Merge pull request #6838 from adityahase/import-fix
fix(import): Import print_function once
2019-01-29 07:22:54 +05:30
Aditya Hase
928ec12d35 fix(import): Import print_function once 2019-01-28 14:54:55 +05:30
Aleksas Pielikis
ecb3d3f56d feat(email): Allow emails to be sent without SMTP authentication by setting (#6816)
* Add email_account option to disable SMTP Authentication.

* Partially reverting email_account.py changes. Unnecessary incoming_server logic was added.

* Codacy code style issue fix.

* Suppress 'Password is required or select Awaiting Password' message if only smtp is used an no athentication is required.

* Suppress 'Password is required or select Awaiting Password' message if only smtp is used an no athentication is required.

* Simplified logic.

* Reverted excessive changes.

* fix: remove description and make label clear
2019-01-28 12:22:28 +05:30
Saif
c294ee3583 feat: Show average of Percent field in report totals row (#6785)
* feat: Use a new report accumulator function for DataTable totals row

* fix: Updated accumulator function according to changes in DataTable
2019-01-28 12:21:37 +05:30
Suraj Shetty
2a431be19b Set empty string if the value is null or undefined (#6803) 2019-01-25 11:59:13 +05:30
Faris Ansari
36775a8b62 fix: Breadcrumbs in File View (#6802)
* fix: Breadcrumbs in File View

* fix: style and duplication
2019-01-25 11:58:25 +05:30
Aditya Hase
837bfc0995 fix(unicode): Import unicode_literals in every file (#6805)
* fix(unicode): Import unicode_literals in every file

* fix(unicode): Test if safe_json_loads return unicode instead of bytes
2019-01-25 11:56:27 +05:30
Faris Ansari
d5cd34457e fix: Bypass filters that cannot be applied (#6818)
Use case:

When you enable Workflow for any DocType, it's status is now tracked by
`workflow_field` and not `docstatus`. When you navigate from
Notification dropdown, it applied a `docstatus` filter on the List View
which cannot be applied. This can be ignored and user can apply his
own filters.
2019-01-25 11:54:55 +05:30
Aditya Hase
51fc91563d feat(email): Check Send Read Receipt checkbox by default (#6817) 2019-01-25 11:53:47 +05:30
Anurag Mishra
37393399ce fix: offset in calendar view (#6815) 2019-01-25 11:28:24 +05:30
Faris Ansari
cc033a67eb fix(PrintFormat): Section Labels with spaces in them got truncated (#6819) 2019-01-25 11:19:57 +05:30
Chinmay Pai
3250553738 fix(notifications): ignore mysql internal error 1684 for concurrent ddl statements (#6826)
apparently this occurs when get_notifcations is called, and at the same time, a table is being modified. to fix this, we just skip the table that is currently being modified.

Signed-off-by: Chinmay Pai <chinmaydpai@gmail.com>
2019-01-25 11:19:17 +05:30
Zarrar
d8187a3f9d fix: unicode character throws error for python 2 (#6822) 2019-01-25 10:24:40 +05:30
Saurabh
97152b5a1e fix: return empty dict if setup wizard is not completed (#6830) 2019-01-25 10:22:13 +05:30
Saurabh
a5d18beefb
Merge pull request #6829 from saurabh6790/notification_fix
fix: return empty dict if site is in installation state or setup wiz …
2019-01-24 19:58:01 +05:30
Saurabh
14911900c8 fix: return empty dict if site is in installation state or setup wiz not completed 2019-01-24 19:56:03 +05:30
Faris Ansari
75f8847ad4
fix: Skip get_notifications before setup_complete (#6828) 2019-01-24 19:15:49 +05:30
Suraj Shetty
fdecd002b7
Merge pull request #6807 from adityahase/fix-mail
fix(email): Pass args as unicode in Py2 & bytes in Py3 to SMTP.login
2019-01-23 20:53:25 +05:30
Zarrar
8bdb0dc5f8 feat: Download json file (#6793)
* feat: download file as json type

* fix: make raw type files downloadable
2019-01-23 16:51:02 +05:30
Aditya Hase
7bd056c2d1 fix: Use ImportError instead of ModuleNotFoundError (#6808)
ModuleNotFoundError is available in python 3.6

This should have been included in Frappe PR #6797
2019-01-23 16:43:37 +05:30
Aditya Hase
6b72faf44f style: Linting fixes (#6809)
* style: Remove unused imports

* style: Remove unused local variables
2019-01-23 16:39:55 +05:30
Frappe Bot
1212139117 Merge branch 'staging-fixes' into staging 2019-01-23 08:10:32 +00:00
Frappe Bot
69548336ba bumped to version 11.0.3-beta.51 2019-01-23 08:10:32 +00:00
Suraj Shetty
f863a3484d fix: Make total row bold (#6810) 2019-01-23 10:46:45 +05:30
Aditya Hase
7a12d3399f fix(email): Pass args as unicode in Py2 & bytes in Py3 to SMTP.login 2019-01-22 23:06:17 +05:30
rohitwaghchaure
ce87a68baa Fix: auto email report not showing all columns in email (#6806) 2019-01-22 22:48:09 +05:30
Sagar Vora
e23faaf79a Merge branch 'staging-fixes' into staging 2019-01-22 15:42:02 +05:30
Sagar Vora
8f7ad2e2f7 bumped to version 11.0.3-beta.50 2019-01-22 16:02:02 +05:50
Sagar Vora
2d166e7513 Merge branch 'master' into staging-fixes 2019-01-22 15:24:48 +05:30
Sagar Vora
3be02c067d Merge branch 'hotfix' 2019-01-22 15:19:38 +05:30
Sagar Vora
a00b063d36 bumped to version 10.1.70 2019-01-22 15:39:38 +05:50
Sagar Vora
3e47cd9a2b
Merge pull request #6788 from sagarvora/freeze-requests-oauthlib
fix(requirements): freeze requests-oauthlib to 1.1.0
2019-01-22 15:11:30 +05:30
Zarrar
c58d2c34d4 fix: don't append signature if it is already present (#6800) 2019-01-22 14:40:26 +05:30
Saif
c7c82ff972 WebsiteGenerator call super class clear_cache (#6786) 2019-01-22 11:28:26 +05:30
Aditya Hase
b2f559ce79 fix(list-view): Show count that matches number of rows (#6798) 2019-01-22 11:27:18 +05:30
Suraj Shetty
132a92e6cc fix: "list object has no get attribute" error while saving new doc (#6799)
* Fix .get() function not found error while saving new doc

* Remove print statement
2019-01-22 11:26:10 +05:30
Nabin Hait
555049b75f
fix(grid): Download hidden fields data from grid (#6796) 2019-01-22 11:25:47 +05:30
Faris Ansari
987a604749 fix: Use ImportError instead of ModuleNotFoundError (#6797)
- ModuleNotFoundError is available in python 3.6
2019-01-21 17:57:38 +05:30
Faris Ansari
6724b0fd26 fix(quill): Convert ol to ul before sending the value to server (#6795) 2019-01-21 17:42:21 +05:30
Suraj Shetty
95e9afa1f3 feat: Clear user permissions button (#6767)
* Add button to delete user permissions in bulk

* Show no records deleted the delete count is 0

* Return this from show of dialog to make it chainable

* Add test for clear user permissions function

* Fix test

* Format code

* Reset the user

* Remove rollback from test

* Move clear user permission button to menu

* fix: Translations
2019-01-21 16:52:12 +05:30
Suraj Shetty
818a37fa08
Merge pull request #6794 from netchampfaris/weird-event-emitter-fix
fix: Make event emitter from blank object
2019-01-21 16:01:51 +05:30
Faris Ansari
76380687ad fix: Make event emitter from blank object
- If a function is passed to jQuery, it calls it 🤷🏻‍♂️
- In hindsight, it is not needed to pass the object to jQuery
- This fixes a weird bug explained here
https://github.com/frappe/frappe/pull/6791
2019-01-21 15:17:06 +05:30
Suraj Shetty
f073b7ded3
Merge pull request #6728 from rohitwaghchaure/fixed_user_permissions_issue_dict
fix: 'dict' object has no attribute 'applicable_for'
2019-01-21 10:46:15 +05:30
Sagar Vora
98bd66ba00 fix(requirements): freeze requests-oauthlib to 1.1.0 2019-01-20 10:35:57 +05:30
Andrew McLeod
d9ee1674c5 fix: Add 'parent' argument to frappe.db.get_value. (#6570)
Add 'parent' to call to get_value in data.js.
Fixes issues with lookups in data.js which check for already existing names. Without this, the get_value calls fail for child fields such as 'barcode' in Item Barcode with PermissionError warning.
2019-01-18 13:59:12 +05:30
Zarrar
3d95621cd5 feat(email): Retry sending Email 3 times before deeming it as error (#6754)
* added field to note number of retries

* incase of unprecedented errors increase retry counter and try sending again
2019-01-18 13:33:59 +05:30
Charles-Henri Decultot
1234852568 fix: Removal of a logging line (#6778) 2019-01-18 12:09:45 +05:30
Suraj Shetty
4086d2edef
Merge pull request #6782 from netchampfaris/misc-fixes-6
fix(timeline-item): User image urls dont load if they have a space
2019-01-18 07:09:09 +05:30
Faris Ansari
e9b33630e9 fix(timeline-item): User images dont load if they have space in the url 2019-01-17 18:04:15 +05:30
Saif
a9b782b861 fix(Caching): Clear document_cache in clear_doctype_cache (which is called from bench migrate) (#6772) 2019-01-17 12:21:41 +05:30