barredterra
368283769f
refactor: move extract_messages_from_code to a separate utils file
...
In order to avoid circular imports.
2024-01-19 16:16:38 +01:00
barredterra
cc6ff2994f
fix: make render_include work without local object
...
frappe.throw relies on local, making it impossible to use this function without an active site.
2024-01-19 16:13:09 +01:00
Akhil Narang
1640aaad04
Merge pull request #24332 from blaggacao/chore/cleanup-low-level-db-interface
...
chore: cleanup low level db interface
2024-01-19 17:06:08 +05:30
Akhil Narang
8a3f14d990
chore: restore original order of parameters - add the new one to the end
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-19 16:28:56 +05:30
Suraj Shetty
2a6d0df575
Merge pull request #24461 from surajshetty3416/fix-sentry-3
2024-01-19 16:13:49 +05:30
Alan
56b85823ca
Merge pull request #24460 from frappe/fix-app-path
...
fix(Build): reinit `app_path`, avoid `get_app_path`
2024-01-19 15:59:12 +05:30
Suraj Shetty
693aada7af
Merge branch 'develop' into fix-sentry-3
2024-01-19 15:56:52 +05:30
Akhil Narang
8d001e530c
Merge pull request #24448 from akhilnarang/fix-failed-decryption-file-name
...
fix(decrypt): wrap the yield and cleanup code in try-finally
2024-01-19 15:51:14 +05:30
Suraj Shetty
0f4a1d8f10
fix: Handle invalid descendant filter
2024-01-19 15:49:02 +05:30
18alantom
60fb4f6d22
fix(Build): reinit app_path, avoid get_app_path
...
frappe/esbuild seems like a ticking timebomb, I have
not seen so many global variables since 2nd year of
engineering.
The function get_app_path just returns a value from an
object that is initialized when the file is imported. Why
is it a function in the first place. What lawless idiocy
is this?
2024-01-19 15:20:30 +05:30
Suraj Shetty
d1f308aad3
fix: Handle bad URL ( #24456 )
2024-01-19 09:34:35 +00:00
David Arnold
a1a653632f
fix: avoid changing argument order
2024-01-19 10:31:57 +01:00
Alan
7a68ebe3a4
Merge pull request #24412 from frappe/add-using-cached-build-flag
...
feat(Bench): add using-cached flag
2024-01-18 18:12:02 +05:30
mergify[bot]
d3868c2757
Merge pull request #24444 from GursheenK/single-doctype-strict-perms
...
fix: disable strict user perms for single doctypes
2024-01-18 12:25:45 +00:00
David Arnold
7bec22e238
Merge remote-tracking branch 'origin/develop' into chore/cleanup-low-level-db-interface
2024-01-18 13:22:33 +01:00
mergify[bot]
483fcf89c3
Merge pull request #24428 from blaggacao/chore/cleanup-frappe-connect
...
chore: cleanup frappe connect (I/II)
2024-01-18 12:15:42 +00:00
mergify[bot]
70cf76cc44
Merge pull request #24434 from blaggacao/feat/suggest-default-db-users-on-prompt
...
feat: add defaults to db superuser prompt
2024-01-18 12:11:04 +00:00
Akhil Narang
39be50c773
fix(decrypt): wrap the yield and cleanup code in try-finally
...
Without this, the cleanup code won't run after if `sys.exit()` is called when we yield
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-01-18 17:37:23 +05:30
David Arnold
2b16450cf0
chore: keep frappe.connect backwards compatible for a while
2024-01-18 12:40:25 +01:00
David Arnold
e5ea601882
test: amend to consistently specify the test env's root db user
2024-01-18 12:25:58 +01:00
18alantom
2da12b27cd
refactor: set using cached with envvar
2024-01-18 16:25:14 +05:30
Gursheen Anand
f74939eb0c
fix: skip strict user perms for single doctypes
2024-01-18 16:10:20 +05:30
David Arnold
9a1af12a41
chore: more concise code
2024-01-18 10:20:12 +01:00
18alantom
9a87ec11e7
fix: add command to indicate use-cached support
2024-01-18 13:15:58 +05:30
Rucha Mahabal
53d4153bcd
Merge pull request #24271 from ruchamahabal/fix-user-slide
...
fix(setup wizard): allow setting user password for an existing user
2024-01-18 13:05:57 +05:30
Ankush Menat
ee6743c26b
fix: avoid mutating list while iterating over it ( #24438 )
2024-01-18 05:44:30 +00:00
Ankush Menat
f36a753c5a
refactor: Start sentry before freezing gc and use in pool ( #24436 )
...
- Workerpool wasn't using sentry
- Sentry was started after freezing GC which causes sentry imports to
not be shared. Freeze GC after most memory intensive work is done.
2024-01-18 05:34:34 +00:00
Ankush Menat
2b3ab02d79
Merge branch 'develop' into add-using-cached-build-flag
2024-01-18 10:51:04 +05:30
Ankush Menat
d0bbade837
Merge branch 'develop' into feat/suggest-default-db-users-on-prompt
2024-01-18 10:48:27 +05:30
Ankush Menat
885fab62f2
ci: split pre-commit config ( #24437 )
2024-01-18 10:45:17 +05:30
David Arnold
bd357f41d3
feat: add defaults to db superuser prompt
2024-01-17 20:25:27 +01:00
David Arnold
f889d09d0b
fix: set defaults at the highest level interface
2024-01-17 18:59:34 +01:00
Ankush Menat
c7f1789daf
fix: select label null breaks form rendereding ( #24427 )
2024-01-17 21:23:54 +05:30
David Arnold
d87092936f
chore: simplify frappe.connect & require explicit site initialization
2024-01-17 16:53:30 +01:00
Corentin Flr
766a7efcd9
fix(js): Handle hidden virtual fields ( #24405 )
2024-01-17 18:28:57 +05:30
Ankush Menat
c177431557
perf: Document objects without circular references ( #17080 )
...
* perf: `Document` objects without circular references
Circular references are usuallly considered bad for GC, avoiding them
since they don't seem to be necessary.
* fix: explicitly convert to weakref
2024-01-17 17:22:55 +05:30
Gursheen Kaur Anand
f45bfe208a
fix: allow accounts manager read perm in currency ( #24419 )
2024-01-17 16:07:22 +05:30
Ankush Menat
afef4b8f30
fix: add short timeout to gravatar ( #24414 )
...
closes https://github.com/frappe/frappe/issues/24377
2024-01-17 09:08:00 +00:00
Ankush Menat
ea08418d7d
fix: ignore unique fieldname validation during migrate ( #24413 )
...
This can be addressed later instead of failing a migrate
2024-01-17 08:52:05 +00:00
18alantom
9ece71bc56
feat: add using-cached flag to bench build
...
- add using-cache flag to node esbuild call
The flag is to be used by bench get-app if its is
using cache.
Flag causes building of assets to not run and
instead updates assets.json files from built assets.
Linking of assets in the sites folder also occurs.
2024-01-17 13:20:57 +05:30
Ankush Menat
c0cf13b8e8
Revert "fix: search_link fails when txt contains parentheses ( #22892 )"
...
This reverts commit 642e9f4ec1
2024-01-17 12:44:20 +05:30
Ankush Menat
ffe84c9f9d
Revert "perf: cache fieldname extraction"
...
This reverts commit c591fcc5c1
2024-01-17 12:44:09 +05:30
Ankush Menat
cf2be9d64e
Merge pull request #24410 from ankush/perf_fieldname
...
perf: cache fieldname extraction
2024-01-17 12:06:55 +05:30
Ankush Menat
c591fcc5c1
perf: cache fieldname extraction
2024-01-17 11:50:13 +05:30
Sambasiva Suda
642e9f4ec1
fix: search_link fails when txt contains parentheses ( #22892 )
...
* fix: search_link fails when txt contains parentheses
* fix: updating regex to replace number params also
* chore: replacing regex with sqlparse
* chore: not including fields like count(1) in asterisk_fields
* fix: owner/module not identified as column
* chore: lint fix and removing exception
* refactor: better function name
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
2024-01-16 21:36:45 +05:30
Corentin Flr
7123f50912
feat(list): Add hide_name_filter setting ( #24402 )
...
Co-authored-by: Corentin Forler <8860073-cforler_dokos@users.noreply.gitlab.com>
2024-01-16 21:15:58 +05:30
Ankush Menat
484049c5ae
fix: simultenous sessions ux ( #24387 )
...
* fix: set 2 as simultaneous_sessions by default
* fix: Correct offset for simultaneous_sessions
* refactor: use freeze_time instead of patching
* chore: misleading docstring
* test: set lower simultaneous_sessions for test
2024-01-16 13:36:05 +00:00
Raffael Meyer
ed09885eb4
Merge pull request #24390 from barredterra/remove-redundant-drive-api-key
2024-01-16 14:08:23 +01:00
barredterra
c17f014ef4
refactor: remove redundant API Key from Google Picker
2024-01-16 13:26:03 +01:00
Ankush Menat
307da3097f
Merge pull request #23329 from akhilnarang/allow-setting-db-username
...
refactor: allow setting a db user name different from the database name
2024-01-16 17:46:03 +05:30
