Commit graph

54015 commits

Author SHA1 Message Date
Sagar Vora
369f15ac09 fix: allow filtering by all permlevel 0 fields with select permission
Users with only 'select' permission can now filter, order by, and
group by all permlevel 0 fields, not just search fields.

- Added _get_filterable_fields() returning all permlevel 0 fields
  for select permission users
- Split permission checking into check_select_field_permission()
  and check_filter_field_permission()
- select field validation uses check_select_field_permission
- Filter/order/group by validation uses check_filter_field_permission
2026-02-20 21:23:29 +05:30
Sumit Jain
ffe362316d
fix: ensure import log is only used for persisted Data Import records (#36999) 2026-02-19 17:06:27 +05:30
Raffael Meyer
13bd30edd5
fix: limit config should not be mandatory (#37247) 2026-02-19 16:11:44 +05:30
Akash Tom
063e600c30
fix(grid): saving of values on navigation using arrow keys (#37243) 2026-02-19 16:05:12 +05:30
Faris Ansari
a4e2cd17f0
Merge pull request #37244 from netchampfaris/sqlite-fts-ranking
refactor: make SQLite search order more reliable
2026-02-19 14:58:46 +05:30
Aarol D'Souza
08793c57f7
fix: force type check in whitelisted methods 2 (#37086)
* fix(diff): add type hints to whitelisted methods

* fix(global_search): add type hints to whitelisted methods

* fix(custom_html_block): add type hints to whitelisted methods

* fix(deleted_document): add type hints to whitelisted methods

* fix(log_settings): add type hints to whitelisted methods

* fix(role): add type hints to whitelisted methods

* fix(user_type): add type hints to whitelisted methods

* fix(rq_job): add type hints to whitelisted methods

* fix(link_preview): add type hints to whitelisted methods

* fix(email_account): add type hints to whitelisted methods

* fix(web_form): add type hints to whitelisted methods

* fix(web_page_view): add type hints to whitelisted methods

* fix(csvutils): add type hints to whitelisted methods

* fix(file_manager): add type hints to whitelisted methods

* fix(email_body): add type hints to whitelisted methods

* fix(email_queue): add type hints to whitelisted methods

* fix(email_template): add type hints to whitelisted methods

* fix(notification): add type hints to whitelisted methods

* fix(email_group): add type hints to whitelisted methods

* fix(inbox): add type hints to whitelisted methods

* fix(recorder): add type hints to whitelisted methods

* fix(sms_settings): add type hints to whitelisted methods

* fix: tighten type hints

* fix(data_import): add type hints to whitelisted methods

* fix(user_permission): add type hints to whitelisted methods

* fix(gantt): add type hints to whitelisted methods

* fix(like): add type hints to whitelisted methods

* fix(search): add type hints to whitelisted methods

* fix(onboarding_step): add type hints to whitelisted methods

* fix(system_console): add type hints to whitelisted methods

* fix(workspace_sidebar): add type hints to whitelisted methods

* fix(todo): add type hints to whitelisted methods

* fix: correct type hints

* fix(print_format): add type hints to whitelisted methods

* fix(client): add type hints to whitelisted methods
2026-02-19 14:58:16 +05:30
Ejaaz Khan
aee0295275
Merge pull request #37242 from Vibhuti410/remove-grid-height-override
fix: restore z-index for sticky grid column
2026-02-19 14:43:21 +05:30
Faris Ansari
7e0be7f170 refactor: make SQLite search order more reliable
- use a stable index checkpoint with creation + name so rows are not skipped
- fetch more BM25 matches before reranking, then return the top MAX_SEARCH_RESULTS
- add stable tie-breakers in reranking (BM25 and original rank)
- improve title matching by checking full words instead of substrings
- remove abs normalization in base score
2026-02-19 14:32:07 +05:30
Frappe
6c55d6a9a0 fix: add z-index back to fix sticky scroll behavior 2026-02-19 14:21:10 +05:30
Vibhuti Garachh
15bcd7d209
fix: remove height override causing layout issue after save (#37236)
Co-authored-by: Frappe <frappe@Vibhutis-MacBook-Air.local>
2026-02-19 14:10:22 +05:30
s-aga-r
6a132e94e0
fix(Email Account): remove redundant field (#37229) 2026-02-19 07:40:37 +00:00
Soham Kulkarni
3d450041d0
Merge pull request #37227 from sokumon/workspace-editing
fix: workpsace editing issues
2026-02-19 13:02:36 +05:30
Frappe
0f40f916ea fix: remove height override causing layout issue after save 2026-02-19 12:55:42 +05:30
Sowmya
bdd5c15bfc
fix(module-def): add validation for rename (#37001) 2026-02-19 12:51:18 +05:30
Diptanil Saha
be12bbaa9f
Merge pull request #37215 from diptanilsaha/stt-zi-pos
fix(form-footer): scroll-to-top button position for mobile and z-index
2026-02-19 12:42:45 +05:30
s-aga-r
2960865605
fix: use default incoming email account as Reply-To (#36793)
* fix: use default incoming email account as `Reply-To`

* chore: set incoming account email as Reply-To

---------

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2026-02-19 06:55:04 +00:00
Prathamesh Kurunkar
6fd9004377
fix(grid_row): skip rendering for compound currency symbols in editable rows (#37160)
* fix(grid_row): skip rendering for compound currency symbols in editable rows

* chore: fix linting
2026-02-19 12:18:22 +05:30
s-aga-r
8bfb42deb4
feat: configurable Reply-To (#36774)
* feat: configurable `Reply-To`

* chore: set `add_reply_to_header` to `1`

* fix: Resolve conflicts

---------

Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2026-02-19 12:13:55 +05:30
sokumon
30f65e4909 fix: dont allow editing workspace on mobile 2026-02-19 12:13:22 +05:30
Gursheen Kaur Anand
199f1f540f
Merge pull request #37183 from GursheenK/link-btn-inset
fix: shadow inset introduces extra spacing for grid icons
2026-02-19 12:11:17 +05:30
sokumon
6a2a7183d0 fix: dont show edit button while editing workspace 2026-02-19 12:08:41 +05:30
s-aga-r
e735ae774e
fix: lower timeout when validating Email Account (#37147)
* fix: reduce Email Domain validate timeout

* fix: lower timeout when validating Email Account (SMTP)

* fix: lower timeout when validating Email Account (IMAP/POP)
2026-02-19 12:01:28 +05:30
Suraj Shetty
8fc4c52f03
fix(modal): improve styling and layout of search modal and help section (#37203)
Co-authored-by: Ejaaz Khan <ejaaz@frappe.io>
Co-authored-by: Diptanil Saha <diptanil@frappe.io>
2026-02-19 11:12:58 +05:30
Sagar Vora
067a6351b5
Merge pull request #37214 from sagarvora/fix/grid-row-docfield-contamination
fix: prevent docfield copy contamination across grid rows on deletion/reorder
2026-02-19 10:32:46 +05:30
Sagar Vora
51c2e9ec89 perf: set docfields only on doc change 2026-02-19 10:30:49 +05:30
MochaMind
9284c19f87
fix: sync translations from crowdin (#37216)
* fix: Spanish translations

* fix: Serbian (Cyrillic) translations

* fix: Swedish translations

* fix: Portuguese, Brazilian translations

* fix: Persian translations

* fix: Burmese translations

* fix: Serbian (Latin) translations
2026-02-19 07:33:18 +05:30
diptanilsaha
8c1e604e53 fix(form-footer): scroll-to-top button position for mobile and z-index 2026-02-19 02:03:58 +05:30
Sagar Vora
9fabfa3054 fix: prevent docfield copy contamination across grid rows on deletion/reorder
set_docfields was passing the row's mutated docfields (with stale
reqd/read_only/hidden from dependency evaluation) as source to
make_docfield_copy_for, poisoning the copy store for whichever doc
landed at that position after deletion/reorder.

- Remove make_docfield_copy_for call from set_docfields (the copy store
  seeds itself lazily from clean originals in get_docfield_copy)
- Always call set_docfields() on refresh so rows pick up correct copies
  when doc identity changes at a position
- Thread grid.docfields through meta.js so new copy-store entries
  include grid-level customizations (set_df_property on child fields)

Closes #36921
2026-02-19 00:48:15 +05:30
Soham Kulkarni
da9cbd74db
Merge pull request #36672 from claytonlin1110/fix/desk-folder-icon-title-edit-persist
fix: desk folder title edit persists and inline editor ui
2026-02-19 00:31:30 +05:30
sokumon
6ce260d169 refactor: better function name 2026-02-18 22:38:02 +05:30
Clayton
51a7dae803 fix: conflict 2026-02-18 21:38:11 +05:30
Clayton
4123acfcd1 fix: remove unnecessary code 2026-02-18 21:38:11 +05:30
Clayton
203b39a42a fix: editable title in edit layout mode only 2026-02-18 21:38:11 +05:30
Clayton
492f730b42 fix: desk folder title edit persists and inline editor ui 2026-02-18 21:38:11 +05:30
Ejaaz Khan
ec2dbdd491
Merge pull request #37202 from iamejaaz/sidebar-menu-position
refactor(ui): reposition menu for improved layout
2026-02-18 20:34:53 +05:30
Hussain Nagaria
8edecdaefc
Merge pull request #37035 from trustedcomputer/fix-attach-print-pdf 2026-02-18 20:28:26 +05:30
Hussain Nagaria
71365066d3
refactor: safer property access 2026-02-18 19:40:47 +05:30
Ejaaz Khan
0254f52834
Merge pull request #37201 from iamejaaz/add-fc-banner-desktop
refactor: remove FC banner from desk
2026-02-18 17:57:14 +05:30
Ejaaz Khan
8cd5ad51b1 refactor(ui): reposition menu for improved layout
Co-authored-by: diptanilsaha <diptanilsaha@users.noreply.github.com>
Co-authored-by: surajshetty3416 <surajshetty3416@users.noreply.github.com>
2026-02-18 17:34:39 +05:30
Ejaaz Khan
6a3357c224 refactor: remove FC banner from desk 2026-02-18 17:25:11 +05:30
Ejaaz Khan
3de8e14754
Merge pull request #37198 from iamejaaz/add-fc-banner-desktop
feat: add FC billing banner on Desktop
2026-02-18 16:25:19 +05:30
Ejaaz Khan
081908540d feat: add FC billing banner on Desktop 2026-02-18 16:08:12 +05:30
Prathamesh Kurunkar
79003d6674
docs(sendmail): clarify behavior of queue_separately and CC/BCC in email_queue (#37113)
* fix(sendmail): enhance queuing of cc and bcc recipients to avoid duplicates

* revert: fix(sendmail): enhance queuing of cc and bcc recipients to avoid duplicates

This reverts commit 66c0c1cfb7c0f46f5687ce5266f945e88dadc1db.

* docs(email_queue): clarify behavior of queue_separately and CC/BCC in email queue
2026-02-18 15:57:20 +05:30
Prathamesh Kurunkar
3e061b026b
fix(email): ensure CC header visibility according to email semantics (#37182)
* fix(email): ensure CC header visibility according to email semantics

* chore(email): fix linting in docs
2026-02-18 15:55:06 +05:30
s-aga-r
13c7a38fce
fix: link received reply of sent email (#37177) 2026-02-18 15:20:48 +05:30
Patel Aasif Khan
9c0acda79a
fix: Fixed Email Header folding issue with Message-ID (#35266)
* fix: Fixed Email Header folding issue with Message-ID

* fix: email header folding with smtp policy refold

* chore: linter

---------

Co-authored-by: s-aga-r <sagarsharma.s312@gmail.com>
2026-02-18 14:33:13 +05:30
Gursheen Anand
5e92584bf5 fix: shadow inset issue in grid links 2026-02-18 14:18:34 +05:30
Harsh Patadia
849a935e20
fix: List Settings UI Issue (#36903)
* fix: List Settings UI Issue #36861

* fix: removed extra padding from top, made everything vertically aligned

* fix: properly formatted the changes made to the file

* fix: failing linter

* fix: failing linter

* fix: failing linter

* fix: failing linter

* fix: failing linter

* fix: formatting

* refactor: code cleanup

---------

Co-authored-by: priyanshshah2442 <priyanshshah2442@gmail.com>
Co-authored-by: Ejaaz Khan <ejaaz@frappe.io>
2026-02-18 14:14:09 +05:30
Gursheen Kaur Anand
9dcbd870c4
Merge pull request #37156 from GursheenK/open-link-icon-overflow
fix(minor): open link button overflows in grid row
2026-02-18 13:09:37 +05:30
Soham Kulkarni
739eae4a4e
Merge pull request #36983 from KerollesFathy/fix-kb-layout
fix: adjust padding and layout for knowledge base
2026-02-18 12:51:48 +05:30