vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1
45857 commits 1 branch 0 tags 587 MiB
Commit graph

223 commits

Author SHA1 Message Date
Ankush Menat
3896296c6f fix: update sort order in doctypes 2024-03-27 11:18:28 +05:30
Ankush Menat
b1a8bc9312
fix: Export None as type if select as no options (#25211) 
Select options can be dynamic, in that case we should at least the
default value `None` as a value `DF.Literal` otherwise is invalid type
annotation.
 2024-03-04 06:42:41 +00:00
Ankush Menat
64a5ebb112
refactor!: Drop user based workflow action compatibility (#24956) 
* test: run workflow actions in tests

* test: fix workflow action tests

* refactor!: Remove compatibility with `user` based workflow action

* test: cleanup test cleanups

* fix: restore form dict after printing

* test: patch printing during workflow tests
 2024-02-20 14:37:13 +00:00
Nihantra C. Patel
15eb1bf839
fix: send_workflow_action_email (#24929) 
* fix: send_workflow_action_email

* fix: send_workflow_action_email
 2024-02-19 06:37:20 +00:00
Ankush Menat
8c5aaeb437 test: avoid fiddling with workflow action columns 2024-02-12 12:38:05 +05:30
Ankush Menat
140a01e2cf perf: cache permission results 
For each transition, we end up redoing perm check. Nothing has really changed there though.
 2024-02-12 11:32:38 +05:30
Ankush Menat
b0a4425230 perf: process workflow email receipients from background 2024-02-12 11:20:17 +05:30
Ankush Menat
8344bce09a refactor: remove needless coupling of return values 2024-02-12 11:14:57 +05:30
Ankush Menat
16fa5ec9bd fix: enqueue_after_commit instead of instantly 2024-02-12 10:51:11 +05:30
Ankush Menat
72c2207e0f refactor: useless use of dict in frappe.get_doc 2024-02-10 12:52:38 +05:30
Akhil Narang
26ae0f3460
fix: ruff fixes 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2024-02-07 17:04:31 +05:30
Ankush Menat
de9ac89748 style: re-format with ruff 2024-02-05 18:53:33 +05:30
Ankush Menat
447f02e8d3
fix!: Remove misleading "raise_exception" (#24266) 
frappe.permission.has_permission won't accept raise_exception anymore,
it was extremely misleading argument and actual purpose of the argument
was to print perm check logs.
 2024-01-11 08:24:18 +00:00
Ankush Menat
02031fc6f4
fix: don't update docstatus (#24216) 
This doesn't make sense.

Updating docstatus without resaving document is a bad idea.

Co-authored-by: rohitwaghchaure <rohitw1991@gmail.com>
 2024-01-09 09:32:03 +00:00
Hussain Nagaria
8d2137c265 docs: consistent doc strings 2023-12-18 18:27:39 +05:30
Corentin Flr
4f809630c5
fix: Set sort_order to DESC if sort_field is modified (#23697) 
Global search and replace operation, including single doctypes where it does not really matter.
 2023-12-13 09:52:14 +05:30
Ankush Menat
21261e63e6
fix: Workflow doc states not existing on new forms (#23756) 
[skip ci]
 2023-12-12 21:43:19 +05:30
barredterra
c35476256f refactor: simplify conditional logic 
Command: `sourcery review --fix --enable de-morgan .`
 2023-12-05 11:14:41 +01:00
Corentin Flr
82623e5977
chore(translations): Remove extra space at end of line 
When editing translation CSV manually in a text editor, one does not always disable the "trim trailing whitespace" feature. This can lead to mis-translations and duplications (when using `bench get-untranslated`).
 2023-11-27 12:17:27 +01:00
Akhil Narang
fbc88a4d24
refactor(treewide): code cleanup 
Drop redundant bool conversion

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-11-23 13:57:51 +05:30
Shariq Ansari
be4e0bbc8a
Merge pull request #23207 from rtdany10/workflow-status 
feat: workflow state wise status override
 2023-11-20 21:06:59 +05:30
Shariq Ansari
da5b723939
Merge pull request #23217 from rtdany10/workflow-docstatus-validation 
fix(workflow): avoid implicit docstatus altering
 2023-11-19 10:55:51 +05:30
Dany Robert
ee4f74913c fix: test docstatus change from workflow 2023-11-19 03:02:30 +00:00
Shariq Ansari
d9691c579e
Merge branch 'develop' into workflow-status 2023-11-18 21:39:58 +05:30
Dany Robert
b4c0b10bff fix(workflow): avoid implicit docstatus altering 2023-11-17 14:01:54 +00:00
Shariq Ansari
45aba69a06 fix: set default state as 0 2023-11-16 12:39:31 +05:30
Dany Robert
3f70cebf65 feat: workflow state wise status override 2023-11-13 13:00:14 +00:00
Shariq Ansari
ff5c6e3394 chore: updated workflow builder banner 2023-10-19 11:34:47 +05:30
Sambasiva Suda
53c795f4b8
fix: Workflow Builder not updating diagram with added states/transitions in table (#22429) 
Co-authored-by: Shariq Ansari <sharique.rik@gmail.com>
 2023-10-03 17:13:51 +05:30
Ankush Menat
dc8d7b019a refactor!: Lower roles from All To Desk User 2023-08-29 12:07:57 +05:30
Ankush Menat
2e9f779a98 fix: check workflow state field to avoid error 2023-08-28 11:02:53 +05:30
Ankush Menat
89c0c1b07b fix: don't enqueue sendmail jobs 
- sendmail just creates email queue, it should be done on the fly.
- if OutgoingEmailError occurs then skip all future ones.
 2023-08-22 15:25:32 +05:30
gavin
453690ecc0
fix(types): Exporter unconditionally marks fields as Nullable (#21997) 
* fix(types): Exporter unconditionally marks fields as Nullable

* fix: correct fieldtype names

* fix: table multi-select type annotations

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
 2023-08-10 10:18:10 +05:30
barredterra
88c8baa9ee refactor: for append to extend, merge list extend 
Replace a for append loop with list extend.
Create the list with values instead of creating
an empty list and extending it with another list.
 2023-08-09 13:25:39 +02:00
barredterra
b553ed98d8 refactor: inline immediately returned variable 
Inline a variable to a return in the case when the
variable being declared is immediately returned
 2023-08-08 18:09:49 +02:00
Ankush Menat
927cd647e4 chore: generate type annotations 2023-07-24 15:32:48 +05:30
Ankush Menat
892c5e30a2 refactor: Simpler workflow caching 
Entire document is cached, so no need to create another layer of cache.
 2023-07-19 16:45:44 +05:30
Ankush Menat
d68e46d2cc fix: disable workflow emails by default 
make it opt-in instead.
 2023-07-19 16:45:44 +05:30
Ankush Menat
58cf770760 fix: All ESLint errors 2023-07-14 15:25:48 +05:30
Ankush Menat
fa6dc03cc8
refactor: frappe.cache() usage to frappe.cache (#21282) 2023-06-08 11:47:17 +05:30
Shariq Ansari
3736aaa26f chore: linter fix 2023-05-10 17:36:57 +05:30
Shariq Ansari
ecc431875e chore: updated banner text 2023-05-10 17:21:39 +05:30
Shariq Ansari
ab5570f447 chore: removed try new workflow builder button 2023-05-10 14:42:35 +05:30
Shariq Ansari
35f1c0213d fix: dont save if state or transition is empty and is_active is set 2023-05-10 14:41:15 +05:30
Shariq Ansari
f5310e1d03 fix: wrong workflow_builder_url in existing doc's banner 2023-05-04 18:06:54 +05:30
Shariq Ansari
997f2f64fa fix: added button on list view to open workflow builder 2023-05-03 16:22:06 +05:30
Shariq Ansari
5ad8079086 fix: added banner on workflow doc to try new workflow builder with gif 2023-05-03 16:06:27 +05:30
Shariq Ansari
9ab905c46c fix: show state/transition data on sidebar on click 2023-05-02 20:09:47 +05:30
Shariq Ansari
f258ca09ac fix: render states & transition by fetching workflow data 2023-05-02 17:55:46 +05:30
Shariq Ansari
96057eb632 fix: try workflow builder button in workflow doc 2023-05-01 13:31:53 +05:30