Commit graph

49141 commits

Author SHA1 Message Date
Ankush Menat
3bfc9fa8da
perf: Don't update list view settings on every query (#31743)
It literally doesn't do anything ever.

User settings are explicitly updated using `user_settings.save` endpoint.
2025-03-16 05:35:39 +00:00
Sagar Vora
445f3cb5a9
Merge pull request #31740 from sagarvora/perf-child-init
perf: preset `_table_fieldnames` for child docs (and a revert)
2025-03-16 01:23:58 +05:30
Sagar Vora
32ff002c32 fix: revert valid columns cache
it is used only once when initialising doc
2025-03-16 01:10:29 +05:30
Sagar Vora
63f2c35290 perf: preset _table_fieldnames for child docs 2025-03-16 00:59:10 +05:30
Ankush Menat
4533f92582
fix: Pin web workers by default (#31739) 2025-03-15 12:01:59 +00:00
Sagar Vora
1722b773ce
Merge pull request #31738 from sagarvora/simplify-load-from-db
fix: simplify `load_from_db` logic
2025-03-15 16:23:57 +05:30
Suraj Shetty
0f8166ad3e
Merge pull request #31737 from ruchamahabal/skip-preloading-assets
fix: skip preloading bundled assets if `http_status_code` is 404
2025-03-15 16:23:04 +05:30
Sagar Vora
09d0abcb54 fix: simplify load_from_db logic 2025-03-15 16:14:55 +05:30
Rucha Mahabal
85bcc372e7 fix: skip preloading bundled assets if http_status_code is 404
Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
2025-03-15 15:27:03 +05:30
Sagar Vora
217debdcfc
Merge pull request #31733 from sagarvora/perf-query-type
perf: compute query type only once
2025-03-15 13:56:39 +05:30
Sagar Vora
fb0e2baa5a perf: store touched_tables in local var 2025-03-15 13:47:45 +05:30
Sagar Vora
521ff071ae perf: compute query type only once 2025-03-15 13:39:57 +05:30
Sagar Vora
42d79a8eae
Merge pull request #31734 from sagarvora/perf-make-key
perf: make redis key faster
2025-03-15 13:21:56 +05:30
Sagar Vora
322312a154 perf: make redis key faster 2025-03-15 13:12:57 +05:30
Ankush Menat
950073a27e
build: pin exact version of mysqlclient (#31730) 2025-03-15 06:20:23 +00:00
Sagar Vora
8e9ebedfcf
Merge pull request #31729 from sagarvora/improve-query-exec
perf: optimize query building code
2025-03-15 10:39:01 +05:30
Sagar Vora
ab98d3716f perf: optimize query building code 2025-03-15 10:29:26 +05:30
Sagar Vora
b2cab51849
feat: re-introduce mysqlclient 🚀 (#31719)
* feat: mysqlclient

* fix: update error attrs

* fix: decode mogrified query to unicode

* fix: do some cleanup

* chore: disable cleanup for now

* fix: remove unnecessary call to as_unicode

* test: skip perf test for now

* fix: fallback to empty str

* fix: unbuffered cursor support

* fix: update converters and other changes

* fix: add cleanup back

* perf: improve timedelta converter

* fix: dont attempt to run query when explain flag is set

* test: cleanup tests

* chore: remove commented code

* perf: store conf as local var

* chore: ensure sequence

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2025-03-15 09:48:21 +05:30
Ejaaz Khan
0e62819741
Merge pull request #31521 from batonac/fix-notification-phone-fields
fix: Notification get_receiver_fields phone field function
2025-03-15 00:51:01 +05:30
Ejaaz Khan
2e32468f86
Merge pull request #31255 from Sanket322/encode_filters
fix: Encode URL filters to handle special characters
2025-03-15 00:35:38 +05:30
Ejaaz Khan
20432552de
Merge pull request #31388 from prateekkaramchandani/fix/confirm-remove-attachment
fix: confirm before removing attachment on clear button in attach control
2025-03-14 23:05:42 +05:30
Sabu Siyad
e012213ca2
docs: base_document: remove(): comment to docstring (#31720) 2025-03-14 16:30:12 +01:00
Sagar Vora
a2939ba220
Merge pull request #31717 from sagarvora/no-getattr
perf: remove `__getattr__` from local & localproxy
2025-03-13 22:49:15 +05:30
Sagar Vora
042372ea86 perf: remove __getattr__ from local & localproxy 2025-03-13 22:36:31 +05:30
Markus Lobedann
18b01453cd
fix: don't generate type information for virtual fields (#31592)
* fix: 🐛 don't generate type information for virtual fields

this leads to linter errors for redeclaration

* fix: 🐛 don't dontype information for virtual fields

Co-authored-by: gavin <gavin18d@gmail.com>

---------

Co-authored-by: gavin <gavin18d@gmail.com>
2025-03-13 18:25:13 +05:30
Marica
cef4d7abb0
Merge pull request #31689 from marination/is-html-refactor
fix: Use DOMParser in `is_html` + Handle html input in `show_message`
2025-03-13 18:09:57 +05:30
Raffael Meyer
fed66a32ed
fix: support "Timespan" in evaluate_filters (#31190)
* fix: support "Timespan" in `evaluate_filters`

* fix: add None case
2025-03-13 12:51:49 +01:00
Marica
68f6f39a9e
Merge pull request #31633 from marination/web-form-translate-link-field
fix: Translate link fields in Webform
2025-03-13 15:46:37 +05:30
Akhil Narang
e1f73a835a
Merge pull request #31551 from cogk/fix-set-text-instead-of-xss-sanitizing
fix: Use jQuery.text() instead of  xss_sanitise
2025-03-13 15:38:40 +05:30
Ankush Menat
e4b0d11b19
fix: only show tracebacks to system users (#31629)
Website users by design are supposed to be "less trusted", so don't show
tracebacks to them.
2025-03-13 14:48:20 +05:30
Suhail
97a1d38814
fix: store unsubscribe params properly (#31583)
* fix: store unsubscribe params properly

Earlier we had a field `unsubscribe_param` but it wasn't used anywhere to store the params.
This made sure only email, doctype and docname was passed as the params while unsubscribing and no custom params wasn't.

* fix: convert unsubscribe_params dict to json before storing
2025-03-13 14:41:45 +05:30
Ankush Menat
fc7ff191b6
fix: avoid overriding saved list filters (#31699)
Only override filters when there's no other active filter (from user settings
or otherwise)
2025-03-13 09:06:52 +00:00
Akhil Narang
3215702749
Merge pull request #31679 from akhilnarang/fix-user-name-sanitisation
fix(user): stricter name validation
2025-03-13 14:26:51 +05:30
Ankush Menat
ba84768ba8
perf: Use cached redirects (#31698) 2025-03-13 13:50:26 +05:30
Ejaaz Khan
91430efdbb
Merge pull request #31693 from iamejaaz/query-report-translate
fix: report header not translated
2025-03-13 11:37:28 +05:30
Akhil Narang
c77dc8ab5a
Merge pull request #31692 from kalungia/sms
fix: increase length for value field in sms parameter
2025-03-13 11:18:18 +05:30
Ejaaz Khan
f462029178 fix: report header not translated 2025-03-13 11:05:09 +05:30
Ankush Menat
357b6fb11a
perf: don't parse comments just to get comment count (#28921)
This parsing isn't necessary and we are copying all of _comments just to count
how many there are.

Imagine 2500 documents w/ 1-2 auto generated comments each.
2025-03-13 05:00:21 +00:00
Abraham Kalungi
adc54286d9 fix: increase length for value field in sms parameter 2025-03-12 19:45:13 +02:00
Soham Kulkarni
2fb2f7598e
Merge pull request #31691 from sokumon/better-sidebar
fix: small fixes to the sidebar
2025-03-12 22:40:03 +05:30
sokumon
aaf5dd8ca2 fix(minor): move drop icon for better alignment 2025-03-12 22:12:40 +05:30
Sagar Vora
caaf9b09f7
Merge pull request #31690 from sagarvora/more-methods
perf: override more `werkzeug.local` methods
2025-03-12 22:07:26 +05:30
sokumon
f5eab0a179 fix: clear selected app after app is selcted 2025-03-12 22:05:21 +05:30
Sagar Vora
00c12cb029 perf: override more werkzeug.local methods 2025-03-12 21:28:23 +05:30
marination
bec966ab7d fix: Use DOMParser in is_html + Handle unparsable html string with jquery 2025-03-12 16:16:31 +01:00
Sagar Vora
8147f04fb5
Merge pull request #31688 from frappe/revert-31664-faster-_dict-getattr
Revert "perf!: faster frappedict getattr"
2025-03-12 18:35:52 +05:30
Sagar Vora
29c318964b
Revert "perf!: faster frappedict getattr" 2025-03-12 18:35:33 +05:30
Sagar Vora
768202a2d2
Merge pull request #31687 from frappe/revert-31666-add-slots
Revert "fix: add `__slots__` to NamespaceDict"
2025-03-12 18:35:10 +05:30
Sagar Vora
5be83f7df8
Revert "fix: add __slots__ to NamespaceDict" 2025-03-12 18:34:17 +05:30
Ankush Menat
70f9524787
fix(UX): Explain why some doctypes automatically have a filter (#31682) 2025-03-12 12:27:54 +00:00