Commit graph

44234 commits

Author SHA1 Message Date
Ankush Menat
3c83b102ef fix: tz aware vs naive comparison 2023-11-24 15:03:08 +05:30
Shariq Ansari
655e646d8b
Merge pull request #23401 from shariquerik/banner-image-name-overlapping
fix: webform banner_image name replacing navbar banner_image
2023-11-24 12:43:42 +05:30
Shariq Ansari
01fb455a76 fix: webform banner_image name replacing navbar banner_image 2023-11-24 11:29:29 +05:30
Ankush Menat
62529f3d74
chore(telemetry): track logged errors (#23390)
Also includes unhandled errors
2023-11-24 04:55:12 +00:00
Ankush Menat
770598df49 Revert "refactor: remove code that manually prevents bulk refresh (#23138)"
This reverts commit 60d99eb20c.
2023-11-24 10:18:29 +05:30
Raffael Meyer
1f6cd8080e
Merge pull request #23392 from barredterra/default-email-group 2023-11-24 01:08:42 +01:00
Raffael Meyer
cc1673a40e
Merge pull request #23394 from barredterra/german-timespan 2023-11-24 01:00:28 +01:00
barredterra
a99bf56160 fix: german translations for timespan 2023-11-24 00:59:22 +01:00
barredterra
06fbe6df20 fix: default Email Group in system language 2023-11-23 16:51:23 +01:00
mergify[bot]
514ea6e259
Merge pull request #23309 from akhilnarang/drop-redundant-bool
refactor(treewide): code cleanup
2023-11-23 11:20:55 +00:00
Akhil Narang
d21c7730da
fix(commands/site): the old logic did rely on 0 evaluting to false
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-23 16:34:28 +05:30
Akhil Narang
23bcb6733e
refactor(website_generator): update variable name to make more sense as per usage
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-11-23 16:06:07 +05:30
Akhil Narang
cc58fd20ca
refactor(oauth): simplify scopes check with the usage of all()
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-23 16:04:56 +05:30
Akhil Narang
f8c5a61bbd
refactor(report): simplify check further
NoneType will evaluate to False here so we don't need this complexity

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-11-23 15:54:13 +05:30
Akhil Narang
f007f16ce9
fix: handle invalid passwords better (#23377)
* chore(login): show a message for response code 500 as well

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

* refactor: reject passwords > 512 characters

Signed-off-by: Akhil Narang <me@akhilnarang.dev>

---------

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-23 15:35:37 +05:30
mergify[bot]
a775d5adb0
Merge pull request #23380 from ruthra-kumar/ignore_dynamic_links_on_virtual_doctypes
fix: ignore dynamic links in virtual doctypes
2023-11-23 09:37:28 +00:00
ruthra kumar
1e0920409f fix: ignore dynamic fields in virtual doctypes 2023-11-23 14:49:28 +05:30
Akhil Narang
fbc88a4d24
refactor(treewide): code cleanup
Drop redundant bool conversion

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-23 13:57:51 +05:30
Ankush Menat
f526054ae2
refactor: Remove usage of utcnow (#23369) 2023-11-23 13:21:27 +05:30
Maharshi Patel
c2309969d5
fix: typo in strip folder name quotes (#23368)
fixed incorrect negative index.
2023-11-23 06:16:54 +00:00
Ankush Menat
21e8abf899
build: python 3.12 support (#22706)
* ci: use python 3.12

We'll use minimum versions on stable branch CI configs.

* build(deps): bump dependencies

- Some for v12 support
- some just for new stuff
2023-11-23 11:42:51 +05:30
Md Hussain Nagaria
6e3b1cc0ad
docs: add BWH link to resources (#23365) 2023-11-22 18:27:54 +05:30
mergify[bot]
9789864f2e
Merge pull request #23360 from akhilnarang/simplify-webform-link-title-check
refactor(web_form): cleanup code
2023-11-22 12:56:03 +00:00
Suraj Shetty
09ded1b671
Merge pull request #23362 from surajshetty3416/fix-email-formatting 2023-11-22 17:15:49 +05:30
Ankush Menat
31e3b3f981
fix: social key signup without signup conf (#23359) 2023-11-22 11:32:45 +00:00
Akhil Narang
3896750e2e
refactor(web_form): cleanup code
`frappe.get_meta()` gives us all the data we require

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-22 17:01:01 +05:30
Suraj Shetty
78c78ece34 fix: Show list similar to how it looks in text editor 2023-11-22 16:51:07 +05:30
Ankush Menat
1a3f39daa0
chore: readme logo on dark theme (#23358)
closes https://github.com/frappe/frappe/issues/23352
2023-11-22 16:20:20 +05:30
Indrajith.vs
a5b102dcd2
fix: button "Add Chart to Dashboard" visible before saving (#23256)
* fix: dashboard chart - add chart to dashboard btn fix

* style: format

[skip ci]

---------

Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-11-22 16:00:09 +05:30
Ankush Menat
e2a7e54af8
Merge pull request #23353 from frappe/mergify/bp/develop/pr-23335
fix: zeros converted to empty string in csv (backport #23335)
2023-11-22 15:48:43 +05:30
Dany Robert
39bd7353d1 fix: zeros converted to empty string in csv
(cherry picked from commit fa4b816ea0431e38538e7095a9db4140926d7207)
2023-11-22 10:12:40 +00:00
Suraj Shetty
2b2a7d44f6
Merge pull request #23347 from surajshetty3416/fix-email-pulling 2023-11-22 13:57:37 +05:30
Suraj Shetty
250dbf6a1c fix(email): Allow users to pull all (read & unread) emails during initial sync 2023-11-22 13:09:34 +05:30
Shariq Ansari
375ec5e470
Merge pull request #23342 from akhilnarang/webform-check-title-link-from-properties 2023-11-22 12:47:17 +05:30
Maharshi Patel
83f2227cdb
fix: review points when added more then once. (#23239)
* fix: review points when added more then once.

previously when user added review more then once it didn't work properly
because of apply_only_once check which is only meant for rule based points
changed that behaviour to only check when called from energy_point_rule by checking if doc.rule is set.
2023-11-22 12:31:35 +05:30
Akhil Narang
67b74cd4bb
fix(web_form): check properties for title field as well
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-22 11:54:36 +05:30
Ankush Menat
a4cbe36cbe
Merge pull request #23132 from frappe/jitter-scheduling
perf(Scheduling): add jitter to job scheduling
2023-11-22 10:59:38 +05:30
Ankush Menat
9738936f60
Merge pull request #23333 from maharshivpatel/fix-file-max-upload-size
fix: honour max file size in upload file
2023-11-22 10:56:42 +05:30
Ankush Menat
28d05c41c3 fix: correct max file size in boot 2023-11-22 10:55:52 +05:30
Ankush Menat
515c4410d5
Merge pull request #23337 from blaggacao/fix/naming-rule-polish-list-view
fix(naming_rule): polish list view
2023-11-22 10:47:26 +05:30
Ankush Menat
b43b8839c0
chore: remove dead link 2023-11-22 10:26:23 +05:30
David Arnold
f9141d04bf
fix(naming_rule): polish list view 2023-11-21 18:02:22 +01:00
Maharshi Patel
5af9b294f5 fix: honour max file size in upload file
In case path is /api/method/upload_file, we should honour the max file size
set in system settings and set request max_content_length to that value.
2023-11-21 16:36:57 +05:30
Ankush Menat
07d0b0aa95
Merge pull request #23317 from frappe/dependabot/github_actions/dessant/lock-threads-5
build(deps): bump dessant/lock-threads from 4 to 5
2023-11-21 15:47:56 +05:30
Ankush Menat
878314c0cb
Merge pull request #23322 from akhilnarang/communication-link-distinct-name
fix(event/sync_communication): add `distinct` while querying communication links
2023-11-21 15:45:17 +05:30
Maharshi Patel
b54b6867c4
fix: Font for arabic and not supported languages (#23234)
As we added Inter Variable Font in v15,
we noticed that the font is not supported for Arabic and other languages.
We added a fallback font for Arabic and other languages.
2023-11-21 14:34:12 +05:30
Akhil Narang
da1fb2ff4e
fix(event/sync_communication): add distinct while querying communication links
There's cases where these are duplicated

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-11-21 13:01:19 +05:30
18alantom
aeec01c7f9 perf(Scheduling): add jitter to job scheduling
Addresses #19007
2023-11-21 12:21:53 +05:30
Ankush Menat
cd189b3f7f fix: remove link - modifying while iterating 2023-11-21 12:01:55 +05:30
TechnicalShree
90cf6bb829
feat: Enabling Redirection to a Custom URL on Notification Click (#22956)
* feat: notification custom routing

* Update frappe/public/js/frappe/ui/notifications/notifications.js

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>

* code refactoring

* field name correction

* fix: json

* fix: auto generation

* lint fix

* fix: lint

---------

Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-11-21 01:23:41 +05:30