Sagar Vora
3eeeab72a2
Merge pull request #27346 from Ninad1306/before_mapping
...
fix: Before Mapping the Doc run `before_mapping` hook
2024-08-22 15:11:33 +05:30
Akhil Narang
43385060e1
Merge pull request #27491 from akhilnarang/revert-27386
...
revert: Merge pull request #27386 from GursheenK/grid-dependent-fields
2024-08-22 12:54:19 +05:30
Kunhi
2596fb7a2f
fix: Unable to save JSON field type in the customize form. ( #27472 )
...
* fix: Unable to save JSON field type in the customize form
* fix: run pre-commit
* precommit, fix
* precommit, linter issue
2024-08-22 12:49:01 +05:30
Akhil Narang
38f4871e23
Revert "Merge pull request #27386 from GursheenK/grid-dependent-fields"
...
This reverts commit ede8e06c03 , reversing
changes made to 35fb0e2687 .
2024-08-22 12:38:40 +05:30
Akhil Narang
273545dcae
Merge pull request #27474 from akhilnarang/notify-email-queue-suspended
...
chore(email_queue): nudge user to resume email queue if suspended and they are manually sending
2024-08-22 12:12:15 +05:30
Akhil Narang
44b091552c
Merge pull request #27477 from ljain112/fix-in-create
...
fix: correct permissions for user cannot create doctypes
2024-08-22 11:11:51 +05:30
Akhil Narang
7e2a69a95b
Merge pull request #27480 from akhilnarang/fix-notification-error-handling
...
fix(notification): can't use `message` where it isn't defined
2024-08-22 11:04:27 +05:30
Akhil Narang
88aa0fa34d
Merge pull request #27481 from akhilnarang/fix-rate-limiter-keyerror
...
fix(rate_limiter): prevent KeyError if the key isn't defined in form_dict
2024-08-22 11:04:12 +05:30
Akhil Narang
0af673a571
fix(rate_limiter): prevent KeyError if the key isn't defined in form_dict
...
Use dict.get(), it'll just return `None` if the key isn't present
(also will handle a `None` key just fine)
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-22 10:47:32 +05:30
Akhil Narang
b4c53392d7
fix(notification): can't use message where it isn't defined
...
Sentry FRAPPE-7VT
Partial revert of 8a7707e3fa
```
UnboundLocalError: cannot access local variable 'message' where it is not associated with a value
File "frappe/app.py", line 114, in application
response = frappe.api.handle(request)
File "frappe/api/__init__.py", line 49, in handle
data = endpoint(**arguments)
File "frappe/api/v1.py", line 36, in handle_rpc_call
return frappe.handler.handle()
File "frappe/handler.py", line 49, in handle
data = execute_cmd(cmd)
File "frappe/handler.py", line 85, in execute_cmd
return frappe.call(method, **frappe.form_dict)
File "__init__.py", line 1768, in call
return fn(*args, **newargs)
File "frappe/utils/typing_validations.py", line 31, in wrapper
return func(*args, **kwargs)
File "frappe/desk/form/save.py", line 37, in savedocs
doc.submit()
File "frappe/utils/typing_validations.py", line 31, in wrapper
return func(*args, **kwargs)
File "frappe/model/document.py", line 1048, in submit
return self._submit()
File "frappe/model/document.py", line 1031, in _submit
return self.save()
File "frappe/model/document.py", line 337, in save
return self._save(*args, **kwargs)
File "frappe/model/document.py", line 390, in _save
self.run_post_save_methods()
File "frappe/model/document.py", line 1131, in run_post_save_methods
self.run_method("on_submit")
File "frappe/model/document.py", line 964, in run_method
self.run_notifications(method)
File "frappe/model/document.py", line 1024, in run_notifications
_evaluate_alert(alert)
File "frappe/model/document.py", line 1007, in _evaluate_alert
evaluate_alert(self, alert.name, alert.event)
File "frappe/email/doctype/notification/notification.py", line 517, in evaluate_alert
msg = f"<details><summary>{title}</summary>{message}</details>"
```
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-22 10:43:36 +05:30
Sumit Bhanushali
60fe377a72
Merge pull request #27429 from Vishnu7025/utils-functions
...
feat: add get_month function to return current or specific month as a…
2024-08-22 01:18:44 +05:30
vishnu
22042ae00b
chore: pre-commit
2024-08-21 18:49:48 +00:00
vishnu
5b73b8c20a
chore: added calendar module
2024-08-21 18:28:34 +00:00
vishnu
ace2122e92
chore: removed extra functiion
2024-08-21 18:07:03 +00:00
ljain112
33ba43270c
fix: correct permissions for user cannot create doctypes
2024-08-21 17:58:52 +05:30
Akhil Narang
1d0f15033a
Merge pull request #27352 from cogk/refactor-move-validations-to-before-insert
...
refactor(File): Move validations to before_insert
2024-08-21 16:42:30 +05:30
Akhil Narang
7ab02055d6
chore(email_queue): nudge user to resume email queue if suspended and they are manually sending
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-21 16:21:52 +05:30
Raffael Meyer
fd09008e07
fix: extract translatable headings and paragraphs from workspaces ( #27464 )
2024-08-20 21:55:39 +00:00
Frappe PR Bot
11311b5b25
fix: sync translations from crowdin ( #27453 )
2024-08-20 23:14:51 +02:00
Raffael Meyer
02d8026c1b
fix: mark genders and salutations as translatable ( #27462 )
2024-08-20 21:11:54 +00:00
Corentin Forler
b7ea5640c7
test(File): Don't check for file deletion in distinct folders
2024-08-20 15:30:44 +02:00
Corentin Forler
96d11ff9f6
test(File): Ensure private file remains private
2024-08-20 15:30:43 +02:00
Corentin Forler
49ec842066
refactor(File): Move validations to before_insert
2024-08-20 15:30:43 +02:00
Akhil Narang
93b1b1f0ea
Merge pull request #27201 from barredterra/refactor-address-query
...
refactor: address query
2024-08-20 17:33:38 +05:30
Akhil Narang
00401f741f
Merge pull request #27205 from barredterra/strings-in-validate_value
...
fix: translatable strings in doc.validate_value
2024-08-20 17:12:00 +05:30
Akhil Narang
c63da52c68
Merge pull request #27308 from cogk/feat-parse-duration-in-control
...
feat(DurationControl): Parse duration string input
2024-08-20 17:06:55 +05:30
Gursheen Kaur Anand
beef1fa224
fix: use authentication url when password not found ( #27451 )
2024-08-20 10:40:38 +02:00
Akhil Narang
e6de4d99fe
Merge pull request #27456 from akhilnarang/fix-system-settings-members
...
fix(system_settings): add back `rate_limit_email_link_login`, drop `sidebar_position`
2024-08-20 14:05:50 +05:30
Akhil Narang
250205a71b
fix(system_settings): add back rate_limit_email_link_login, drop sidebar_position
...
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-20 13:51:33 +05:30
Akhil Narang
8bd2c8d8fa
Merge pull request #27418 from cogk/feat-allow-editable-cells-in-custom-reports
...
feat: Allow editable cells in custom reports
2024-08-20 13:36:54 +05:30
Akhil Narang
5cd757c349
Merge pull request #26845 from rtdany10/role
...
feat: role replication
2024-08-20 13:19:01 +05:30
Akhil Narang
5149a92cbf
Merge pull request #27434 from akhilnarang/fix-html-sanitize
...
fix(sanitize_html): sanitize all string inputs if specified
2024-08-20 11:52:40 +05:30
Nabin Hait
e54274f290
chore: Deleted all the form tours ( #27403 )
2024-08-20 10:39:40 +05:30
Akhil Narang
256cf7b419
Merge pull request #27445 from barredterra/prepared_report_dev_mode
...
fix: don't auto-enable prepared report in developer mode
2024-08-20 10:08:15 +05:30
barredterra
e796e2c0f9
fix: don't enable prepared report in developer mode
2024-08-19 20:19:12 +02:00
Raffael Meyer
6c5a099c1e
fix: translatable strings ( #27443 )
2024-08-19 14:43:19 +00:00
Frappe PR Bot
4f127d4338
chore: update POT file ( #27433 )
2024-08-19 15:36:29 +02:00
Frappe PR Bot
147e9da66b
fix: sync translations from crowdin ( #27206 )
2024-08-19 15:35:50 +02:00
Sumit Bhanushali
66afd3d471
Merge pull request #27431 from dj12djdjs/fix-redis-connect-digital-ocean
...
fix: allow `rediss` connection scheme
2024-08-19 17:04:09 +05:30
Akhil Narang
036c525647
Merge pull request #27437 from akhilnarang/fix-export-text-editor-empty-crash
...
fix(exporter): don't crash when a `Text Editor` field doesn't have a value
2024-08-19 13:12:40 +05:30
Akhil Narang
82cd08afd2
fix(sanitize_html): sanitize all string inputs
...
No reason to exclude JSON and what bs4 *thinks* is invalid HTML
The browser is happy to render both of those if its remotely valid
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-19 13:10:15 +05:30
Akhil Narang
f281638156
fix(exporter): don't crash when a Text Editor field doesn't have a value
...
Stacktrace: https://katb.in/rumuxohevar
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2024-08-19 12:59:36 +05:30
Rushabh Mehta
f63abe1b54
Merge pull request #27413 from rmehta/fix-desk-style
...
fix(style): Cleaner Workspace
2024-08-19 12:22:16 +05:30
Rushabh Mehta
e285501a4d
Merge pull request #27421 from cogk/chore-remove-unreachable-branch
...
chore: Remove unreachable branch
2024-08-19 12:08:50 +05:30
Rushabh Mehta
37b7fa59b1
fix(styles): various styles and updates to workspaces
2024-08-19 12:06:55 +05:30
Devin Slauenwhite
f2422ad219
fix: allow rediss connection scheme
2024-08-17 16:15:25 -04:00
vishnu
b41083561e
feat: Add get_month function to return current or specific month as a string
2024-08-17 14:11:00 +00:00
Corentin Forler
27ed833ebc
chore: Remove unreachable branch
2024-08-16 16:40:37 +02:00
Shariq Ansari
d70190f8d3
Merge pull request #27417 from shariquerik/apps-switcher-fix
...
fix: Redirect issue in apps switcher
2024-08-16 15:25:49 +05:30
Shariq Ansari
903ffd804c
chore: corrected variable name
2024-08-16 15:12:21 +05:30