David Arnold
40a2daf84c
chore: give cli invocations of dbtools a dedicated interface
2023-11-09 12:14:41 +01:00
mergify[bot]
cfbe6da959
Merge pull request #23167 from blaggacao/refactor/psql-conn-string
...
chore: compose postgres conn settings in the same way as with mariadb
2023-11-09 10:28:44 +00:00
Ankush Menat
60d99eb20c
refactor: remove code that manually prevents bulk refresh ( #23138 )
...
[skip ci]
2023-11-09 15:51:41 +05:30
David Arnold
d5a390cd95
chore: compose postgres conn settings in the same way as with mariadb
2023-11-09 10:00:24 +01:00
Shariq Ansari
731e5175e7
Merge pull request #23154 from shariquerik/form-builder-fixes-3
2023-11-08 14:40:53 +05:30
Shariq Ansari
1e7b45e324
test: fixed failing form builder UI test
2023-11-08 14:13:48 +05:30
Shariq Ansari
98f357cbb1
chore: handle dark mode
2023-11-08 13:50:47 +05:30
Shariq Ansari
4d6bc58a59
revert: code control loosing focus when edit (for now reverting need better fix)
2023-11-08 13:31:25 +05:30
Ankush Menat
e91b72e8c4
Merge pull request #23144 from blaggacao/fix/preserve-integration-request-data-format
...
fix(integration): preserver data json formatting on update
2023-11-08 12:51:03 +05:30
Ankush Menat
9d45ee80a2
Merge pull request #23146 from barredterra/ignore-filetype-case
...
fix: ignore case of filetype
2023-11-08 12:49:21 +05:30
Shariq Ansari
5e07df7af4
fix: removed unsed code from Column.vue
2023-11-08 12:13:10 +05:30
Shariq Ansari
3efbc30222
fix: added all options to add/remove section/column in section header
2023-11-08 11:55:38 +05:30
Shariq Ansari
88113b6c08
fix: added Dropdown component
2023-11-08 11:54:35 +05:30
barredterra
5e660437df
fix: ignore case of filetype
2023-11-07 17:08:20 +01:00
David Arnold
ec4bc971c5
fix(integration): preserver data json formatting on update
2023-11-07 16:43:13 +01:00
Ankush Menat
e14349d656
fix: newsletter indicator filters
...
strings are all truthy.
closes https://github.com/frappe/frappe/issues/23107
2023-11-07 20:10:48 +05:30
mergify[bot]
d3c534e0cf
fix: attempt to not pass an empty string to json.loads ( #23139 ) ( #23141 )
...
* fix: attempt to not pass an empty string to `json.loads`
* fix: ignore all falsy fields
---------
Co-authored-by: Ankush Menat <ankush@frappe.io>
(cherry picked from commit 6a8cf0689ae8e70f99ffd6957603d6583b4bdf92)
Co-authored-by: Arjun <contact@arjunchoudhary.com>
2023-11-07 20:04:20 +05:30
Shariq Ansari
aa55ccf88f
fix: always show section header
2023-11-07 19:32:15 +05:30
Shariq Ansari
bce95096f6
chore: show fields table in customize form
2023-11-07 19:28:00 +05:30
Arjun
67bac7863e
fix(UX): updated error.html message ( #23129 )
...
* UX: updated error.html
* chore: wspace
* chore: simpler message.
assuming foss deploys
---------
Co-authored-by: Ankush Menat <ankushmenat@gmail.com>
2023-11-07 18:27:11 +05:30
Ankush Menat
326a691f38
Merge pull request #23133 from ankush/req_parsing
...
refactor: Use werkzeug to identify JSON requests
2023-11-07 17:45:30 +05:30
Ankush Menat
284649d4f2
fix: Use werkzeug to identify JSON requests
...
We were excluding flavoured JSON like `application/vnd.xxx+json` which
can be parsed as JSON.
2023-11-07 17:28:33 +05:30
Raffael Meyer
d593390a74
Merge pull request #23124 from barredterra/remove-unused-method
2023-11-06 20:12:14 +01:00
barredterra
e3ff2456ef
chore: remove unused method
2023-11-06 19:46:34 +01:00
Ankush Menat
0aa3b51faa
fix: single global search sync
...
closes https://github.com/frappe/frappe/issues/23106
2023-11-06 20:29:16 +05:30
Ankush Menat
72ca95dec0
fix: Only allow standard print format modification in migrate ( #23112 )
...
* fix: Only allow standard print format modification in migrate
AFAIK only valid use case is fixtures and there too it should avoid
"standard".
* chore: typo
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
---------
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2023-11-06 19:28:10 +05:30
Ankush Menat
47c3151662
fix: remove data import legacy leftover fields ( #23113 )
...
* fix: clear last message if ignoring DNE
* fix: attempt to delete data import legacy leftover fields
2023-11-06 19:18:39 +05:30
Suraj Shetty
2aa79202f3
Merge pull request #23116 from vishakhdesai/get_open_grid_form-not-a-function-error
2023-11-06 17:50:29 +05:30
Suraj Shetty
a562b30fa3
Merge pull request #22600 from bosue/quick_entry_remove_saving_message
2023-11-06 17:49:14 +05:30
mergify[bot]
9bedb19cf5
fix: ToDo assignment (backport #23056 ) ( #23114 )
...
Co-authored-by: CahyadiSuwindra <149154168+CahyadiSuwindra@users.noreply.github.com>
2023-11-06 17:46:36 +05:30
Vishakh Desai
c06fe30b11
fix: get_open_grid_form function not found
2023-11-06 17:29:44 +05:30
Suraj Shetty
e3d536659e
Merge pull request #22684 from GursheenK/audit-trail-filters
2023-11-06 17:12:45 +05:30
Bernd Oliver Sünderhauf
6378a45146
fix(UX): Remove freeze on QuickEntryForm, slower fade out after save.
2023-11-06 11:43:25 +01:00
Ankush Menat
69857f3c36
fix(UX): Restrict grid upload to CSV files ( #23109 )
...
Users end up uploading wrong files and wonder why it's not working.
Only CSV filetype is supported here.
Internal refernce: 5377
2023-11-06 15:26:44 +05:30
Bernd Oliver Sünderhauf
a0d52c9319
refactor(DRY): QuickEntryForm
2023-11-06 10:51:57 +01:00
Bernd Oliver Sünderhauf
5f8b93ee4c
fix(UX): Replace 'Saving...' indicator by 'Created new...' success message for Quick Entry saves.
2023-11-06 10:51:34 +01:00
Maharshi Patel
4bba64d8e4
fix(minor): web and timeline styles ( #23083 )
2023-11-06 11:30:39 +05:30
mergify[bot]
4f81cf32eb
Merge pull request #22862 from SaiFi0102/grid-ui-perf
...
perf(Grid Table): 60% - 75% faster grid refresh
2023-11-06 05:04:18 +00:00
Bernd Oliver Sünderhauf
0b4bf84e38
fix(I18n): Use normalize to make fuzzy_match recognize diacritics, umlauts etc. ( #22828 )
...
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2023-11-06 10:10:23 +05:30
Ankush Menat
fa5a472686
Merge pull request #23094 from frappe/integration_smtp_test
...
test: smtp integration test using smtp4dev
2023-11-04 15:44:31 +05:30
Ankush Menat
3905e8970a
test: smtp integration test using smtp4dev
2023-11-04 15:26:40 +05:30
Ankush Menat
3211a77dc8
fix: handle emails sent from console
2023-11-04 14:30:37 +05:30
Ankush Menat
4255a0ec46
Merge pull request #23075 from ankush/reuse_smtp_sess
...
perf: reuse SMTP session for email queue
2023-11-04 14:21:43 +05:30
Ankush Menat
089985e53b
feat: frappe.job local for reading job info
2023-11-04 14:06:31 +05:30
Ankush Menat
ecca32853e
test: ensure that same smtpserver is being reused
2023-11-04 13:53:08 +05:30
Ankush Menat
0362de82bb
fix: Mark fake site config emali account with internal attribute
2023-11-04 13:41:18 +05:30
Ankush Menat
a4382fda5a
fix: Automatically close SMTP connections on exit
2023-11-04 11:51:42 +05:30
Ankush Menat
d5d0dfb58b
perf: Reuse SMTP connection when flushing email queue
...
This depends on https://github.com/frappe/frappe/pull/23070
2023-11-04 11:32:48 +05:30
Ankush Menat
4e318a0280
fix: Abort flushing email queue if >50% fail.
...
When email queue batch failes >33% with >10 count, frappe will now abort
sending emails.
We already notify users via system notification so this
assumes that user will notice it and fix it in sometime.
With previous commits we also prioritize fresh emails over retries.
2023-11-04 11:25:09 +05:30
Ankush Menat
050c0b26f8
fix: flush emails from single background jobs
2023-11-04 11:23:44 +05:30