Commit graph

255 commits

Author SHA1 Message Date
David Arnold
40a2daf84c
chore: give cli invocations of dbtools a dedicated interface 2023-11-09 12:14:41 +01:00
gavin
bedef22f34
fix(cli): Use mysql CLI as fallback is mariadb isnt found (#23004) 2023-10-30 19:48:04 +05:30
Akhil Narang
091ebdd8dc
refactor(treewide): use mariadb commands directly instead of mysql (#22620)
This has been done because the mysql command issues a deprecation warning now

mysql: Deprecated program name. It will be removed in a future release, use '/usr/bin/mariadb' instead

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
2023-10-10 12:49:16 +05:30
barredterra
ed2290d1d6 Merge branch 'develop' into feat/improve-openid-connect-devx 2023-10-07 15:22:59 +02:00
Suraj Shetty
80347c9f28
Merge branch 'develop' into update-cy-new 2023-09-25 14:53:23 +05:30
Gavin D'souza
b19c569761
fix(run-ui-tests): Set default browser as chrome
Co-authored-by: Suraj Shetty <surajshetty3416@gmail.com>
2023-09-25 11:11:13 +05:30
Gavin D'souza
a5f709b468
ci: Use electron browser over chrome
* Electron is already shipped along with Cypress. Can we use it?
* Pass --record kwarg only if CYPRESS_RECORD_KEY envvar is set
2023-09-23 18:12:48 +05:30
Suraj Shetty
a496f6b5e1 build: Update cypress 2023-09-22 11:19:41 +05:30
Ankush Menat
56371f09e0 Revert "fix!: Bind development server only to localhost (#22397)"
This reverts commit 9244140816.

Breaks docker development installs
2023-09-20 11:43:56 +05:30
David Arnold
64a09be958
Merge branch 'develop' into feat/improve-openid-connect-devx 2023-09-16 09:58:53 +02:00
Ankush Menat
9244140816
fix!: Bind development server only to localhost (#22397) 2023-09-13 17:26:19 +05:30
Ankush Menat
970a740164
revert: #22308 (#22389)
* Revert "chore: move function to correct file"

This reverts commit ebfdfa283b.

* Revert "refactor!: merge get_site_url into get_url (#22308)"

This reverts commit 2001bc278f.
2023-09-13 14:34:52 +05:30
Ankush Menat
64dd4b876b fix: UI test dont start without init 2023-09-13 12:33:49 +05:30
David Arnold
2001bc278f
refactor!: merge get_site_url into get_url (#22308)
* chore: merge get_site_url into get_url

* fix: keep alias with deprecation notice
2023-09-11 15:09:05 +05:30
David Arnold
87684e2647
feat: add werkzeug proxyfix to development server 2023-09-07 01:30:25 +02:00
Ankush Menat
b29272c092 fix: ipython console
https://github.com/ipython/ipython/issues/13966
2023-09-03 19:59:41 +05:30
Raffael Meyer
8f7a4f6697
Merge pull request #21873 from blaggacao/dont-exceed-python-module-boundary 2023-08-21 17:10:27 +02:00
Ankush Menat
fd740b780b fix: use vanilla eval 2023-08-21 12:09:45 +05:30
David Arnold
8dabd2bae6
refactor: make the app source accessor explicit
The parent folder of a python module (inside `./site-packages`) can be
`./lib`. Separate code paths that depend on the app source into its own
getter so that patching that function becomes easier in those cases
where the python module is not served from the source checkout.
2023-08-20 01:11:05 +02:00
David Arnold
6b2bb9a2ab
fix: add env overrides for service orchestration (#21577)
This avoids having to manipulate config files in brittle bash
entrypoints that need to react to dynamic service discovery.

This significantly improves the operability of various bench sites.
2023-07-14 11:39:01 +05:30
Suraj Shetty
fe25fe1db1 feat: A flag (--save-metafiles) to save esbuild metafiles
- Useful for analysing bundle size
2023-06-26 09:14:17 +05:30
Alfredo Altamirano
c6b1b026c5
fix: data-import command fails with local files (#20521) (#21381)
* fix: data is retrieved from db instead of local file

* fix: data import command only accepts absolute path

* fix: revert expanduser

- Shells expand it. Works fine with bash/zsh
- Doesn't work anyway as click wont let you init a path that doesn't
  exist

* Revert "fix: data is retrieved from db instead of local file"

This reverts commit cbe50a26da61e01b5a9a7c51f8632defb0913aab.

* fix: allow local import if from console

---------

Co-authored-by: Alfredo Altamirano <Ahuahuachi@users.noreply.github.com>
Co-authored-by: Ankush Menat <ankush@frappe.io>
2023-06-20 18:09:23 +05:30
Ankush Menat
63a1a32594 chore: remove unused argument 2023-06-13 19:03:52 +05:30
Ankush Menat
3005e66e45 refactor!: Drop previously deprecated code 2023-06-13 16:00:43 +05:30
Ankush Menat
b3d370a0b1 refactor!: remove rollback_observers
use `frappe.db.after_rollback.add` instead
2023-06-03 18:44:19 +05:30
Devin Slauenwhite
6bda014406
fix: install cypress plugins in frappe namespace (#20459) 2023-03-28 14:34:45 +05:30
Ankush Menat
f089e9108e
fix: hard link environment variable (#20467)
On docker based deploys symlinking inside volume doesn't work.

[skip ci]
2023-03-27 15:58:43 +05:30
Gavin D'souza
01cc586e20 fix: Use yarn to figure out bin path instead of npm
Npm v9 doesn't have bin anymore. This causes run-ui-tests to fail

refs:
- https://docs.npmjs.com/cli/v8/commands/npm-bin
- https://yarnpkg.com/cli/bin
2023-02-13 13:42:59 +05:30
gavin
ee80d6a504
feat(cli): Pass extra args to DB console (#19809) 2023-01-27 22:57:19 +05:30
Ankush Menat
ffc5447548
fix: set-config without -g must specify site (#19782) 2023-01-25 20:33:55 +05:30
Gavin D'souza
d357af1533 refactor: Add a maxsplit limit to string splits 2023-01-24 19:22:51 +05:30
Ankush Menat
87561940a4
feat: Interactively add a new patch (#19722) 2023-01-23 15:04:43 +05:30
Ankush Menat
3ff49ec0ad fix: mariadb convert port to string for os.execv 2022-12-20 15:14:38 +05:30
Ankush Menat
db35431b8c fix(postgres): psql with remote databases
If you dont use unix socket psql command doesn't work.
2022-12-20 15:14:38 +05:30
Ankush Menat
8107781f1c
fix: move filelock imports to functions (#19300) 2022-12-15 15:21:31 +05:30
Ankush Menat
49437f53b4
feat: operation level locking for CLI commands (#19162)
This prevents mistakenly issuing same commands twice which can be
dangerous.

added global lock(s):
- [x] bench build

added site level lock(s):
- [x] bench new-site sitename
- [x] bench --site sitename migrate
- [x] bench install-app appname
- [x] bench build
- [x] bench restore (the code is just meh, needs some cleanup)

closes https://github.com/frappe/frappe/issues/13215
2022-12-08 13:24:43 +05:30
Ankush Menat
5d1444c21c
docs: add missing help text for commands (#19039)
closes https://github.com/frappe/frappe/issues/19036

[skip ci]
2022-11-29 16:01:25 +05:30
gavin
440825a372
refactor: which > find_executable (#18872)
Use shutil from the standard library instead of distutils to find
executables in PATH
2022-11-14 18:15:38 +05:30
Ankush Menat
cfee53d573
refactor: load balanced parallel tests without orchestrator (#18386)
* feat: dry run in test runner for debuggin

* refactor: load balance TestRunner using # of tests
2022-10-12 12:13:24 +05:30
Ankush Menat
40f6a34840 build: pin testing-library/dom temporarily
refer https://github.com/testing-library/dom-testing-library/issues/1169
2022-09-19 16:21:23 +05:30
Ankush Menat
c400e18979 refactor: drop file upload plugin
Cypress supports this natively now!
2022-09-08 16:51:59 +05:30
Ankush Menat
e397b27d29 test: upgrade cypress from v6 to v10
chore: run cypress migrator

fix: specPattern should be an array

test: correct intercept URL

This is breaking change in cypress 7.0

test: make list view test rerunnable

test: redo undo tests and add compare doc

test: scroll to action button

chore: drop flaky tests

fix: remove scroll behaviour

fix: clear filters before running count test

test: input delay causes flake
2022-09-02 17:47:30 +05:30
Ankush Menat
4944246a0d
test: allow passing arbitrary args to cypress (#17997) 2022-08-30 21:27:25 +05:30
Gavin D'souza
287f33e0b1 fix(run-tests): Throw traceback with ctx variables 2022-08-08 16:06:41 +05:30
Gavin D'souza
bcfa8c276e fix: Set default port attribute for Database classes
db.default_port wil be available as a class attribute to hold defaults
for DB types.

Usage: frappe.conf.db_port or frappe.db.default_port
Why: I couldn't run the mariadb command because the defaults aren't set
for my system. server is remote / containerized. Setting port in
equivalent mysql command fixes this.
2022-07-22 13:16:26 +05:30
Gavin D'souza
1ccdad811a Merge branch 'develop' of github.com:frappe/frappe into mariadb-client-refactor 2022-07-19 16:23:24 +05:30
Ankush Menat
468a5c55a3
ci: fix weird version check in cypress tests (#17499) 2022-07-13 18:08:20 +05:30
Gavin D'souza
71b5c77e6e Merge branch 'develop' of github.com:frappe/frappe into mariadb-client-refactor 2022-07-05 14:55:02 +05:30
Ankush Menat
81b37cb7d2
refactor: clean up code to py310 supported features (#17367)
refactor: clean up code to py39+ supported syntax

- f-strings instead of format
- latest typing support instead of pre 3.9 TitleCase
- remove UTF-8 declarations.
- many more changes

Powered by https://github.com/asottile/pyupgrade/ + manual cleanups
2022-07-01 11:51:05 +05:30
Gavin D'souza
b867dedf15 refactor(run-ui-tests): Maintain list of cypress plugins 2022-06-24 00:18:24 +05:30