Commit graph

35822 commits

Author SHA1 Message Date
Conor
40ba1ac9ba fix: Postgres Compatibility
* Handle inconsistencies in type handling in DatabaseQuery & Database
  APIs
* Update incompatible queries with frappe.qb notation
* Fixed use cases discovered by failing ERPNext CI tests

fix: db independent syntax for user_type

fix: handle postgres datetime values

feat: add ability to auto commit on db inserts

feat: add ability to escape underscore in postgres

fix: handle missing data in test runner bootstrapping

fix: db independent syntax for queries

fix: refactor to use qb

fix: update cache for language

fix: use pluck in email_queue

Co-authored-by: gavin <gavin18d@gmail.com>

fix: don't auto insert on tests for make_property_setter

fix: remove auto_commit in custom_field insertion

fix: remove auto_commit functionality

fix: review comments

fix: revert link validation

fix: style suggestion for readability

Co-authored-by: gavin <gavin18d@gmail.com>

fix: revert .lower() in link validation

fix: add rollback for setup_wizard

Revert "fix: add rollback for setup_wizard"

This reverts commit 83b3b0913db17718ccd5edae01858cff15603829.

Revert "feat: add ability to escape underscore in postgres"

This reverts commit 8ed9c2aa3306438e94bb813f60e65b416d0b947b.

fix: more concise representation of order fields

Co-authored-by: gavin <gavin18d@gmail.com>
2022-01-07 10:44:57 +05:30
Verequies
379342d0ca fix: Postgres Compatibility for Standard Views
Core/User DocType: Add 'group_by' for PostgreSQL

Signed-off-by: Verequies <hamishclaxton@gmail.com>

fix: Postgres Compatibility for Standard Views

Desk/Dashboard DocType: Fix lowercase table name

Signed-off-by: Verequies <hamishclaxton@gmail.com>

Desk/Page/Setup Wizard: Fix data not being commited to database

Signed-off-by: Verequies <hamishclaxton@gmail.com>

Model/db_query: Fix queries with order_by and group_by for PostgreSQL

Signed-off-by: Verequies <hamishclaxton@gmail.com>

Model/db_query: Fix order_by without table name for PostgreSQL

Signed-off-by: Verequies <hamishclaxton@gmail.com>
2022-01-06 14:02:23 +05:30
mergify[bot]
87adfb5ebd
Merge pull request #15203 from DeeMysterio/star-rating-dev
feat: make rating field's stars customizable with options field
2021-12-17 11:17:23 +00:00
mergify[bot]
021a451283
Merge pull request #15142 from pateljannat/data-deletion-enhancements
fix: User Account Deletion Flow
2021-12-17 10:59:34 +00:00
mergify[bot]
acba26b025
fix(Translations): Search suggestions for lists, reports etc (backport #15305) (#15346)
Co-authored-by: Lev Vereshchagin <mail@vrslev.com>
Co-authored-by: Suraj Shetty <13928957+surajshetty3416@users.noreply.github.com>
2021-12-17 16:00:32 +05:30
mergify[bot]
e50d3ab6ac
Merge pull request #15344 from Aradhya-Tripathi/at-fixes
fix(db): fixed distinct in get_values
2021-12-17 09:52:28 +00:00
Aradhya
7faa843e97 feat: Added distinct in get_value 2021-12-17 15:01:24 +05:30
Jannat Patel
d0c570ae02 fix: function name and comment 2021-12-17 15:00:56 +05:30
mergify[bot]
ce6601b1b3
Merge pull request #15336 from frappe/fix-frappe-qb-set-syntax-in-email-account
fix: syntax error in using frappe.qb  in email_account.py
2021-12-17 09:04:39 +00:00
mergify[bot]
e738b1f6f2
Merge pull request #15337 from resilient-tech/perf-translation
perf: improve translation speed
2021-12-17 08:39:56 +00:00
Suraj Shetty
edd9464c54
Merge branch 'develop' into fix-frappe-qb-set-syntax-in-email-account 2021-12-17 14:03:49 +05:30
Suraj Shetty
7c6b3dbc80
Merge branch 'develop' into fix-frappe-qb-set-syntax-in-email-account 2021-12-17 14:03:32 +05:30
Aradhya
e1360a3770 test: Added tests for distinct in get values 2021-12-17 13:45:57 +05:30
Aradhya
33b4ff0a84 fix(db): fixed distinct in get_values
refactor: remove redundant imports
2021-12-17 13:30:07 +05:30
Suraj Shetty
83be5f934b
Merge branch 'develop' into star-rating-dev 2021-12-17 11:31:11 +05:30
Faris Ansari
89648a5cf7
Merge pull request #15340 from netchampfaris/meta-table-fields
fix: set empty lists for unset meta table fields
2021-12-17 10:52:03 +05:30
mergify[bot]
50c653d620
Merge pull request #15220 from v0l/develop
feat: add number format for BTC
2021-12-16 17:14:28 +00:00
Faris Ansari
133ab39de2
Merge pull request #15334 from netchampfaris/server-script-error-ux
fix: Server Script UX
2021-12-16 20:32:18 +05:30
Faris Ansari
c6f9920795 fix: removing map filter
these can potentially lead to security issues, avoiding for now
2021-12-16 20:31:50 +05:30
Faris Ansari
2cfebf2a96 fix: set empty lists for unset meta table fields 2021-12-16 20:20:19 +05:30
Suraj Shetty
4d2548cff9
Merge branch 'develop' into star-rating-dev 2021-12-16 19:40:25 +05:30
mergify[bot]
bf56858f09
Merge pull request #13504 from hrwX/multi_timezone_support
feat: Convert datetime field values to system timezone
2021-12-16 14:08:44 +00:00
Sagar Vora
0f98f8a3a4 fix: dont create copy of object 2021-12-16 17:36:57 +05:30
Faris Ansari
0bc3ff794b fix: remove attr helpers and type
these can potentially lead to security issues, avoiding for now
2021-12-16 16:21:05 +05:30
Sagar Vora
fdf060178b fix: increase timeout to 100ms 2021-12-16 13:39:49 +05:30
Faris Ansari
eaec262b25 fix: Throw actual exception instead of ValidationError
- to make tests pass
2021-12-16 13:35:45 +05:30
Sagar Vora
774b1dcd07 perf: improve translation speed 2021-12-16 13:10:41 +05:30
kamaljohnson
bf9ef972c8 refactor: remove debug statement 2021-12-16 13:08:47 +05:30
kamaljohnson
7744924797 fix: syntax error in frappe.qb set in email_account.py 2021-12-16 13:01:16 +05:30
Faris Ansari
7c8659388d fix(server-script): add common python builtins 2021-12-16 12:19:08 +05:30
mergify[bot]
59db87cb47
Merge pull request #15280 from phot0n/fix-jpeg-rgba-upload
fix: upload jpeg image with alpha channel
2021-12-16 06:28:53 +00:00
Faris Ansari
f6c38b6b6e fix(ux): Show better error message when server script fails 2021-12-16 11:56:55 +05:30
Jannat Patel
2c397e4270 fix: on hold status button 2021-12-16 11:12:26 +05:30
mergify[bot]
95b5a919a6
Merge pull request #15331 from ruchamahabal/unable-to-cancel
fix: use `get_all` instead of `get_list` while fetching linked doctypes
2021-12-16 05:14:38 +00:00
Jannat Patel
c5c439ff03 fix: on hold status for data deletion 2021-12-16 10:02:07 +05:30
Rucha Mahabal
d56fea4a47 fix: use get_all instead of get_list while fetching linked doctypes 2021-12-16 09:11:21 +05:30
mergify[bot]
20a2a2dd03
Merge pull request #15320 from ankush/fix/inconsistent_link_field_behaviour
fix: set invalid link fields to `undefined` instead `''`
2021-12-15 17:41:46 +00:00
Suraj Shetty
1e3d58c14f
refactor: Use null instead of undefined 2021-12-15 21:53:25 +05:30
mergify[bot]
2b198014a4
Merge pull request #14438 from rohitwaghchaure/shortcut-keys-for-grid
feat: keyboard shortcuts for the grid
2021-12-15 15:36:45 +00:00
Jannat Patel
e57d2d0aa2 fix: removed sla and added auto deletion 2021-12-15 19:36:36 +05:30
Ankush Menat
b633f31bf4 fix: set link field to undefined instead of empty string
This breaks other code where undefined values are removed, technically
invalid value for link field => unset link field so it should be
undefined
2021-12-15 18:41:56 +05:30
Suraj Shetty
79c2464a7a fix: Update descriptions 2021-12-15 17:42:59 +05:30
Suraj Shetty
ede927f03e fix: Make description translatable 2021-12-15 17:39:13 +05:30
Faris Ansari
cee24f7043
Merge pull request #15299 from netchampfaris/list-view-ux
fix(performance): list view bulk operations
2021-12-15 15:38:15 +05:30
Ankush Menat
dd336a2990
Merge pull request #15311 from netchampfaris/document-state-reload-patch
fix: reload doctype state early to fix patch
2021-12-15 13:34:16 +05:30
Faris Ansari
c109804ba1 test: update ui tests for list view
- Keep checkbox checked after Refresh
2021-12-15 12:32:00 +05:30
mergify[bot]
a949894e31
Merge pull request #15309 from nextchamp-saqib/show-scan-btn
fix(ux): always show scan barcode button
2021-12-15 06:56:00 +00:00
Faris Ansari
a2e24581bd fix: reload doctype state early to fix patch 2021-12-15 12:01:00 +05:30
Faris Ansari
3650968ccc style: missing semicolon 2021-12-15 11:44:26 +05:30
mergify[bot]
1d4c74d455
Merge pull request #15306 from pateljannat/text-editor-fixes
fix: Text Editor Height
2021-12-15 06:09:51 +00:00