Commit graph

42008 commits

Author SHA1 Message Date
Ankush Menat
4376ebb3dc refactor: replace todo tour with user tour
adding more users is most likely to improve adoption. so better place to
show tours is user doctype?
2023-05-24 13:24:09 +05:30
Ankush Menat
657c2ba3b2 fix: clear cached onboarding status on update 2023-05-24 12:48:07 +05:30
Ankush Menat
09ce5f7a94 chore: fix main workspace tour copy
- fix copy
- make it run on any workspace
2023-05-24 12:44:27 +05:30
Ankush Menat
8d63e2f183 fix: clear boot cache on updating form tour 2023-05-24 12:31:51 +05:30
Ankush Menat
78dc9fc9ac fix: fieldtype json -> text 2023-05-24 12:06:04 +05:30
Maharshi Patel
19c4b396ae chore: fix linters 2023-05-24 11:44:36 +05:30
Maharshi Patel
e7c71a2411 Merge branch 'onboarding-tour' of https://github.com/maharshivpatel/frappe into onboarding-tour 2023-05-24 11:43:29 +05:30
Maharshi Patel
f07f442de1
Merge branch 'develop' into onboarding-tour 2023-05-24 11:43:05 +05:30
Maharshi Patel
9fec2fb499 fix: change onboarding_status type to long text
json type breaks unrelated tests and in mariadb json is alias for long text.
2023-05-24 11:42:35 +05:30
PeterG
a182414610
fix(workflow): populate doc from db in apply_workflow (#21068) 2023-05-24 11:35:37 +05:30
Maharshi Patel
5f91ed93ef
Merge branch 'develop' into onboarding-tour 2023-05-23 18:16:20 +05:30
Aditya Hase
22e3ec8bf4
fix(build): Propogate exit code from yarn build to bench build (#21084)
When `yarn build` fails `bench build` ignores the error and exits with exit code 0
2023-05-23 15:47:13 +05:30
Ankush Menat
119313810e
fix: misc onboarding fixes (#21078)
* fix: show fields without label too

* fix: make form tour step editable

* fix: hide duplicate save buttons


[skip ci]
2023-05-23 15:39:00 +05:30
Maharshi Patel
69705ec086 fix: update module in json to Desk 2023-05-23 15:36:59 +05:30
Maharshi Patel
4557a7b664 fix: minor changes as per review. 2023-05-23 15:23:58 +05:30
Maharshi Patel
2451d8d263 fix: remove always required for element_selector. 2023-05-23 15:22:27 +05:30
Maharshi Patel
20d0e28092 fix: remove onboarding_tours_section 2023-05-23 15:20:35 +05:30
Maharshi Patel
4e74051732 fix: add form tour settings to desk module. 2023-05-23 15:18:15 +05:30
Maharshi Patel
028508c947 fix: remove from settings from core module. 2023-05-23 13:25:37 +05:30
Maharshi Patel
05b1793fcd fix: load onboarding_tours async
loads onboarding_tours if enable_onboarding is checked and form tours are available for user.
2023-05-23 12:42:12 +05:30
Ankush Menat
5b881636bb chore: track route views for first few days
Identifying where users drop off is tricky without knowing what they are
doing in system. Tracking first few days routes will likely give some
insights.
2023-05-23 12:35:40 +05:30
mergify[bot]
8440ba1d3c
Merge pull request #21055 from marination/geolocation-control-first-load
fix: [Geolocation] Load map libraries at build time to avoid async issues during first render
2023-05-23 03:46:07 +00:00
Suraj Shetty
978032a2f2
Merge branch 'develop' into geolocation-control-first-load 2023-05-23 08:55:22 +05:30
Suraj Shetty
a960fe08f4
Merge pull request #21071 from cwerner1/patch-1 2023-05-23 08:52:20 +05:30
Christian Werner
98d56d2412 Update de.csv
Update Translation

'No' means 'Nein' in German and not 'nothing' 'Kein'
2023-05-22 19:39:21 +02:00
Ankush Menat
fe67fcdb11
Merge pull request #21072 from ankush/onboarding_
fix(ux): auto jump to next step in onboarding
2023-05-22 21:45:28 +05:30
Ankush Menat
baa7c9dd40 chore: track dismissed onboardings 2023-05-22 21:41:13 +05:30
Ankush Menat
253b9bb1f5 fix(UX): activate next step automatically 2023-05-22 21:36:59 +05:30
Ankush Menat
c643d4a33c chore: capitalization 2023-05-22 16:15:53 +05:30
Ankush Menat
9f83ead7a2 fix: remove setup_complete events
This can trigger along side actual setup complete event causing two
parallel requests.
2023-05-22 14:48:19 +05:30
Deepesh Garg
0c5948b5e7
Merge pull request #20715 from vorasmit/default-user-perm
fix: set default user value only if enabled
2023-05-22 13:28:22 +05:30
Ritwik Puri
3568f6c633
Merge pull request #21061 from frappe/webhook-improvements
feat(minor): Webhook DocType enhancements
2023-05-22 12:25:58 +05:30
Marica
de89db078b
Merge branch 'develop' into geolocation-control-first-load 2023-05-22 12:20:55 +05:30
Ankush Menat
2b2139c7ae chore(UX): increase default session inactivity period 2023-05-22 11:12:38 +05:30
Mohammad Hussain Nagaria
c8762068be
Merge branch 'develop' into webhook-improvements 2023-05-21 15:54:50 +05:30
Hussain Nagaria
c1d90b1d6a fix(ui): rearrange fields in webhook request log doctype 2023-05-21 15:50:52 +05:30
Hussain Nagaria
d31d07ed23 fix(ux): set language to enable syntax highlighting JSON 2023-05-21 15:44:33 +05:30
Hussain Nagaria
cb1dce5ef5 fix(ux): add description for jinja support 2023-05-21 15:44:03 +05:30
Hussain Nagaria
cf49369d14 feat(minor): add request log to connections 2023-05-21 15:31:37 +05:30
paurosello
5394e731a8
fix: cast doc name to string while exporting child docs (#21057) 2023-05-20 18:19:11 +05:30
marination
5f6a6a025a fix: Load map libraries at build time to avoid async issues during geolocation render
- When gelocation control is built, it awaits loading of libraries
- Withi the control everything is await but a layer above where multiple controls are sequentially built this breaks
- Form render goes ahead without waiting for the gelocation control
- The `onload_post_render` in `Location` cannot find the map wrapper as the control is still being built
- Therefore, on a hard load, the control does not show up and appears on soft reload.
2023-05-19 16:56:54 +05:30
Ritwik Puri
219d3c304e
chore: add back prepared_report_name to url
[skip ci]
2023-05-19 16:28:48 +05:30
Ritwik Puri
5a889f0da9
chore: dont track changes for prepared report
[skip ci]
2023-05-19 16:06:03 +05:30
Ritwik Puri
a0fe38ecff
fix: set filters when redirecting via show report button in prepared report 2023-05-19 15:51:29 +05:30
Maharshi Patel
b4387086b4 fix: linter for onboarding.bundle.js 2023-05-19 11:26:03 +05:30
Maharshi Patel
e191d6fb73
Merge branch 'develop' into onboarding-tour 2023-05-19 11:05:50 +05:30
Ankush Menat
d0a24e66c5
fix: incorrect caching of is_owner permissions (#21048)
- Create a doctype
- Pick any role and only allow owner to create, read, write.
- after_insert hook re-save the document
- This will fail because there's a function call to `frappe.only_has_select_perm` which doesn't pass the is_owner, this is likely acceptable if document is not available.

Fix: cache should be separate for is_owner

Triggered from but not caused by https://github.com/frappe/frappe/pull/20810
2023-05-19 09:34:48 +05:30
Suraj Shetty
3669567bb4
Merge pull request #21047 from pateljannat/remove-canonical-link 2023-05-19 08:29:35 +05:30
Ritwik Puri
94be05f3d2
Merge pull request #21049 from ruthra-kumar/invalid_sql_error_while_filtering_on_multi_select
fix: using 'Equals' and 'Is' on multiselect throws error if 'get_filters_cond' is used for formating filters
2023-05-18 18:11:19 +05:30
ruthra kumar
6b2bcd5b07 fix: using 'Equals' and 'Is' on multiselect throws error 2023-05-18 16:48:19 +05:30