vassili/seitime-frappe
1
0
Fork 0
Code Issues Pull requests Projects Releases Packages Wiki Activity Actions 1
44661 commits 1 branch 0 tags 587 MiB
Commit graph

44661 commits

This branch
This branch
All branches
Author SHA1 Message Date
hhharsha36
445da4319b
fix: error - permission denied for schema public from Postgres >= 15 during initial DB setup (#23799) 
Error from Postgres:
ERROR:  permission denied for schema public at character 14

Error from Frappe:
psql:/home/frappe/frappe-bench/apps/frappe/frappe/database/postgres/framework_postgres.sql:72: ERROR:  permission denied for schema public

Error Causer:
Starting Postgres version >= 15, all users will have the `CREATE` permission revoked by default.

Fix:
Grant relevant privileges to the database in question for the user. In this case, DB owner privilege.

Note: the below two permission attempts were unsuccessful and still caused the same public schema permission error

GRANT USAGE, CREATE ON SCHEMA public TO {frappe.conf.db_name};
GRANT ALL ON SCHEMA public TO {frappe.conf.db_name}

References:
https://stackoverflow.com/questions/74110708/postgres-15-permission-denied-for-schema-public
https://stackoverflow.com/questions/67276391/why-am-i-getting-a-permission-denied-error-for-schema-public-on-pgadmin-4
 2023-12-27 16:04:21 +05:30
Corentin Flr
91405493e5
fix(text_editor): Fix bubble's link tooltip clipping (#23911) 
* fix(text_editor): Use body as bounds to avoid bubble's tooltip clipping

* fix(text_editor): Allow overflow for link tooltip
 2023-12-27 16:03:18 +05:30
Ankush Menat
6367194620
perf: skip network call if no doc (#23967) 
If link field has no value then its title will always be undefined.
 2023-12-27 14:15:20 +05:30
Maharshi Patel
c3cc310496
Merge pull request #23287 from fadilsiddique/numbercard_fix 
fix: number card layout
only align flex-start for shortcut-widget-box instead of all widget-head
 2023-12-27 13:46:41 +05:30
Maharshi Patel
53ab3c6491 Merge branch 'develop' into numbercard_fix 2023-12-27 13:39:00 +05:30
Maharshi Patel
39136b01b6 fix: shortcut-widget-box should have flex-start 
As we changed align-items to space-between for widget head,
we need to override .shortcut-widget-box to flex-start
 2023-12-27 13:32:04 +05:30
Maharshi Patel
547523c7b4
fix(minor): mobile menu class (#23970) 
removed `.collapse.show` class as it is removed during opening animation of menu.
 2023-12-27 13:16:02 +05:30
Maharshi Patel
fe906966d4
fix(minor): Onboarding check if element available (#23947) 
only try to find parent_element_selector if element exists
 2023-12-27 12:02:37 +05:30
Ankush Menat
a16db1be32
fix: show relative path in loaded JS (#23964) 
[skip ci]
 2023-12-27 10:46:30 +05:30
Akhil Narang
ba01eb99cb
Merge pull request #23892 from jjaycaneza/fix-childTable-skip_dirty_trigger-param 
fix: add skip_dirty_trigger param for child_table
 2023-12-26 17:54:22 +05:30
Sagar Vora
f54e0c94b7
Merge pull request #23948 from frappe-tianjy/fix/frappe.ui.Capture.prototype.setup_remove_action 2023-12-26 17:35:14 +05:30
Fierflame
c5990938fd fix: Solve the problem that there is no forEach instance method in HTMLCollection in some environments, which leads to the failure of camera-related functions. 2023-12-26 19:50:33 +08:00
猛火
854cebd5b1
fix: Solve the problem that the document editor will report an error when the type name includes multiple spaces (#23940) 2023-12-26 14:34:48 +05:30
Ankush Menat
4b5658a507
Merge pull request #23926 from cogk/fix-child-doc-defaults 
fix(document): Pass parent_doc and parentfield for child in _set_defaults
 2023-12-26 13:27:05 +05:30
Ankush Menat
bedf270bc4
Merge pull request #23935 from barredterra/print-font 
fix: use system font for printing
 2023-12-26 12:21:15 +05:30
Ankush Menat
2dfef73ae8
Merge pull request #22915 from akhilnarang/dont-extract-backup-unconditionally 
perf: don't extract gzipped backups
 2023-12-26 12:19:10 +05:30
Xiaoguang Sun
68d4a5ad82
Do not call begin in updatedb after syncing (#23934) 
Do not call begin in updatedb after syncing as commit does it already.

Signed-off-by: Xiaoguang Sun <sunxiaoguang@gmail.com>
 2023-12-26 12:12:19 +05:30
Akhil Narang
43021911ff
fix: simplify parsing version for older backups 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-26 11:09:08 +05:30
Akhil Narang
6e8f32af58
chore: don't pipe output through pv 
No point if we're using `execute_in_shell()`

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-26 11:09:08 +05:30
Akhil Narang
3fe840fb31
fix(postgres): make use of common helper 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-26 11:09:08 +05:30
Akhil Narang
76c9fbd0cd
fix: use source before changing its contents 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-26 11:09:08 +05:30
Akhil Narang
b010dc584f
chore(installer): fix output when prompting user about downgrade 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-26 11:09:08 +05:30
Akhil Narang
9bf818eb4a
chore: add in some tests for backup 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-26 11:09:08 +05:30
Akhil Narang
7f433b84af
feat: allow creating a backup with the older metadata style 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-26 11:09:08 +05:30
Akhil Narang
998f2c10d6
fix: handle older gzipped backups as well 
Also fix the actual comparison

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-26 11:09:08 +05:30
Akhil Narang
a06e402f38
refactor: use a function with context manager for backup decryption 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-26 11:09:08 +05:30
Akhil Narang
2e382040cd
fix: simplify version detection logic 
Our version detection code is relatively simple, so we shouldn't have any exceptions arising there
Just check for a None return value to decide whether we should use the older logic

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-26 11:09:08 +05:30
Akhil Narang
148efbc3ed
refactor(restore): adjust downgrade check 
First actually check whether its a downgrade, then check for the force flag

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-26 11:09:08 +05:30
Akhil Narang
012b0fdb7e
fix(postgres/setup): use gzip to get backup contents if the file is an archive 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-26 11:09:08 +05:30
Akhil Narang
50d21677b8
chore: drop use of magic library, run file command directly 
Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-26 11:09:08 +05:30
Akhil Narang
2b7c74dd5e
feat(restore): handle encrypted backups better 
Determine the mimetype based on the file contents instead of waiting for an exception
Cleaner + no need of duplicate code

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-26 11:09:08 +05:30
Akhil Narang
0b508e2a96
feat(db_manager): avoid extraction of DB dump if gzipped 
Use `gzip -cd` to directly get the contents onto stdout and pipe to mariadb

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-26 11:09:08 +05:30
Akhil Narang
7db8baa7c4
feat(installer): drop actual gzip file extraction 
Use `zgrep` to check for table name match where required

Also use a table that's at the top of the dump files (`__Auth`)

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-26 11:09:07 +05:30
Akhil Narang
cb7c0e653c
fix(Backup): automatically rollback decryption when object is being deleted 
This allows us to not have to call it everytime before returning

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-26 11:08:48 +05:30
Akhil Narang
3b0f6de883
perf: don't extract backup files unless required 
Read from the gzipped file wherever possible

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-26 11:08:48 +05:30
barredterra
ad93afcd4c fix: use system font for printing 
This way, content from Text Editor will have the same style as the rest of the print.
 2023-12-25 18:28:18 +01:00
Corentin Flr
42fbb58626
fix(document): Pass parent_doc and parentfield in _set_defaults 2023-12-23 20:40:52 +01:00
Shariq Ansari
77f04c9fc4
Merge pull request #23921 from shariquerik/minor-fix-1 
chore: minor fix
 2023-12-23 11:54:13 +05:30
Shariq Ansari
fc13ff5f29 chore: minor fix 2023-12-23 11:39:39 +05:30
Raffael Meyer
c26ccad9e2
Merge pull request #23914 from barredterra/email-linking-hotfix 2023-12-22 11:44:54 +01:00
Raffael Meyer
5fc3cb6d79
Merge pull request #23915 from frappe/de-missing-comma 2023-12-22 11:43:05 +01:00
Raffael Meyer
f2b9f759ab
fix: missing comma in translations file 2023-12-22 11:41:16 +01:00
barredterra
62d634eab4 Revert "fix: check the correct email account" 
This reverts commit 2507c6af97.
 2023-12-22 11:28:05 +01:00
Ankush Menat
4d68a46b10
fix: Set default child table fields on save (#23913) 
We set defaults on creation of new doc but when you append a new child
doc on existing document it doesn't seem to set the defaults.

This seems like a bug and not a deliberate choice.
 2023-12-22 08:02:36 +00:00
Akhil Narang
7c9fbb637d
Merge pull request #23912 from akhilnarang/fix-redirect-mandatory-default 
fix(redirect): make the status codes a `select` field instead of `int`
 2023-12-22 12:59:47 +05:30
Akhil Narang
ff4dca3e16
fix(redirect): make the status codes a select field instead of int 
Drop mandatory, assume sane defaults
The current implementation broke old users of redirects like helpdesk app

Signed-off-by: Akhil Narang <me@akhilnarang.dev>
 2023-12-22 12:25:41 +05:30
Corentin Flr
1d23888475
fix(translations): Add context to Image Cropper text (#23908) 2023-12-21 23:20:25 +05:30
Ankush Menat
5e2ace4c08
perf: Use set for tracking whitelisted methods (#23905) 
List look ups are O(N). This is still a microoptimization at best
considering other overhead.
 2023-12-21 23:19:06 +05:30
Akhil Narang
25ba2822be
Merge pull request #23431 from barredterra/newsletter-welcome-url 
feat(Newsletter): redirect to welcome URL
 2023-12-21 17:10:06 +05:30
Shariq Ansari
fad6cff1ad
Merge pull request #23893 from shariquerik/allow-crop-attach-image-sidebar 
fix: allow aspect ratio options to crop from sidebar image field
 2023-12-21 14:31:20 +05:30