Shariq Ansari
45e2361dcc
fix(linter): Trim Trailing Whitespace
2022-03-31 11:58:50 +05:30
Shariq Ansari
1fdfbeb083
fix: added is_system_generated field in customize form field doctype
2022-03-31 11:56:35 +05:30
Shariq Ansari
36a69f9e0d
fix: Remove row highlight code from setup_sortable method
2022-03-24 11:56:29 +05:30
Shariq Ansari
eadf6acab9
Merge branch 'develop' into customize-form-highlighted-rows-fix
2022-03-23 17:36:59 +05:30
Suraj Shetty
76ee35f865
Merge pull request #16219 from hrwX/camera_upload
2022-03-23 16:52:03 +05:30
mergify[bot]
00defb746e
Merge pull request #16376 from nabinhait/assignment-fix
...
fix: Show assignments based on allocated todo only
2022-03-23 11:19:07 +00:00
gavin
3b3b895bdd
Merge pull request #16379 from gavindsouza/start-transaction-log-settings
...
fix(test): start transaction explicitly before savepoint
2022-03-23 16:17:25 +05:30
Raffael Meyer
f80a16ed14
feat: add translated search doctypes to hooks ( #16197 )
...
In `search.py` it was hardcoded that **DocType** and **Role** get translated before matching against the search text. This way, a user can type in his local language and still see correct results.
This feature is useful for other DocTypes as well. The criterion would be: there is a small, fairly static number of records, so that the performance impact of translating all names first is not too bad.
This PR adds a hook `translated_search_doctypes` that determines which DocType names get translated before search.
I also added **Country** to `translated_search_doctypes` for frappe. The link to **Country** is frequently used in **Address**, but until now there was no way to use it in the local language. There are ~70% less Countries than DocTypes (including ERPNext), so the performance should be fine.
ERPNext could, for example, add the **Gender** DocType to this hook. As there are very few genders, translating them is fast and improves the UX.
Docs: https://frappeframework.com/docs/v13/user/en/python-api/hooks/edit?wiki_page_patch=b4d7c8d6fc
2022-03-23 10:43:04 +00:00
Gavin D'souza
93a36092fd
fix(test): start transaction explicitly before savepoint
2022-03-23 16:00:25 +05:30
mergify[bot]
64efc6bd88
Merge pull request #16042 from saxenabhishek/aks-feat-parse_app_name
...
feat: app name parsing
2022-03-23 09:01:52 +00:00
mergify[bot]
70bbcccba7
Merge pull request #16118 from shadrak98/log-settings
...
fix: clean up logs job was broken
2022-03-23 08:47:40 +00:00
mergify[bot]
87e640c660
Merge pull request #16147 from shadrak98/customize-form-chore
...
fix: remove custom-fields too on reset-to-default
2022-03-23 08:46:22 +00:00
Shariq Ansari
d83bdfe119
fix: Custom field highlight goes away when change grid page
2022-03-23 14:13:55 +05:30
Gavin D'souza
22fc955e65
fix: Tabs > Spaces
2022-03-23 13:37:41 +05:30
Carlos Ríos
e8fdca8698
feat(logger): implement stream_only to use StreamHandler instead of RotatingFileHandler ( #16274 )
...
* feat: implement valued parameter 'stream_only' in 'get_logger()' in order to stream logs into stderr instead rotating log files.
Co-authored-by: gavin <gavin18d@gmail.com>
2022-03-23 13:37:12 +05:30
gavin
a7f1639e65
Merge branch 'develop' into log-settings
2022-03-23 13:20:33 +05:30
Gavin D'souza
b79d55c5d3
refactor(minor): clear_outbox
...
* Use pluck API instead of building dict and then accesing keys
* Styled query
* Added type hints
2022-03-23 13:18:22 +05:30
Nabin Hait
762aeb32f0
fix: Show assignments based on allocated todo only
2022-03-23 13:13:31 +05:30
Gavin D'souza
300227ba71
fix(set_single_value): Make value parameter optional
...
Similar to set_value for accepting multiple columns ot be updated for
the same Table through a Dict as the second positional arg
Misc: Added type hints
2022-03-23 13:11:55 +05:30
Gavin D'souza
85c7057ae4
fix(activity_log): Remove unused import from namespace
2022-03-23 13:11:17 +05:30
Gavin D'souza
ee355b9cd6
test(log_settings): test_delete_logs
...
* Refactored TestCase to test "correctly"
* Got rid of earlier flaky logic
* Dropped unwanted tests
2022-03-23 13:09:36 +05:30
shadrak gurupnor
01978ffe73
fix: remove customizations which is not system_generated
2022-03-23 12:16:17 +05:30
Suraj Shetty
cd8bd4ccf0
Merge pull request #16278 from surajshetty3416/is-system-generated-customization
2022-03-23 10:52:21 +05:30
Suraj Shetty
25072fafbe
Merge pull request #16372 from surajshetty3416/fix-calendar
2022-03-23 10:23:28 +05:30
Suraj Shetty
6b6514c796
fix: Use calendar name as it is
...
Do not convert route to title case since calendar names are case sensitive, and it breaks for calendar names which are all CAPs
2022-03-23 09:34:19 +05:30
Raffael Meyer
ead843cf28
Merge branch 'develop' into camera_upload
2022-03-22 16:12:30 +01:00
saxenabhishek
1507751a01
test: test_app_name_parser
2022-03-22 14:17:01 +05:30
saxenabhishek
f8c4098585
docs: docstings and refs
2022-03-22 14:17:01 +05:30
saxenabhishek
c53e6d822d
feat: parse app name from tags and urls
2022-03-22 14:16:59 +05:30
gavin
dbff1de9ac
Merge pull request #16337 from alyf-de/dont-assign-variable-to-itself
...
refactor: don't assign variable to itself
2022-03-22 12:02:08 +05:30
mergify[bot]
aa42efe1de
Merge pull request #16363 from alyf-de/fullargspec
...
refactor: call getfullargspec only once
2022-03-22 06:24:28 +00:00
mergify[bot]
5e6955ba30
Merge pull request #16358 from shariquerik/attach-on-submitted-doc-fix
...
fix: Attach not working on submitted doc
2022-03-22 06:15:40 +00:00
Shariq Ansari
d30f9e1d78
fix: wait until attach is cleared before saving
2022-03-22 11:23:43 +05:30
Shariq Ansari
2d77379c13
Merge branch 'develop' into attach-on-submitted-doc-fix
2022-03-22 11:21:57 +05:30
mergify[bot]
a4f0344aaf
Merge pull request #16361 from alyf-de/fix-exists-pop
...
fix: copy dict before popping keys
2022-03-22 04:42:02 +00:00
mergify[bot]
d4175f673d
Merge pull request #16362 from alyf-de/delete_doc_if_exists
...
perf: exists is already checked in delete_doc
2022-03-22 04:41:17 +00:00
Suraj Shetty
6de9d13569
Merge pull request #16364 from surajshetty3416/auto-hide-page-head
2022-03-22 09:40:15 +05:30
Suraj Shetty
7a9536332e
feat: Hide page head while scrolling down
...
- To create more reading area in the form
2022-03-22 09:16:39 +05:30
barredterra
8cf2bf8953
refactor: call getfullargspec only once
2022-03-21 23:09:58 +01:00
barredterra
179c9f117c
perf: exists is already called in delete_doc
2022-03-21 21:12:05 +01:00
barredterra
44a7c0dd93
fix: copy dict before popping keys
2022-03-21 20:51:59 +01:00
barredterra
512c622487
test: make sure exists doesn't eat the doctype key
2022-03-21 20:51:35 +01:00
mergify[bot]
6dfd279863
Merge pull request #16336 from hrwX/fix_parse_email_test
...
chore: prefix test for parse_email
2022-03-21 18:17:54 +00:00
Suraj Shetty
a1664330a7
Merge pull request #16344 from frappe/mergify/bp/develop/pr-16239
2022-03-21 20:49:33 +05:30
Shariq Ansari
5c6c9bb5c4
fix: resolved conflicts in database.py
2022-03-21 18:16:54 +05:30
Shariq Ansari
d97c7e7caf
fix: resolved conflicts in permissions.py
2022-03-21 18:05:01 +05:30
Shariq Ansari
aa0d10fe0e
fix: First set in model then save attachment
2022-03-21 17:24:18 +05:30
mergify[bot]
367e3fdb4e
Merge pull request #16357 from tirkarthi/fix-assert-1
...
test: Use assertEqual instead of assertEquals for Python 3.11 compatibility.
2022-03-21 11:43:56 +00:00
Karthikeyan Singaravelan
880832671a
fix: use assertEqual instead of assertEquals for Python 3.11 compatibility
2022-03-21 11:05:43 +00:00
Suraj Shetty
47d9f0573d
Merge pull request #16353 from frappe/mergify/bp/develop/pr-16018
2022-03-21 15:18:55 +05:30
